Gabriel Ivăncescu : mshtml: Use unlink and destructor in the vtbl for HTMLTxtRange.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 1904dd0be3261ce2f0c0b7ef93053d9e735aa145
URL:    https://gitlab.winehq.org/wine/wine/-/commit/1904dd0be3261ce2f0c0b7ef93053d9...

Author: Gabriel Ivăncescu 
Date:   Thu Aug  3 15:56:12 2023 +0300

mshtml: Use unlink and destructor in the vtbl for HTMLTxtRange.

Signed-off-by: Gabriel Ivăncescu

---

dlls/mshtml/range.c | 36 ++++++++++++++++++++++++++++--------
 1 file changed, 28 insertions(+), 8 deletions(-)

diff --git a/dlls/mshtml/range.c b/dlls/mshtml/range.c
index d55851ac87e..562dbf35b49 100644
--- a/dlls/mshtml/range.c
+++ b/dlls/mshtml/range.c
@@ -855,14 +855,8 @@ static ULONG WINAPI HTMLTxtRange_Release(IHTMLTxtRange *iface)

TRACE("(%p) ref=%ld\n", This, ref);

-    if(!ref) {
-        if(This->nsrange)
-            nsIDOMRange_Release(This->nsrange);
-        if(This->doc)
-            list_remove(&This->entry);
+    if(!ref)
         release_dispex(&This->dispex);
-        free(This);
-    }

return ref;
 }
@@ -1718,13 +1712,39 @@ static const IOleCommandTargetVtbl OleCommandTargetVtbl = {
     RangeCommandTarget_Exec
 };

+static inline HTMLTxtRange *HTMLTxtRange_from_DispatchEx(DispatchEx *iface)
+{
+    return CONTAINING_RECORD(iface, HTMLTxtRange, dispex);
+}
+
+static void HTMLTxtRange_unlink(DispatchEx *dispex)
+{
+    HTMLTxtRange *This = HTMLTxtRange_from_DispatchEx(dispex);
+    unlink_ref(&This->nsrange);
+    if(This->doc) {
+        This->doc = NULL;
+        list_remove(&This->entry);
+    }
+}
+
+static void HTMLTxtRange_destructor(DispatchEx *dispex)
+{
+    HTMLTxtRange *This = HTMLTxtRange_from_DispatchEx(dispex);
+    free(This);
+}
+
+static const dispex_static_data_vtbl_t HTMLTxtRange_dispex_vtbl = {
+    HTMLTxtRange_destructor,
+    HTMLTxtRange_unlink
+};
+
 static const tid_t HTMLTxtRange_iface_tids[] = {
     IHTMLTxtRange_tid,
     0
 };
 static dispex_static_data_t HTMLTxtRange_dispex = {
     L"TextRange",
-    NULL,
+    &HTMLTxtRange_dispex_vtbl,
     IHTMLTxtRange_tid,
     HTMLTxtRange_iface_tids
 };