Module: wine Branch: master Commit: 0e6ad1fa8566f07fc82c392a80ad4b1b7e86a84c URL: http://source.winehq.org/git/wine.git/?a=commit;h=0e6ad1fa8566f07fc82c392a80...
Author: Rob Shearman robertshearman@gmail.com Date: Mon Mar 15 19:30:50 2010 +0000
widl: Remove some FIXME comments and replace them with comments explaining why the current behaviour is correct.
---
tools/widl/typegen.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index b7982b0..a241e69 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -1555,8 +1555,10 @@ static void write_member_type(FILE *file, const type_t *cont, reloff = absoff - (*tfsoff + 2);
print_file(file, 2, "0x4c,\t/* FC_EMBEDDED_COMPLEX */\n"); - /* FIXME: actually compute necessary padding */ - print_file(file, 2, "0x0,\t/* FIXME: padding */\n"); + /* padding is represented using FC_STRUCTPAD* types, so presumably + * this is left over in the format for historical purposes in MIDL + * or rpcrt4. */ + print_file(file, 2, "0x0,\n"); print_file(file, 2, "NdrFcShort(0x%hx),\t/* Offset= %hd (%u) */\n", reloff, reloff, absoff); *tfsoff += 4; @@ -1651,8 +1653,11 @@ static int write_pointer_description_offsets( { unsigned int memsize;
- /* pointer instance */ - /* FIXME: sometimes from end of structure, sometimes from beginning */ + /* pointer instance + * + * note that MSDN states that for pointer layouts in structures, + * this is a negative offset from the end of the structure, but + * this statement is incorrect. all offsets are positive */ print_file(file, 2, "NdrFcShort(0x%hx),\t/* Memory offset = %d */\n", *offset_in_memory, *offset_in_memory); print_file(file, 2, "NdrFcShort(0x%hx),\t/* Buffer offset = %d */\n", *offset_in_buffer, *offset_in_buffer);