Module: wine Branch: master Commit: cee52d598853dbf07ca492f4a8755b4ce65d9eb4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=cee52d598853dbf07ca492f4a...
Author: Eric Pouech eric.pouech@gmail.com Date: Tue Sep 7 09:27:07 2021 +0200
dbghelp: Get rid of useless symt_normalize_func().
Signed-off-by: Eric Pouech eric.pouech@gmail.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
dlls/dbghelp/dbghelp_private.h | 2 -- dlls/dbghelp/dwarf.c | 1 - dlls/dbghelp/msc.c | 3 --- dlls/dbghelp/stabs.c | 1 - dlls/dbghelp/symbol.c | 14 -------------- 5 files changed, 21 deletions(-)
diff --git a/dlls/dbghelp/dbghelp_private.h b/dlls/dbghelp/dbghelp_private.h index 162e8bc004d..f9191ae1205 100644 --- a/dlls/dbghelp/dbghelp_private.h +++ b/dlls/dbghelp/dbghelp_private.h @@ -745,8 +745,6 @@ extern struct symt_function* const char* name, ULONG_PTR addr, ULONG_PTR size, struct symt* type) DECLSPEC_HIDDEN; -extern BOOL symt_normalize_function(struct module* module, - const struct symt_function* func) DECLSPEC_HIDDEN; extern void symt_add_func_line(struct module* module, struct symt_function* func, unsigned source_idx, int line_num, diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index 319f5c2673c..af84fb660b8 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -1983,7 +1983,6 @@ static struct symt* dwarf2_parse_subprogram(dwarf2_parse_context_t* ctx, symt_add_function_point(ctx->module, subpgm.func, SymTagCustom, &subpgm.frame, NULL); } - if (subpgm.func) symt_normalize_function(subpgm.ctx->module, subpgm.func);
return di->symt; } diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c index 36ab355d0a3..c3e243879b2 100644 --- a/dlls/dbghelp/msc.c +++ b/dlls/dbghelp/msc.c @@ -1827,7 +1827,6 @@ static BOOL codeview_snarf(const struct msc_debug_info* msc_dbg, const BYTE* roo } else if (curr_func) { - symt_normalize_function(msc_dbg->module, curr_func); curr_func = NULL; } break; @@ -2035,8 +2034,6 @@ static BOOL codeview_snarf(const struct msc_debug_info* msc_dbg, const BYTE* roo } }
- if (curr_func) symt_normalize_function(msc_dbg->module, curr_func); - return TRUE; }
diff --git a/dlls/dbghelp/stabs.c b/dlls/dbghelp/stabs.c index bdafb98bbd4..7008f60ea82 100644 --- a/dlls/dbghelp/stabs.c +++ b/dlls/dbghelp/stabs.c @@ -1196,7 +1196,6 @@ static void stabs_finalize_function(struct module* module, struct symt_function* DWORD disp;
if (!func) return; - symt_normalize_function(module, func); /* To define the debug-start of the function, we use the second line number. * Not 100% bullet proof, but better than nothing */ diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c index e91f0dd1e07..8f192662b7d 100644 --- a/dlls/dbghelp/symbol.c +++ b/dlls/dbghelp/symbol.c @@ -470,20 +470,6 @@ struct symt_hierarchy_point* symt_add_function_point(struct module* module, return sym; }
-BOOL symt_normalize_function(struct module* module, const struct symt_function* func) -{ - assert(func); - /* We aren't adding any more locals or line numbers to this function. - * Free any spare memory that we might have allocated. - */ - assert(func->symt.tag == SymTagFunction); - -/* EPP vector_pool_normalize(&func->vlines, &module->pool); */ -/* EPP vector_pool_normalize(&func->vchildren, &module->pool); */ - - return TRUE; -} - struct symt_thunk* symt_new_thunk(struct module* module, struct symt_compiland* compiland, const char* name, THUNK_ORDINAL ord,