Francois Gouget : testbot/web: Simplify FormPage::GetDisplayValue().

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 15657d233d70b3ff724910b41313a6631b9b6695
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=15657d233d70b3ff724910b4...

Author: Francois Gouget 
Date:   Fri Nov 30 12:55:15 2018 +0100

testbot/web: Simplify FormPage::GetDisplayValue().

Signed-off-by: Francois Gouget 
Signed-off-by: Alexandre Julliard

---

testbot/lib/ObjectModel/CGI/FormPage.pm | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm
index 01f7894..735755f 100644
--- a/testbot/lib/ObjectModel/CGI/FormPage.pm
+++ b/testbot/lib/ObjectModel/CGI/FormPage.pm
@@ -189,12 +189,8 @@ sub GetDisplayValue($$)
 {
   my ($self, $PropertyDescriptor) = @_;

-  my $Value;
-  if (defined($self->GetParam($PropertyDescriptor->GetName())))
-  {
-    $Value = $self->GetParam($PropertyDescriptor->GetName());
-  }
-  else
+  my $Value = $self->GetParam($PropertyDescriptor->GetName());
+  if (!defined $Value)
   {
     $Value = $self->GetPropertyValue($PropertyDescriptor);
   }