Francois Gouget : testbot/web: Simplify the FeedBack page by using GetParam() to set suitable defaults.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 5e34ba480fac9e561253ca91c1ea9530a4bd1e0e
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=5e34ba480fac9e561253ca91c...

Author: Francois Gouget 
Date:   Fri Jun 13 18:23:32 2014 +0200

testbot/web: Simplify the FeedBack page by using GetParam() to set suitable defaults.

---

testbot/web/Feedback.pl |   22 +++-------------------
 1 file changed, 3 insertions(+), 19 deletions(-)

diff --git a/testbot/web/Feedback.pl b/testbot/web/Feedback.pl
index f0ae921..5d3e2e6 100644
--- a/testbot/web/Feedback.pl
+++ b/testbot/web/Feedback.pl
@@ -42,27 +42,11 @@ sub _initialize($$$)
   my $Session = $self->GetCurrentSession();
   if (defined($Session))
   {
+    # Provide default values
     my $User = $Session->User;
-    $self->{Name} = $User->RealName;
-    $self->{EMail} = $User->EMail;
+    $self->GetParam("Name", $User->RealName) if (!defined $self->GetParam("Name"));
+    $self->GetParam("EMail", $User->EMail) if (!defined $self->GetParam("EMail"));
   }
-  else
-  {
-    $self->{Name} = undef;
-    $self->{EMail} = undef;
-  }
-}
-
-sub GetPropertyValue($$)
-{
-  my ($self, $PropertyDescriptor) = @_;
-
-  if (defined($self->{$PropertyDescriptor->GetName()}))
-  {
-    return $self->{$PropertyDescriptor->GetName()};
-  }
-
-  return $self->SUPER::GetPropertyValue($PropertyDescriptor);
 }

sub GetTitle($)