Gabriel Ivăncescu : mshtml: Use unlink and destructor in the vtbl for HTMLDOMRange.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 5c3f4e4b7c7c8fd543c4d0d1f19878bd35d0a86a
URL:    https://gitlab.winehq.org/wine/wine/-/commit/5c3f4e4b7c7c8fd543c4d0d1f19878b...

Author: Gabriel Ivăncescu 
Date:   Thu Aug  3 15:56:12 2023 +0300

mshtml: Use unlink and destructor in the vtbl for HTMLDOMRange.

Signed-off-by: Gabriel Ivăncescu

---

dlls/mshtml/range.c | 30 ++++++++++++++++++++++++------
 1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/dlls/mshtml/range.c b/dlls/mshtml/range.c
index 1f062f5022a..d55851ac87e 100644
--- a/dlls/mshtml/range.c
+++ b/dlls/mshtml/range.c
@@ -1799,12 +1799,8 @@ static ULONG WINAPI HTMLDOMRange_Release(IHTMLDOMRange *iface)

TRACE("(%p) ref=%ld\n", This, ref);

-    if(!ref) {
-        if(This->nsrange)
-            nsIDOMRange_Release(This->nsrange);
+    if(!ref)
         release_dispex(&This->dispex);
-        free(This);
-    }

return ref;
 }
@@ -2063,6 +2059,28 @@ static const IHTMLDOMRangeVtbl HTMLDOMRangeVtbl = {
     HTMLDOMRange_getBoundingClientRect,
 };

+static inline HTMLDOMRange *HTMLDOMRange_from_DispatchEx(DispatchEx *iface)
+{
+    return CONTAINING_RECORD(iface, HTMLDOMRange, dispex);
+}
+
+static void HTMLDOMRange_unlink(DispatchEx *dispex)
+{
+    HTMLDOMRange *This = HTMLDOMRange_from_DispatchEx(dispex);
+    unlink_ref(&This->nsrange);
+}
+
+static void HTMLDOMRange_destructor(DispatchEx *dispex)
+{
+    HTMLDOMRange *This = HTMLDOMRange_from_DispatchEx(dispex);
+    free(This);
+}
+
+static const dispex_static_data_vtbl_t HTMLDOMRange_dispex_vtbl = {
+    HTMLDOMRange_destructor,
+    HTMLDOMRange_unlink
+};
+
 static const tid_t HTMLDOMRange_iface_tids[] = {
     IHTMLDOMRange_tid,
     0
@@ -2070,7 +2088,7 @@ static const tid_t HTMLDOMRange_iface_tids[] = {

static dispex_static_data_t HTMLDOMRange_dispex = {
     L"Range",
-    NULL,
+    &HTMLDOMRange_dispex_vtbl,
     DispHTMLDOMRange_tid,
     HTMLDOMRange_iface_tids
 };