Module: wine Branch: master Commit: 896be411438f961503478843fc7e2ddda8c28f75 URL: http://source.winehq.org/git/wine.git/?a=commit;h=896be411438f961503478843fc...
Author: Marcus Meissner marcus@jet.franken.de Date: Fri Dec 31 12:50:36 2010 +0100
crypt32: Handle NULL ptr leak in CryptDecodeObjectEx (Coverity).
---
dlls/crypt32/decode.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c index a1431fb..dd0064d 100644 --- a/dlls/crypt32/decode.c +++ b/dlls/crypt32/decode.c @@ -5976,8 +5976,15 @@ BOOL WINAPI CryptDecodeObjectEx(DWORD dwCertEncodingType, LPCSTR lpszStructType, }
SetLastError(NOERROR); - if (dwFlags & CRYPT_DECODE_ALLOC_FLAG && pvStructInfo) + if (dwFlags & CRYPT_DECODE_ALLOC_FLAG) + { + if (!pvStructInfo) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } *(BYTE **)pvStructInfo = NULL; + } decodeFunc = CRYPT_GetBuiltinDecoder(dwCertEncodingType, lpszStructType); if (!decodeFunc) {