Juan Lang : crypt32: Explicitly pass array pointer when decoding cert policy qualifiers rather than assuming a particular alignment .

[Alexandre Julliard]

Module: wine
Branch: master
Commit: f5946e4acbbacfaa979ee025e74321503c08ae41
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f5946e4acbbacfaa979ee025e7...

Author: Juan Lang 
Date:   Wed Oct 14 12:56:03 2009 -0700

crypt32: Explicitly pass array pointer when decoding cert policy qualifiers rather than assuming a particular alignment.

---

dlls/crypt32/decode.c |   30 ++++++++++++++++++++++++++----
 1 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c
index 7475a83..fdd0251 100644
--- a/dlls/crypt32/decode.c
+++ b/dlls/crypt32/decode.c
@@ -3938,14 +3938,36 @@ static BOOL CRYPT_AsnDecodePolicyQualifiers(const BYTE *pbEncoded,
     struct AsnArrayDescriptor arrayDesc = { ASN_SEQUENCEOF,
      CRYPT_AsnDecodePolicyQualifier, sizeof(CERT_POLICY_QUALIFIER_INFO), TRUE,
      offsetof(CERT_POLICY_QUALIFIER_INFO, pszPolicyQualifierId) };
-    struct GenericArray *entries = pvStructInfo;
+    DWORD bytesNeeded;

TRACE("%p, %d, %08x, %p, %d\n", pbEncoded, cbEncoded, dwFlags,
      pvStructInfo, pvStructInfo ? *pcbStructInfo : 0);

-    ret = CRYPT_AsnDecodeArray(&arrayDesc, pbEncoded, cbEncoded, dwFlags,
-     NULL, pvStructInfo, pcbStructInfo, pcbDecoded,
-     entries ? entries->rgItems : NULL);
+    ret = CRYPT_AsnDecodeArrayNoAlloc(&arrayDesc, pbEncoded, cbEncoded,
+     NULL, NULL, &bytesNeeded, pcbDecoded);
+    if (ret)
+    {
+        /* The size expected by the caller includes the combination of
+         * CERT_POLICY_INFO's cPolicyQualifier and rgPolicyQualifier,
+         * in addition to the size of all the decoded items.
+         * CRYPT_AsnDecodeArrayNoAlloc only returns the size of the decoded
+         * items, so add the size of cPolicyQualifier and rgPolicyQualifier.
+         */
+        bytesNeeded += FINALMEMBERSIZE(CERT_POLICY_INFO, cPolicyQualifier);
+        if (!pvStructInfo)
+            *pcbStructInfo = bytesNeeded;
+        else if ((ret = CRYPT_DecodeEnsureSpace(dwFlags, NULL, pvStructInfo,
+         pcbStructInfo, bytesNeeded)))
+        {
+            CERT_POLICY_INFO *info;
+
+            info = (CERT_POLICY_INFO *)((BYTE *)pvStructInfo -
+             offsetof(CERT_POLICY_INFO, cPolicyQualifier));
+            ret = CRYPT_AsnDecodeArrayNoAlloc(&arrayDesc, pbEncoded, cbEncoded,
+             &info->cPolicyQualifier, info->rgPolicyQualifier, &bytesNeeded,
+             pcbDecoded);
+        }
+    }
     TRACE("Returning %d (%08x)\n", ret, GetLastError());
     return ret;
 }