Francois Gouget : Revert "testbot/web: Tweak ItemPage to save the Item directly.".

[Alexandre Julliard]

Module: tools
Branch: master
Commit: ed4208e634b2fa21d3a8d3580882976bb31f51d0
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=ed4208e634b2fa21d3a8d358...

Author: Francois Gouget 
Date:   Sat Apr 21 19:56:52 2018 +0200

Revert "testbot/web: Tweak ItemPage to save the Item directly.".

Saving the item directly is ok when modifying it, but DBIBackend only
supports saving new items through the collection. In particular the
registration web page depends on that so we have no choice but to go
through the collection.

This reverts commit c18379abe004411ca779d4c42e26d7e7f3d72ba6.

Signed-off-by: Alexandre Julliard

---

testbot/lib/ObjectModel/CGI/ItemPage.pm | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index c208aea..9b9f2ff 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -134,16 +134,6 @@ sub SaveProperty($$$)
   return 1;
 }

-sub Save($)
-{
-  my ($self) = @_;
-
-  return !1 if (!$self->SaveProperties());
-
-  ($self->{ErrField}, $self->{ErrMessage}) = $self->{Item}->Save();
-  return ! defined($self->{ErrMessage});
-}
-
 sub OnAction($$)
 {
   my ($self, $Action) = @_;