Dmitry Timoshkov : msi: Avoid using dialog record after free.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 2ad9312f02b86591073532737f8afac20aed8a9b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2ad9312f02b86591073532737f...

Author: Dmitry Timoshkov 
Date:   Tue Aug 18 17:40:05 2015 +0800

msi: Avoid using dialog record after free.

---

dlls/msi/dialog.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
index 5d3527f..a79ce1f 100644
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -3664,8 +3664,11 @@ static LRESULT msi_dialog_oncreate( HWND hwnd, LPCREATESTRUCTW cs )
     if (!dialog->default_font)
     {
         dialog->default_font = strdupW(dfv);
-        msiobj_release( &rec->hdr );
-        if (!dialog->default_font) return -1;
+        if (!dialog->default_font)
+        {
+            msiobj_release( &rec->hdr );
+            return -1;
+        }
     }

title = msi_get_deformatted_field( dialog->package, rec, 7 );