Module: wine Branch: master Commit: c34089014646c8ac203bd7bdf509b9a1431078c5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c34089014646c8ac203bd7bdf...
Author: Sven Baars sven.wine@gmail.com Date: Sun May 26 16:07:46 2019 +0200
kernel32/tests: Open and close the right file handle (Coverity).
Signed-off-by: Sven Baars sven.wine@gmail.com Signed-off-by: Zhiyi Zhang zzhang@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
dlls/kernel32/tests/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index 9bf80f6..b22ae19 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -3735,13 +3735,13 @@ static void test_ReplaceFileA(void) /* replace file while replacement is opened */ ret = GetTempFileNameA(temp_path, prefix, 0, replacement); ok(ret != 0, "GetTempFileNameA error (replacement) %d\n", GetLastError()); - CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0); + hReplacementFile = CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0); ok(hReplacementFile != INVALID_HANDLE_VALUE, "unexpected error, replacement file should be able to be opened %d\n", GetLastError()); ret = pReplaceFileA(replaced, replacement, NULL, 0, 0, 0); ok(!ret, "expect failure\n"); ok(GetLastError() == ERROR_SHARING_VIOLATION, "expect ERROR_SHARING_VIOLATION, got %#x.\n", GetLastError()); - CloseHandle(hReplacedFile); + CloseHandle(hReplacementFile);
/* replacement file still exists, make pass w/o "replaced" */ ret = DeleteFileA(replaced);