Serge Gautherie : wininet: Get rid of user buffer in create_cookie_url().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: d2a1c906dc4979eeabe256f77a58d67290da372d
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=d2a1c906dc4979eeabe256f77...

Author: Serge Gautherie 
Date:   Thu Jul 16 06:00:11 2020 +0200

wininet: Get rid of user buffer in create_cookie_url().

Signed-off-by: Serge Gautherie 
Signed-off-by: Jacek Caban 
Signed-off-by: Alexandre Julliard

---

dlls/wininet/cookie.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c
index b5f779b267..1786b3d281 100644
--- a/dlls/wininet/cookie.c
+++ b/dlls/wininet/cookie.c
@@ -147,28 +147,31 @@ static cookie_domain_t *get_cookie_domain(substr_t domain, BOOL create)

static WCHAR *create_cookie_url(substr_t domain, substr_t path, substr_t *ret_path)
 {
-    WCHAR user[UNLEN], *p, *url;
+    WCHAR *p, *url;
     DWORD len, user_len, i;

static const WCHAR cookie_prefix[] = {'C','o','o','k','i','e',':'};

-    user_len = ARRAY_SIZE(user);
-    if(!GetUserNameW(user, &user_len))
-        return FALSE;
-    user_len--;
+    user_len = 0;
+    if(GetUserNameW(NULL, &user_len) || GetLastError() != ERROR_INSUFFICIENT_BUFFER)
+        return NULL;

+    /* user_len already accounts for terminating NULL */
     len = ARRAY_SIZE(cookie_prefix) + user_len + 1 /* @ */ + domain.len + path.len;
-    url = heap_alloc((len+1) * sizeof(WCHAR));
+    url = heap_alloc(len * sizeof(WCHAR));
     if(!url)
         return NULL;

memcpy(url, cookie_prefix, sizeof(cookie_prefix));
     p = url + ARRAY_SIZE(cookie_prefix);

-    memcpy(p, user, user_len*sizeof(WCHAR));
+    if(!GetUserNameW(p, &user_len)) {
+        heap_free(url);
+        return NULL;
+    }
     p += user_len;

-    *p++ = '@';
+    *(p - 1) = '@';

memcpy(p, domain.str, domain.len*sizeof(WCHAR));
     p += domain.len;