Francois Gouget : testbot: Adjust the StepsTasks fields.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 7289b67f0fd4c5a6b00aa5e59475610519080b4c
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=7289b67f0fd4c5a6b00aa5e5...

Author: Francois Gouget 
Date:   Thu May 31 10:59:40 2018 +0200

testbot: Adjust the StepsTasks fields.

The StepTask class duplicates the Step and Task classes and its fields
are mostly used in read-only mode so we don't care about their exact
type too much, particularly for enums. Still, try to specify valid
lengths so we don't get errors one day if Validate() is called.

Signed-off-by: Francois Gouget 
Signed-off-by: Alexandre Julliard

---

testbot/lib/WineTestBot/StepsTasks.pm | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/testbot/lib/WineTestBot/StepsTasks.pm b/testbot/lib/WineTestBot/StepsTasks.pm
index ff94b14..db0cc06 100644
--- a/testbot/lib/WineTestBot/StepsTasks.pm
+++ b/testbot/lib/WineTestBot/StepsTasks.pm
@@ -162,20 +162,21 @@ sub CreateItem($)
   return WineTestBot::StepTask->new($self);
 }

+# Note: To simplify maintenance replace enums with simple string fields.
 my @PropertyDescriptors = (
-  CreateBasicPropertyDescriptor("Id", "Id", 1,  1, "N", 4),
-  CreateBasicPropertyDescriptor("StepNo", "Step no", !1,  1, "N", 2),
-  CreateBasicPropertyDescriptor("TaskNo", "Task no", ! 1,  1, "N", 2),
-  CreateBasicPropertyDescriptor("Type", "Step type", !1, 1, "A", 6),
-  CreateBasicPropertyDescriptor("Status", "Status",  !1,  1, "A", 9),
-  CreateItemrefPropertyDescriptor("VM", "VM", !1,  1, &CreateVMs, ["VMName"]),
+  CreateBasicPropertyDescriptor("Id", "Id", 1, 1, "N", 4),
+  CreateBasicPropertyDescriptor("StepNo", "Step no", !1, 1, "N", 2),
+  CreateBasicPropertyDescriptor("TaskNo", "Task no", !1, 1, "N", 2),
+  CreateBasicPropertyDescriptor("Type", "Step type", !1, 1, "A", 32),
+  CreateBasicPropertyDescriptor("Status", "Status", !1, 1, "A", 32),
+  CreateItemrefPropertyDescriptor("VM", "VM", !1, 1, &CreateVMs, ["VMName"]),
   CreateBasicPropertyDescriptor("Timeout", "Timeout", !1, 1, "N", 4),
-  CreateBasicPropertyDescriptor("FileName", "File name",  !1,  1, "A", 64),
-  CreateBasicPropertyDescriptor("FileType", "File Type",  !1,  1, "A", 64),
+  CreateBasicPropertyDescriptor("FileName", "File name", !1, 1, "A", 100),
+  CreateBasicPropertyDescriptor("FileType", "File Type", !1, 1, "A", 32),
   CreateBasicPropertyDescriptor("CmdLineArg", "Command line args", !1, !1, "A", 256),
   CreateBasicPropertyDescriptor("Started", "Execution started", !1, !1, "DT", 19),
   CreateBasicPropertyDescriptor("Ended", "Execution ended", !1, !1, "DT", 19),
-  CreateBasicPropertyDescriptor("TestFailures", "Number of test failures", !1, !1, "N", 5),
+  CreateBasicPropertyDescriptor("TestFailures", "Number of test failures", !1, !1, "N", 6),
 );

sub CreateStepsTasks(;$$)