Hans Leidekker : wbemprox: Add helpers for retrieving class instances.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 0f11ac361e39c370f5fe995dc41bb81ab9df574b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0f11ac361e39c370f5fe995dc4...

Author: Hans Leidekker 
Date:   Wed Jul 25 13:12:28 2012 +0200

wbemprox: Add helpers for retrieving class instances.

---

dlls/wbemprox/services.c         |   65 ++++++++++++++++++++------------------
 dlls/wbemprox/wbemprox_private.h |    1 +
 2 files changed, 35 insertions(+), 31 deletions(-)

diff --git a/dlls/wbemprox/services.c b/dlls/wbemprox/services.c
index 8edd2f6..e8c5461 100644
--- a/dlls/wbemprox/services.c
+++ b/dlls/wbemprox/services.c
@@ -235,40 +235,54 @@ static HRESULT WINAPI wbem_services_QueryObjectSink(
     return WBEM_E_FAILED;
 }

-static HRESULT WINAPI wbem_services_GetObject(
-    IWbemServices *iface,
-    const BSTR strObjectPath,
-    LONG lFlags,
-    IWbemContext *pCtx,
-    IWbemClassObject **ppObject,
-    IWbemCallResult **ppCallResult )
+static HRESULT create_instance_enum( const WCHAR *class, IEnumWbemClassObject **iter )
 {
     static const WCHAR selectW[] = {'S','E','L','E','C','T',' ','*',' ','F','R','O','M',' ',0};
-    IEnumWbemClassObject *iter;
     WCHAR *query;
     HRESULT hr;

-    TRACE("%p, %s, 0x%08x, %p, %p, %p\n", iface, debugstr_w(strObjectPath), lFlags,
-          pCtx, ppObject, ppCallResult);
-
-    if (lFlags) FIXME("unsupported flags 0x%08x\n", lFlags);
+    query = heap_alloc( strlenW( class ) * sizeof(WCHAR) + sizeof(selectW) );
+    if (!query) return E_OUTOFMEMORY;

-    /* FIXME: parse path */
-
-    if (!(query = heap_alloc( strlenW( strObjectPath ) * sizeof(WCHAR) + sizeof(selectW) )))
-        return E_OUTOFMEMORY;
     strcpyW( query, selectW );
-    strcatW( query, strObjectPath );
+    strcatW( query, class );

-    hr = exec_query( query, &iter );
+    hr = exec_query( query, iter );
     heap_free( query );
+    return hr;
+}
+
+HRESULT get_object( const WCHAR *path, IWbemClassObject **obj )
+{
+    IEnumWbemClassObject *iter;
+    HRESULT hr;
+
+    /* FIXME: parse path */
+
+    hr = create_instance_enum( path, &iter );
     if (hr != S_OK) return hr;

-    hr = WbemClassObject_create( NULL, iter, 0, (void **)ppObject );
+    hr = WbemClassObject_create( NULL, iter, 0, (void **)obj );
     IEnumWbemClassObject_Release( iter );
     return hr;
 }

+static HRESULT WINAPI wbem_services_GetObject(
+    IWbemServices *iface,
+    const BSTR strObjectPath,
+    LONG lFlags,
+    IWbemContext *pCtx,
+    IWbemClassObject **ppObject,
+    IWbemCallResult **ppCallResult )
+{
+    TRACE("%p, %s, 0x%08x, %p, %p, %p\n", iface, debugstr_w(strObjectPath), lFlags,
+          pCtx, ppObject, ppCallResult);
+
+    if (lFlags) FIXME("unsupported flags 0x%08x\n", lFlags);
+
+    return get_object( strObjectPath, ppObject );
+}
+
 static HRESULT WINAPI wbem_services_GetObjectAsync(
     IWbemServices *iface,
     const BSTR strObjectPath,
@@ -397,22 +411,11 @@ static HRESULT WINAPI wbem_services_CreateInstanceEnum(
     IWbemContext *pCtx,
     IEnumWbemClassObject **ppEnum )
 {
-    static const WCHAR selectW[] = {'S','E','L','E','C','T',' ','*',' ','F','R','O','M',' ',0};
-    WCHAR *query;
-    HRESULT hr;
-
     TRACE("%p, %s, 0%08x, %p, %p\n", iface, debugstr_w(strClass), lFlags, pCtx, ppEnum);

if (lFlags) FIXME("unsupported flags 0x%08x\n", lFlags);

-    if (!(query = heap_alloc( strlenW( strClass ) * sizeof(WCHAR) + sizeof(selectW) )))
-        return E_OUTOFMEMORY;
-    strcpyW( query, selectW );
-    strcatW( query, strClass );
-
-    hr = exec_query( query, ppEnum );
-    heap_free( query );
-    return hr;
+    return create_instance_enum( strClass, ppEnum );
 }

static HRESULT WINAPI wbem_services_CreateInstanceEnumAsync(
diff --git a/dlls/wbemprox/wbemprox_private.h b/dlls/wbemprox/wbemprox_private.h
index 14c97b2..725ea8c 100644
--- a/dlls/wbemprox/wbemprox_private.h
+++ b/dlls/wbemprox/wbemprox_private.h
@@ -142,6 +142,7 @@ HRESULT get_propval( const struct view *, UINT, const WCHAR *, VARIANT *,
                      CIMTYPE *, LONG * ) DECLSPEC_HIDDEN;
 HRESULT put_propval( const struct view *, UINT, const WCHAR *, VARIANT *, CIMTYPE ) DECLSPEC_HIDDEN;
 HRESULT get_properties( const struct view *, SAFEARRAY ** ) DECLSPEC_HIDDEN;
+HRESULT get_object( const WCHAR *, IWbemClassObject ** ) DECLSPEC_HIDDEN;

HRESULT WbemLocator_create(IUnknown *, LPVOID *) DECLSPEC_HIDDEN;
 HRESULT WbemServices_create(IUnknown *, const WCHAR *, LPVOID *) DECLSPEC_HIDDEN;