Michael Stefaniuc : wininet: Simplify the check for an empty string ( PVS-Studio).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 51302e011af440eada59bf09759e0ad06a42d1f4
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=51302e011af440eada59bf0975...

Author: Michael Stefaniuc 
Date:   Mon Nov 10 23:41:51 2014 +0100

wininet: Simplify the check for an empty string (PVS-Studio).

---

dlls/wininet/ftp.c            | 2 +-
 dlls/wininet/tests/internet.c | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/wininet/ftp.c b/dlls/wininet/ftp.c
index 855aee0..f45e495 100644
--- a/dlls/wininet/ftp.c
+++ b/dlls/wininet/ftp.c
@@ -2496,7 +2496,7 @@ HINTERNET FTP_Connect(appinfo_t *hIC, LPCWSTR lpszServerName,
         if(hIC->proxyBypass)
             FIXME("Proxy bypass is ignored.\n");
     }
-    if (!lpszUserName || !strlenW(lpszUserName)) {
+    if (!lpszUserName || !lpszUserName[0]) {
         HKEY key;
         WCHAR szPassword[MAX_PATH];
         DWORD len = sizeof(szPassword);
diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c
index 1548615..5e09525 100644
--- a/dlls/wininet/tests/internet.c
+++ b/dlls/wininet/tests/internet.c
@@ -1578,7 +1578,7 @@ static void test_InternetGetConnectedStateExA(void)
     res = pInternetGetConnectedStateExA(&flags, buffer, 1, 0);
     ok(res == TRUE, "Expected TRUE, got %d\n", res);
     ok(flags, "Expected at least one flag set\n");
-    ok(strlen(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenA(buffer));
+    ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenA(buffer));

buffer[0] = 0;
     flags = 0;
@@ -1592,7 +1592,7 @@ static void test_InternetGetConnectedStateExA(void)
     res = pInternetGetConnectedStateExA(&flags, buffer, 1, 0);
     ok(res == TRUE, "Expected TRUE, got %d\n", res);
     ok(flags, "Expected at least one flag set\n");
-    ok(strlen(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenA(buffer));
+    ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenA(buffer));
 }

static void test_InternetGetConnectedStateExW(void)
@@ -1667,7 +1667,7 @@ static void test_InternetGetConnectedStateExW(void)
     res = pInternetGetConnectedStateExW(&flags, buffer, 1, 0);
     ok(res == TRUE, "Expected TRUE, got %d\n", res);
     ok(flags, "Expected at least one flag set\n");
-    ok(lstrlenW(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenW(buffer));
+    ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenW(buffer));

buffer[0] = 0;
     flags = 0;
@@ -1681,7 +1681,7 @@ static void test_InternetGetConnectedStateExW(void)
     res = pInternetGetConnectedStateExW(&flags, buffer, 1, 0);
     ok(res == TRUE, "Expected TRUE, got %d\n", res);
     ok(flags, "Expected at least one flag set\n");
-    ok(lstrlenW(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenW(buffer));
+    ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenW(buffer));
 }

/* ############################### */