Nikolay Sivov : comctl32/monthcal: Fix MCM_SETCURSEL for multiple calendars case.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 2c6443ae57ec50494894751f77f3f6103e8bc77a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2c6443ae57ec50494894751f77...

Author: Nikolay Sivov 
Date:   Mon Sep 19 10:44:22 2011 +0400

comctl32/monthcal: Fix MCM_SETCURSEL for multiple calendars case.

---

dlls/comctl32/monthcal.c |   96 ++++++++++++++++++++++++++-------------------
 1 files changed, 55 insertions(+), 41 deletions(-)

diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c
index cb007d7..d757c31 100644
--- a/dlls/comctl32/monthcal.c
+++ b/dlls/comctl32/monthcal.c
@@ -202,6 +202,11 @@ static inline void MONTHCAL_NotifySelect(const MONTHCAL_INFO *infoPtr)
     SendMessageW(infoPtr->hwndNotify, WM_NOTIFY, nmsc.nmhdr.idFrom, (LPARAM)&nmsc);
 }

+static inline int MONTHCAL_MonthDiff(const SYSTEMTIME *left, const SYSTEMTIME *right)
+{
+    return (right->wYear - left->wYear)*12 + right->wMonth - left->wMonth;
+}
+
 /* returns the number of days in any given month, checking for leap days */
 /* January is 1, December is 12 */
 int MONTHCAL_MonthLength(int month, int year)
@@ -1462,6 +1467,7 @@ static LRESULT
 MONTHCAL_SetCurSel(MONTHCAL_INFO *infoPtr, SYSTEMTIME *curSel)
 {
   SYSTEMTIME prev = infoPtr->minSel;
+  INT diff;
   WORD day;

TRACE("%p\n", curSel);
@@ -1474,7 +1480,22 @@ MONTHCAL_SetCurSel(MONTHCAL_INFO *infoPtr, SYSTEMTIME *curSel)

if(!MONTHCAL_IsDateInValidRange(infoPtr, curSel, FALSE)) return FALSE;

-  infoPtr->calendars[0].month = *curSel;
+  /* scroll calendars only if we have to */
+  diff = MONTHCAL_MonthDiff(&infoPtr->calendars[MONTHCAL_GetCalCount(infoPtr)-1].month, curSel);
+  if (diff <= 0)
+  {
+    diff = MONTHCAL_MonthDiff(&infoPtr->calendars[0].month, curSel);
+    if (diff > 0) diff = 0;
+  }
+
+  if (diff != 0)
+  {
+    INT i;
+
+    for (i = 0; i < MONTHCAL_GetCalCount(infoPtr); i++)
+      MONTHCAL_GetMonth(&infoPtr->calendars[i].month, diff);
+  }
+
   infoPtr->minSel = *curSel;
   infoPtr->maxSel = *curSel;

@@ -1542,56 +1563,49 @@ MONTHCAL_GetSelRange(const MONTHCAL_INFO *infoPtr, SYSTEMTIME *range)
 static LRESULT
 MONTHCAL_SetSelRange(MONTHCAL_INFO *infoPtr, SYSTEMTIME *range)
 {
-  TRACE("%p\n", range);
-
-  if(!range) return FALSE;
+  SYSTEMTIME old_range[2];

-  if(infoPtr->dwStyle & MCS_MULTISELECT)
-  {
-    SYSTEMTIME old_range[2];
+  TRACE("%p\n", range);

-    /* adjust timestamps */
-    if(!MONTHCAL_ValidateTime(&range[0]))
-      MONTHCAL_CopyTime(&infoPtr->todaysDate, &range[0]);
-    if(!MONTHCAL_ValidateTime(&range[1]))
-      MONTHCAL_CopyTime(&infoPtr->todaysDate, &range[1]);
+  if(!range || !(infoPtr->dwStyle & MCS_MULTISELECT)) return FALSE;

-    /* maximum range exceeded */
-    if(!MONTHCAL_IsSelRangeValid(infoPtr, &range[0], &range[1], NULL)) return FALSE;
+  /* adjust timestamps */
+  if(!MONTHCAL_ValidateTime(&range[0])) MONTHCAL_CopyTime(&infoPtr->todaysDate, &range[0]);
+  if(!MONTHCAL_ValidateTime(&range[1])) MONTHCAL_CopyTime(&infoPtr->todaysDate, &range[1]);

-    old_range[0] = infoPtr->minSel;
-    old_range[1] = infoPtr->maxSel;
+  /* maximum range exceeded */
+  if(!MONTHCAL_IsSelRangeValid(infoPtr, &range[0], &range[1], NULL)) return FALSE;

-    /* swap if min > max */
-    if(MONTHCAL_CompareSystemTime(&range[0], &range[1]) <= 0)
-    {
-      infoPtr->minSel = range[0];
-      infoPtr->maxSel = range[1];
-    }
-    else
-    {
-      infoPtr->minSel = range[1];
-      infoPtr->maxSel = range[0];
-    }
-    infoPtr->calendars[0].month = infoPtr->minSel;
+  old_range[0] = infoPtr->minSel;
+  old_range[1] = infoPtr->maxSel;

-    /* update day of week */
-    MONTHCAL_CalculateDayOfWeek(&infoPtr->minSel, TRUE);
-    MONTHCAL_CalculateDayOfWeek(&infoPtr->maxSel, TRUE);
+  /* swap if min > max */
+  if(MONTHCAL_CompareSystemTime(&range[0], &range[1]) <= 0)
+  {
+    infoPtr->minSel = range[0];
+    infoPtr->maxSel = range[1];
+  }
+  else
+  {
+    infoPtr->minSel = range[1];
+    infoPtr->maxSel = range[0];
+  }
+  infoPtr->calendars[0].month = infoPtr->minSel;

-    /* redraw if bounds changed */
-    /* FIXME: no actual need to redraw everything */
-    if(!MONTHCAL_IsDateEqual(&old_range[0], &range[0]) ||
-       !MONTHCAL_IsDateEqual(&old_range[1], &range[1]))
-    {
-       InvalidateRect(infoPtr->hwndSelf, NULL, FALSE);
-    }
+  /* update day of week */
+  MONTHCAL_CalculateDayOfWeek(&infoPtr->minSel, TRUE);
+  MONTHCAL_CalculateDayOfWeek(&infoPtr->maxSel, TRUE);

-    TRACE("[min,max]=[%d %d]\n", infoPtr->minSel.wDay, infoPtr->maxSel.wDay);
-    return TRUE;
+  /* redraw if bounds changed */
+  /* FIXME: no actual need to redraw everything */
+  if(!MONTHCAL_IsDateEqual(&old_range[0], &range[0]) ||
+     !MONTHCAL_IsDateEqual(&old_range[1], &range[1]))
+  {
+     InvalidateRect(infoPtr->hwndSelf, NULL, FALSE);
   }

-  return FALSE;
+  TRACE("[min,max]=[%d %d]\n", infoPtr->minSel.wDay, infoPtr->maxSel.wDay);
+  return TRUE;
 }