Module: tools Branch: master Commit: 497bad412434293d907e96e73cfc4b7287d86e0e URL: https://source.winehq.org/git/tools.git/?a=commit;h=497bad412434293d907e96e7...
Author: Francois Gouget fgouget@codeweavers.com Date: Thu Mar 8 17:48:56 2018 +0100
testbot: Simplify updating a Step's status.
Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
testbot/lib/WineTestBot/Steps.pm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm index 23e02cb..b8dbaec 100644 --- a/testbot/lib/WineTestBot/Steps.pm +++ b/testbot/lib/WineTestBot/Steps.pm @@ -146,12 +146,7 @@ sub UpdateStatus($$) return $Status if ($Status ne "queued" && $Status ne "running");
my %Has; - my $Tasks = $self->Tasks; - foreach my $TaskKey (@{$Tasks->GetKeys()}) - { - my $Task = $Tasks->GetItem($TaskKey); - $Has{$Task->UpdateStatus($Skip)} = 1; - } + map { $Has{$_->UpdateStatus($Skip)} = 1 } (@{$self->Tasks->GetItems()});
# Inherit the tasks most significant status. # Note that one or more tasks may have been requeued during the cleanup phase