David Kahurani : msvcrt: Free previous environment variable when clearing.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 1580c1133a190f850182ce891f7299a157b1d0fb
URL:    https://gitlab.winehq.org/wine/wine/-/commit/1580c1133a190f850182ce891f7299a...

Author: David Kahurani 
Date:   Fri Jan 26 16:08:33 2024 +0300

msvcrt: Free previous environment variable when clearing.

Shifting the rest of the variables by one towards indices of lesser value
overwrites the variable being cleared and effectively leaks it.

Signed-off-by: David Kahurani

---

dlls/msvcrt/environ.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/msvcrt/environ.c b/dlls/msvcrt/environ.c
index aa857afa615..a0d2e08c7d0 100644
--- a/dlls/msvcrt/environ.c
+++ b/dlls/msvcrt/environ.c
@@ -161,6 +161,7 @@ static int env_set(char **env, wchar_t **wenv)
     *eq = '=';
     if (!eq[1])
     {
+        free(MSVCRT__environ[idx]);
         for(; MSVCRT__environ[idx]; idx++)
             MSVCRT__environ[idx] = MSVCRT__environ[idx + 1];
     }
@@ -187,6 +188,7 @@ static int env_set(char **env, wchar_t **wenv)
     *weq = '=';
     if (!weq[1])
     {
+        free(MSVCRT__wenviron[idx]);
         for(; MSVCRT__wenviron[idx]; idx++)
             MSVCRT__wenviron[idx] = MSVCRT__wenviron[idx + 1];
     }