Module: wine Branch: master Commit: 0755a581fd42a898dbed7fd68c8047e6253250e5 URL: https://gitlab.winehq.org/wine/wine/-/commit/0755a581fd42a898dbed7fd68c8047e...
Author: Gabriel Ivăncescu gabrielopcode@gmail.com Date: Wed Jun 21 21:12:50 2023 +0300
mshtml: Fix element leaks in get_elem_source_index.
Signed-off-by: Gabriel Ivăncescu gabrielopcode@gmail.com
---
dlls/mshtml/htmlelemcol.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/dlls/mshtml/htmlelemcol.c b/dlls/mshtml/htmlelemcol.c index 75c86a8b4dd..75ee079e3c7 100644 --- a/dlls/mshtml/htmlelemcol.c +++ b/dlls/mshtml/htmlelemcol.c @@ -778,8 +778,8 @@ HRESULT get_elem_source_index(HTMLElement *elem, LONG *ret) nsIDOMNode *parent_node, *iter; UINT16 parent_type; HTMLDOMNode *node; - int i; nsresult nsres; + unsigned i, j; HRESULT hres;
iter = elem->node.nsnode; @@ -830,7 +830,11 @@ HRESULT get_elem_source_index(HTMLElement *elem, LONG *ret) break; } IHTMLDOMNode_Release(&node->IHTMLDOMNode_iface); + + for(j = 0; j < buf.len; j++) + IHTMLDOMNode_Release(&buf.buf[j]->node.IHTMLDOMNode_iface); free(buf.buf); + if(i == buf.len) { FIXME("The element is not in parent's child list?\n"); return E_UNEXPECTED;