Francois Gouget : testbot/web: Show the number of test units with failed tests.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: a318cfe5f94db5ecd46060caa6b96c3509b137c3
URL:    https://gitlab.winehq.org/winehq/tools/-/commit/a318cfe5f94db5ecd46060caa6b9...

Author: Francois Gouget 
Date:   Thu Nov 17 18:20:30 2022 +0100

testbot/web: Show the number of test units with failed tests.

---

testbot/web/JobDetails.pl | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl
index 506c7602..a4a250fa 100644
--- a/testbot/web/JobDetails.pl
+++ b/testbot/web/JobDetails.pl
@@ -50,7 +50,7 @@ sub DisplayProperty($$)
   my ($self, $PropertyDescriptor) = @_;

my $PropertyName = $PropertyDescriptor->GetName();
-  return $PropertyName =~ /^(?:Id|PreviousNo|Type|VM|FileType|Missions|NewWarnings|NewTestFailures|FailedTestUnits)$/ ? "" :
+  return $PropertyName =~ /^(?:Id|PreviousNo|Type|VM|FileType|Missions|NewWarnings|NewTestFailures)$/ ? "" :
          $PropertyName eq "Started" ? ("ro", "timetipdate") :
          $self->SUPER::DisplayProperty($PropertyDescriptor);
 }
@@ -85,6 +85,10 @@ sub GenerateHeaderView($$$)
   {
     print "<a class='title' title='New / All'>Failures</a>";
   }
+  elsif ($PropertyName eq "FailedTestUnits")
+  {
+    print "<a class='title' title='Failed test units'>Units</a>";
+  }
   else
   {
     $self->SUPER::GenerateHeaderView($Row, $Col);
@@ -164,6 +168,13 @@ sub GenerateDataView($$$)
     print "<span class='$class'>", $StepTask->TestFailures, "</span></a>";
     return;
   }
+  if ($PropertyName eq "FailedTestUnits" and defined $StepTask->FailedTestUnits)
+  {
+    my $class = $StepTask->TestFailures ? "testfail" : "success";
+    print "<a href='#k", $StepTask->GetKey(), "'><span class='$class'>",
+          $StepTask->FailedTestUnits, "</span></a>";
+    return;
+  }
   $self->SUPER::GenerateDataView($Row, $Col);
 }