Module: wine Branch: master Commit: e403292e5af8e5a1bc18de74a28d2fee6c482b19 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e403292e5af8e5a1bc18de74a2...
Author: Gerald Pfeifer gerald@pfeifer.com Date: Thu Nov 1 17:58:32 2007 +0100
shell32: Avoid checking for <0 for unsigned variables.
---
dlls/shell32/recyclebin.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/dlls/shell32/recyclebin.c b/dlls/shell32/recyclebin.c index 441068f..ddf2fc3 100644 --- a/dlls/shell32/recyclebin.c +++ b/dlls/shell32/recyclebin.c @@ -381,7 +381,7 @@ static HRESULT WINAPI RecycleBin_GetDefaultColumnState(IShellFolder2 *iface, UIN { RecycleBin *This = (RecycleBin *)iface; TRACE("(%p, %d, %p)\n", This, iColumn, pcsFlags); - if (iColumn < 0 || iColumn >= COLUMNS_COUNT) + if (iColumn >= COLUMNS_COUNT) return E_INVALIDARG; *pcsFlags = RecycleBinColumns[iColumn].pcsFlags; return S_OK; @@ -400,7 +400,7 @@ static HRESULT WINAPI RecycleBin_GetDetailsOf(IShellFolder2 *iface, LPCITEMIDLIS WCHAR buffer[MAX_PATH];
TRACE("(%p, %p, %d, %p)\n", This, pidl, iColumn, pDetails); - if (iColumn < 0 || iColumn >= COLUMNS_COUNT) + if (iColumn >= COLUMNS_COUNT) return E_FAIL; pDetails->fmt = RecycleBinColumns[iColumn].fmt; pDetails->cxChar = RecycleBinColumns[iColumn].cxChars; @@ -446,7 +446,7 @@ static HRESULT WINAPI RecycleBin_MapColumnToSCID(IShellFolder2 *iface, UINT iCol { RecycleBin *This = (RecycleBin *)iface; TRACE("(%p, %d, %p)\n", This, iColumn, pscid); - if (iColumn<0 || iColumn>=COLUMNS_COUNT) + if (iColumn>=COLUMNS_COUNT) return E_INVALIDARG; pscid->fmtid = *RecycleBinColumns[iColumn].fmtId; pscid->pid = RecycleBinColumns[iColumn].pid;