Rémi Bernon : winemac.drv: Stop using the cached_modes_mutex for get_default_bpp.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 3e3beee0b4d3c619e62a1d64b757d0a80c1cc967
URL:    https://gitlab.winehq.org/wine/wine/-/commit/3e3beee0b4d3c619e62a1d64b757d0a...

Author: Rémi Bernon 
Date:   Fri Sep  9 08:32:43 2022 +0200

winemac.drv: Stop using the cached_modes_mutex for get_default_bpp.

---

dlls/winemac.drv/display.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c
index b981aa12e35..f3d9ef06712 100644
--- a/dlls/winemac.drv/display.c
+++ b/dlls/winemac.drv/display.c
@@ -51,9 +51,6 @@ static const WCHAR initial_mode_keyW[] = {'I','n','i','t','i','a','l',' ','D','i
     ' ','M','o','d','e'};
 static const WCHAR pixelencodingW[] = {'P','i','x','e','l','E','n','c','o','d','i','n','g',0};

-static int cached_default_mode_bpp;
-static pthread_mutex_t cached_modes_mutex = PTHREAD_MUTEX_INITIALIZER;
-
 static BOOL inited_original_display_mode;

@@ -400,22 +397,23 @@ static BOOL display_mode_matches_descriptor(CGDisplayModeRef mode, const struct

static int get_default_bpp(void)
 {
+    static int cached;
     int ret;

-    if (!cached_default_mode_bpp)
+    if (!cached)
     {
         CGDisplayModeRef mode = CGDisplayCopyDisplayMode(kCGDirectMainDisplay);
         if (mode)
         {
-            cached_default_mode_bpp = display_mode_bits_per_pixel(mode);
+            cached = display_mode_bits_per_pixel(mode);
             CFRelease(mode);
         }

-        if (!cached_default_mode_bpp)
-            cached_default_mode_bpp = 32;
+        if (!cached)
+            cached = 32;
     }

-    ret = cached_default_mode_bpp;
+    ret = cached;

TRACE(" -> %d\n", ret);
     return ret;
@@ -800,9 +798,7 @@ LONG macdrv_ChangeDisplaySettings(LPDEVMODEW displays, HWND hwnd, DWORD flags, L
         return DISP_CHANGE_FAILED;
     }

-    pthread_mutex_lock(&cached_modes_mutex);
     bpp = get_default_bpp();
-    pthread_mutex_unlock(&cached_modes_mutex);

desc = create_original_display_mode_descriptor(macdrv_displays[0].displayID);