Gabriel Ivăncescu : mshtml: Do not release the principal returned by GetPrincipal.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: a80a3be462f31546190085fd1ddd065ad8b30077
URL:    https://gitlab.winehq.org/wine/wine/-/commit/a80a3be462f31546190085fd1ddd065...

Author: Gabriel Ivăncescu 
Date:   Tue Apr 25 20:29:25 2023 +0300

mshtml: Do not release the principal returned by GetPrincipal.

Signed-off-by: Gabriel Ivăncescu

---

dlls/mshtml/nsembed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c
index 3e315bc7211..16659055295 100644
--- a/dlls/mshtml/nsembed.c
+++ b/dlls/mshtml/nsembed.c
@@ -2440,6 +2440,7 @@ nsIXMLHttpRequest *create_nsxhr(nsIDOMWindow *nswindow)
     nsres = nsIGlobalObject_QueryInterface(nsglo, &IID_nsIScriptObjectPrincipal, (void**)&sop);
     assert(nsres == NS_OK);

+    /* The returned principal is *not* AddRef'd */
     nspri = nsIScriptObjectPrincipal_GetPrincipal(sop);
     nsIScriptObjectPrincipal_Release(sop);

@@ -2451,7 +2452,6 @@ nsIXMLHttpRequest *create_nsxhr(nsIDOMWindow *nswindow)
         if(NS_FAILED(nsres))
             nsIXMLHttpRequest_Release(nsxhr);
     }
-    nsISupports_Release(nspri);
     nsIGlobalObject_Release(nsglo);
     if(NS_FAILED(nsres)) {
         ERR("nsIXMLHttpRequest_Init failed: %08lx\n", nsres);