Module: wine Branch: master Commit: 5da9250394facb73148ddc7646753a6e730b5206 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5da9250394facb73148ddc7646...
Author: Zebediah Figura z.figura12@gmail.com Date: Thu Jul 6 22:37:01 2017 -0500
msi: Don't increment the refcount when creating dialogs.
Signed-off-by: Zebediah Figura z.figura12@gmail.com Signed-off-by: Hans Leidekker hans@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
dlls/msi/dialog.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c index fc9c24c..c3b74e6 100644 --- a/dlls/msi/dialog.c +++ b/dlls/msi/dialog.c @@ -3916,7 +3916,6 @@ static msi_dialog *dialog_create( MSIPACKAGE *package, const WCHAR *name, msi_di return NULL; strcpyW( dialog->name, name ); dialog->parent = parent; - msiobj_addref( &package->hdr ); dialog->package = package; dialog->event_handler = event_handler; dialog->finished = 0; @@ -3927,7 +3926,6 @@ static msi_dialog *dialog_create( MSIPACKAGE *package, const WCHAR *name, msi_di rec = msi_get_dialog_record( dialog ); if( !rec ) { - msiobj_release( &package->hdr ); msi_free( dialog ); return NULL; } @@ -4054,7 +4052,6 @@ void msi_dialog_destroy( msi_dialog *dialog )
msi_free( dialog->control_default ); msi_free( dialog->control_cancel ); - msiobj_release( &dialog->package->hdr ); dialog->package = NULL; msi_free( dialog ); }