Module: wine Branch: refs/heads/master Commit: ababfdef82764d4d73f708f9642c893facfb1e3b URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=ababfdef82764d4d73f708f9...
Author: Robert Shearman rob@codeweavers.com Date: Wed May 10 13:13:45 2006 +0100
rpcrt4: Use the buffer passed in as an argument and don't increment the buffer in the MIDL_STUB_MESSAGE in the inner pointer marshalling/unmarshalling routines as these can be used for embedded pointers, which handle the allocating or finding of the buffer themselves. Do the incrementing in the outer NdrPointerMarshall/Unmarshall/BufferSize routines instead.
---
dlls/rpcrt4/ndr_marshall.c | 55 ++++++++++++++++++++++++++++++++++++-------- 1 files changed, 45 insertions(+), 10 deletions(-)
diff --git a/dlls/rpcrt4/ndr_marshall.c b/dlls/rpcrt4/ndr_marshall.c index bbf9dd3..6c9e852 100644 --- a/dlls/rpcrt4/ndr_marshall.c +++ b/dlls/rpcrt4/ndr_marshall.c @@ -754,8 +754,7 @@ #endif case RPC_FC_UP: /* unique pointer */ case RPC_FC_OP: /* object pointer - same as unique here */ TRACE("writing %p to buffer\n", Pointer); - NDR_LOCAL_UINT32_WRITE(pStubMsg->Buffer, (unsigned long)Pointer); - pStubMsg->Buffer += 4; + NDR_LOCAL_UINT32_WRITE(Buffer, (unsigned long)Pointer); break; case RPC_FC_FP: default: @@ -803,12 +802,12 @@ void WINAPI PointerUnmarshall(PMIDL_STUB pointer_id = ~0UL; break; case RPC_FC_UP: /* unique pointer */ - pointer_id = NDR_LOCAL_UINT32_READ(pStubMsg->Buffer); - pStubMsg->Buffer += 4; + pointer_id = NDR_LOCAL_UINT32_READ(Buffer); + TRACE("pointer_id is 0x%08lx\n", pointer_id); break; case RPC_FC_OP: /* object pointer - we must free data before overwriting it */ - pointer_id = NDR_LOCAL_UINT32_READ(pStubMsg->Buffer); - pStubMsg->Buffer += 4; + pointer_id = NDR_LOCAL_UINT32_READ(Buffer); + TRACE("pointer_id is 0x%08lx\n", pointer_id); if (*pPointer) FIXME("free object pointer %p\n", *pPointer); break; @@ -855,7 +854,6 @@ void WINAPI PointerBufferSize(PMIDL_STUB break; case RPC_FC_OP: case RPC_FC_UP: - pStubMsg->BufferLength += 4; /* NULL pointer has no further representation */ if (!Pointer) return; @@ -1285,9 +1283,22 @@ unsigned char * WINAPI NdrPointerMarshal unsigned char *pMemory, PFORMAT_STRING pFormat) { + unsigned char *Buffer; + TRACE("(%p,%p,%p)\n", pStubMsg, pMemory, pFormat);
- pStubMsg->BufferMark = pStubMsg->Buffer; + /* incremement the buffer here instead of in PointerMarshall, + * as that is used by embedded pointers which already handle the incrementing + * the buffer, and shouldn't write any additional pointer data to the wire */ + if (*pFormat != RPC_FC_RP) + { + ALIGN_POINTER(pStubMsg->Buffer, 4); + Buffer = pStubMsg->Buffer; + pStubMsg->Buffer += 4; + } + else + Buffer = pStubMsg->Buffer; + PointerMarshall(pStubMsg, pStubMsg->Buffer, pMemory, pFormat);
STD_OVERFLOW_CHECK(pStubMsg); @@ -1303,10 +1314,24 @@ unsigned char * WINAPI NdrPointerUnmarsh PFORMAT_STRING pFormat, unsigned char fMustAlloc) { + unsigned char *Buffer; + TRACE("(%p,%p,%p,%d)\n", pStubMsg, ppMemory, pFormat, fMustAlloc);
- pStubMsg->BufferMark = pStubMsg->Buffer; - PointerUnmarshall(pStubMsg, pStubMsg->Buffer, ppMemory, pFormat, fMustAlloc); + /* incremement the buffer here instead of in PointerUnmarshall, + * as that is used by embedded pointers which already handle the incrementing + * the buffer, and shouldn't read any additional pointer data from the + * buffer */ + if (*pFormat != RPC_FC_RP) + { + ALIGN_POINTER(pStubMsg->Buffer, 4); + Buffer = pStubMsg->Buffer; + pStubMsg->Buffer += 4; + } + else + Buffer = pStubMsg->Buffer; + + PointerUnmarshall(pStubMsg, Buffer, ppMemory, pFormat, fMustAlloc);
return NULL; } @@ -1319,6 +1344,16 @@ void WINAPI NdrPointerBufferSize(PMIDL_S PFORMAT_STRING pFormat) { TRACE("(%p,%p,%p)\n", pStubMsg, pMemory, pFormat); + + /* incremement the buffer length here instead of in PointerBufferSize, + * as that is used by embedded pointers which already handle the buffer + * length, and shouldn't write anything more to the wire */ + if (*pFormat != RPC_FC_RP) + { + ALIGN_LENGTH(pStubMsg->BufferLength, 4); + pStubMsg->BufferLength += 4; + } + PointerBufferSize(pStubMsg, pMemory, pFormat); }
-
Alexandre Julliard