Rémi Bernon : imm32: Don't hide/show IME UI window in ImmSetCompositionWindow.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 2fda6abfc4ecd1ddbac658fd59b3a4d85d516a2d
URL:    https://gitlab.winehq.org/wine/wine/-/commit/2fda6abfc4ecd1ddbac658fd59b3a4d...

Author: Rémi Bernon 
Date:   Fri Apr 14 09:17:17 2023 +0200

imm32: Don't hide/show IME UI window in ImmSetCompositionWindow.

---

dlls/imm32/imm.c         | 10 ----------
 dlls/imm32/tests/imm32.c |  2 +-
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c
index 2fd247f36c7..554cc00b457 100644
--- a/dlls/imm32/imm.c
+++ b/dlls/imm32/imm.c
@@ -2629,9 +2629,7 @@ BOOL WINAPI ImmSetCompositionStringW(
  */
 BOOL WINAPI ImmSetCompositionWindow( HIMC himc, COMPOSITIONFORM *composition )
 {
-    BOOL reshow = FALSE;
     INPUTCONTEXT *ctx;
-    HWND ui_hwnd;

TRACE( "himc %p, composition %s\n", himc, debugstr_composition( composition ) );

@@ -2641,14 +2639,6 @@ BOOL WINAPI ImmSetCompositionWindow( HIMC himc, COMPOSITIONFORM *composition )
     ctx->cfCompForm = *composition;
     ctx->fdwInit |= INIT_COMPFORM;

-    if ((ui_hwnd = get_ime_ui_window()) && IsWindowVisible( ui_hwnd ))
-    {
-        reshow = TRUE;
-        ShowWindow( ui_hwnd, SW_HIDE );
-    }
-
-    if (ui_hwnd && reshow) ShowWindow( ui_hwnd, SW_SHOWNOACTIVATE );
-
     ImmNotifyIME( himc, NI_CONTEXTUPDATED, 0, IMC_SETCOMPOSITIONWINDOW );
     SendMessageW( ctx->hWnd, WM_IME_NOTIFY, IMN_SETCOMPOSITIONWINDOW, 0 );

diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c
index 92b59b7d005..9857583fafa 100644
--- a/dlls/imm32/tests/imm32.c
+++ b/dlls/imm32/tests/imm32.c
@@ -6221,7 +6221,7 @@ static void test_ImmSetCompositionWindow(void)
     memset( &comp_form, 0xcd, sizeof(comp_form) );
     ok_ret( 1, ImmSetCompositionWindow( himc, &comp_form ) );
     process_messages();
-    todo_wine ok_seq( set_composition_window_0_seq );
+    ok_seq( set_composition_window_0_seq );
     ok_eq( INIT_COMPFORM, ctx->fdwInit, UINT, "%u" );
     check_composition_form( &ctx->cfCompForm, &comp_form );
     ok_ret( 1, IsWindowVisible( ime_windows.ime_ui_hwnd ) );