Module: wine Branch: master Commit: 8978a4b51b26f3d6f2a937cb5ee7f93c96a67d5c URL: http://source.winehq.org/git/wine.git/?a=commit;h=8978a4b51b26f3d6f2a937cb5e...
Author: Michael Stefaniuc mstefani@redhat.de Date: Thu Jul 19 01:54:54 2012 +0200
dsound: Merge IUnknown into the main DirectSound object.
---
dlls/dsound/dsound.c | 126 +++++++++++++----------------------------- dlls/dsound/dsound_private.h | 2 - 2 files changed, 38 insertions(+), 90 deletions(-)
diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c index b8c3d8b..6ce01b2 100644 --- a/dlls/dsound/dsound.c +++ b/dlls/dsound/dsound.c @@ -44,14 +44,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(dsound); /***************************************************************************** * IDirectSound COM components */ -struct IDirectSound_IUnknown { - const IUnknownVtbl *lpVtbl; - LONG ref; - LPDIRECTSOUND8 pds; -}; - -static HRESULT IDirectSound_IUnknown_Create(LPDIRECTSOUND8 pds, LPUNKNOWN * ppunk); - struct IDirectSound_IDirectSound { const IDirectSoundVtbl *lpVtbl; LONG ref; @@ -72,20 +64,15 @@ struct IDirectSound8_IDirectSound8 { static HRESULT IDirectSound8_IDirectSound8_Create(LPDIRECTSOUND8 pds, LPDIRECTSOUND8 * ppds); static ULONG WINAPI IDirectSound8_IDirectSound8_AddRef(LPDIRECTSOUND8 iface);
-/***************************************************************************** - * IDirectSound implementation structure - */ -struct IDirectSoundImpl -{ - LONG numIfaces; +typedef struct IDirectSoundImpl { + IUnknown IUnknown_iface; /* Separate refcount, not for COM aggregation */ + LONG ref, numIfaces; DirectSoundDevice *device; BOOL has_ds8; - LPUNKNOWN pUnknown; LPDIRECTSOUND pDS; LPDIRECTSOUND8 pDS8; -}; +} IDirectSoundImpl;
-static ULONG WINAPI IDirectSound_IUnknown_AddRef(LPUNKNOWN iface); static ULONG WINAPI IDirectSound_IDirectSound_AddRef(LPDIRECTSOUND iface);
const char * dumpCooperativeLevel(DWORD level) @@ -172,16 +159,8 @@ static HRESULT DSOUND_QueryInterface( }
if (IsEqualIID(riid, &IID_IUnknown)) { - if (!This->pUnknown) { - IDirectSound_IUnknown_Create(iface, &This->pUnknown); - if (!This->pUnknown) { - WARN("IDirectSound_IUnknown_Create() failed\n"); - *ppobj = NULL; - return E_NOINTERFACE; - } - } - IDirectSound_IUnknown_AddRef(This->pUnknown); - *ppobj = This->pUnknown; + IUnknown_AddRef(&This->IUnknown_iface); + *ppobj = &This->IUnknown_iface; return S_OK; } else if (IsEqualIID(riid, &IID_IDirectSound)) { if (!This->pDS) { @@ -223,84 +202,53 @@ static void directsound_destroy(IDirectSoundImpl *This) }
/******************************************************************************* - * IDirectSound_IUnknown + * IUnknown Implementation for DirectSound */ -static HRESULT WINAPI IDirectSound_IUnknown_QueryInterface( - LPUNKNOWN iface, - REFIID riid, - LPVOID * ppobj) +static inline IDirectSoundImpl *impl_from_IUnknown(IUnknown *iface) { - IDirectSound_IUnknown *This = (IDirectSound_IUnknown *)iface; - TRACE("(%p,%s,%p)\n",This,debugstr_guid(riid),ppobj); - return DSOUND_QueryInterface(This->pds, riid, ppobj); + return CONTAINING_RECORD(iface, IDirectSoundImpl, IUnknown_iface); }
-static ULONG WINAPI IDirectSound_IUnknown_AddRef( - LPUNKNOWN iface) +static HRESULT WINAPI IUnknownImpl_QueryInterface(IUnknown *iface, REFIID riid, void **ppv) { - IDirectSound_IUnknown *This = (IDirectSound_IUnknown *)iface; - ULONG ref = InterlockedIncrement(&(This->ref)); - TRACE("(%p) ref was %d\n", This, ref - 1); - return ref; -} - -static ULONG WINAPI IDirectSound_IUnknown_Release( - LPUNKNOWN iface) -{ - IDirectSound_IUnknown *This = (IDirectSound_IUnknown *)iface; - ULONG ref = InterlockedDecrement(&(This->ref)); - TRACE("(%p) ref was %d\n", This, ref + 1); - if (!ref && !InterlockedDecrement(&((IDirectSoundImpl *)This->pds)->numIfaces)) { - ((IDirectSoundImpl*)This->pds)->pUnknown = NULL; - directsound_destroy((IDirectSoundImpl*)This->pds); - HeapFree(GetProcessHeap(), 0, This); - TRACE("(%p) released\n", This); - } - return ref; + IDirectSoundImpl *This = impl_from_IUnknown(iface); + TRACE("(%p,%s,%p)\n", This, debugstr_guid(riid), ppv); + return DSOUND_QueryInterface((IDirectSound8 *)This, riid, ppv); }
-static const IUnknownVtbl DirectSound_Unknown_Vtbl = +static ULONG WINAPI IUnknownImpl_AddRef(IUnknown *iface) { - IDirectSound_IUnknown_QueryInterface, - IDirectSound_IUnknown_AddRef, - IDirectSound_IUnknown_Release -}; + IDirectSoundImpl *This = impl_from_IUnknown(iface); + ULONG ref = InterlockedIncrement(&This->ref);
-static HRESULT IDirectSound_IUnknown_Create( - LPDIRECTSOUND8 pds, - LPUNKNOWN * ppunk) -{ - IDirectSound_IUnknown * pdsunk; - TRACE("(%p,%p)\n",pds,ppunk); + TRACE("(%p) ref=%d\n", This, ref);
- if (ppunk == NULL) { - ERR("invalid parameter: ppunk == NULL\n"); - return DSERR_INVALIDPARAM; - } + if(ref == 1) + InterlockedIncrement(&This->numIfaces);
- if (pds == NULL) { - ERR("invalid parameter: pds == NULL\n"); - *ppunk = NULL; - return DSERR_INVALIDPARAM; - } + return ref; +}
- pdsunk = HeapAlloc(GetProcessHeap(),0,sizeof(*pdsunk)); - if (pdsunk == NULL) { - WARN("out of memory\n"); - *ppunk = NULL; - return DSERR_OUTOFMEMORY; - } +static ULONG WINAPI IUnknownImpl_Release(IUnknown *iface) +{ + IDirectSoundImpl *This = impl_from_IUnknown(iface); + ULONG ref = InterlockedDecrement(&This->ref);
- pdsunk->lpVtbl = &DirectSound_Unknown_Vtbl; - pdsunk->ref = 0; - pdsunk->pds = pds; + TRACE("(%p) ref=%d\n", This, ref);
- InterlockedIncrement(&((IDirectSoundImpl *)pds)->numIfaces); - *ppunk = (LPUNKNOWN)pdsunk; + if (!ref && !InterlockedDecrement(&This->numIfaces)) + directsound_destroy(This);
- return DS_OK; + return ref; }
+static const IUnknownVtbl unk_vtbl = +{ + IUnknownImpl_QueryInterface, + IUnknownImpl_AddRef, + IUnknownImpl_Release +}; + /******************************************************************************* * IDirectSound_IDirectSound */ @@ -646,6 +594,8 @@ static HRESULT IDirectSoundImpl_Create(void **ppv, BOOL has_ds8) return DSERR_OUTOFMEMORY; }
+ obj->IUnknown_iface.lpVtbl = &unk_vtbl; + obj->ref = 0; obj->numIfaces = 0; obj->device = NULL; obj->has_ds8 = has_ds8; diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h index c2449b3..8d361bc 100644 --- a/dlls/dsound/dsound_private.h +++ b/dlls/dsound/dsound_private.h @@ -39,8 +39,6 @@ extern int ds_default_bits_per_sample DECLSPEC_HIDDEN; /***************************************************************************** * Predeclare the interface implementation structures */ -typedef struct IDirectSoundImpl IDirectSoundImpl; -typedef struct IDirectSound_IUnknown IDirectSound_IUnknown; typedef struct IDirectSound_IDirectSound IDirectSound_IDirectSound; typedef struct IDirectSound8_IDirectSound8 IDirectSound8_IDirectSound8; typedef struct IDirectSoundBufferImpl IDirectSoundBufferImpl;
-
Alexandre Julliard