Module: tools Branch: master Commit: f162348ba523c8adf59af6d459ad2b2f065baa58 URL: https://source.winehq.org/git/tools.git/?a=commit;h=f162348ba523c8adf59af6d4...
Author: Francois Gouget fgouget@codeweavers.com Date: Fri Jun 1 09:42:00 2018 +0200
Revert "testbot/web: Tweak VMDetails.pl to save the Item directly.".
Saving the item directly is ok when modifying it, but DBIBackend only supports saving new items through the collection. In particular the VMDetails page is also used to create new VMs so we have no choice but to go through the collection.
This reverts commit 71a9602bb6eab2b54e930080b8ef728064d6a664.
Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
testbot/web/admin/VMDetails.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/testbot/web/admin/VMDetails.pl b/testbot/web/admin/VMDetails.pl index 0571471..9603e34 100644 --- a/testbot/web/admin/VMDetails.pl +++ b/testbot/web/admin/VMDetails.pl @@ -62,7 +62,8 @@ sub Save($) } }
- ($self->{ErrField}, $self->{ErrMessage}) = $self->{Item}->Save(); + my $ErrKey; + ($ErrKey, $self->{ErrField}, $self->{ErrMessage}) = $self->{Collection}->Save(); return ! defined($self->{ErrMessage}); }