Octavian Voicu : vbscript: Fix possible memory leak/ crash caused by race condition in VBScriptParse_InitNew.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 2f053965a2dd8f167b0f0189f312b229e5372a69
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2f053965a2dd8f167b0f0189f3...

Author: Octavian Voicu 
Date:   Thu Sep  1 05:23:12 2011 +0300

vbscript: Fix possible memory leak/crash caused by race condition in VBScriptParse_InitNew.

---

dlls/vbscript/vbscript.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/vbscript/vbscript.c b/dlls/vbscript/vbscript.c
index 084337f..caee4d4 100644
--- a/dlls/vbscript/vbscript.c
+++ b/dlls/vbscript/vbscript.c
@@ -348,7 +348,7 @@ static ULONG WINAPI VBScriptParse_Release(IActiveScriptParse *iface)
 static HRESULT WINAPI VBScriptParse_InitNew(IActiveScriptParse *iface)
 {
     VBScript *This = impl_from_IActiveScriptParse(iface);
-    script_ctx_t *ctx;
+    script_ctx_t *ctx, *old_ctx;

TRACE("(%p)\n", This);

@@ -359,8 +359,8 @@ static HRESULT WINAPI VBScriptParse_InitNew(IActiveScriptParse *iface)
     if(!ctx)
         return E_OUTOFMEMORY;

-    ctx = InterlockedCompareExchangePointer((void**)&This->ctx, ctx, NULL);
-    if(ctx) {
+    old_ctx = InterlockedCompareExchangePointer((void**)&This->ctx, ctx, NULL);
+    if(old_ctx) {
         destroy_script(ctx);
         return E_UNEXPECTED;
     }