Module: wine Branch: master Commit: 6fd349c6e0262d0b4c5739c90883131c1b145818 URL: https://gitlab.winehq.org/wine/wine/-/commit/6fd349c6e0262d0b4c5739c90883131...
Author: Zebediah Figura zfigura@codeweavers.com Date: Fri Feb 16 22:02:54 2024 -0600
shell32: Do not set the default menu item from ShellView_DoContextMenu().
This was added in f045c9df8130db17e4d379b56744f21f9a1491f8, with no explanation.
It does not affect any behaviour in Wine, since FWF_DESKTOP is never set.
It does not make sense, since "open" is already usually the default action on Windows, and it's not obvious why FWF_DESKTOP would affect this.
It also leans on IContextMenu implementation details.
---
dlls/shell32/shlview.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c index abe13981df1..9c699ecda08 100644 --- a/dlls/shell32/shlview.c +++ b/dlls/shell32/shlview.c @@ -1039,9 +1039,6 @@ static void ShellView_DoContextMenu(IShellViewImpl * This, WORD x, WORD y, BOOL /* let the ContextMenu merge its items in */ if (SUCCEEDED(IContextMenu_QueryContextMenu( pContextMenu, hMenu, 0, FCIDM_SHVIEWFIRST, FCIDM_SHVIEWLAST, wFlags ))) { - if (This->FolderSettings.fFlags & FWF_DESKTOP) - SetMenuDefaultItem(hMenu, FCIDM_SHVIEW_OPEN, MF_BYCOMMAND); - if( bDefault ) { TRACE("-- get menu default command\n");