Zebediah Figura : vkd3d-shader/hlsl: Return bool from compare_function_decl().

[Alexandre Julliard]

Module: vkd3d
Branch: master
Commit: 8f041fbe6f7e74ef3108a54b037c4d427e66d587
URL:    https://gitlab.winehq.org/wine/vkd3d/-/commit/8f041fbe6f7e74ef3108a54b037c4d...

Author: Zebediah Figura 
Date:   Fri Sep  8 16:47:19 2023 -0500

vkd3d-shader/hlsl: Return bool from compare_function_decl().

---

libs/vkd3d-shader/hlsl.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c
index 7893497d..37dfccf2 100644
--- a/libs/vkd3d-shader/hlsl.c
+++ b/libs/vkd3d-shader/hlsl.c
@@ -2098,21 +2098,20 @@ static int compare_param_hlsl_types(const struct hlsl_type *t1, const struct hls
     return 0;
 }

-static int compare_function_decl(const struct hlsl_ir_function_decl *decl,
+static bool func_decl_matches(const struct hlsl_ir_function_decl *decl,
         const struct hlsl_func_parameters *parameters)
 {
     size_t i;
-    int r;

-    if ((r = vkd3d_u32_compare(parameters->count, decl->parameters.count)))
-        return r;
+    if (parameters->count != decl->parameters.count)
+        return false;

for (i = 0; i < parameters->count; ++i)
     {
-        if ((r = compare_param_hlsl_types(parameters->vars[i]->data_type, decl->parameters.vars[i]->data_type)))
-            return r;
+        if (compare_param_hlsl_types(parameters->vars[i]->data_type, decl->parameters.vars[i]->data_type))
+            return false;
     }
-    return 0;
+    return true;
 }

struct hlsl_ir_function_decl *hlsl_get_func_decl(struct hlsl_ctx *ctx, const char *name,
@@ -2126,7 +2125,7 @@ struct hlsl_ir_function_decl *hlsl_get_func_decl(struct hlsl_ctx *ctx, const cha

LIST_FOR_EACH_ENTRY(decl, &func->overloads, struct hlsl_ir_function_decl, entry)
     {
-        if (!compare_function_decl(decl, parameters))
+        if (func_decl_matches(decl, parameters))
             return decl;
     }