Zebediah Figura : vkd3d-shader/preproc: Parse hash marks as two separate tokens when not in stringification contexts.

[Alexandre Julliard]

Module: vkd3d
Branch: master
Commit: 9b98489155fb479d6b4c891db9a345086e830f3d
URL:    https://gitlab.winehq.org/wine/vkd3d/-/commit/9b98489155fb479d6b4c891db9a345...

Author: Zebediah Figura 
Date:   Sat Jul 29 18:08:29 2023 -0500

vkd3d-shader/preproc: Parse hash marks as two separate tokens when not in stringification contexts.

---

libs/vkd3d-shader/preproc.l     | 37 ++++++++++++++++++++++---------------
 tests/preproc-macro.shader_test |  4 ++++
 2 files changed, 26 insertions(+), 15 deletions(-)

diff --git a/libs/vkd3d-shader/preproc.l b/libs/vkd3d-shader/preproc.l
index 8e35e355..20bf5cb5 100644
--- a/libs/vkd3d-shader/preproc.l
+++ b/libs/vkd3d-shader/preproc.l
@@ -29,6 +29,13 @@

#define YY_DECL static int preproc_lexer_lex(YYSTYPE *yylval_param, YYLTYPE *yylloc_param, yyscan_t yyscanner)

+static struct preproc_macro *preproc_get_top_macro(struct preproc_ctx *ctx)
+{
+    if (!ctx->expansion_count)
+        return NULL;
+    return ctx->expansion_stack[ctx->expansion_count - 1].macro;
+}
+
 static void update_location(struct preproc_ctx *ctx);

#define YY_USER_ACTION update_location(yyget_extra(yyscanner));
@@ -124,7 +131,20 @@ INT_SUFFIX      [uUlL]{0,2}
         const char *p;

if (!ctx->last_was_newline)
-            return T_HASHSTRING;
+        {
+            struct preproc_macro *macro;
+
+            /* Stringification is only done for function-like macro bodies.
+             * Anywhere else, we need to parse it as two separate tokens.
+             * We could use a state for this, but yyless() is easier and cheap.
+             */
+
+            if ((macro = preproc_get_top_macro(ctx)) && macro->arg_count)
+                return T_HASHSTRING;
+
+            yyless(1);
+            return T_TEXT;
+        }

for (p = yytext + 1; strchr(" \t", *p); ++p)
             ;
@@ -218,13 +238,6 @@ static bool preproc_is_writing(struct preproc_ctx *ctx)
     return file->if_stack[file->if_count - 1].current_true;
 }

-static struct preproc_macro *preproc_get_top_macro(struct preproc_ctx *ctx)
-{
-    if (!ctx->expansion_count)
-        return NULL;
-    return ctx->expansion_stack[ctx->expansion_count - 1].macro;
-}
-
 /* Concatenation is not done for object-like macros, but is done for both
  * function-like macro bodies and their arguments. */
 static bool should_concat(struct preproc_ctx *ctx)
@@ -440,9 +453,6 @@ int yylex(YYSTYPE *lval, YYLTYPE *lloc, yyscan_t scanner)
         switch (func_state->state)
         {
             case STATE_NONE:
-            {
-                struct preproc_macro *macro;
-
                 if (token == T_CONCAT && should_concat(ctx))
                 {
                     while (ctx->buffer.content_size
@@ -451,9 +461,7 @@ int yylex(YYSTYPE *lval, YYLTYPE *lloc, yyscan_t scanner)
                     break;
                 }

-                /* Stringification, however, is only done for function-like
-                 * macro bodies. */
-                if (token == T_HASHSTRING && (macro = preproc_get_top_macro(ctx)) && macro->arg_count)
+                if (token == T_HASHSTRING)
                 {
                     const struct preproc_text *expansion;
                     const char *p = text + 1;
@@ -585,7 +593,6 @@ int yylex(YYSTYPE *lval, YYLTYPE *lloc, yyscan_t scanner)
                 else
                     vkd3d_string_buffer_printf(&ctx->buffer, "%s ", text);
                 break;
-            }

case STATE_IDENTIFIER:
                 if (token == '(')
diff --git a/tests/preproc-macro.shader_test b/tests/preproc-macro.shader_test
index 0fe73f7c..b2f2530e 100644
--- a/tests/preproc-macro.shader_test
+++ b/tests/preproc-macro.shader_test
@@ -301,3 +301,7 @@ fail
 [preproc]
 #define __LINE__ pass
 __LINE__
+
+[preproc]
+#define KEY pass
+apple # KEY