Rob Shearman : wininet: Add tests for passing invalid parameters into InternetTimeFromSystemTimeA/ W.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 2584323ff9bf400e1828fee95c752ee402f539cf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2584323ff9bf400e1828fee95c...

Author: Rob Shearman 
Date:   Fri Oct  3 12:58:25 2008 +0100

wininet: Add tests for passing invalid parameters into InternetTimeFromSystemTimeA/W.

---

dlls/wininet/tests/internet.c |   62 +++++++++++++++++++++++++++++++++++++++++
 1 files changed, 62 insertions(+), 0 deletions(-)

diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c
index 7edb6bc..91d72cc 100644
--- a/dlls/wininet/tests/internet.c
+++ b/dlls/wininet/tests/internet.c
@@ -381,6 +381,37 @@ static void InternetTimeFromSystemTimeA_test(void)
     ok( !memcmp( string, expect, sizeof(expect) ),
         "InternetTimeFromSystemTimeA failed (%u)\n", GetLastError() );

+    /* test NULL time parameter */
+    SetLastError(0xdeadbeef);
+    ret = pInternetTimeFromSystemTimeA( NULL, INTERNET_RFC1123_FORMAT, string, sizeof(string) );
+    error = GetLastError();
+    ok( !ret, "InternetTimeFromSystemTimeA should have returned FALSE\n" );
+    todo_wine
+    ok( error == ERROR_INVALID_PARAMETER,
+        "InternetTimeFromSystemTimeA failed with ERROR_INVALID_PARAMETER instead of %u\n",
+        error );
+
+    /* test NULL string parameter */
+    SetLastError(0xdeadbeef);
+    ret = pInternetTimeFromSystemTimeA( &time, INTERNET_RFC1123_FORMAT, NULL, sizeof(string) );
+    error = GetLastError();
+    todo_wine
+    ok( !ret, "InternetTimeFromSystemTimeA should have returned FALSE\n" );
+    ok( error == ERROR_INVALID_PARAMETER,
+        "InternetTimeFromSystemTimeA failed with ERROR_INVALID_PARAMETER instead of %u\n",
+        error );
+
+    /* test invalid format parameter */
+    SetLastError(0xdeadbeef);
+    ret = pInternetTimeFromSystemTimeA( &time, INTERNET_RFC1123_FORMAT + 1, string, sizeof(string) );
+    error = GetLastError();
+    ok( !ret, "InternetTimeFromSystemTimeA should have returned FALSE\n" );
+    todo_wine
+    ok( error == ERROR_INVALID_PARAMETER,
+        "InternetTimeFromSystemTimeA failed with ERROR_INVALID_PARAMETER instead of %u\n",
+        error );
+
+    /* test too small buffer size */
     SetLastError(0xdeadbeef);
     ret = pInternetTimeFromSystemTimeA( &time, INTERNET_RFC1123_FORMAT, string, 0 );
     error = GetLastError();
@@ -405,6 +436,37 @@ static void InternetTimeFromSystemTimeW_test(void)
     ok( !memcmp( string, expect, sizeof(expect) ),
         "InternetTimeFromSystemTimeW failed (%u)\n", GetLastError() );

+    /* test NULL time parameter */
+    SetLastError(0xdeadbeef);
+    ret = pInternetTimeFromSystemTimeW( NULL, INTERNET_RFC1123_FORMAT, string, sizeof(string) );
+    error = GetLastError();
+    ok( !ret, "InternetTimeFromSystemTimeW should have returned FALSE\n" );
+    todo_wine
+    ok( error == ERROR_INVALID_PARAMETER,
+        "InternetTimeFromSystemTimeW failed with ERROR_INVALID_PARAMETER instead of %u\n",
+        error );
+
+    /* test NULL string parameter */
+    SetLastError(0xdeadbeef);
+    ret = pInternetTimeFromSystemTimeW( &time, INTERNET_RFC1123_FORMAT, NULL, sizeof(string) );
+    error = GetLastError();
+    ok( !ret, "InternetTimeFromSystemTimeW should have returned FALSE\n" );
+    todo_wine
+    ok( error == ERROR_INVALID_PARAMETER,
+        "InternetTimeFromSystemTimeW failed with ERROR_INVALID_PARAMETER instead of %u\n",
+        error );
+
+    /* test invalid format parameter */
+    SetLastError(0xdeadbeef);
+    ret = pInternetTimeFromSystemTimeW( &time, INTERNET_RFC1123_FORMAT + 1, string, sizeof(string) );
+    error = GetLastError();
+    ok( !ret, "InternetTimeFromSystemTimeW should have returned FALSE\n" );
+    todo_wine
+    ok( error == ERROR_INVALID_PARAMETER,
+        "InternetTimeFromSystemTimeW failed with ERROR_INVALID_PARAMETER instead of %u\n",
+        error );
+
+    /* test too small buffer size */
     SetLastError(0xdeadbeef);
     ret = pInternetTimeFromSystemTimeW( &time, INTERNET_RFC1123_FORMAT, string, sizeof(string)/sizeof(string[0]) );
     error = GetLastError();