Francois Gouget : testbot/Users: Fix UserDetails. pl to reuse WaitForApproval() instead of incompletely duplicating it.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 5a6b0e8323ea7ef2056ccec29d57d37fc56d8c55
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=5a6b0e8323ea7ef2056ccec29...

Author: Francois Gouget 
Date:   Wed Apr  3 16:58:34 2013 +0200

testbot/Users: Fix UserDetails.pl to reuse WaitForApproval() instead of incompletely duplicating it.

---

testbot/web/admin/UserDetails.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testbot/web/admin/UserDetails.pl b/testbot/web/admin/UserDetails.pl
index 9e79aa4..bc56eec 100644
--- a/testbot/web/admin/UserDetails.pl
+++ b/testbot/web/admin/UserDetails.pl
@@ -1,6 +1,7 @@
 # User details page
 #
 # Copyright 2009 Ge van Geldorp
+# Copyright 2013 Francois Gouget
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
@@ -53,8 +54,7 @@ sub GetActions
   my $self = shift;

my @Actions;
-  if ($self->{Item}->Active && length($self->{Item}->Password) == 1 &&
-      ! defined($LDAPServer))
+  if (!defined $LDAPServer and $self->{Item}->WaitingForApproval())
   {
     $Actions[0] = "Approve";
   }