Module: tools Branch: master Commit: 8251347264b5b60d3954aa9a8aad7ab649e21bdb URL: https://gitlab.winehq.org/winehq/tools/-/commit/8251347264b5b60d3954aa9a8aad...
Author: Jeremy White jwhite@codeweavers.com Date: Mon Aug 8 09:36:27 2022 -0500
Only assign reviewers on the first version of MR.
This avoids an issue that arose when Torge rebased a large volume of patches which resulted in assignment of MR 564 to much of the world.
---
gitlab/gitlab-to-mail/gitlabtomail.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitlab/gitlab-to-mail/gitlabtomail.py b/gitlab/gitlab-to-mail/gitlabtomail.py index 525130e8..221e587e 100755 --- a/gitlab/gitlab-to-mail/gitlabtomail.py +++ b/gitlab/gitlab-to-mail/gitlabtomail.py @@ -625,8 +625,8 @@ def process_mr(mr, update_db, assigner): log(f"MR{iid}v{version} - skipping, has no changes") return
- # Assign reviewers if there are none currently - if len(mr['reviewers']) == 0: + # Assign reviewers if there are none currently, but only on the first submission + if len(mr['reviewers']) == 0 and len(versions) == 1: full_version = fetch_mr_version(iid, versions[0]['id']) assigner.assign_reviewers(iid, mr['author'], full_version, update_db)
-
Alexandre Julliard