Sven Baars : kernelbase: Call create_key() from create_subkey().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 3bbd37d0bbf047218e48b5e3b54b6e5df94caa90
URL:    https://gitlab.winehq.org/wine/wine/-/commit/3bbd37d0bbf047218e48b5e3b54b6e5...

Author: Sven Baars 
Date:   Fri Mar 17 17:30:23 2023 +0100

kernelbase: Call create_key() from create_subkey().

---

dlls/kernelbase/registry.c | 28 ++++++----------------------
 1 file changed, 6 insertions(+), 22 deletions(-)

diff --git a/dlls/kernelbase/registry.c b/dlls/kernelbase/registry.c
index f9e647a026a..a69a87ebb3d 100644
--- a/dlls/kernelbase/registry.c
+++ b/dlls/kernelbase/registry.c
@@ -227,44 +227,28 @@ static NTSTATUS open_key( HKEY *retkey, HKEY root, UNICODE_STRING *name, DWORD o
     return status;
 }

+static NTSTATUS create_key( HKEY *retkey, HKEY root, UNICODE_STRING name, ULONG options, ACCESS_MASK access,
+                            const UNICODE_STRING *class, PULONG dispos );
+
 static NTSTATUS create_subkey( HKEY *subkey, HKEY root, UNICODE_STRING *name, DWORD options, ACCESS_MASK access,
                                const UNICODE_STRING *class, PULONG dispos )
 {
+    ACCESS_MASK access_64 = access & ~KEY_WOW64_32KEY;
     DWORD i = 0, len = name->Length / sizeof(WCHAR);
     WCHAR *buffer = name->Buffer;
-    OBJECT_ATTRIBUTES attr;
     UNICODE_STRING str;
     NTSTATUS status;

-    attr.Length = sizeof(attr);
-    attr.RootDirectory = root;
-    attr.ObjectName = &str;
-    attr.Attributes = 0;
-    attr.SecurityDescriptor = NULL;
-    attr.SecurityQualityOfService = NULL;
-
     if (i < len && buffer[i] == '\') return STATUS_OBJECT_PATH_INVALID;
     while (i < len && buffer[i] != '\') i++;

str.Buffer = name->Buffer;
     str.Length = i * sizeof(WCHAR);

-    if (i == len)
-    {
-        if (options & REG_OPTION_OPEN_LINK) attr.Attributes |= OBJ_OPENLINK;
-    }
-    else
-    {
+    if (i < len)
         options &= ~REG_OPTION_CREATE_LINK;
-    }
-
-    status = NtCreateKey( (HANDLE *)subkey, access, &attr, 0, class, options, dispos );
-    if (status == STATUS_PREDEFINED_HANDLE)
-    {
-        *subkey = get_perflib_key( *subkey );
-        status = STATUS_SUCCESS;
-    }

+    status = create_key( subkey, root, str, options, access_64, class, dispos );
     if (!status)
     {
         while (i < len && buffer[i] == '\') i++;