Module: wine Branch: master Commit: ea60927fbda8bb9635a8002450336a1cb506e82f URL: https://source.winehq.org/git/wine.git/?a=commit;h=ea60927fbda8bb9635a800245...
Author: Sven Baars sbaars@codeweavers.com Date: Sun Aug 2 19:20:23 2020 +0200
wbemprox: Avoid a use after free (Coverity).
Signed-off-by: Sven Baars sbaars@codeweavers.com Signed-off-by: Hans Leidekker hans@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
dlls/wbemprox/builtin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index f055547a6b..4edda854b5 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -2116,9 +2116,9 @@ static WCHAR *get_diskdrive_serialnumber( WCHAR letter ) heap_free( desc ); break; } + size = desc->Size; heap_free( desc ); - if (GetLastError() == ERROR_MORE_DATA) size = desc->Size; - else break; + if (GetLastError() != ERROR_MORE_DATA) break; }
done: