Alexandre Julliard pushed to branch master at wine / wine
Commits: 93a6d341 by Elizabeth Figura at 2024-12-17T14:54:34+01:00 Revert "wined3d: Use bindless textures for GLSL shaders if possible.".
This reverts commit f6a1844dbed91b441ad69e7b15b5be242d063e87.
The use of bindless textures results in several bugs. Some appear to be our bugs; at least some of these would require us to attempt to keep textures nonresident when not used, and others have not yet been debugged. Some appear to be driver bugs or at least exacerbations of existing bugs that are not really fixable.
At the same time, separate samplers are a d3d10-level feature, and any d3d10-level GPU should be capable of supporting Vulkan, which does not use combined samplers. The Vulkan renderer does not suffer from the problem that the GL renderer does in this case.
Put another way, any application that is helped by the original commit should also be helped by the Vulkan renderer, and if the application in question is capable of running on a given GPU in the first place then the GPU should in practice support Vulkan.
The original commit fixed a clear and definite bug, and thus this revert reintroduces regressions in some applications, while fixing regressions in others. The long-term fix for these regressions is to finish the Vulkan renderer and default to it where possible.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56474 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56523 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56605 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56627 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57409
- - - - -
8 changed files:
- dlls/d3d11/tests/d3d11.c - dlls/wined3d/adapter_gl.c - dlls/wined3d/context_gl.c - dlls/wined3d/device.c - dlls/wined3d/glsl_shader.c - dlls/wined3d/texture.c - dlls/wined3d/view.c - dlls/wined3d/wined3d_gl.h
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/93a6d341d4cc00c46d576333fa0a804...