Giovanni Mascellani : vkd3d-shader/d3dbc: Destroy the SM1 parser on parsing errors.

[Alexandre Julliard]

Module: vkd3d
Branch: master
Commit: a2fb9588c7c4627b68e660a1d61e4dcc4f69f524
URL:    https://gitlab.winehq.org/wine/vkd3d/-/commit/a2fb9588c7c4627b68e660a1d61e4d...

Author: Giovanni Mascellani 
Date:   Thu Sep  7 11:29:49 2023 +0200

vkd3d-shader/d3dbc: Destroy the SM1 parser on parsing errors.

---

libs/vkd3d-shader/d3dbc.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/libs/vkd3d-shader/d3dbc.c b/libs/vkd3d-shader/d3dbc.c
index 554a3632..be2cb08a 100644
--- a/libs/vkd3d-shader/d3dbc.c
+++ b/libs/vkd3d-shader/d3dbc.c
@@ -1341,12 +1341,19 @@ int vkd3d_shader_sm1_parser_create(const struct vkd3d_shader_compile_info *compi
         ++instructions->count;
     }

-    *parser = &sm1->p;
-
     for (i = 0; i < ARRAY_SIZE(sm1->p.shader_desc.flat_constant_count); ++i)
         sm1->p.shader_desc.flat_constant_count[i].external = get_external_constant_count(sm1, i);

-    return sm1->p.failed ? VKD3D_ERROR_INVALID_SHADER : VKD3D_OK;
+    if (sm1->p.failed)
+    {
+        WARN("Failed to parse shader.\n");
+        shader_sm1_destroy(&sm1->p);
+        return VKD3D_ERROR_INVALID_SHADER;
+    }
+
+    *parser = &sm1->p;
+
+    return VKD3D_OK;
 }

bool hlsl_sm1_register_from_semantic(struct hlsl_ctx *ctx, const struct hlsl_semantic *semantic,