ChangeSet ID: 30028 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner@winehq.org 2006/11/26 20:32:22
Modified files: include : testData.php
Log message: Alexander Nicolaysen Sørnes alex@thehandofagony.com Add basic rating logic checking to testData::CheckOutputEditorInput() to prevent people from saying a running application is garbage and an application that won't install is platinum.
Patch: http://cvs.winehq.org/patch.py?id=30028
Old revision New revision Changes Path 1.10 1.11 +9 -1 appdb/include/testData.php
Index: appdb/include/testData.php diff -u -p appdb/include/testData.php:1.10 appdb/include/testData.php:1.11 --- appdb/include/testData.php:1.10 27 Nov 2006 2:32:22 -0000 +++ appdb/include/testData.php 27 Nov 2006 2:32:22 -0000 @@ -582,7 +582,15 @@ class testData{
if (empty($aValues['sTestedRating'])) $errors .= "<li>Please enter a rating based on how well this application runs.</li>\n"; - + + // Basic checking of rating logic to ensure that the users test results + // are consistent + if (($aValues['sRuns'] != "Yes") && ($aValues['sTestedRating'] != GARBAGE_RATING)) + $errors .= "<li>Applications that do not run should be rated ‘Garbage’.</li>\n"; + + if (($aValues['sInstalls'] == "No") && ($aValues['sTestedRating'] == PLATINUM_RATING)) + $errors .= "<li>An application can only get a Platinum rating if it installs and runs ‘out of the box’.</li>\n"; + return $errors;
}