- wine-devel - winehq.org

Re: Fix regression in CreateProcess
by Mike McCormack 24 Oct '04

24 Oct '04

Eric Pouech wrote: > As Mike reported, there was a bug in CreateProcess introduced with the > runtime info handling. > This patch should take care of it. > A+ Hi Eric, This patch fixes the problem! thanks for your help! Mike

1 0

The wine user guide: an idea
by Noam Raphael 23 Oct '04

23 Oct '04

Hello, First, let me apologize: I am not familiar with wine, and I didn't make a decent research before I posted this message. I just read through the wine user guide, and though of something that could be nice for a user as lazy as I am. Since the introduction asked for comments, I comment. What I would like is a section with common use cases of wine and step-by-step instructions for each of them. It shouldn't be long - it should be mostly links to other parts of the user guide. I think of something like that: CASE: I have a working windows machine, and I would like to use the installed programs from linux. (which happens to be my situation...) WHAT TO DO: 1. Install wine (see ...) 2. Copy all files into your home dir, for example, ~/wine/C 3. Run winecfg (see ...) ... This would give the users (or at least me) a nice warm feeling that what I want to do was already done and isn't so complicated (I hope - I haven't tried it yet). Have a good week, Noam Raphael P.S. if you reply, can you please CC me? I'm not a member of wine-devel.

1 0

Re: wine devel documentation reorganization
by Mike Hearn 23 Oct '04

23 Oct '04

Spiffy. As part of my ongoing quest to make Wine hacking less scary, I've written some docs on SEH. I'll submit them to the kernel modules section when I get net access back. Just a heads up in case anybody else was thinking of covering that topic. Eric Pouech wrote: > As posted on wine-devel, here's a patch to reorganize the Wine > Developer's Guide. > It's gzip:ed because of the size (160KB). > Here's the changelog for those who don't want to open the gzip: > > A+ > Reorganizing wine-devel: > - killing the advanced part > (and moving its chapters in both developing Wine and Wine > archi parts) > - creating a new book on coding practices > from i18n.sgml, patches.sgml and porting.sgml (developing > Wine) > - creating a new book on some debugging strategies > from the old advanced book and cvs-regression.sgml > (developing Wine) > - creating a new book on the kernel modules (NTDLL & KERNEL32) > from architure.sgml / related DLLs and > address-space.sgml, console.sgml, threading.sgml > - creating a new book on the windowing > from architure.sgml / USER32 and related > - creating a new book on the graphical parts > from architure.sgml / GDI32 and related > Other changes: > - removed list of DLLs and their role (from the > modules overview) > - removed in X11 keyboard mapping section the part related > to submit a patch

2 1

Re: Fully Revised Wine User Guide Introduction
by Francois Gouget 23 Oct '04

23 Oct '04

On Fri, 22 Oct 2004, Scott Ritchie wrote: > The version 0.9 todo list (bug 85) specifies the need for a rewritten > intro to the Wine User Guide. > > This patch is that rewritten intro. It rewords things to make Wine > easier to understand for the new user, gives it a more professional > look, and removes some outdated information. Unlike my previous patch, > this one should be properly formatted, It still has awfully long lines. Are you sure you sent the right patch? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.

1 0

Program To Check System Metrics
by William Poetra Yoga H 23 Oct '04

23 Oct '04

Hi guys (& gals), if you remember I was working on the caption buttons. I haven't submitted the patch yet (it's still in progress) and I wish to know the relations between system metrics, because I think they are very closely related to drawing on the screen, like borders, sizes, etc. I'm writing an app here, called metrics, but since this is my first Win32 program, I've encountered many problems (and solved only a few :-P). I've read bits of theForge's Win32 tutorial at www.winprog.org (I got the link from Wine), but I just can't figure out how to handle the "Refresh" and "Save" buttons properly. "Refresh" is for refreshing (regetting) the metric values, and save is for saving the values to a file. Please help me with this, and be informed that this is my first Win32 app, so bear with me... File is attached. _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

1 0

IE6 install Regression
by Mike McCormack 23 Oct '04

23 Oct '04

Hi Eric, The following patch causes the IE6 installer to crash. Thanks to Rob for figuring out which patch caused the problem very quickly :) Mike Log message: Eric Pouech <pouech-eric(a)wanadoo.fr> - msvcrt: the file descriptors are now inherited between parent/child processes - kernel32.CreateProcess: make use of the *reserved2 fields for C-RunTime data inheritance http://www.winehq.org/hypermail/wine-cvs/2004/09/0039.html ... 001f:Call kernel32.GetStartupInfoA(77adfca4) ret=500b34f6 001f:Ret kernel32.GetStartupInfoA() retval=77adfca4 ret=500b34f6 trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x500b354f trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=780704e4 trace:seh:EXC_RtlRaiseException eax=00570000 ebx=77efd6e8 ecx=00000040 edx=77b004e0 esi=780704e4 edi=500c7ab8 trace:seh:EXC_RtlRaiseException ebp=77adfcec esp=77adfc98 cs=0073 ds=007b es=007b fs=0033 gs=0000 flags=00210 202 trace:seh:EXC_CallHandler calling handler at 0x77c0e240 code=c0000005 flags=0

2 3

Re: Fix for bug 824 - proper handling of REG_MULTI_SZ
by Alexandre Julliard 23 Oct '04

23 Oct '04

Randy Galbraith <randy.galbraith(a)cox.net> writes: > This proposed patch addresses the concern raised by bug 824. This > patch changes the handling of REG_MULTI_SZ from REG_SZ to REG_BINARY. Do you actually have an app that depends on this? I agree that in theory we should preserve the data exactly, but this means giving up on an easily editable registry format, so it should be done only if something really needs it. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: winapi_check and 16 bit -register functions
by Alexandre Julliard 22 Oct '04

22 Oct '04

Francois Gouget <fgouget(a)free.fr> writes: > Yesterday's winapi_check path warns about 32 bit -register functions > that are implemented by stdcall functions, but not about 16 bit > -register functions implemented by stdcall functions. The reason is > that for the latter the calling convention is set to 'pascal' or > 'pascal16' in winapi_check. However I suspect these too should be > implemented as cdecl. They could, but that will require some changes to the .spec.c code, right now the calling convention is based on the type specified in the spec file, so pascal register functions have to be WINAPI. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [dx9-12] Major change to desgin
by Alexandre Julliard 22 Oct '04

22 Oct '04

"Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: > I have changed the design so only the Direct3D<interface><8/9> ones extend > IUnknown, and so there is no reference counting of the IWineD3D > objects. I don't think that's a good idea. If you are using COM interfaces then you need to use them the COM way, this means IWineD3D should derive from IUnknown and freeing it should be done through the Release method. If you don't want to use standard COM then don't declare COM interfaces at all, create your own mechanism. > Instead, when any Direct3D<interface><8/9> is Released to zero, then it > calls a Free method in its WineD3D equivalent interface. I also changed the > IWineD3D interface to contain, as a void *, a pointer to its 'parent' (by > which I mean the Direct3D8/9 interface) plus a function (GetParent) which > returns that pointer. This is bad too, you shouldn't use void*, you should use proper types, at the very least IUnknown*, but preferably define an IWineD3DUser interface or something like that. -- Alexandre Julliard julliard(a)winehq.org

2 4

Wine on OpenBSD
by Sascha Hanse 22 Oct '04

22 Oct '04

> >> I just tried to install the recent Wine-tarball (20041019) on my >> OpenBSD 3.6. First I had to remove kthread.c:275: the RFTHREAD flag. >> Then the'make depend && make' worked properly but the make install >> first fails with: >> >> /usr/bin/install -c serialui.dll.so >> /usr/local/lib/wine/serialui.dll.so cd `dirname setupapi/__install__` >> && make install gcc -g -O2 -o install install.c > >Your make tries to build the 'make install' target from install.c, >that won't work of course. I guess we'll have to rename that file, >unless OpenBSD make has an equivalent of the .PHONY target. > >-- >Alexandre Julliard >julliard_at_winehq.org Hi Julliard, thank you for your response. Could you tell me when or how this can be done? -- Anyone who considers arithmetical methods of producing random digits is, of course, in a state of sin. --John von Neumann (1951)

2 2

Re: Add list for monitoring Appdb
by Jeremy Newman 22 Oct '04

22 Oct '04

I'm holding off on this patch until I get more comments on why we should or shouldn't create yet another mailing list. My personal opinion is that we don't need a mailing list for this. The change emails can go straight to the app owners themselves, and possibly to the appdb admins. I know I wouldn't care seeing update emails for apps I don't maintain. Just my opinion. I will create this list if there is enough interest in it. On Wed, 2004-10-13 at 10:38 -0700, Tony Lambregts wrote: > I am working on a series of changes that will let changes to the appdb > be emailed to administrators, application owners and other users. > > This will be similar to how bugzilla does it. > > When someone changes an application an email listing the changes gets > sent to the following > > - Appdb administrators. > - Application owners. > - Aplication monitors. > > One of the things that I think is a repository the way wine-bugs(a)winehq.org > does for bugzilla > > I need Jeremy to set up the email account and the mailman account. > > Change log: Add link for monitoring changes to application database > > files changed: lostwages/templates/en/forums.template > > > Tony Lambregts > > Index: forums.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/forums.template,v > retrieving revision 1.16 > diff -u -r1.16 forums.template > --- forums.template 15 Sep 2004 20:05:31 -0000 1.16 > +++ forums.template 13 Oct 2004 15:46:24 -0000 > @@ -97,6 +97,13 @@ > <a href="http://bugs.winehq.org/">Bug Tracking Database</a>. > > <li> > + [<a href="http://www.winehq.org/mailman/listinfo/wine-appdb">(Un-)Subscribe</a>] > + [<a href="http://www.winehq.org/hypermail/wine-appdb/">Archive </a>] > + <a href="mailto:wine-appdb@winehq.org">wine-appdb(a)winehq.org</a> > + A low traffic (2/day) read-only list for monitoring submissions to the > + <a href="http://appdb.winehq.org/">Application Database</a>. > + > + <li> > [<a href="http://www.winehq.org/mailman/listinfo/wine-tests-results">(Un-)Subscribe</a>] > [<a href="http://www.winehq.org/hypermail/wine-tests-results/">Archive</a>] > <a href="mailto:wine-tests-results@winehq.org">wine-tests-results(a)winehq.org</a> > > >

3 2

Re: shellpath.c: Avoid copying invalid data on error
by Alexandre Julliard 22 Oct '04

22 Oct '04

Juan Lang <juan_lang(a)yahoo.com> writes: > The following is a better patch, I think, in that > - it doesn't add a break statement to the default case > (some compilers warn on this) I seriously doubt that, what compiler does this for you? It's much better practice to always add break to all cases, otherwise when someone adds some code at the end of the switch they will forget to add a break to the previous case. > - WCHAR szBuildPath[MAX_PATH], szTemp[MAX_PATH]; > + WCHAR szBuildPath[MAX_PATH], szTemp[MAX_PATH] = { 0 }; This fills the whole buffer with zeroes, that's not really needed. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dlls/shlwapi PathIsValidChar
by Alexandre Julliard 22 Oct '04

22 Oct '04

Ge van Geldorp <gvg(a)reactos.com> writes: > Did this patch: http://www.winehq.org/hypermail/wine-patches/2004/09/0446.html > fall through the cracks or is it not acceptable? I think a lookup table would be more elegant (and faster...) -- Alexandre Julliard julliard(a)winehq.org

1 0

unaligned access bug in winspool on sparc
by Eric Frias 22 Oct '04

22 Oct '04

I just ran across an evil little bug in the WINSPOOL_GetPrinter_2 function. It looks like this type of bug could be hiding in other API functions too. It causes a segmentation fault because of an unaligned access on Solaris (sparc). This function packs a PRINTER_INFO_2 structure and all of its variable-length fields into one contiguous block of memory. The structure is first, then several strings, and then a DEVMODE structure. The problem is that because the strings can be any length, the DEVMODE structure itself could be placed at an unaligned (odd) address. So on our system, wine runs correctly if we only have printers with an even number of letters in their name in the printcap file, but it crashes if any have an odd number of letters in their name. I put in a quick hack that aligns it to a 4-byte boundary. I think a two-byte boundary would suffice, but I decided to err on the safe side since I wasn't sure. I inserted the following block near line 1822 in info.c: ------ { int bytesOfPadding = (4 - (*pcbNeeded % 4)) % 4; if (space && bytesOfPadding <= left) { ptr += bytesOfPadding; left -= bytesOfPadding; } else space = FALSE; *pcbNeeded += bytesOfPadding; } ------ right before the line: ------ if(WINSPOOL_GetDevModeFromReg(hkeyPrinter, Default_DevModeW, ptr, left, &size, unicode)) { ----- What is the correct way to align this structure? Are there any macros that specify the necessary alignment for each architecture? I'm also wondering if there are any other functions that are likely to contain the same bug. Thanks, Eric

1 0

Re: msdn: d3drs_wrapn[0-7] ???
by Devils Cry 22 Oct '04

22 Oct '04

Well, i aplied the changes raphael suggested and although i dont understand what they do they work :D @David Welch Yeah, already found that out, but thx anyway, i think i understand it a bit better now :) /Me moving on for validateshaders... lets see what that gets :D Cheers Nikolas

1 0

Re: Add function prototypes to wineconf
by Chris Morgan 22 Oct '04

22 Oct '04

I think the idea is that we should move the functionality of wineconf into winecfg so winecfg should be able to autodetect and import the configurations from existing windows installs. Wineconf hasn't been well maintained lately so maybe now is a good time to encourage people to implement that functionality in winecfg by removing it ;-) Chris > > From: Francois Gouget <fgouget(a)free.fr> > Date: 2004/10/22 Fri PM 12:21:32 EDT > To: wine-patches(a)winehq.org > Subject: Add function prototypes to wineconf > > > This tool generates a Wine configuration containing [Drive] sections! > In other words it's pretty outdated. It was last updated almost 18 > months ago! > > Is it even worth keeping? Maybe the best thing to do is to do a cvs > delete on it? > > In case we want to keep it I added function prototypes. However I did > not change its behavior any further. On my machine it runs but perl > issues a couple of warnings... the same one it was issuing before I ever > touched it. > > > Changelog: > > * tools/wineconf > > Add function prototypes. > Change the way functions are called and their declaration order so > perl can check the prototypes. > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > "Lotto: A tax on people who are bad at math." -- unknown > "Windows: Microsoft's tax on computer illiterates." -- WE7U >

1 0

modal message box fixme
by Ivan Leo Puoti 22 Oct '04

22 Oct '04

I've written an app that calls a modal message box, if the uType parameter passed to MessageBox is MB_TASKMODAL or MB_SYSTEMMODAL a fixme is printed, but if it's MB_APPLMODA wine doesn't print a fixme. Is the attached fix correct (It works for me)? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Using Microsoft C++ Toolkit with Wine
by Dan Kegel 22 Oct '04

22 Oct '04

I've posted about this before, but never really tied things up in a neat package, so: Here's a document that describes how to use Microsoft C++ Toolkit on Linux to build Windows programs: http://www.kegel.com/wine/cl-howto.html I hope that helps a few people. I certainly find it convenient when writing Wine conformance tests. To build a Wine conformance test standalone, I start the test off with the lines #include <stdarg.h> #include <windef.h> #include <winbase.h> #ifndef STANDALONE #include "wine/test.h" #define ok2 ok #else #include <assert.h> #include <stdio.h> #define START_TEST(name) main(int argc, char **argv) #define ok(condition, msg) \ do { \ if(!(condition)) \ { \ fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__); \ exit(0); \ } \ } while(0) #define ok2(condition, msg, arg) \ do { \ if(!(condition)) \ { \ fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__, arg); \ exit(0); \ } \ } while(0) #define todo_wine #endif #include <winerror.h> and use ok2 for those calls to ok that have one argument after the format string. That .c file should be fine for either normal or standalone use. (I haven't tested ok2 yet under the normal wine build, but I think #define ok2 ok should work.) Then I can compile with cl -DSTANDALONE -D_X86_ myfile.c and get a quickie Windows executable for just that test file. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: Cleanup config
by Alexandre Julliard 22 Oct '04

22 Oct '04

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > [wine] > -"Windows" = "c:\\windows" > -"System" = "c:\\windows\\system" > -"Temp" = "e:\\" > -"Path" = "c:\\windows;c:\\windows\\system;e:\\;e:\\test;f:\\" > -"Profile" = "c:\\windows\\Profiles\\Administrator" This is OK except for the windows dir, that one is still being used by the registry code. -- Alexandre Julliard julliard(a)winehq.org

2 2

wine 1019 build fails at wine_marlett.sfd
by sean 22 Oct '04

22 Oct '04

I'm trying to buid wine-10192004. I've installed fontforge-10142004. The wine build fails here: fontforge -script ../fonts/genttf.ff wine_marlett.sfd Copyright (c) 2000-2004 by George Williams. Executable based on sources from 10:52 14-Oct-2004. FontForge used to be named PfaEdit. make[1]: *** [wine_marlett.ttf] Segmentation fault This not a machine error. The sigsegv happens if I execute this command in the build directory. Before that i get: fontforge -script ../fonts/genttf.ff wine_courier.sfd Copyright (c) 2000-2004 by George Williams. Executable based on sources from 10:52 14-Oct-2004. FontForge used to be named PfaEdit. LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt wine_courier.ttf 13 1252 96 128 ../tools/fnt2fon wine_courier-1252-96-13.fnt wine_coure.fon Wine Courier 10 pts 96x96 dpi LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt wine_courier.ttf 13 1250 96 128 ../tools/fnt2fon wine_courier-1250-96-13.fnt wine_couree.fon Wine Courier 10 pts 96x96 dpi LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt wine_courier.ttf 13 1251 96 128 Missing glyph for char 0402 Missing glyph for char 0403 Missing glyph for char 0453 Missing glyph for char 0409 Missing glyph for char 040a Thanks for any help. sean

1 0

Re: Add list for monitoring Appdb
by Tony Lambregts 22 Oct '04

22 Oct '04

Quoting Chris Morgan I was intending to submitt a patch to allow each user to turn on emails. By default no one would recieve emails. If administrators turn on the switch then they would recieve emails from any app that changed. For application Owners/ Maintainers, they would recieve emails when something changed for thier app. The idea for a mailing list archive is so we have a record of what was changed the same way that we have for bugzilla. Mostly it is a safegaurd for when we open up the DB to individual app Owners/maintainers. > > Maybe there should be an option for an admin to add themselves to both a > global and a app specific list so when things change for an app an email is > sent to all people on the global list and then all people on the app specific > list. This lets people opt-in if they want to get the emails. > > Chris > > > On Thursday 21 October 2004 3:58 pm, Jeremy Newman wrote: > > I'm holding off on this patch until I get more comments on why we should > > or shouldn't create yet another mailing list. > > > > My personal opinion is that we don't need a mailing list for this. The > > change emails can go straight to the app owners themselves, and possibly > > to the appdb admins. I know I wouldn't care seeing update emails for > > apps I don't maintain. Just my opinion. > > > > I will create this list if there is enough interest in it. > > > > On Wed, 2004-10-13 at 10:38 -0700, Tony Lambregts wrote: > > > I am working on a series of changes that will let changes to the appdb > > > be emailed to administrators, application owners and other users. > > > > > > This will be similar to how bugzilla does it. > > > > > > When someone changes an application an email listing the changes gets > > > sent to the following > > > > > > - Appdb administrators. > > > - Application owners. > > > - Aplication monitors. > > > > > > One of the things that I think is a repository the way > > > wine-bugs_at_winehq.org does for bugzilla > > > > > > I need Jeremy to set up the email account and the mailman account. > > > > > > Change log: Add link for monitoring changes to application database > > > > > > files changed: lostwages/templates/en/forums.template > > > > > > > > > Tony Lambregts > > > > > > Index: forums.template > > > =================================================================== > > > RCS file: /home/wine/lostwages/templates/en/forums.template,v > > > retrieving revision 1.16 > > > diff -u -r1.16 forums.template > > > --- forums.template 15 Sep 2004 20:05:31 -0000 1.16 > > > +++ forums.template 13 Oct 2004 15:46:24 -0000 > > > @@ -97,6 +97,13 @@ > > > Bug Tracking Database. > > > > > > <li> > > > + [<a > > > href="http://www.winehq.org/mailman/listinfo/wine-appdb">(Un-)Subscribe</ > > >a>] + [<a href="http://www.winehq.org/hypermail/wine-appdb/">Archive > > > </a>] + <a > > > href="mailto:wine-appdb_at_winehq.org">wine-appdb_at_winehq.org</a> + A > > > low traffic (2/day) read-only list for monitoring submissions to the + > > > Application Database. + > > > + <li> > > > [<a > > > href="http://www.winehq.org/mailman/listinfo/wine-tests-results">(Un-)Sub > > >scribe</a>] [<a > > > href="http://www.winehq.org/hypermail/wine-tests-results/">Archive</a>] > > > <a > > > href="mailto:wine-tests-results_at_winehq.org">wine-tests-results_at_winehq.org > > ></a> > > -- > Tony Lambregts > > -- Tony Lambregts

2 1

Re: d3drs_wrap[0-7] ???
by N. Dahn 21 Oct '04

21 Oct '04

Hopefully this isnt the case, and according to this http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dx8_c/dire… i have luck for this time i think. :) Comments? Okay, i think i got one step further: on gamedev.net i found the suggestion to use glTexParameteri(GL_TEXTURE_2D, TEXTURE_WRAP_U/V/W, wrapParm). Besides, could this also be an 3D Texture? I think I worked it out and im going to try it out now, but theres one thing bothering me: as mentioned earlier in d3d there exists the d3dwrapcoord_3 flag which wraps textures through the 4th dimension (that should be time). However, i was unable to find _anything_ going into that direction in opengl so i stubbed it out for now. Does anybody know how to proceed with this? BTW, is there a way to figure out what an undocumented function does? (namely d3drs 172 and 173) Cheers Nikolas

3 3

Winedbg: watchpoints broken?
by Walt Ogburn 21 Oct '04

21 Oct '04

Hi, Winedbg's watchpoints don't seem to work for me: when I try to watch a memory location, winedbg responds that a watchpoint has been set at a different, always constant location (I suspect this is actually in winedbg's memory space). Nothing happens when the location I was trying to watch changes. Here is a cut-and-paste from my winedbg session. I try to watch memory location 0x0041a5ec, but I can set other breakpoints and see that the value has changed without the watchpoint taking effect. ----------------------------------------------------------------------- Wine-dbg>run In 32 bit mode. 0x4049a81f start_process+0xcf [/home/reuben/project/wine/wine/dlls/kernel/../../include/winternl.h:1249] in kernel32: jmp 0x4049a815 start_process+0xc5 [/home/reuben/project/wine/wine/dlls/kernel/process.c:1022] in kernel32 1249 static inline void WINAPI DbgBreakPoint(void) { __asm__ __volatile__("int3"); } 1249 static inline void WINAPI DbgBreakPoint(void) { __asm__ __volatile__("int3"); } Wine-dbg>watch *0x0041a5ec Watchpoint 1 at 0x405ae8c4 Wine-dbg>x 0x0041a5ec 00000000 Wine-dbg>break *0x004130ec Breakpoint 2 at 0x004130ec Wine-dbg>cont fixme:ole:CoRegisterMessageFilter stub Stopped on breakpoint 2 at 0x004130ec Wine-dbg>x 0x0041a5ec 403e9d40 Wine-dbg>cond 2 $ecx==0x10 Wine-dbg>cont Stopped on breakpoint 2 at 0x004130ec Wine-dbg>x 0x0041a5ec 00000000 Wine-dbg>info break Breakpoints: 2: y 0x004130ec (1) stop when ($ecx == 16) Watchpoints: 1: y 0x405ae8c4 on 4 bytes (W) -------------------------------------------------------------------------- The fact that winedbg thinks the watchpoint is 0x405ae8c4 is especially puzzling, but it's entirely possible that the confusion lies with me rather than winedbg. Thanks, Walter

2 5

Re: wine/ programs/winhelp/hlp2sgml.c dlls/winsock ...
by Vincent Béron 21 Oct '04

21 Oct '04

Le mar 19/10/2004 à 19:55, Alexandre Julliard a écrit : [snip] > 1.161 1.162 +2 -2 wine/dlls/winsock/socket.c This change removed LONG to put long instead, which is not the same size on Alpha between Windows and Unix. LONG can be made the same size on both. > 1.32 1.33 +2 -2 wine/dlls/rpcrt4/rpc_server.c Same thing here. Shouldn't we use LONG in both places? Vincent

2 1

Re: winedos: per drive current directory
by Eric Pouech 21 Oct '04

21 Oct '04

Markus Amsler a écrit : > Microsoft's Segmented-Executable Linker Version 5.10 shipped with QBasic > 7.1 needs per drive current directory. > > Changelog > * Implement per drive current directory. IMO, you should keep the part of the note dealing with where to store the list of current drives (as it's not done yet in DOS style) A+

1 0

Graphic problems with wxtide32
by Uwe Bonnes 21 Oct '04

21 Oct '04

Hallo, wxtide (http://www.wxtide32.com/download.html) is an opne source program that shows graphic problems. For example, when started, a left click in the tide window brings up a gray window, where some text should appear. This window is managed by following code: static void open_popup(DWORD mouseXY, char *text) { int mouseX, mouseY, cxscreen, cyscreen, startX, startY, side; PAINTSTRUCT ps; RECT purc = {0,0,0,0}; HFONT oldfont; #define POPUP_BORDER 1 close_popup(); // Open window with dummy position and size to get device context popup = CreateWindow("STATIC", "", WS_POPUP|WS_VISIBLE,//|WS_BORDER, 10,10,250,50, window, NULL, t_hinst, NULL); BeginPaint(popup,&ps); oldfont = SelectFont(ps.hdc,gfont); // Get extents for this text DrawText(ps.hdc, text, strlen(text), &purc, DT_CALCRECT); purc.right += POPUP_BORDER*2; purc.bottom += POPUP_BORDER*2; mouseX = LOWORD(mouseXY); mouseY = HIWORD(mouseXY); cxscreen = GetSystemMetrics(SM_CXSCREEN); // cyscreen = GetSystemMetrics(SM_CYFULLSCREEN); if (side=(cxscreen > (mouseX + winX + purc.right))) startX = mouseX + winX; else startX = mouseX + winX - purc.right; if (0 < (mouseY + winY - purc.bottom)) startY = mouseY + winY - purc.bottom; else startY = mouseY + winY; // Now make window the right size and in the right place MoveWindow(popup,startX,startY,purc.right,purc.bottom,FALSE); // SetTextColor(ps.hdc,fgtext_color); // SetBkColor(ps.hdc,RGB(255,255,255)); FillRect( ps.hdc, &purc, GetStockObject(WHITE_BRUSH)); FrameRect(ps.hdc, &purc, GetStockObject(BLACK_BRUSH)); purc.left += POPUP_BORDER; purc.top += POPUP_BORDER; purc.right -= POPUP_BORDER; purc.bottom -= POPUP_BORDER; DrawText(ps.hdc,text,strlen(text),&purc, DT_WORDBREAK|(side? DT_LEFT : DT_RIGHT)); SelectFont(ps.hdc,oldfont); EndPaint(popup,&ps); } Any idea what wine is doing wron? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: msdn: d3drs_wrap[0-7] ???
by Devils Cry 21 Oct '04

21 Oct '04

> yes, its strange. having a real demo of use should help a lot Okay, i tested what i did with a game but the game doesnt call it directly so i guess its right what you said, its done be the d3dtss_address thing. Ill have a _very_ close look at it as my understanding of c isnt that deep atm... > Hmm, i don't think it match exactly OpenGL WRAP specs > but i haven't understand d3d wrapping specs, and i havent seen any > game using it to test :( Try Chaos Legion, its really fun and it uses the wrap calls ;D BTW, for ommiting redundances, ive currently done the d3drs_lineantialias and the ive stubbed out the d3drs_debugmonitortoken call, i think we dont need it. Regards, Nikolas

1 0

Toolbar control Messages causing WM_PAINT
by Thorsten Kani 21 Oct '04

21 Oct '04

I did a quick check of ToolbarMessages that cause WM_PAINT instantly: TB_CHANGEBITMAP TB_CHECKBUTTON TB_DELETEBUTTON TB_ENABLEBUTTON TB_INDERTERMINATE TB_MARKBUTTON TB_PRESSBUTTON TB_SETBITMAPSIZE TB_SETBUTTONSIZE TB_SETBUTTONWIDTH TB_SETCOLOSCHEME TB_SETIMAGELIST TB_SETINDENT TB_SETINSERTMARK TB_SETMAXTEXTROWS TB_SETSTATE I left some the remaining ToolbarMessages untestet because i did not know how to send them correcty with controlspy. other Messages showing up and caused Paint: WM_UNKNOWN(128) WM_CHILDACTIVATE WM_ERASEBKGND WM_MOUSELEAVE(borders) probably this is not everything you need. (: Tho

1 0

Winecfg resources
by David Kredba 21 Oct '04

21 Oct '04

Hello all. There are disabled other than English resources in the wincfg.rc file. I finished tranlating resources to the Czech language and want to enable it. Why are non English resources commented out ? Thanks, David -- David Kredba <kredba at ibot.cas.cz> GPG: ID 1024D/5B6B02DE Fingerprint: F0B3312596BEDCF91DFB 0699E06AACD75B6B02DE

2 1

Re: [wineD3D] HW Vertex Buffer
by Ann and Jason Edmeades 21 Oct '04

21 Oct '04

Hiya, Re your new patch... -#define IWineD3DDevice_CreateVertexBuffer(p,a,b,c,d,e,f) (p)->lpVtbl->CreateVertexBuffer(p,a,b,c,d,e,f) +#define IWineD3DDevice_SetFVF(p,a) (p)->lpVtbl->SetFVF(p,a) +#define IWineD3DDevice_GetFVF(p,a) (p)->lpVtbl->GetFVF(p,a) +#define IWineD3DDevice_CreateVertexDeclaration(p,a,r) (p)->lpVtbl->CreateVertexDeclaration(p,a,r) +#define IWineD3DDevice_SetVertexDeclaration(p,a) (p)->lpVtbl->SetVertexDeclaration(p,a) +#define IWineD3DDevice_GetVertexDeclaration(p,a) (p)->lpVtbl->GetVertexDeclaration(p,a) +#define IWineD3DDevice_CreateVertexShader(p,a,r) (p)->lpVtbl->CreateVertexShader(p,a,r) +#define IWineD3DDevice_SetVertexShader(p,a) (p)->lpVtbl->SetVertexShader(p,a) +#define IWineD3DDevice_GetVertexShader(p,a) (p)->lpVtbl->GetVertexShader(p,a) +#define IWineD3DDevice_CreatePixelShader(p,a,r) (p)->lpVtbl->CreatePixelShader(p,a,r) +#define IWineD3DDevice_SetPixelShader(p,a) (p)->lpVtbl->SetPixelShader(p,a) +#define IWineD3DDevice_GetPixelShader(p,a) (p)->lpVtbl->GetPixelShader(p,a) +#define IWineD3DDevice_CreateVertexBuffer(p,a,b,c,d,e,f) (p)->lpVtbl->CreateVertexBuffer(p,a,b,c,d,e,f) +#define IWineD3DDevice_BindVertexBuffer(p,a) (p)->lpVtbl->BindVertexBuffer(p,a) +#define IWineD3DDevice_UnbindVertexBuffer(p,a) (p)->lpVtbl->UnbindVertexBuffer(p,a) Some of these are defining functions which dont exist yet in wined3d, which will get confusing. Additionally, the functionality for the wined3d vertex buffer is almost untested, because its just copying code and ensuring it gets driven. The d3d9 -> wined3d support isnt enough to prove your changes actually work, and I would rather we didnt put in untested code during the migration phase. I'm finding it hard to keep track of where I am on the migration from d3d8 -> wined3d, so could I ask that you hold off this patch for a month or so, until I can get enought support into the wined3d library so you can prove the new code works. I could do with the d3d8, d3d9 and wined3d code staying fixed as I try to shuffle it all around. Once I get enough in wined3d to be able to prove parts of it work, and we are using it from both d3d8 and d3d9 then by all means put in this change. I'd also comment that this change is desperately needed as hardware buffer support should speed up the d3d support too. It seems odd to turn away new code, especially when hardly anyone else helps on the d3d side! Jason

2 2

msdn: d3drs_wrap[0-7] ???
by Ann and Jason Edmeades 21 Oct '04

21 Oct '04

As I understand it, there is texture states (D3DTSS_ADDRESSU/V/W) which map to the GL_WRAP_* states, and there is no direct mapping for the d3drs_* versions. I am not sure I understand the differences, but you would need to understand it before implementing it. BTW Any help on the d3d8/9 interfaces is very welcome - there's not enough people working on it (Nor the ddraw stuff either, come to that). I'm working on moving all the code from d3d8 into wined3d and calling from both d3d8/d3d9. It will probably take another month or so, but if patches could be held until it is complete I would appreciate it - I'm afraid of dropping or missing something as I go! Regards, Jason

2 1

msdn: d3drs_wrap[0-7] ???
by Devils Cry 21 Oct '04

21 Oct '04

Hi folks! Dunno why, but this list regrets my subscriptionrequests. Anyway, lets see if this gets through... Im currently working a bit on the d3d8 dll (i know there are currently heavy changes made, just creating some new interfaces) and am now focusing on the d3drs_wrap[0-7] function. I have some problems understanding what it should do, from msdn: [quote] D3DRS_WRAP0 [ie, its the same for wrap0 to 7] Texture-wrapping behavior for multiple sets of texture coordinates. Valid values for this render state can be any combination of the D3DWRAPCOORD_0 (or D3DWRAP_U), D3DWRAPCOORD_1 (or D3DWRAP_V), D3DWRAPCOORD_2 (or D3DWRAP_W), and D3DWRAPCOORD_3 flags. These cause the system to wrap in the direction of the first, second, third, and fourth dimensions, sometimes referred to as the s, t, r, and q directions, for a given texture. The default value for this render state is 0 (wrapping disabled in all directions). [/quote] My current thoughts are to enable the GL_TEXTURE_WRAP_S, T and R functions by the value passed to it (ie for 2 enable the S and T wrappers), but i guess this isnt exactly what it should do. Any thoughts, ideas, guesses? BTW, i havent found anything matching the D3DWRAPCOORD_3 flag (should be the 4th dimension). Is there something i can use for this? Thx in advance Nikolas

2 1

msdn: d3drs_wrap[0-7] ???
by Devils Cry 21 Oct '04

21 Oct '04

Hi folks! Im currently working a bit on the d3d8 dll (i know there are currently heavy changes made, just creating some new interfaces) and am now focusing on the d3drs_wrap[0-7] function. I have some problems understanding what it should do, from msdn: [quote] D3DRS_WRAP0 [ie, its the same for wrap0 to 7] Texture-wrapping behavior for multiple sets of texture coordinates. Valid values for this render state can be any combination of the D3DWRAPCOORD_0 (or D3DWRAP_U), D3DWRAPCOORD_1 (or D3DWRAP_V), D3DWRAPCOORD_2 (or D3DWRAP_W), and D3DWRAPCOORD_3 flags. These cause the system to wrap in the direction of the first, second, third, and fourth dimensions, sometimes referred to as the s, t, r, and q directions, for a given texture. The default value for this render state is 0 (wrapping disabled in all directions). [/quote] My current thoughts are to enable the GL_TEXTURE_WRAP_S, T and R functions by the value passed to it (ie for 2 enable the S and T wrappers), but i guess this isnt what it should do. Any thoughts, ideas, guesses? BTW, i havent found anything matching the D3DWRAPCOORD_3 flag (should be the 4th dimension). Is there something i can use for this? Thx in advance Nikolas

1 0

Re: shell32: shlfileop; Add resource for renaming files on collision (patch 2)
by Tobias Burnus 21 Oct '04

21 Oct '04

Hello, Rolf Kalbermatter wrote: > + IDS_COPY_X_OF_TEXT "Kopie%svon %s" > + IDS_COPY_X_OF_TEXT "Copy%sof %s" I may miss something, but I think there is are space missing around the first '%s'. Tobias

1 0

RE: Treeview +/-
by Ge van Geldorp 21 Oct '04

21 Oct '04

> From: Jon Griffiths > > Hi, > > Fixing my own FIXME. > > Cheers, > Jon > > +wine/dlls/comctl32/treeview.c > Draw +/- correctly for large icon sizes (patch applied here: http://www.winehq.org/hypermail/wine-cvs/2004/10/0115.html) I can see that this would be an improvement for large icon sizes, but I don't think it's good for small icon sizes. See attached screenshot of regedit. Maybe the height/width at which to switch to the Rectangle drawing algorithm needs a bit of tuning? Ge van Geldorp.

1 0

scroll bars not shown
by Nicolai Kuntze 21 Oct '04

21 Oct '04

Hi, in the application given in Bug 2302 are in some menus the scroll bars missing. I think the programm gets wrong dimensions from the size of the window. I do not have enough experience to track the bug by myself. Can someone please have a look on it? I have tried with the latest CVS checkout and comctrl32 as an native library. Yours, Nicolai ---- Diese Nachricht wurde auf Viren und andere gefaehrliche Inhalte sowie Spam untersucht.

1 0

Wine on OpenBSD
by Sascha Hanse 21 Oct '04

21 Oct '04

Hi people, I just tried to install the recent Wine-tarball (20041019) on my OpenBSD 3.6. First I had to remove kthread.c:275: the RFTHREAD flag. Then the 'make depend && make' worked properly but the make install first fails with: /usr/bin/install -c serialui.dll.so /usr/local/lib/wine/serialui.dll.so cd `dirname setupapi/__install__` && make install gcc -g -O2 -o install install.c install.c:23: windef.h: No such file or directory install.c:24: winbase.h: No such file or directory install.c:25: winreg.h: No such file or directory install.c:26: winternl.h: No such file or directory install.c:27: winerror.h: No such file or directory install.c:28: wingdi.h: No such file or directory install.c:29: winuser.h: No such file or directory install.c:30: winnls.h: No such file or directory install.c:31: setupapi.h: No such file or directory install.c:33: wine/unicode.h: No such file or directory install.c:34: wine/debug.h: No such file or directory *** Error code 1 Stop in /home/sensei/wine-20041019/dlls/setupapi. *** Error code 1 Stop in /home/sensei/wine-20041019/dlls (line 416 of Makefile). *** Error code 1 Stop in /home/sensei/wine-20041019 (line 301 of Makefile). After that I copied all needed headerfiles into dlls/setupapi/ and finally I got these errors: [SNIP] /tmp//ccU25700.o(.text+0x18d1): In function `InstallHinfSectionW': /home/sensei/wine-20041019/dlls/setupapi/install.c:927: undefined reference to `SetupOpenInfFileW'/tmp//ccU25700.o(.text+0x18e1):/home/sensei/wine-200 41019/dlls/setupapi/install.c:930: undefined reference to `SetupInitDefaultQueueCallback'/tmp//ccU25700.o(.text+0x18f0):/home/sen sei/wine-20041019/dlls/setupapi/install.c:931: undefined reference to `SetupDefaultQueueCallbackW'/tmp//ccU25700.o(.text+0x1912):/home/sensei /wine-20041019/dlls/setupapi/install.c:934: undefined reference to `SetupTermDefaultQueueCallback'/tmp//ccU25700.o(.text+0x1918):/home/sen sei/wine-20041019/dlls/setupapi/install.c:935: undefined reference to `SetupCloseInfFile'/tmp//ccU25700.o(.text+0x193e): In function `InstallHinfSectionA':/home/sensei/wine-20041019/dlls/setupapi/install. c:950: undefined reference to `RtlCreateUnicodeStringFromAsciiz'/tmp//ccU25700.o(.text+0x195f):/home/ sensei/wine-20041019/dlls/setupapi/install.c:953: undefined reference to `RtlFreeUnicodeString'/tmp//ccU25700.o(.rodata+0x80): In function `get_field_string':/home/sensei/wine-20041019/dlls/setupapi/install.c:9 8: undefined reference to `__wine_dbch_setupapi' collect2: ld returned 1 exit status*** Error code 1 Stop in /home/sensei/wine-20041019/dlls/setupapi. *** Error code 1 Stop in /home/sensei/wine-20041019/dlls/setupapi. *** Error code 1 Stop in /home/sensei/wine-20041019/dlls (line 416 of Makefile). *** Error code 1 Stop in /home/sensei/wine-20041019 (line 301 of Makefile). Please CC me because I'm not subscribed to the list. -Sascha -- Anyone who considers arithmetical methods of producing random digits is, of course, in a state of sin. --John von Neumann (1951)

2 1

Re: Tiny optimizations of bit testing operations
by Rein Klazes 21 Oct '04

21 Oct '04

On Wed, 20 Oct 2004 19:48:05 +0900, you wrote: > Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Tiny optimizations of bit testing operations. Testing with gcc 3.3.5: > - BOOL min_or_max_box = (wndPtr->dwStyle & WS_MAXIMIZEBOX) || > - (wndPtr->dwStyle & WS_MINIMIZEBOX); > + BOOL min_or_max_box = wndPtr->dwStyle & (WS_MAXIMIZEBOX | WS_MINIMIZEBOX); At moderate optimization levels (-O1) gcc compiles this to identical code. > - if((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) != 0) > + if (wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) At any optimization level, gcc compiles this to identical code. > if ((wndPtr->dwStyle & WS_VSCROLL) && > - ((((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) != 0) && (ptClient.x <= rcClient.left + GetSystemMetrics(SM_CXVSCROLL))) || > - (((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) == 0) && (ptClient.x >= rcClient.right - GetSystemMetrics(SM_CXVSCROLL))))) > + (((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) && (ptClient.x <= rcClient.left + GetSystemMetrics(SM_CXVSCROLL))) || > + (!(wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) && (ptClient.x >= rcClient.right - GetSystemMetrics(SM_CXVSCROLL))))) Not different then the previous example. >From the C point of view these bit logics are identical. The compiler finds that out easy. Rein. -- Rein Klazes rklazes(a)xs4all.nl

4 4

IE6: Help Engine Sputtering, Main Engine Doesn't Start, Segmentation Fault
by Dan McGhee 21 Oct '04

21 Oct '04

At the outset I must apologize for the length of this post. This situation is intricately convoluted and, currently, I cannot interpret the information that I have collected. Right now I can only relay information that I think is relevant. I would be more than happy to generate more info, but I will need some specific direction for commands and so forth. Right now I have reached the limit of my current troubleshooting skills. My overall goal is to get Edit Studio 4, a video editing application, running in wine. It depends on the IE6 Help Engine. There are other situations with this app and that's why I don't depend on an older version of wine to run it. Right now, if I can't get IE6 to run its help engine, I can't get my app to work. Here goes on my problems with IE6. Conventions: 1013 implies wine compiled from the cvs update on October 13 and a .wine, created from that update aug implies wine version compiled from the cvs update on October 13 and a .wine from a wine version, compiled from my repository, before the 20040824 16:00:16 CDT commit Symptoms: 1. with wine from 1013 and .wine from 1013, IE6 exits with no window--this started sometime after the September snapshot 2. with wine from 1013, any version of wine that I compile, and .wine from aug, IE6 runs and Help works 3. with wine from September snapshot and .wine from 1013, IE6 creates a segmentation fault My original symptom was that I couldn't get IE6 Help to work after the September snapshot. I did a regression and identified the commit of 20040824 16:00:16 CDT as causing the problem. The commit edits this patch: http://cvs.winehq.org/patch.py?id=13475 Among other things this patch changes wine/dlls/Makefile.in wine/configure.ac wine/configure it also changes itss.dll. However, my symptoms still persist whether I use a native or builtin version of itss. I include this information because I don't know if the symptoms are separate problems or are related. I am not able to pin point the cause of Symptom 1 because I do not yet know how to update my repository to do a regression. I must wait for the archive after the October snapshot. I have reasoned, since I can get IE6 to work completely using a ~/.wine created before that August commit, that the problem lies somewhere in the "fake windows" directory. There are differences in the registry, win.ini and system.ini files, but I do not know how to diagnose them. The following excerpt, from one of the logs I created, shows that there is a completely different sequence, between the working and non-working situations, when shell32 loads for the first time: trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shell32.dll" : builtin -trace:loaddll:MODULE_FlushModrefs Unloaded module L"c:\\windows\\system\\shell32.dll" : builtin -trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shell32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\ole32.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\BROWSEUI.dll" : native err:shell:ReadCabinetState Initializing shell cabinet settings trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\browselc.dll" : native -trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\RPCRT4.DLL" : native +trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\shdoclc.dll" : native +err:rebar:REBAR_WindowProc unknown msg 200b wp=00000000 lp=71180f00 +trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\uxtheme.dll" : builtin +trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\RPCRT4.dll" : native +trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\lz32.dll" : builtin +trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\version.dll" : builtin +trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\urlmon.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\MSOSS.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\CRYPT32.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\OLEAUT32.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\WININET.dll" : native I stopped the excerpt here because this is the point at which the non-working situation exits. I have generated a log from +relay "grepped" for shell32 but do not know how to interpret it to see if I can glean any more information. This log and all the others are contained in the tarball that I have attached. It creates a directory called "wine-trouble" and contains all the information that I have generated. The README contains specifics of what I have done. As I was composing the README for inclusion here, I realized that I had not done two things. I forgot to copy shell and shell32 to my fake windows directory so that all of my tests were conducted with builtin shell and shell32. Additionally, I have not run wine compiled before the August commit with a fake windows created on October 13. I will do both of these and see if I get differenet results. I'm really interested in resolving this and would rather that I had been able to supply better information. However, my knowlege of winedbg, windows and cvs does not currently allow me to proceed further. If anyone wants me to do more, I would appreciate being pointed in the right direction, but I will need some specifics. I have found no documentation on any of the wine mailing lists or other forums to indicate that anyone else is having this problem. It could be something that I am doing. This is why I haven't yet submitted a bug report. If a bug report would be more appropriate, I will do that. Thanks, Dan

1 1

Re: [wineD3D] HW Vertex Buffer
by Raphael 21 Oct '04

21 Oct '04

Hi again, A better patch than previous Changelog: - beta implementation of HW Vertex Buffer support (using ARB_vertex_buffer_object): locking/unlocking, creation, destruction - some wined3d headers/interface extension Todo - Bind/Unbind on rendering (use exported APIs, see IWineD3DDevice_BindVertexBuffer/IWineD3DDevice_UnbindVertexBuffer) Regards, Raphael

1 0

wine developer guide
by Eric Pouech 20 Oct '04

20 Oct '04

While looking at the WDG (and please don't count me in about arguing whether it's WDG or WD'sG or WD'G), I came onto the Advanced Topics book after the two big ones ("Developing Wine" and "Wine Architecture") I does seem very odd to me as it right now: - it just contains "random" bits of information on some parts of wine - we don't have (yet) a uniform way to qualify something of advanced So my proposal would be to: - get rid of "Advanced Topics" book altogether, and keep only "Developing Wine" (the way we'd like development going on) and "Wine architecture" (the way it works - or it's supposed to) - move the various items from "Advanced Topics" to where they belong (see below) - maybe tag in both the "developing" and "architecture" books which parts are really advanced (change of font, specific paragraph type... pick up the visual effect you like most) The mapping that could be done would be: 14.1 Keyboard => Architecture/X11DRV DLL 14.2 Undocumented API => somewhere in the "developing" chapter 14.3 accelerators => Architecture/USER32.DLL 14.4 HW trace => somewhere in the "developing" chapter (likely in debugging) 15 Porting to new OS => somewhere in the "developing" chapter (likely in writing patches, to be renamed as "coding practice" or so) 16 Consoles => Architecture/KERNEL32.DLL 17 Address space => Architecture/6.3.4 (as advanced material) 18 Regression testing => somewhere in the "developing" chapter (in conformance tests) Likewise, the 5.1 about adding new languages could be moved into the "coding practice" part. If noone objects, I'll submit the changes. A+

1 0

Stack overflows
by Robert Lunnon 20 Oct '04

20 Oct '04

I have been trying to make wine work properly with Solaris xlib and have been experiencing a few stack overflow exceptions eg 0009:Ret kernel32._LeaveSysLevel() retval=00000000 ret=7f86a7ba 0009:Ret user32.USER_Unlock() retval=00000000 ret=7f53f837 0009:Call ntdll.RtlEnterCriticalSection(7f579840) ret=7f549249 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=7f549249 0009:Call ntdll.RtlLeaveCriticalSection(7f579840) ret=7f54926a 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=7f54926a 0009:Call ntdll.RtlEnterCriticalSection(7f579840) ret=7f549249 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=7f549249 err:seh:setup_exception stack overflow 0 bytes in thread 0009 eip ca096003 esp 7fc11000 stack 7fc10000-7fd10000 As I recall PE executables specify the stack size in the PE header so in the past I have used a little windows utility under wine to increase the stack allocation to the program, sometimes with mixed results. I Thought I'd post here to find out if this is known problem and what the cause is. I had presumed it was probably due to the extra call layering through xlib adding too much overhead to the stack for the app. Assuming this is the issue there were two actions I was looking at taking 1. A Wine utility to adjust the stack allocation for the executable 2. Adjust the stack allocation in wine to allow a little extra for wine over and above that requested by the app. Opinions ? Bob

1 0

Reimplementing SHGetFolder functions
by Juan Lang 20 Oct '04

20 Oct '04

Any reason this patch wasn't applied? http://www.winehq.org/hypermail/wine-patches/2004/10/0167.html I know it's big, but I hope the test cases help demonstrate its correctness. Let me know if there's anything else I can do to help a review. Thanks, --Juan __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail

2 1

Re: Startmenu
by Robert Shearman 20 Oct '04

20 Oct '04

Thorsten Kani wrote: > Nice Patch - looks good now! > i have changed the offsets and used SM_CXBORDER instead of SM_CXEDGE. > (According to MSDN, cxedge is used for 3D while cxborder is used for > Flat ) > This seems to fix the"draw below" issue. Visual Experience comes now > really near native. > > I noticed that SM_CXEDGE is used everywhere, regardless of Style > TBSTYLE_FLAT. > Please review my attached Patch. It seems to me that this Stylechecks > shoud be used everywhere. I don't think this is correct. If you change the return value for GetSystemMetrics(SM_CXEDGE) in wine/windows/sysmetrics.c then you can see that it does affect the spacing between border and icon (but our toolbar control doesn't exactly match the native for this). > As for String position issue, maybe i can help out with the controlspy > check. > Im interested in understanding the controls and wanted to play around > with CSpy anyway. > Suggestions ? You can download controlspy here: http://www.microsoft.com/msj/0798/controlspy.aspx It is very useful for throwing messages at the common controls, but it cannot test custom draw functionality and it is becoming dated (it is missing new functionality from comctl32 v5.80 and new controls). Rob

2 2

Re: dlls/x11drv/winpos.c::SWP_DoOwnedPopups()
by Dmitry Timoshkov 20 Oct '04

20 Oct '04

"Peter Riocreux" <par+wine_patches(a)silistix.com> wrote: > The comment above SWP_DoOwnedPopups in dlls/x11drv/winpos.c suggests > that the only thing missing is what I *might* have fixed here, > therefore the patch also removes the FIXME and the WARN. It compiles > and doesn't break any behaviour I can test, but I am only guessing > whether I have done the right thing. You have to write a test case and add it to existing ones in dlls/user/tests/win.c to confirm that the patch is correct. -- Dmitry.

2 3

DrawTextA: regarding the nCount variable
by William Poetra Yoga H 20 Oct '04

20 Oct '04

In the MSDN, it is stated that if nCount is 1, then it is assumed that lpString is a null-terminated string. But in the DrawTextExA function, it is -1, as in the code: if (count == -1) count = strlen(str); Shouldn't this be 1 instead of -1? CMIIW. (But theForger's tutorial also uses -1) _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

3 3

Re: ADVAPI32: implement ChangeServiceConfigA using ChangeServiceConfigW (take 2)
by Robert Shearman 20 Oct '04

20 Oct '04

Mike McCormack wrote: > > oops. The macro functions for duplicating strings already exist, so > use them instead. > > Mike > > > ChangeLog: > * implement ChangeServiceConfigA using ChangeServiceConfigW > >------------------------------------------------------------------------ > >Index: dlls/advapi32/service.c >=================================================================== >RCS file: /home/wine/wine/dlls/advapi32/service.c,v >retrieving revision 1.60 >diff -u -r1.60 service.c >--- dlls/advapi32/service.c 27 Sep 2004 20:35:27 -0000 1.60 >+++ dlls/advapi32/service.c 20 Oct 2004 07:28:54 -0000 >@@ -810,7 +810,8 @@ > > static inline VOID SERV_free( LPWSTR wstr ) > { >- HeapFree( GetProcessHeap(), 0, wstr ); >+ if (wstr) >+ HeapFree( GetProcessHeap(), 0, wstr ); > } > > There is no need for this check. Freeing NULL pointers is not an error and is handled by the RtlFreeHeap code. Rob

1 0

Re: fix tbn_deletingbutton
by Dmitry Timoshkov 19 Oct '04

19 Oct '04

"Thorsten Kani" <beebix(a)gmx.net> wrote: > I'm a bit unsure about my solution, but actually everything works. > -complaints appreciated- > --- toolbar.c 23 Sep 2004 22:51:14 -0000 1.194 > +++ toolbar.c 10 Oct 2004 17:29:01 -0000 > @@ -3191,12 +3191,20 @@ > TOOLBAR_INFO *infoPtr = TOOLBAR_GetInfoPtr (hwnd); > INT nIndex = (INT)wParam; > NMTOOLBARW nmtb; > + WCHAR Buffer[256]; > > if ((nIndex < 0) || (nIndex >= infoPtr->nNumButtons)) > return FALSE; > > memset(&nmtb, 0, sizeof(nmtb)); > nmtb.iItem = nIndex; > + memcpy(&nmtb.tbButton, &infoPtr->buttons[nIndex], sizeof(nmtb.tbButton) ); > + nmtb.cchText = 256; > + nmtb.pszText = Buffer; > +#if (_WIN32_IE >= 0x500) > + nmtb.rcButton =(RECT)infoPtr->buttons[nIndex].rect; > +#endif > + > TOOLBAR_SendNotify((NMHDR *)&nmtb, infoPtr, TBN_DELETINGBUTTON); 1. do not use _WIN32_IE version checks in Wine code, they have no sense 2. there is no point in setting a pointer to a not initialized buffer 3. there is no need to cast RECT to a RECT -- Dmitry.

3 8

Re: add epoll implementation to libwine_port (take 3)
by Chris Dodd 19 Oct '04

19 Oct '04

Mike McCormack <mike(a)codeweavers.com> wrote in news:4174D681.9050503@codeweavers.com: > A few more changes after consulting with Alexandre. > > ChangeLog: > * add epoll implementation to libwine_port : > + __asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl > %%ebx" + : "=a" (ret) : "0" : A random question here from someone who is not too familiar with wine internals -- why are you using inline asm code instead of syscall(2)? It seems like syscall would be both simpler and more portable. Chris Dodd cdodd(a)acm.org

1 0

Re: add epoll implementation to libwine_port (take 3)
by Boaz Harrosh 19 Oct '04

19 Oct '04

Mike McCormack wrote: > > > ChangeLog: > * add epoll implementation to libwine_port > >.... > > >+ __asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl %%ebx" > > Grate ! [Q] Does that mean that we directly check if it is supported in kernel, bypassing glibc all together? how do we avoid conflicts with glibc?

4 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel