wine-devel April 2023

9 participants
9 discussions

TestBot News - MR false positives analysis
by Francois Gouget 19 Oct '23

19 Oct '23

I have been reviewing the TestBot and GitLab CI test results for the merged MRs. While doing that I updated the TestBot's known failures list (https://testbot.winehq.org/FailuresList.pl) in order to drive down the false positive rate. Incidentally I also collected the list of test units causing false positives, so I'll start with that. Specifically, here are the bugs to fix to help the GitLab CI: * Bug 53433 - mmdevapi:capture - impacted 18 MRs * Bug 54064 - ntdll:threadpool - impacted 15 MRs * Bug 54078 - ntdll:pipe - impacted 11 MRs * Bug 54140 - mmdevapi:render - impacted 5 MRs * Bug 54005 - ole32:clipboard - impacted 5 MRs * Bug 54037 - user32:msg - impacted 5 MRs * Bug 54074 - ws2_32:sock - impacted 5 MRs I classified the TestBot / GitLab CI results as follows: * False positive Cases where the CI system incorrectly claimed the MR introduces new failures. This is typically the case when the failures that are already present in nightly WineTest results. * Bad merge MRs that break a test and got merged anyway. * Collateral Damage from a bad merge The false positives (aka collateral damage) caused by one of the bad merges above. * Outside interference This identifies false positives that are not random and intrinsic to the test but that result from change outside the Wine infrastructure, for instance certificates that expire, or configuration changes to servers that break the tests that depend on it. Of those the only ones that a CI can really avoid are the first type, aka "False positive". So I calculated the corresponding weekly rate: Adjusted False Positive rate Week | TestBot | GitLab CI 2022-11-14 | 21.9% | 8.3% 2022-11-21 | 8.0% | 21.6% 2022-11-28 | 14.7% | 28.4% 2022-12-05 | 8.5% | 24.5% 2022-12-12 | 0.0% | 20.0% Note that the TestBot's 8% rate for the 11-21 week is not representative because Wine was broken that week (collateral damage) which prevented the tests from running in Wine, and thus from contributing real "false positives". Also the 12-12 week is still incomplete obviously. Even so I think his shows the TestBot is improving. Here's a list of the incidents for the weeks above: * 11-14 An external certificate revocation issue caused crypt32:cert to fail systematically. This impacted 14 merge requests and was fixed in MR1360. * 11-17 MR!1399 got merged despite the TestBot detecting that it prevented 32-bit Wine tests from running to completion. This impacted 39 merge requests. I could have reduced that number if I had been faster to reconfigure the TestBot to stop running the full 32-bit Wine test suite. This was fixed in MR!1524. * 11-17 MR!1398 got merged despite the TestBot detecting that it broke ntoskrnl.exe:ntoskrnl on Windows 7. This was fixed in MR!1803. * 11-22 MR!1495 got merged despite the TestBot detecting that it broke vbscript:run on Windows *. I don't have a record of the impacted MRs or of when it was fixed. * 11-23 The b00a831d direct commit broke kernel32:process in Wine. This got fixed since. * 12-07 MR!1732 got merged despite the TestBot detecting that it broke taskschd:scheduler on Windows *. I immediately added a known failure entry and no MR got impacted. This was fixed in MR!1736. If not filtering out the failures caused by these incidents, the false positive rate is: Raw False Positive rate Week | TestBot | GitLab CI 2022-11-14 | 52.1% | 27.1% 2022-11-21 | 50.0% | 29.5% 2022-11-28 | 20.0% | 33.7% 2022-12-05 | 19.1% | 57.4% 2022-12-12 | 0.0% | 20.0% I think that also shows that the TestBot is improving. I have attached the raw data I collected and shell snippets to extract various statistics (failures-mr.txt) as well as a spreadsheet import (failures.xls). -- Francois Gouget <fgouget(a)codeweavers.com>

1 5

Wine staging 8.7 release
by Alistair Leslie-Hughes 30 Apr '23

30 Apr '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.7 (530 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * none Added: * none Updated: * wined3d-WINED3DFMT_B8G8R8X8_UNORM Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Some questions about handling filenames in wineserver
by Richard W.M. Jones 25 Apr '23

25 Apr '23

I'm trying to bring my old AF_UNIX patch up to date: https://www.winehq.org/pipermail/wine-devel/2021-May/187049.html It's not going too well as the code has changed quite a lot. One particular problem I'm having is in wineserver. We need to convert the Windows socket path encoded as a UTF-8 string (eg. Z:\tmp\sock) into a Unix filename. In the old code I used: + num = MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, NULL, 0); + win_path = HeapAlloc(GetProcessHeap(), 0, num * sizeof(WCHAR)); + if (win_path == NULL) + return 0; + MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, win_path, num); + unix_path = wine_get_unix_file_name(win_path); + heap_free(win_path); However none of this seems to work inside wineserver (I guess because it's not part of the "Windows world"). I cannot work out the equivalent of this for wineserver, or if there's something else I should be doing, such as converting the path before it is sent to wineserver. Supplemental question: There appears to be duplicate socket handling code in wineserver server/sock.c and dlls/ntdll/unix/socket.c. In my tests only the wineserver code is called, and never the ntdll/unix code. Why is that? (I'm not very familiar with the architecture of wine, which seems a bit confusing, so I'm just guessing how it all works.) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW

3 4

Wine-Staging 8.6 release
by Zebediah Figura 16 Apr '23

16 Apr '23

The Wine-Staging development release 8.6 is now available. Summary since last release: * Rebased to upstream Wine 8.6. 532 patches are applied to upstream Wine. Patches removed from Wine-Staging since the last release: * win32u-GPU_properties * winex11-wglShareLists. This fixed Wine bug 25495 [1], which is not currently fixed by any other mechanism. However, the relevant patch is a hack, and hence not suitable for Wine-Staging either. Patches added: * None. Patches otherwise updated: * None. Binary packages for various distributions will be available from: https://www.winehq.org/download As always, if you find a bug, please report it via https://bugs.winehq.org ἔρρωσθε, Zeb Figura [1] https://bugs.winehq.org/show_bug.cgi?id=25495

1 1

wine-8.0.1-rc1 Available
by Michael Stefaniuc 05 Apr '23

05 Apr '23

Hello, I have pushed wine-8.0.1-rc1 (f7512a4e1236c36d926ff753decf412eb82a6a35) to https://gitlab.winehq.org/mstefani/wine/-/tree/stable https://people.redhat.com/mstefani/wine/stable/ And created the draft merge request https://gitlab.winehq.org/wine/wine/-/merge_requests/2585 After the 7.0.x Stable releases didn't go so well I'm trying for 8.0.x a time based approach: - Include stuff from 4 devel releases, about 2 months worth. - Last included devel release should be out for 1-2 other devel (2 - 4 weeks). - Merge request in draft state for 1-2 weeks. What's new in this release: - Fixes for macOS Ventura 13.3 on Apple Silicon - Tamil and Turkish translation updates - Various bug fixes ---------------------------------------------------------------- Bugs fixed in 8.0,1 (total 36): - #49615 Device read errors logged in dmesg when running wine commands with empty CD/DVD drive, since 5.5 - #51345 Regression: Visual Studio 2005 "package load failure" - #52506 Setup of game "What's the Secret?" fails to create icon - #52878 Free PC Audit 5.1.211.96 fails to show info in 'Brief' tab (needs GetBinaryValue method of the StdRegProv class) - #53274 adsldp:ldap - test_ParseDisplayName() sometimes fails to connect to the server - #53926 New typelib marshaller depends on IID_IDispatch support from target interface - #53981 Chromium broken sandbox due to GetSecurityInfo giving access denied - #54030 Snagit needs Win32_Volume class ( 'select deviceid from win32_volume where driveletter =C:') - #54215 ListView doesn't refresh when changing between List and Details styles. - #54234 vbscript fails to compile when colon follows Else in If...Else - #54289 RtlCopyContext buffer overflow - #54318 Rich Edit inserts newly composed text at wrong position when system IME composition ends while a selection is active - #54337 AviUtl shows Japanese text as garbage after conversion in ExEdit edit box - #54353 crypt32:cert - testVerifyRevocation() gets unexpected success in Wine on second run - #54357 Spurious fixme message when calling ScrollWindow() - #54364 RtlGenRandom fails on systems with more than 128 cores - #54371 loader won't launch from PATH unless named "wine" - #54376 ws2_32:sock - test_reuseaddr() overflows a sockaddr variable by reading an AF_INET6 peer name into it - #54379 since wine 8.0 print doesn't work any more - #54432 Missing ntdll.RtlAddressInSectionTable() implementation causes all GraalVM Native Image exes to crash on load - #54449 nethack crashes - #54456 vbscript memory leak in For Each with SafeArray as group - #54457 vbscript memory leaks in interp_redim_preserve - #54458 vbscript memory leaks in Global_Split - #54489 VarAbs() does not handle BSTR arguments correctly - #54490 vbscript fails to compile when statement follows ElseIf - #54493 vbscript fails to compile concat when used without space and expression begins with H - #54495 Motorola Ready For Assistant does not start, needs ext-ms-win-networking-wlanapi-l1-1-0.dll - #54563 The gif is displaying wrongly, with weird backgrounds of various colors - #54564 Rich Edit crashes when Ctrl+Right is pressed at past the final paragraph - #54570 Saints Row: The Third heavy rain causes heavy fps reductions - #54581 SpeedCommander 20 installer crashes on unimplemented function SHELL32.dll.Shell_GetCachedImageIndexW - #54617 KakaoTalk IM text edit window leaves artifacts when the text overflows and scroll bar appears - #54663 ldp.exe crashes on unimplemented function wldap32.dll.ldap_set_dbg_flags - #54690 ldp.exe crashes when attempting to connect to an invalid host - #54707 adsldp:ldap - test_DirectorySearch() fails on Windows and Linux ---------------------------------------------------------------- Changes since 8.0: Akihiro Sagawa (2): user32/tests: Add DBCS WM_CHAR tests for edit control. user32/edit: Fix WM_CHAR handler for double-byte characters. Alex Henrie (5): shell32: Add support for Program Manager icons with arguments. wldap32: Add ldap_set_dbg_flags stub. wldap32: Handle null LDAPMessage in ldap_count_entries. wldap32: Handle null LDAPMessage in ldap_parse_result. server: Fix buffer overrun in map_view handler. Alexandre Julliard (2): gitlab: Add workaround for more strict git ownership check. ntdll: Prefer the ntdll path over argv[0] on platforms without reliable exe information. Alistair Leslie-Hughes (1): mountmgr.sys: Don't attempt to read from invalid media. Brendan Shanks (7): loader: In macOS preloader, move the top-down allocations area down. loader: In macOS preloader, stop using mincore() to test if a region is empty. server: On macOS, fake debug registers when running under Rosetta. ntdll: Add a WARN when setting debug registers fails under Rosetta. loader: In macOS preloader, fix an environment variable sometimes being lost. taskmgr: Use exit code 1 when terminating processes. taskkill: Use exit code 1 when terminating processes. Carlos Rodriguez (1): wined3d: Add GPU information for another Intel UHD 630 GPU. Dmitry Timoshkov (3): win32u: Give full access rights to the process window station. win32u: Give full access rights to the thread desktop. rpcrt4: Mark the buffer as invalid in NdrProxyFreeBuffer(). Eric Pouech (3): ntdll: Implement RtlAddressInSectionTable. conhost: Only update font when running with a window. winedbg: Use debuggee's bitness for 'examine /a' command. Florian Will (2): gdiplus/tests: Test for GdipPrivateAddFontFile() sharing violation. gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile(). Gabriel Ivăncescu (1): jscript: Fix jsstr leak after changing variant type to BSTR. Gijs Vermeulen (1): shell32: Add Shell_GetCachedImageIndexA/W exports. Giovanni Mascellani (1): wbemprox: Do not call Release() inside wbemprox_cf_CreateInstance(). Hans Leidekker (8): wbemprox: Implement GetBinaryValue() method. adsldp/tests: Avoid test failures when the server is down. wbemprox: Implement Win32_Volume. advapi32: Bump random buffer size. msi: Install and patch global assemblies in InstallFinalize. msi: Perform late initialization of the assembly caches. adsldp/tests: Skip all remaining tests when the server is down. adsldp/tests: Fix test failures. Hugh McMaster (2): regedit: Allow export_key() to return TRUE. regedit: Append '.reg' file extension if necessary. Illia Polishchuk (2): d3d9/tests: Add test for non-indexed instancing drawing. d3d9: Always draw only a single instance for non-indexed draws. Jacek Caban (2): win32u: Silence spurious FIXME in NtUserScrollWindowEx. oleaut32: Remove overflow check for VT_R4 and VT_R8 in VarAbs. Jason Millard (7): vbscript: Fix compile when colon follows Else on new line. vbscript: Fix memory leak in owned safearray iterator. vbscript: Fix memory leak in Split(). vbscript: Fix memory leak in Split(). oleaut32: Fix VarAbs function for BSTR with positive values. vbscript: Fix compile when statement after ElseIf or after separator. vbscript: Fix compile issue with non hex after concat without space. Jinoh Kang (7): ws2_32/test: Fix sockaddr buffer overflow in test_reuseaddr. riched20: Obtain the composition start index after deleting selection. riched20/tests: Test for word movement across paragraph boundary. riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. riched20/tests: Test for ITextDocument::Freeze and ITextDocument::Unfreeze. riched20: Don't assume that TxDraw preserves the device context's brush selection. riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. K.B.Dharun Krishna (1): po: Update Tamil translation. Michael Stefaniuc (2): tools: Get the ANNOUNCE bug list from the stable-notes git notes. gitlab: Do not run the build script on each commit. Nikolay Sivov (1): apisetschema: Add ext-ms-win-networking-wlanapi-l1-1-0. Paul Gofman (5): ntdll: Factor out context_copy_ranges() function. ntdll: Do not use extended context in RtlCopyContext() if extended state is not copied. cryptnet: Cache revocation status in verify_cert_revocation(). cryptnet: Use cert data hash as cache id instead of serial number. cryptnet: Also hash issuer cert for cache id. Piotr Caban (7): msvcrt: Don't crash on NULL argument in getenv. msvcrt: Don't crash on NULL argument in _wgetenv. msvcrt: Improve error handling in getenv_s. msvcrt: Improve error handling in _wgetenv_s. winspool: Fix FILE: output handling in StartDocDlgW. localspl: Ignore an empty output string. gdiplus: Use transparency instead of background color if transparent color flag is set in GIF GCE. Rémi Bernon (2): dwrite: Statically init the system_fallback locale list. services: Use a separate allocation for NotifyParamsArray[0].params. Serkan Önder (1): po: Update Turkish translation. Tingzhong Luo (1): evr: Fix crash when clearing input type for the mixer. Zebediah Figura (1): oleaut32: Manually construct a stub buffer for dispinterfaces. Zhiyi Zhang (3): comctl32/tests: Add WM_STYLECHANGED tests for changing listview view styles. comctl32/listview: Repaint when changing view styles. user32/tests: Test winstation and desktop access rights. bye michael

1 0

Wine CE 8.5 Released, Cross Architecture Windows Emulator, Support Wow64, Base on wine and qemu
by fanwj＠mail.ustc.edu.cn 03 Apr '23

03 Apr '23

Wine CE is a compatibility layer capable of running Windows applications on Cross-architecture paltform of Linux, It base on wine and qemu, and support aarch64 and riscv64 Linux. It can emulate x86(32bit) x64, aarch64 windows app. Project Address: https://gitlab.com/wine-ce/wine-ce Binary Downnload: https://gitlab.com/wine-ce/wine-ce/-/releases/v8.5 Demo Video: RISCV 64: https://www.bilibili.com/video/BV1gv4y1578t AARCH 64: https://www.bilibili.com/video/BV1yc41157iS

1 0

A novel and accurate method to calculate Julliard Rank
by Alex Henrie 02 Apr '23

02 Apr '23

Dear Wine developers, I am excited to announce that I have discovered a novel and accurate method to calculate a Wine developer's Julliard Rank! As we all know, the Julliard Rank is a measure of how much trust Wine's chief maintainer Alexandre Julliard has in a person, and consequently how easily their patches are accepted.[1] What no one seems to have realized until now is that a person's Julliard Rank has a perfect linear correlation with the number of outstanding bisected regressions caused by that person! Alexandre himself is of course at the top with 21 outstanding regressions, followed of course by Zeb with 15. Henri and Jacek are not far behind with 11 each, Rémi and Zhiyi are somewhat lower with 6 each, and predictably I myself don't even make the cut. That means that 49% of the 142 regressions are held by the top 14% of the 44 people on the list.[2] It is intolerable that so many regressions are concentrated in the hands of so few. There is only one rational course of action: We must rise up and act together to take the regressions that belong to those at the top away from them. When their source of power is gone, the vinous elite will be no different from τῶν πολλῶν. There is unfortunately no alternative but to forcefully abolish the classist system that divides developers into regression-haves and regression-have-nots, but after everyone is made into a regression-have-not, a new era of equality, peace, and alcoholism for all will begin. Sincerely, The Central Committee of the Workers' Wine Party (WWP) [1] https://wiki.winehq.org/Developer_FAQ#I_sent_a_merge_request.2C_but_it_got_… [2] https://source.winehq.org/regressions

3 3

Wine configurations naming
by Eric Pouech 01 Apr '23

01 Apr '23

Hi, it seems we should gain some clarification for the naming of the various ways Wine can be configured. This question arises between "old wow64" and "new wow64" esp. some use wow64 without it being very clear to what it applies (some using wine's old wow64 configuration as it was the only one, others refer to window's wow64 architecture, hence "new wow64" in wine lingo) some have used multi-arch wow(64) or multi arch wine for reference to the new wine wow64... it seems to me we'd better use a common denomination for all of this... - only applying to cross compilation (open point if we still need to refer to ELF/dylib exec:s) - different from images naming (for which the <CPU>-<HOST> applies) So this mail to share the question, and a proposal - *wow64*: the new multi-arch wow64 configuration, which mimics windows wow64 architecture ; dropping the 'new' to match with windows (and also, not sure that in 10years from now it will still be "new") - (wine)*old wow64*: the wine-only old wow64 configuration if needed (at least to remind that they exist) - *pure32*: the 32bit only configuration - *pure64*: the 64bit only configuration Note: the proposal doesn't include whether the configuration can run a module for a given CPU. That's questionable. For comments, rant, other proposals... better ideas TIA

5 6

Wine staging 8.5 release
by Alistair Leslie-Hughes 01 Apr '23

01 Apr '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.5 (537 patches are applied to wine vanilla) The patchinstall.sh script is no longer available and users should use the staging/patchinstall.py instead. Upstreamed (Either directly from staging or fixed with a similar patch). * dinput: Allow mapping of controls based of Genre type. Added: * MR 2449: Allow Diable IV to run without reporting errors. * [53826] Attempting to install / update battle.net fails with Qt error. Updated: * mfplat-streaming-support Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2023