- wine-devel - winehq.org

Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]
by Andreas Mohr 20 Aug '04

20 Aug '04

Hi all, this is a nice little posting from the Con Kolivas Linux interactivity patches list. Note that it is about Cedega, not Wine, but it might easily affect Wine, too. Are we doing some big no-nos in the threading area here? (or maybe it's just done the way it is because we cannot do it a different, better way?) For the whole discussion, please see http://bhhdoa.org.au/pipermail/ck/2004-August/000428.html Andreas Mohr ----- Forwarded message from ck-request(a)vds.kolivas.org ----- Message: 12 Date: Mon, 16 Aug 2004 21:31:59 +1000 From: Con Kolivas <kernel(a)kolivas.org> Subject: Re: [ck] 2.6.8.1-ck1, cedega-cvs, ALSA sound (choppy) To: greblus(a)poczta.onet.pl Cc: ck(a)vds.kolivas.org Message-ID: <41209B2F.4030207(a)kolivas.org> Content-Type: text/plain; charset="us-ascii" Wiktor Grebla wrote: > On Mon, Aug 16, 2004 at 08:16:08PM +1000, Con Kolivas wrote: > > >>It wont be a preempt threshold problem. >>See if it's a priority issue on the part of wine*. Be absolutely certain >>that wineserver, wine and the game are all run the _same_ priority and >>not a better priority than X. Send me the output of 'top -b -n 1' during >>the sound being choppy. Then try running _all_ the wine things at nice >>+19. This is a simple sanity check to see where the problem lies. > > > It's in fact as you say, all parts of wine have different priorities, and > some of them are higher than X: > > greblus@greblus:~$ top -n 1 -b | grep wine > 1630 greblus 23 0 471m 230m 164m R 92.8 45.9 1:54.63 wine > 1666 greblus 20 0 471m 230m 164m S 2.0 45.9 0:01.64 wine > 1629 greblus 20 0 2400 1192 2176 S 0.0 0.2 0:00.00 winex > 1633 greblus 20 0 6864 5056 6756 S 0.0 1.0 0:01.10 wineserver > 1634 greblus 20 0 6864 5056 6756 S 0.0 1.0 0:00.15 wineserver > 1659 greblus 20 0 471m 230m 164m S 0.0 45.9 0:00.00 wine > 1660 greblus 21 0 471m 230m 164m S 0.0 45.9 0:00.00 wine > 1662 greblus 20 0 471m 230m 164m S 0.0 45.9 0:00.06 wine > 1663 greblus 33 0 471m 230m 164m R 0.0 45.9 0:00.41 wine > > greblus@greblus:~$ top -b -n 1 | grep X > 621 root 20 0 88092 18m 75m S 0.0 3.8 1:02.96 X > > After renicing all of them there is no problem with choppy sound in all of time > wasting programs I've on my disk :>, and overall (subjective) performance is > better of course. > > Full output of top -b -n 1 is here: > http://unixforge.org/~greblus/ck/top_-b_-n_1.txt > > Kindest Regards, > W. Thanks for details. You do not have different nice levels; that is PRI that is different, which is the "dynamic" priority that constantly changes by the scheduler. It is as I suspected, though - if you renice everything +19 and the problem goes away it is bad programming on the wine developers' part that use what's called sched_yield instead of proper locking between their threads. Don't concern yourself over the details, but at least you have a simple workaround... sigh Cheers, Con

2 1

Re: Different X Displays and Wine
by Eric Frias 20 Aug '04

20 Aug '04

Alexandre Julliard (julliard_at_winehq.org) wrote:> We don't support having the same user run from different displays at> the same time. I don't think that's a common setup at all. It probably is not a common setup, but Boaz isn't the only person to have been bitten by this. It has happened both to us and to people who use our software. In our development environment, we usually use one or two common user accounts to do all development and testing in. I know this isn't ideal, but I don't have any power to change this. Anyway, with this setup, it is very easy to have two people developing or testing from the same account but displaying on separate machines. Right now we have been doing what was suggested earlier -- we have a script to launch our application and this script creates a .wine-$DISPLAY directory and points WINEPREFIX to that directory. This works well enough for now. It's inconvenient that the config file and registry aren't shared, so doing things like changing printer settings is a bit of a chore, but this hasn't bothered us too much yet. We're also making the assumption that not many users will be running this on multiple displays, so things will just work for most users and the few that do try to run on multiple displays will at least be able to do it. I'm curious how much work would be involved in fixing this correctly. I've never looked at the wineserver code, so I don't know if this would just be a matter of adding another variable to a data structure that gets passed around to all of the windowing code, or if this would require major changes to the way wineserver works. If it's reasonably easy, I might be able to make the fix or lend some assistance; if it is a large amount of work, we'll probably be happy with the workaround we have. Eric

2 2

winetest results refused by server
by Robert Reif 20 Aug '04

20 Aug '04

The winetest server has been refusing to accept test results for a while now. Could someone look into it.

1 0

Re: RE: Adventures in serial port.
by Pouech Eric DMI AEI CAEN 20 Aug '04

20 Aug '04

> I have tried the updates but to no avail. I have a test program that > appears to work well. However when that code is used in my project I still > lose some characters at the end of the message. The main difference is that > my project uses sockets, in another thread, to transfer the read/write data > to/from another application. Could the results from the socket calls be > messing with the ReadFile() results? I will make an example program that > includes sockets to see if I can verify this. does your program (the final one, not the test) use the same buffers and/or the same events in the two threads ? As most of the read/write structures are thread-dependent, I don't really see how two threads could thrash their data, except for some buffer overflow, hence my first question. A+

1 0

make CryptSetProviderEx update the provider Name and TypeName to registry
by James Hawkins 20 Aug '04

20 Aug '04

Changelog * Call provider.dll's DllRegisterServer from CryptSetProviderEx to update the Name and TypeName values in the registry properly when setting the default provider -- James Hawkins

1 0

RE: Adventures in serial port.
by Scott Snell 20 Aug '04

20 Aug '04

Hi Eric, I have tried the updates but to no avail. I have a test program that appears to work well. However when that code is used in my project I still lose some characters at the end of the message. The main difference is that my project uses sockets, in another thread, to transfer the read/write data to/from another application. Could the results from the socket calls be messing with the ReadFile() results? I will make an example program that includes sockets to see if I can verify this. regards, scott. > -----Original Message----- > From: Eric Pouech [SMTP:pouech-eric@wanadoo.fr] > Sent: Thursday, 19 August 2004 3:14 > To: Scott Snell > Subject: Re: Adventures in serial port. > > Scott Snell a écrit : > > Fantastic! Can you let me know when it is committed? > it is

1 0

Re: Let StartServiceCtrlDispatcher handle services started other than with StartService (with patch)
by Alexander Yaworsky 20 Aug '04

20 Aug '04

I think that this is incorrect. If you let StartServiceCtrlDispatcher to continue with no error, you make calling program think that it is running under control of service control manager. When service program handles somehow any kind of its launching, the behaviour may be quite different. Also, under windows StartServiceControlDispatcher always fails if service program is started not with StartService (maybe we should add 15 seconds delay to exactly emulate versions earlier than XP? ;-))). Alexander

1 0

Re: KERNEL: pull WINDIR and WINSYSDIR from config before using hardcoded defaults (possible fix for WWN #234, #235 c:\\windows is not accessible Error)
by Alex Villacís Lasso 20 Aug '04

20 Aug '04

Alex Villacís Lasso wrote: > Alexandre Julliard wrote: > >> Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: >> >> >> >>> Changelog: >>> * if windir or winsysdir environment vars are undefined, pull values >>> from config file before falling to hardcoded values >>> >> >> >> This of course defeats the whole purpose of the use of environment >> variables, which is to get rid of the config file. If the environment >> variables are not set it's because the user's config is wrong, they >> should be set in HKLM\System\CurrentControlSet\Control\SessionManager >> or (preferably) in HKCU\Environment. The code is supposed to migrate >> them automatically, but this may not always work if the registry >> already contains other values, in which case it needs to be fixed by >> hand. Going back to the config file is definitely not the right way. >> >> >> > Thanks for pointing me to misc/registry.c, it helped a LOT. > > Upon examination of the function convert_environment(), I realized the > following: the function > queries HKEY_CURRENT_USER/Environment with a call to NtCreateKey(). If > the call succeeds, > but the result is something other than REG_CREATED_NEW_KEY, the > function terminates in > the assumption that the environment was already migrated in a previous > invocation of Wine. > > The problem is, this assumption is false when the user has a Windows > partition for a Wine drive, > and the user has environment variables of his/her own in the registry. > For example, I am a cygwin user > and I have a Win2k registry with the variables VISUAL, CVS_RSH, and > CVSROOT already defined. > When the function sees that HKEY_CURRENT_USER/Environment already > exists (because it was > taken from the native Windows registry), it (incorrectly) skips the > migration of the config file variables. > > The obvious solution (implemented by this patch) is to remove the > assumption about > HKEY_CURRENT_USER/Environment being newly created, and instead test > for every value before > migrating. > > I hope this is definitely the right way. > > Changelog: > * Do not assume HKEY_CURRENT_USER/Environment exists ==> config file > was migrated. Instead test > for every key to migrate under HKEY_CURRENT_USER/Environment > > Alex Villacis Lasso > UPDATE: %Systemroot% should be migrated too, and this patch combines this and the previous fix. --- wine-20040813/misc/registry.c 2004-07-29 20:35:52.000000000 -0500 +++ wine-20040813-patch/misc/registry.c 2004-08-19 19:47:12.000000000 -0500 @@ -242,7 +242,7 @@ } /******************************************************************/ -/* WINDOWS 31 REGISTRY LOADER, supplied by Tor Sjøwall, tor(a)sn.no */ +/* WINDOWS 31 REGISTRY LOADER, supplied by Tor Sjwall, tor(a)sn.no */ /* reghack - windows 3.11 registry data format demo program. @@ -277,7 +277,7 @@ deduced from the reg.dat file by me. Mistakes may have been made. I claim no rights and give no guarantees for this program. - Tor Sjøwall, tor(a)sn.no + Tor Sjwall, tor(a)sn.no */ /* reg.dat header format */ @@ -1861,6 +1861,7 @@ static const WCHAR windowsW[] = {'w','i','n','d','o','w','s',0}; static const WCHAR systemW[] = {'s','y','s','t','e','m',0}; static const WCHAR windirW[] = {'w','i','n','d','i','r',0}; + static const WCHAR systemrootW[] = {'S','y','s','t','e','m','r','o','o','t',0}; static const WCHAR winsysdirW[] = {'w','i','n','s','y','s','d','i','r',0}; static const WCHAR envW[] = {'E','n','v','i','r','o','n','m','e','n','t',0}; static const WCHAR tempW[] = {'T','E','M','P',0}; @@ -1894,59 +1895,83 @@ NtClose( hkey_old ); return; } - if (disp != REG_CREATED_NEW_KEY) goto done; - /* convert TEMP */ + /* Test for existence of TEMP */ RtlInitUnicodeString( &nameW, tempW ); - if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + if (NtQueryValueKey(hkey_env, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) { - NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); - RtlInitUnicodeString( &nameW, tmpW ); - NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); - MESSAGE( "Converted temp dir to new entry HKCU\\Environment \"TEMP\" = %s\n", - debugstr_w( (WCHAR*)info->Data ) ); + /* convert TEMP */ + RtlInitUnicodeString( &nameW, tempW ); + if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); + RtlInitUnicodeString( &nameW, tmpW ); + NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); + MESSAGE( "Converted temp dir to new entry HKCU\\Environment \"TEMP\" = %s\n", + debugstr_w( (WCHAR*)info->Data ) ); + } } - /* convert PATH */ + /* Test for existence of PATH */ RtlInitUnicodeString( &nameW, pathW ); - if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + if (NtQueryValueKey(hkey_env, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) { - NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); - MESSAGE( "Converted path dir to new entry HKCU\\Environment \"PATH\" = %s\n", - debugstr_w( (WCHAR*)info->Data ) ); + /* convert PATH */ + RtlInitUnicodeString( &nameW, pathW ); + if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); + MESSAGE( "Converted path dir to new entry HKCU\\Environment \"PATH\" = %s\n", + debugstr_w( (WCHAR*)info->Data ) ); + } } - /* convert USERPROFILE */ - RtlInitUnicodeString( &nameW, profileW ); - if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) - { - RtlInitUnicodeString( &nameW, userprofileW ); - NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); - MESSAGE( "Converted profile dir to new entry HKCU\\Environment \"USERPROFILE\" = %s\n", - debugstr_w( (WCHAR*)info->Data ) ); + /* Test for existence of USERPROFILE */ + RtlInitUnicodeString( &nameW, userprofileW ); + if (NtQueryValueKey(hkey_env, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + /* convert USERPROFILE */ + RtlInitUnicodeString( &nameW, profileW ); + if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + RtlInitUnicodeString( &nameW, userprofileW ); + NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); + MESSAGE( "Converted profile dir to new entry HKCU\\Environment \"USERPROFILE\" = %s\n", + debugstr_w( (WCHAR*)info->Data ) ); + } } - /* convert windir */ - RtlInitUnicodeString( &nameW, windowsW ); - if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) - { - RtlInitUnicodeString( &nameW, windirW ); - NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); - MESSAGE( "Converted windows dir to new entry HKCU\\Environment \"windir\" = %s\n", - debugstr_w( (WCHAR*)info->Data ) ); + /* Test for existence of windir */ + RtlInitUnicodeString( &nameW, windirW ); + if (NtQueryValueKey(hkey_env, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + /* convert windir */ + RtlInitUnicodeString( &nameW, windowsW ); + if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + RtlInitUnicodeString( &nameW, windirW ); + NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); + RtlInitUnicodeString( &nameW, systemrootW ); + NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); + MESSAGE( "Converted windows dir to new entry HKCU\\Environment \"windir\" = %s\n", + debugstr_w( (WCHAR*)info->Data ) ); + } } - - /* convert winsysdir */ - RtlInitUnicodeString( &nameW, systemW ); - if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) - { - RtlInitUnicodeString( &nameW, winsysdirW ); - NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); - MESSAGE( "Converted system dir to new entry HKCU\\Environment \"winsysdir\" = %s\n", - debugstr_w( (WCHAR*)info->Data ) ); + + /* Test for existence of winsysdir */ + RtlInitUnicodeString( &nameW, winsysdirW ); + if (NtQueryValueKey(hkey_env, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + /* convert winsysdir */ + RtlInitUnicodeString( &nameW, systemW ); + if (!NtQueryValueKey( hkey_old, &nameW, KeyValuePartialInformation, buffer, sizeof(buffer), &dummy )) + { + RtlInitUnicodeString( &nameW, winsysdirW ); + NtSetValueKey( hkey_env, &nameW, 0, info->Type, info->Data, info->DataLength ); + MESSAGE( "Converted system dir to new entry HKCU\\Environment \"winsysdir\" = %s\n", + debugstr_w( (WCHAR*)info->Data ) ); + } } - -done: NtClose( hkey_old ); NtClose( hkey_env ); }

1 0

poll vs. epoll
by Shachar Shemesh 19 Aug '04

19 Aug '04

Hi all, I have a program (a server) that has a very large number of synchronization constructs. Even when everything is idle there, wineserver is taking 60% of the CPU, raising load average to 2.4. When load is applied, response time occasionally jumps from tenths of a second to two minutes. I noticed that in server/fd.c, the wineserver is using "poll" to select between file descriptors. The application is going through this code over 2000 times a second, with over 380 file descriptors each time. I am wondering whether this can be the cause of the slowdown. One of the possible solutions to this would be to use epoll instead. This, of course, would have to be backed by a configure check, as not all systems for which wine is intended support epoll. Another, arguably better, solution would be to use libevent for this purpose. Libevent has the distinct advantage that it automatically chooses the best tool for the job (epoll, poll, /dev/poll, or if all else fails, select). However, if there is another, independent use of poll, porting the semantics to libevent may prove non-trivial. So what does the forum think? One last question. What are the "users"? What constructs cause a new file descriptor to be allocated in the wineserver? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: KERNEL: pull WINDIR and WINSYSDIR from config before using hardcoded defaults (possible fix for WWN #234, #235 c:\\windows is not accessible Error)
by Michael Stefaniuc 19 Aug '04

19 Aug '04

On Thu, Aug 19, 2004 at 03:54:40PM -0500, Alex Villacís Lasso wrote: > I hope this is definitely the right way. > > Changelog: > * Do not assume HKEY_CURRENT_USER/Environment exists ==> config file was > migrated. Instead test > for every key to migrate under HKEY_CURRENT_USER/Environment > > Alex Villacis Lasso > > --- wine-20040813/misc/registry.c 2004-07-29 20:35:52.000000000 -0500 > +++ wine-20040813-patch/misc/registry.c 2004-08-19 15:35:00.000000000 -0500 > @@ -242,7 +242,7 @@ > } > > /******************************************************************/ > -/* WINDOWS 31 REGISTRY LOADER, supplied by Tor Sj?wall, tor(a)sn.no */ > +/* WINDOWS 31 REGISTRY LOADER, supplied by Tor Sjwall, tor(a)sn.no */ > /* > reghack - windows 3.11 registry data format demo program. > > @@ -277,7 +277,7 @@ > deduced from the reg.dat file by me. Mistakes may > have been made. I claim no rights and give no guarantees for this program. > > - Tor Sj?wall, tor(a)sn.no > + Tor Sjwall, tor(a)sn.no Was this name change planned? bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: FontDlg fix
by Alexandre Julliard 19 Aug '04

19 Aug '04

Jacek Caban<jack(a)itma.pwr.wroc.pl> writes: > + if(chf16->lpTemplateName) > + { > + len1 = strlen(MapSL(chf16->lpTemplateName)); > + chf32w->lpTemplateName = malloc(len1 * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, (LPSTR)MapSL(chf16->lpTemplateName), > + len1, (LPWSTR)chf32w->lpTemplateName, len1); > + } > + if(chf16->lpszStyle) > + { > + len2 = strlen(MapSL(chf16->lpszStyle)); > + chf32w->lpszStyle = malloc(len2 * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, (LPSTR)MapSL(chf16->lpTemplateName), > + len2, chf32w->lpszStyle, len2); > + } These strings never get freed (and please use HeapAlloc instead of malloc). Also the length arguments are wrong, you can't use strlen() to determine the size of the Unicode string. There are similar problems at other places in your patch too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gethostbyname on local host returns 127.0.0.1 for address
by Juan Lang 19 Aug '04

19 Aug '04

Robert wrote: > On windows gethostbyname for the local host returns > the addresses of the available network interfaces. > On wine and unix, it only returns the localhost > 127.0.0.1. > > Any ideas on how to get the windows behavior? I assume you're referring to gethostname (as in your sample code), not gethostbyname (as in your email). Well, I guess you'd have to modify winsock/socket.c's WS_gethostname function, maybe to call GetAdaptersInfo or some such. That'll get you the addresses, anyway. If you want a name other than localhost you may want to call GetNetworkParams too. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - 50x more storage than other providers! http://promotions.yahoo.com/new_mail

2 2

RE: iostream and msvcrt?
by Scott Snell 19 Aug '04

19 Aug '04

Is that simpler than fixing the MSVCRT headers? I have used STLport before so the idea sounds feasable to me. I imagine I have to change the gcc-linux.mak by: replacing the call to gcc with winegcc, removing references to GLIBC, adding a path pointing to /include/wine/MSVCRT. Anything else? regards, Scott. > -----Original Message----- > From: Boaz Harrosh [SMTP:boaz@hishome.net] > Sent: Tuesday, 17 August 2004 18:18 > To: Scott Snell > Cc: Wine-Devel (E-mail) > Subject: Re: iostream and msvcrt? > > Using gcc's c++ libraries will not work with msvcrt. If it will compile > (which it doesn't) it will not load. (Some circular linking) > Your best bet is STLPort. Check it out. What I have done is a special > makefiles set with special config.h that compiles and links STLPort over > msvcrt. I have written to STLPort if they want my changes as support for > another platform but I never got a response from them. Do you need me to > dig out the old HD and pack you an STLPort compiled over msvcrt? > You might need to make some changes because it is from before winegcc > times,. Going strait for gcc. and maybe some wine stuff changed since > than. > > Scott Snell wrote: >

3 2

Wine Status - User Interface
by Tom 19 Aug '04

19 Aug '04

Hello, I have been working on a update for the Status UI page over the last couple day's and i'm attaching a copy of what I have. I've re-named the template to .html so you can view it in your e-mail program or browser of choice. I haven't done the changelog so just view this againt http://www.winehq.org/site/status_ui for changes or diff. commits, suggestions, and flames are welcomed Regards, Tom

2 1

gethostbyname on local host returns 127.0.0.1 for address
by Robert Reif 19 Aug '04

19 Aug '04

On windows gethostbyname for the local host returns the addresses of the available network interfaces. On wine and unix, it only returns the localhost 127.0.0.1. Any ideas on how to get the windows behavior? #include <stdio.h> #ifdef _WIN32 #include <winsock2.h> #include <ws2tcpip.h> #else #include <netdb.h> #endif int main(int argc, char* argv[]) { char host_name[1024]; char ** alias; struct hostent * host; unsigned int i = 0; #ifdef _WIN32 WSADATA wsaData; WORD wVersionRequested = MAKEWORD(2, 2); int error = WSAStartup(wVersionRequested, &wsaData); if (error != 0) { fprintf(stderr, "WSAStartup failed\n"); return 1; } // Confirm that the Windows Sockets DLL supports 2.2. // Note that if the DLL supports versions greater // than 2.2 in addition to 2.2, it will still return // 2.2 in wVersion since that is the version we // requested. if (LOBYTE(wsaData.wVersion) != 2 || HIBYTE(wsaData.wVersion) != 2) { fprintf(stderr, "couldn't find dll\n"); return 1; } #endif if (gethostname(host_name, sizeof(host_name)) != 0) { fprintf(stderr, "gethostname failed\n"); return 1; } printf("host: %s\n", host_name); host = gethostbyname(host_name); if (host == 0) { fprintf(stderr, "gethostbyname failed\n"); return 1; } printf("name of host: %s\n", host->h_name); for (alias = host->h_aliases; *alias != NULL; alias++) printf("alias: %s\n", *alias); printf("length of address: %d\n", host->h_length); while (host->h_addr_list[i] != 0) { struct in_addr n_addr; memcpy(&n_addr, host->h_addr_list[i], sizeof(struct in_addr)); printf("%d: %s\n", i, inet_ntoa(n_addr)); i++; } return 0; }

1 0

Re: Fixed some ref handling
by Alexandre Julliard 18 Aug '04

18 Aug '04

Jacek Caban<jack(a)itma.pwr.wroc.pl> writes: > I attached two test. The first is simple and shows a problem > that the patch fixes but the second one is a more complex test. Could you please merge the test into the existing test framework? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Removed slovenian translation
by Alexandre Julliard 18 Aug '04

18 Aug '04

Jacek Caban<jack(a)itma.pwr.wroc.pl> writes: > Changelog: > Removed slovenian translation If the translation is not complete it should be fixed, or at worse commented out. Removing it doesn't make sense, we'll need to add it back someday anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: KERNEL: pull WINDIR and WINSYSDIR from config before using hardcoded defaults (possible fix for WWN #234, #235 c:\\windows is not accessible Error)
by Alexandre Julliard 18 Aug '04

18 Aug '04

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > Changelog: > * if windir or winsysdir environment vars are undefined, pull values > from config file before falling to hardcoded values This of course defeats the whole purpose of the use of environment variables, which is to get rid of the config file. If the environment variables are not set it's because the user's config is wrong, they should be set in HKLM\System\CurrentControlSet\Control\SessionManager or (preferably) in HKCU\Environment. The code is supposed to migrate them automatically, but this may not always work if the registry already contains other values, in which case it needs to be fixed by hand. Going back to the config file is definitely not the right way. -- Alexandre Julliard julliard(a)winehq.org

1 0

bug
by Ivan Leo Puoti 18 Aug '04

18 Aug '04

Since futimes is used instead of utime the installer of word viewer 97 has had a few installation issues. For a start, when the setup looks for installed components, it goes into a non infinite loop that lasts a few minutes. This only took a few seconds previously. I don't know what is causing this slow performance. The changelog of the patch that caused this regression says "so that it can be done on the client side.", maybe doing the call on client side makes it slow because the call has to go trough wineserver? I don't know. Also the graphics aren't redrawn until the loop ends. A relay log of the loop follows. I'm not very confident that I'll be able to fix this myself, but any help/hints are welcome. Interestingly the loop doesn't occur during a call to kernel.dll.SetFileTime() that's the function modified by the patch. The patch that causes the problem is http://cvs.winehq.org/patch.py?id=11722 Subsequent patches have obviously modified the function, but this hasn't solved the problem. MAybe the subsequent patches avoid an infinite loop (I don't remember the loop finishing with wine from a few months ago). Ivan.

1 0

New Fun Project - Winelib port of Allegiance
by Steven Edwards 18 Aug '04

18 Aug '04

Hi all, Microsoft Research has released a Shared Source version of the game Allegiance. This is a hefty 512 meg download and of course the license that it is under would prevent anyone from sharing the changes but this would really allow us to improve Winelib by porting such a massive game. http://research.microsoft.com/research/allegiance/ Grab your copy quick before they pull it down. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - 50x more storage than other providers! http://promotions.yahoo.com/new_mail

1 0

Re: OLEAUT32: implementation for IPersistPropertyBag_Load for OLEFont
by Robert Shearman 18 Aug '04

18 Aug '04

Alex Villacís Lasso wrote: > This implementation is enough to satisfy VB6 when loading font objects > from property bags in projects. > > Changelog: > * Added implementation for IPersistPropertyBag_Load on OLEFont Looks good, but a few comments below: ... >+ V_VT(&valueAttr) = VT_EMPTY; > > It is probably better practice to use VariantInit here. >+ iRes = IPropertyBag_Read(pPropBag, sAttrName, &valueAttr, pErrorLog); >+ switch (iRes) { > > >+ case S_OK: >+ if (V_VT(&valueAttr) == VT_BSTR) { >+ /* Type is BSTR, use for name directly */ >+ OLEFontImpl_put_Name(this, V_BSTR(&valueAttr)); >+ >+ /* FIXME: Leaking memory here? */ >+ } else { >+ /* Don't know how to handle this type */ >+ FIXME("Name has type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ } > Perhaps use VariantChangeType here? >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } > Catch the errors you need to (why is E_INVALIDARG ok?) and either move these common debug statements to the end of the function (they should also be ERR's, not FIXME's). Also, you other unexpected errors, which is bad. >+ } >+ >+ if (iRes == S_OK) { >+ CY iSize; >+ iSize.s.Hi = 0; >+ iSize.s.Lo = 0; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrSize, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ iSize.s.Lo = V_I2(&valueAttr) * 10000UL; >+ break; >+ case VT_UI2: >+ iSize.s.Lo = V_UI2(&valueAttr) * 10000UL; >+ break; >+ case VT_I4: >+ iSize.s.Lo = V_I4(&valueAttr) * 10000UL; >+ break; >+ case VT_UI4: >+ iSize.s.Lo = V_UI4(&valueAttr) * 10000UL; >+ break; >+ case VT_R4: >+ iSize.s.Lo = (ULONG)(V_R4(&valueAttr) * 10000UL); >+ break; >+ case VT_R8: >+ iSize.s.Lo = (ULONG)(V_R8(&valueAttr) * 10000UL); >+ break; > > Again, perhaps use VariantChangeType here? >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Size type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } >+ if (iRes != E_NOTIMPL) IFont_put_Size(this, iSize); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } > Same comment as before about errors. >+ } >+ if (iRes == S_OK) { >+ signed short iCharset = 0; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrCharset, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ if (V_I2(&valueAttr) < 0) { >+ FIXME("Unexpected value for Font Charset (%hd), using 0\n", V_I2(&valueAttr)); >+ } else { >+ iCharset = V_I2(&valueAttr); >+ } >+ break; >+ case VT_UI2: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Charset (%ld), using 0\n", V_UI4(&valueAttr)); >+ } else { >+ iCharset = V_UI2(&valueAttr); >+ } >+ break; >+ case VT_I4: >+ if (V_I4(&valueAttr) < 0 || V_I4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Charset (%ld), using 0\n", V_I4(&valueAttr)); >+ } else { >+ iCharset = V_I4(&valueAttr); >+ } >+ break; >+ case VT_UI4: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Charset (%ld), using 0\n", V_UI4(&valueAttr)); >+ } else { >+ iCharset = V_UI4(&valueAttr); >+ } >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Charset type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; > > Use VariantChangeType here and you will get all the bounds checking for free. >+ } >+ if (iRes != E_NOTIMPL) IFont_put_Charset(this, iCharset); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ signed short iWeight = FW_NORMAL; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrWeight, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ if (V_I2(&valueAttr) < 0) { >+ FIXME("Unexpected value for Font Weight (%hd), using FW_NORMAL\n", V_I2(&valueAttr)); >+ } else { >+ iWeight = V_I2(&valueAttr); >+ } >+ break; >+ case VT_UI2: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Weight (%ld), using FW_NORMAL\n", V_UI4(&valueAttr)); >+ } else { >+ iWeight = V_UI2(&valueAttr); >+ } >+ break; >+ case VT_I4: >+ if (V_I4(&valueAttr) < 0 || V_I4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Weight (%ld), using FW_NORMAL\n", V_I4(&valueAttr)); >+ } else { >+ iWeight = V_I4(&valueAttr); >+ } >+ break; >+ case VT_UI4: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Weight (%ld), using FW_NORMAL\n", V_UI4(&valueAttr)); >+ } else { >+ iWeight = V_UI4(&valueAttr); >+ } >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Weight type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ } > Again, use VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Weight(this, iWeight); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ BOOL bUnderline = FALSE; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrUnderline, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ bUnderline = V_I2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_I4: >+ bUnderline = V_I4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI2: >+ bUnderline = V_UI2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI4: >+ bUnderline = V_UI4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_BOOL: >+ bUnderline = V_BOOL(&valueAttr); >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Underline type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } > Again, VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Underline(this, bUnderline); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ BOOL bItalic = FALSE; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrItalic, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ bItalic = V_I2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_I4: >+ bItalic = V_I4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI2: >+ bItalic = V_UI2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI4: >+ bItalic = V_UI4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_BOOL: >+ bItalic = V_BOOL(&valueAttr); >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Italic type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } > Again, use VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Italic(this, bItalic); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ BOOL bStrikethrough = FALSE; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrStrikethrough, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ bStrikethrough = V_I2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_I4: >+ bStrikethrough = V_I4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI2: >+ bStrikethrough = V_UI2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI4: >+ bStrikethrough = V_UI4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_BOOL: >+ bStrikethrough = V_BOOL(&valueAttr); >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Strikethrough type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } > > Again, use VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Strikethrough(this, bStrikethrough); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ return iRes; > } > > static HRESULT WINAPI OLEFontImpl_IPersistPropertyBag_Save( > > Thanks, Rob

1 0

Re: Some more hardcoded c:\windows paths
by Juan Lang 18 Aug '04

18 Aug '04

Vincent wrote: > Any idea why CSIDL_PROGRAMS was HKEY_DISALLOWED? That, apparently, was my mistake. I introduced it here: http://www.winehq.org/hypermail/wine-patches/2004/04/0106.html Thanks for fixing it. --Juan __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail

1 0

Re: WineSetupTk...
by Ivan Leo Puoti 18 Aug '04

18 Aug '04

> I doubt there's a one maintainer Nobody maintains it because it's obsolete and isn't used with current versions of wine. Ivan.

1 0

Re: WineSetupTk...
by Mike Hearn 18 Aug '04

18 Aug '04

> I didn't realize that WineSetupTk was depreciated when I wrote. I just want to > play StarCraft and Diablo and was finding the documentation a bit hard to > follow. (I couldn't find my .wine.conf file and got stuck, that's why I > thought I needed WineSetupTk.) I will poke at it a bit myself and if I can > figure out how it works, maybe then I can make a suggestion or two for > clearing up the documentation. (Who maintains the documentation, BTW?) OK, what specifically were you trying to configure. Our aim (obviously) is that StarCraft and such should work out of the box with no configuration needed.

2 1

"winetest" throws an exception after the unsuccessful send operation
by Saulius Krasuckas 18 Aug '04

18 Aug '04

I am getting this after all the tests were performed, network transfer of the report file was over and after the http server has responded (with some error-message) in Wine: err:win:WIN_FindWndPtr window 0x10022 belongs to other process err:win:WIN_FindWndPtr window 0x10022 belongs to other process wine: Unhandled exception (thread 000b), starting debugger... fixme:console:SetConsoleCtrlHandler (0x4067a644,1) - no error checking or testing yet WineDbg starting on pid 0xa Unhandled exception: page fault on read access to 0xffe5024c in 32-bit code (0x40045cf2). In 32 bit mode. 0x40045cf2 pthread_mutex_lock in libpthread.so.0: movl 0xc(%edi),%eax Wine-dbg>bt Backtrace: =>1 0x40045cf2 pthread_mutex_lock+0x12 in libpthread.so.0 (0x40c0fe28) 2 0x42075bea free+0x9a in libc.so.6 (0x40c0fe48) 3 0x4065753a send_file+0x362(name=0x781e4a80) [send.c:217] in winetest (0x40c0fe78) 4 0x40656f2e .L256+0xde in winetest (0x40c0fe9c) 5 0x4065511c __wine_exe_main+0x11c in winetest (0x40c0ff2c) 6 0x403a101a start_process+0xf2(arg=0x0) [process.c:995] in kernel32 (0x40c0fff4) 7 0x4002a8cd wine_switch_to_stack+0x11 in libwine.so.1 (0x00000000) And the error message in the message-box looks like this: Can't submit logfile '/tmp/rescVOMCP'. Server response: <!DOCTYPE HTML PUBLIC"... ... <title>500 Internal Server Error</title> ... <p>The server encountered an internal error or misconfiguration and was unable to complete your request.</p> ... <address>Apache 2.0.40 Server at test.winehq.org Port 80</address> <body><html> Back to the code. Excerpts from the programs/winetest/send.c: > unsigned char *buffer; ... > buffer = xmalloc (BUFLEN + 1); ... > if (ret) { > buffer[total] = 0; > str = strstr (buffer, "\r\n\r\n"); > if (str) buffer = str + 4; > report (R_ERROR, "Can't submit logfile '%s'. " > "Server response: %s", name, buffer); > } > free (buffer); Is it OK to try to free the modified "buffer" ptr? I thought we should preserve its value. We can use the "str" instead of the "buffer". I've tried such mod and it worked fine in my case: --- wine/programs/winetest/send.c 6 Jul 2004 21:03:22 -0000 1.12 +++ wine/programs/winetest/send.c 18 Aug 2004 07:41:24 -0000 @@ -209,9 +209,9 @@ if (ret) { buffer[total] = 0; str = strstr (buffer, "\r\n\r\n"); - if (str) buffer = str + 4; + str = (str)?(str + 4):(buffer); report (R_ERROR, "Can't submit logfile '%s'. " - "Server response: %s", name, buffer); + "Server response: %s", name, str); } free (buffer); return ret; Should I submit it to the wine-patches or I am wrong with it?

2 3

Re: WineSetupTk...
by Ivan Leo Puoti 18 Aug '04

18 Aug '04

>Ivan, do we need to remove links to sourceforge since its no longer >available? Actually iy is, but it isn't listed on the download page. Like all files on sf, you can't remove a release, but you can hide it. >I would guess so.. So do you want to do it or me? I'll send in a patch. Ivan.

1 0

Re: More winecfg todos
by Jacek Caban 18 Aug '04

18 Aug '04

> You probably want to increase the size of the drive mappings list so it > fills the tab, currently there is just a lot of empty space at the top of > the pane now you removed the old stuff. I have almost ready patch. I've attached screenshot. Is it a good idea? Thanks, Jacek

6 15

Interesting bug
by Mike Hearn 18 Aug '04

18 Aug '04

From the appdb: ----------------------------------------------------------------------- * SAVE FOR WEB Solution* : Well, after a fair amount of trail-and-error testing, I have FINALLY found what WILL or WONT allow Save-For-Web to work... It actually is how you execute Photoshop.exe ... if you try to run it with forward slashes in the path, Save for Web will NOT work. If you execute with backslashes, Save for Web WILL work. So... Save for Web works with: wine "c:\program files\adobe\Photoshop 7.0\Photoshop.exe" Save for Web WILL NOT work with: wine "c:/program files/adobe/Photoshop 7.0/Photoshop.exe" Enjoy! Hiji ----------------------------------------------------------------------- I don't have Photoshop here, but perhaps we should ensure that argv[0] and equivalents always use backslashes?

2 1

Re: winealsa dsound capture message patch
by Alexandre Julliard 18 Aug '04

18 Aug '04

Robert Reif <reif(a)earthlink.net> writes: > Adds missing wine specific dsound capture message support. This patch causes the dsound capture test to hang for me. Here's the output I get before killing it: capture.c:230:Testing Primary Sound Capture Driver - winealsa.drv fixme:wave:widDsCreate DirectSoundCapture not implemented The (slower) DirectSound HEL mode will be used instead. capture.c:256: DirectSoundCapture Caps: size=16 flags=0x00000020 formats=fffff channels=2 capture.c:331: Testing the capture buffer at 8000x8x1 PCM capture.c:123: Caps: size = 16 flags=0x00000000 buffer size=8000 capture.c:142: tag=0x0001 8000x8x1 avg.B/s=8000 align=1 capture.c:154: status=0x0000 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Wine Status - User Interface
by James Hawkins 18 Aug '04

18 Aug '04

---------- Forwarded message ---------- From: James Hawkins <truiken(a)gmail.com> Date: Mon, 16 Aug 2004 13:43:21 -0500 Subject: Re: Wine Status - User Interface To: twickline(a)sitestar.net Hey Tom, printdlg AFAIK is very close to being complete. The only things I can think of that would need to be done concerning the print dialog is to verify how windows handles the printer stats (Status, Type, Where, Comment) when no printer is selected/installed. Another thing that could be implemented is the printer help. I will have to test out the print properties dialog when i set up my printer in a week. I dont really know anything about Page Setup or Print Property Sheet, but I will definitely look into it now. On Mon, 16 Aug 2004 09:52:58 -0400, Tom <twickline(a)sitestar.net> wrote: > James Hawkins wrote: > > Hey Tom, > > > > Yea this looks good. Percentages look good too. Keep up the good work! > > > > Hello James, > > Thanks for the speedy reply :) > Would you by chance know what needs to be done, what is missing from > /commdlg/printdlg.c ? > > Do you know anything about Page Setup or Print Property Sheet ? > I looked through our source but i didn't find a relivent source file for > them. > > Regards, > > Tom > > -- James Hawkins -- James Hawkins

2 1

Menu problem: top menu drawn ok, pulldowns miss text
by Tobias Burnus 18 Aug '04

18 Aug '04

Hello, I have a strange problem with the Cambridge Advanced Learner's Dictionary. It, finally¹, starts up but (besides other problems) there is a glitch in the menu. The menu bar looks ok, the dropdown menus work, but the items are empty. The (single?) submenu works again. See http://www.physik.fu-berlin.de/~tburnus/wine/cald2.png Has anyone an ad-hoc idea or knows which are the best debugging flags? Even with the default setting I get hundreds of such lines: fixme:ddraw:Main_DirectDrawClipper_SetClipList (0x40410e80,0x4067ea8c,0),stub! Thus I want to do a wise choise for the menus. (At the startup, it comes up with an open File menu and the menu item "Menu 1" to "Menu 7" which closes after a few seconds by itself: http://www.physik.fu-berlin.de/~tburnus/wine/cald3.png) Regards, Tobias ¹ Great work! A few weeks ago, it didn't come up at all but was stalled with the splash screen. PS: See also http://dictionary.cambridge.org/cald/cdrom/, unfortunally, there is no free demo version :-( PPS: The other problems are mentioned above are: - Somehow no words are shown (makes it unusable). This and the other bugs might relate to the following error: err:module:import_dll No implementation for URLMON.DLL.CoInternetCreateZoneManager imported from L"C:\\windows\\system\\IEBrowser.ilx", setting to 0xdeadbeef err:module:import_dll No implementation for URLMON.DLL.CoInternetCreateSecurityManager imported from L"C:\\windows\\system\\IEBrowser.ilx", setting to 0xdeadbeef - Some exception ("thrown by funReadIniFile" - file not found) dialog covers a lot of the space but seems otherwise not to harm: http://www.physik.fu-berlin.de/~tburnus/wine/cald4.png (The question is only: Why is the file not found.)

2 1

Re: WineSetupTk...
by Ivan Leo Puoti 18 Aug '04

18 Aug '04

> winesetuptk is still maintained? I thought the recent config file changes broke it! I've recently removed it from the sourceforge download page. Ivan.

2 1

Re: Do more tests in non-interactive mode (resubmit)
by Alexandre Julliard 18 Aug '04

18 Aug '04

Francois Gouget <fgouget(a)codeweavers.com> writes: > This way we exercise almost as much of the API as in interactive mode > without disturbing users, and the tests still run fast. The slowest one > is the winmm test which takes 16 seconds on my machine which supports > all the tested sound formats (but has only one sound card). Given that > winetest's timeout is two minutes this gives a wide margin. The capture test takes about 80 seconds here with the ALSA driver, which is a bit long. It also fails with the OSS driver: capture.c:128: Test failed: WaitForSingleObject failed for header capture.c:129: Test failed: WHDR_DONE not set in frag.dwFlags capture.c:130: Test failed: frag.dwBytesRecorded=512, should be 800 capture.c:128: Test failed: WaitForSingleObject failed for header capture.c:129: Test failed: WHDR_DONE not set in frag.dwFlags capture.c:130: Test failed: frag.dwBytesRecorded=512, should be 800 capture.c:128: Test failed: WaitForSingleObject failed for header capture.c:129: Test failed: WHDR_DONE not set in frag.dwFlags capture.c:130: Test failed: frag.dwBytesRecorded=512, should be 800 capture.c:128: Test failed: WaitForSingleObject failed for header capture.c:129: Test failed: WHDR_DONE not set in frag.dwFlags capture.c:130: Test failed: frag.dwBytesRecorded=1024, should be 1600 capture.c:128: Test failed: WaitForSingleObject failed for header capture.c:129: Test failed: WHDR_DONE not set in frag.dwFlags etc. Also the wave test makes a lot of noise here, both with ALSA and OSS drivers. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Removed slovenian translation
by Marcelo Duarte 17 Aug '04

17 Aug '04

Use diff -u Si.rc /dev/null Jacek Caban wrote: > I found that slovenian translation is incomplete and not translated, > so I removed this from winecfg.rc. Si.rc should be remove too, but > I don't know how to do this in patch. > > Changelog: > Removed slovenian translation > > Index: programs/winecfg/winecfg.rc > =================================================================== > RCS file: /home/wine/wine/programs/winecfg/winecfg.rc,v > retrieving revision 1.10 > diff -u -r1.10 winecfg.rc > --- programs/winecfg/winecfg.rc 22 Jul 2004 19:45:00 -0000 1.10 > +++ programs/winecfg/winecfg.rc 16 Aug 2004 19:23:12 -0000 > @@ -32,7 +32,6 @@ > #include "It.rc" > #include "Pt.rc" > #include "Ru.rc" > -#include "Si.rc" > > LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL > > > >

2 1

Re: Added path settings to winecfg
by Marcelo Duarte 17 Aug '04

17 Aug '04

Hi, I think that you do not need to modify the .rc files from languages other than En.rc and your native language. If you do not translate, it will more easy to us to known that it is wrong and needs to be translated. This is my position in relation to Pt.rc. Thank you. Jacek Caban wrote: > Changelog: > Added path settings to winecfg. > >

2 1

RE: iostream and msvcrt?
by Scott Snell 17 Aug '04

17 Aug '04

Hi Mike, Even if I change my command to be: winegcc -c -mno-cygwin -I/usr/local/include/wine/msvcrt -o test.o test.cpp I get the same spread of errors. I am converting an MSVC project that uses both these header files and I'm trying to understand why the MSVCRT header files provided with wine wont work with my project. regards, Scott. > -----Original Message----- > From: Mike Hearn [SMTP:m.hearn@signal.QinetiQ.com] > Sent: Tuesday, 17 August 2004 18:38 > To: Scott Snell > Cc: Wine-Devel (E-mail) > Subject: Re: iostream and msvcrt? > > Why are you trying to use G++ with the MSVCRT (Microsoft Visual C++ > runtime) ? That can surely never work: even if the headers were > compatible, the ABI used is not.

1 0

Re: don't kill the destktop
by Dmitry Timoshkov 17 Aug '04

17 Aug '04

"Ferenc Wagner" <wferi(a)afavant.elte.hu> wrote: > ChangeLog: The desktop process is not automatically > restarted under Win95, so stop killing it. This patch causes test_shell_window tests fail under win2k SP4. Please either fix the failures or revert the patch. -- Dmitry.

2 1

Re: ADVAPI32: implement and test BuiltTrusteeWithName
by Alexandre Julliard 17 Aug '04

17 Aug '04

Mike McCormack <mike(a)codeweavers.com> writes: > + pTrustee->TrusteeForm = NO_MULTIPLE_TRUSTEE; > + pTrustee->TrusteeType = TRUSTEE_IS_NAME; > + ok( trustee.TrusteeForm == TRUSTEE_IS_NAME, "TrusteeForm wrong\n"); > + ok( trustee.TrusteeType == TRUSTEE_IS_UNKNOWN, "TrusteeType wrong\n"); So which one is correct, the code or the test? <g> -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: GetFontLanguageInfo patch.
by Shachar Shemesh 17 Aug '04

17 Aug '04

Leib Moscovitz wrote: > Shachar Shemesh wrote: > >> Leib Moscovitz wrote: >> >>> Dear Shachar, >>> >>> Yes, there is Pmail for Windows (version 4.2 already), and the >>> problem is that it doesn't handle Hebrew RTL correctly - I was >>> wondering whether there's any solution to this that you know of. >>> >>> Thanks, >>> >>> Leib Moscovitz >>> >> Is it only on Wine that it doesn't, or also on Windows? >> >> Please keep posts on list. >> >> Shachar >> > I only know about Windows - I am just an amateur, and as such I don't > even know what Wine is. Wine cannot solve incomplete functionality Windows applications have. It will not help you. Wine is aimed at making Windows applications run on Linux and other Unixes. It has nothing to do with what a given application does or does not know how to do on Windows. More info on http://www.winehq.org. Please CC the list (wine devel) when replying. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

Re: GetFontLanguageInfo patch.
by Shachar Shemesh 17 Aug '04

17 Aug '04

Leib Moscovitz wrote: > Dear Shachar, > > Yes, there is Pmail for Windows (version 4.2 already), and the problem > is that it doesn't handle Hebrew RTL correctly - I was wondering > whether there's any solution to this that you know of. > > Thanks, > > Leib Moscovitz > Is it only on Wine that it doesn't, or also on Windows? Please keep posts on list. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

Re: GetFontLanguageInfo patch.
by Rein Klazes 17 Aug '04

17 Aug '04

On Tue, 17 Aug 2004 18:05:44 +0200, you wrote: > Dear Sir, > > I am searching for a way to make Pegasus Mail for Windows (4.x) display > Hebrew correctly, from right to left, and I came across a post of yours via > Google which seems to deal with this issue. > > Have you developed any solution to this problem, and if so, is it publicly > available? > > Many thanks, > > Leib Moscovitz > Unfortunately the issue that you refer to was fixing some left-to-right problem. I do not know if or how it works for right-to-left writing. I have cc' ed this message to the wine developers list, perhaps the developer that is working on/with this, Shachar Shemesh, can shine a bit of light on the issue. Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 1

WineSetupTk...
by Tashlan 17 Aug '04

17 Aug '04

Dear Oh Glorious Developers, (without which none of this would be possible) I have decided to try Wine for the first time and I'm trying to keep it simple. You have a link for WineSetupTk but I can't seem to find the file anywhere! Not sure where it is, but it sounded really helpful. Link appears on this page with description of WineSetupTk... http://www.winehq.com/site/docs/wine-user/config-helper-programs The Link points here... http://sourceforge.net/project/showfiles.php?group_id=6241 Thanks in advance, Tashlan

2 1

iostream and msvcrt?
by Scott Snell 17 Aug '04

17 Aug '04

Hi All, Thanks to everyone who has helped me with winelib, so far most things are going really well! However here is an issue I cant solve - iostream and msvcrt. Here is an example file: // test.cpp module #include <process.h> #include <iostream> int test() { return 1; } If I compile it using: wineg++ -c -mno-cygwin -I/usr/local/include/wine/msvcrt -o test.o test.cpp or wineg++ -c -I/usr/local/include/wine/msvcrt -o test.o test.cpp I get a multitude of errors such as: In file included from /usr/include/c++/3.3.2/iosfwd:46, from /usr/include/c++/3.3.2/ios:44, from /usr/include/c++/3.3.2/ostream:45, from /usr/include/c++/3.3.2/iostream:45, from test.cpp:2: /usr/include/c++/3.3.2/i386-redhat-linux/bits/c++locale.h:53: error: `uselocale' was not declared in this scope In file included from /usr/include/c++/3.3.2/i386-redhat-linux/bits/c++io.h:35, from /usr/include/c++/3.3.2/bits/fpos.h:44, from /usr/include/c++/3.3.2/iosfwd:49, from /usr/include/c++/3.3.2/ios:44, from /usr/include/c++/3.3.2/ostream:45, from /usr/include/c++/3.3.2/iostream:45, from test.cpp:2: /usr/include/c++/3.3.2/cstdio:167: error: `snprintf' not declared /usr/include/c++/3.3.2/cstdio:168: error: `vfscanf' not declared /usr/include/c++/3.3.2/cstdio:169: error: `vscanf' not declared /usr/include/c++/3.3.2/cstdio:171: error: `vsscanf' not declared So whats my newbie mistake? thanks, Scott.

3 3

Forcing 32 bit mode in configure
by Mike Hearn 17 Aug '04

17 Aug '04

Hi, Does anybody know how to force gcc to compile in 32 bit mode on 64 bit chips, and if so could they please write a patch? I've seen quite a few posts to end user forums lately saying that people were trying to compile Wine on AMD64 (and failing, obviously). thanks -mike

5 4

linking with windows .lib fies?
by Scott Snell 17 Aug '04

17 Aug '04

Hi All, I have a MSVC project I am converting with winebuild. My project links in a windows .lib file that is provided by a third party. Can I link this library file into my winelib project, and if so how? I cant seem to find any recent discussion on this topic so if you could point me to some I would be very grateful. regards, Scott. PS sorry for the repeat - this question was embedded inside an email on a different topic.

3 2

Re: [Wine]First use of 20040813
by Ivan Leo Puoti 16 Aug '04

16 Aug '04

> The game servers I was running was Descent 3. There is a linux client of Descent 3, so the probably is a server for linux. Ivan.

1 0

Re: update the faq take 2 : faq-2.diff
by Ivan Leo Puoti 16 Aug '04

16 Aug '04

> Who feels his patch is correct. Ivan thinks the patch is correct too.

1 0

Re: [Wine]faking network shares
by Ivan Leo Puoti 16 Aug '04

16 Aug '04

> Perhaps someone could add this to The documentation is in the /documentation directory in the source tree. Just make any changes you want, make a patch following the instructions at http://www.winehq.com/site/sending_patches then send the patch to wine-patches(a)winehq.com Ivan.

1 0

Re: wave tests patch
by Francois Gouget 16 Aug '04

16 Aug '04

Robert Reif wrote: > Notify when position format not supported. > Test that position is 0 at start. Good patch. I was worried that tracing all waveGetPosition() failures would clober the output but after that's what one wants when tracing is enabled. Plus it uncovers interesting results: wave.c:584:found 1 WaveOut devices wave.c:472: 0: "SigmaTel Audio" (\\?\pci#ven_8086&dev_24c5&subsys_01641028&rev_01#3&61aaa01&0&fd#{6994ad04-93ef-11d0-a3cc-00a0c9223196}\wave) 5.10 (1:100): channels=65535 formats=bffff support=002c(WAVECAPS_VOLUME WAVECAPS_LRVOLUME WAVECAPS_SAMPLEACCURATE) wave.c:482:Playing a 5 seconds reference tone. wave.c:483:All subsequent tones should be identical to this one. wave.c:484:Listen for stutter, changes in pitch, volume, etc. wave.c:369:Playing 5 second 440Hz tone at 22050x 8x1 wave.c:268:TIME_MS not supported, returned TIME_SAMPLES wave.c:290:TIME_SMPTE not supported, returned TIME_SAMPLES wave.c:268:TIME_MS not supported, returned TIME_SAMPLES wave.c:290:TIME_SMPTE not supported, returned TIME_SAMPLES ... I get the same results on Windows 95, 98 and NT4. How is it that this works on your machine? Anyway, assuming that we need to round up I propose to modify the implementation as in the attached patch. The advantage is that it does not rely on ceil(). In fact it doesn't even use floating point arithmetic so we cannot get any rounding error. If this patch is ok by you, then I can apply it to all the drivers. I also noticed that we have similar code for the input devices. Does this one also round up? Or does it round down? (I could very well see MS make that one round down) -- Francois Gouget fgouget(a)codeweavers.com Index: dlls/winmm/wineoss/audio.c =================================================================== RCS file: /var/cvs/wine/dlls/winmm/wineoss/audio.c,v retrieving revision 1.135 diff -u -r1.135 audio.c --- dlls/winmm/wineoss/audio.c 19 Jul 2004 20:08:06 -0000 1.135 +++ dlls/winmm/wineoss/audio.c 20 Jul 2004 08:58:43 -0000 @@ -2077,7 +2077,6 @@ */ static DWORD wodGetPosition(WORD wDevID, LPMMTIME lpTime, DWORD uSize) { - double time; DWORD val; WINE_WAVEOUT* wwo; @@ -2116,15 +2115,21 @@ TRACE("TIME_SAMPLES=%lu\n", lpTime->u.sample); break; case TIME_SMPTE: - time = (double)val / (double)wwo->format.wf.nAvgBytesPerSec; - lpTime->u.smpte.hour = time / (60 * 60); - time -= lpTime->u.smpte.hour * (60 * 60); - lpTime->u.smpte.min = time / 60; - time -= lpTime->u.smpte.min * 60; - lpTime->u.smpte.sec = time; - time -= lpTime->u.smpte.sec; - lpTime->u.smpte.frame = round(time * 30); - lpTime->u.smpte.fps = 30; + val = val / (wwo->format.wBitsPerSample / 8) / wwo->format.wf.nChannels; + lpTime->u.smpte.sec = val / wwo->format.wf.nSamplesPerSec; + val -= lpTime->u.smpte.sec * wwo->format.wf.nSamplesPerSec; + lpTime->u.smpte.min = lpTime->u.smpte.sec / 60; + lpTime->u.smpte.sec -= 60 * lpTime->u.smpte.min; + lpTime->u.smpte.hour = lpTime->u.smpte.min / 60; + lpTime->u.smpte.min -= 60 * lpTime->u.smpte.hour; + lpTime->u.smpte.fps = 30; + lpTime->u.smpte.frame = val * lpTime->u.smpte.fps / wwo->format.wf.nSamplesPerSec; + val -= lpTime->u.smpte.frame * wwo->format.wf.nSamplesPerSec / lpTime->u.smpte.fps; + if (val != 0) + { + /* Round up */ + lpTime->u.smpte.frame++; + } TRACE("TIME_SMPTE=%02u:%02u:%02u:%02u\n", lpTime->u.smpte.hour, lpTime->u.smpte.min, lpTime->u.smpte.sec, lpTime->u.smpte.frame);

3 4

Adventures in serial port.
by Scott Snell 16 Aug '04

16 Aug '04

Hi All, I have been trying for several weeks to transfer our product to linux using wine. I am so close it hurts! The only issue has been the serial ports. Threads, sockets, and timers appear to be working as advertised (an impressive feat of wine as it is!). However the serial port has failed me. I have used versions 20040716 and 20040505 both as RPM's and source code (with various patches applied to the source). The major issue is reliability. I can successfully get test programs to echo back a character received on the serial port. However when I use the port in anger it often drops bytes. Calls to ReadFile will drop the last byte when the packet size is 30 bytes, and up to the last 5 bytes when the packet size is 200+ bytes. After a while calls to WriteFile will actually stop sending bytes even though it returns successfully. The program has several threads but I have modified it so that the calls to ReadFile/Writfile are in the same thread inside a loop. I set the timeout parameters to return immediately from a ReadFile with any available bytes. If you are interested I can post the shell of my code. Unfortunately the sands of time keep flowing and I am under pressure to find a solution. I have decided to use winelib to build our program that uses the serial port and write native code to read/write to the serial port. The rest of the suite I will continue to use with wine. This has gone well so far and again I am suprised at how smoothly I can do things, this time with winelib/winemaker. However I have struck a problem. My windows program code links in a .lib file that is provided by a third party. Can I link this library file into my winelib project, and if so how? I cant seem to find any recent discussion on this topic so if you could point me to some I would be very grateful. regards, scott.

5 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel