- wine-devel - winehq.org

Multiple .rc files
by Ge van Geldorp 03 Jan '04

03 Jan '04

(for wine-devel readers: this is about the port of Wine DLLs to ReactOS and the problems we're having since a lot of the DLLs have a separate version.rc.) > From: Filip Navara > > Not really. The actual problem is that binutils supports only one > resource file. Previously it linked correctly the version.rc > file, now > it links correctly the shres.rc file and the version.rc is missing. A > workaround would be to create one file (shell32.rc) that > would #include > both "shres.rc" and "version.rc". Any better idea? You're right, but since the wine dlls on your page contained no version resources either I thought I might get away with it :) Maybe we can convince the Wine people to #include "version.rc" from shres.rc? Does anyone have an idea why that's not done already? Gé van Geldorp.

1 0

Debugger Woes
by Robert Shearman 03 Jan '04

03 Jan '04

Hi, After the automatic glibc detection changes the Wine debugger stopped loading symbols correctly, making it harder to debug programs. I only recently noticed this due to lack of disk space and not compiling and installing the whole tree on a cvs update. However, I have now spent some time looking at the problem. By applying the following patch to winedbg, I saw that the address for the ELF debugging section was not being found properly. Index: programs/winedbg/stabs.c =================================================================== RCS file: /home/wine/wine/programs/winedbg/stabs.c,v retrieving revision 1.11 diff -u -r1.11 stabs.c --- programs/winedbg/stabs.c 15 Dec 2003 19:53:08 -0000 1.11 +++ programs/winedbg/stabs.c 1 Jan 2004 17:49:02 -0000 @@ -1625,6 +1625,7 @@ do { if (!DEBUG_READ_MEM_VERBOSE((void*)dyn_addr, &dyn, sizeof(dyn))) goto leave; + WINE_TRACE("dyn.d_tag is %d\n", dyn.d_tag); dyn_addr += sizeof(dyn); } while (dyn.d_tag != DT_DEBUG && dyn.d_tag != DT_NULL); if (dyn.d_tag == DT_NULL) goto leave; An example from loading "winedbg --debugmsg +winedbg notepad": trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 1448084550 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is -997982209 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 1457883477 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 1455977869 ... trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 0 I believe these invalid values are being caused because we are mmap'ing "wine" and reading in the values from the .dynamic section, but the ".dynamic" section hasn't been intialized by the ELF loader. This previously wasn't as issue since "wine" would already have been loaded. However, now "wine" exec's "wine-kthread" or "wine-pthead" as appropriate and then exits and so is no longer in memory. This appears to have been anticipated with the check further up in the stabs.c file that examines the "WINELOADER" environment variable to find the file to mmap. If this is set to "wine-pthread", for example, then the problem goes away. Hence the attached patch. Perhaps the real fix should be made to programs/winedbg/stabs.c. We could either not use the ".dynamic" section somehow or use the dlsym rather than mmap so that we properly initialize the ".dynamic" section. Rob P.S. above trace with patch applied: trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 1 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 1 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 1 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 12 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 13 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 4 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 5 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 6 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 10 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 11 trace:winedbg:DEBUG_ReadExecutableDbgInfo dyn.d_tag is 21

2 1

Re: Printing bugfixes
by Dmitry Timoshkov 03 Jan '04

03 Jan '04

"Mike Hearn" <mike(a)theoretic.com> wrote: > + num = sizeof(PrinterName); > + if (!GetDefaultPrinterW(PrinterName, &num)) > + WCHAR default_name[255]; > + DWORD default_name_size = sizeof(default_name); > + > + if (GetDefaultPrinterW(default_name, &default_name_size) == 0) { You should pass the size of buffer in characters, not in bytes to GetDefaultPrinter. -- Dmitry.

1 0

Re: Endless WM_PAINT loop fix
by Alexandre Julliard 02 Jan '04

02 Jan '04

Rein Klazes <rklazes(a)xs4all.nl> writes: > Changelog: > windows : painting.c > If RedrawWindow is called with the RDW_INVALIDATE flag, if the > UpdateRgn parameter is a NULLREGION and the Window has no update > region yet, ignore the call. This should be integrated with the update region calculations, we shouldn't add such special cases outside of the main code. -- Alexandre Julliard julliard(a)winehq.com

1 0

wine-bugs Mailings Enhancement request
by Uwe Bonnes 02 Jan '04

02 Jan '04

A happy new year to everybody! As a lot of wine-bugs are reworked(mostly thanks to Markus), I get a lot of mails from wine-bugs. However it is hard to follow the threads by only getting information about the last status update. At least the information of the name of the originator of bug should be resent, perhaps even the last two or three status updates. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: PATCH: Fix DLL constructors on OpenBSD
by Alexandre Julliard 02 Jan '04

02 Jan '04

wiml(a)underhill.hhhh.org (Wim Lewis) writes: > Use the GCC attribute((constructor)) syntax for DLL initializer hooks > if possible, instead of the inline-asm syntax. The dll init routine needs to be in the .init section in order to be called first, attribute((constructor)) is not good enough. Why doesn't it work on OpenBSD? Is the section name different? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: [WINEALSA] Fix compilation issue with ALSA 0.5
by Christian Costa 02 Jan '04

02 Jan '04

Christian Costa wrote: > Hi, > > This patch fixes a compilation issue with ALSA 0.5 (reported by Carl > Sopchak) > that appears when adding WaveIn support. > > Bye. > > Changelog : > Fix compilation issue with ALSA 0.5. > > Christian Costa titan.costa(a)wanadoo.fr > > > BTW: Happy new year to all! Bye, Christian

1 0

Re: Printing bugfixes
by Huw D M Davies 02 Jan '04

02 Jan '04

On Thu, Jan 01, 2004 at 08:23:20PM +0000, Mike Hearn wrote: > ChangeLog: > - Write out default printer name in the order used by WinME > - Support PRINTER_ENUM_DEFAULT > - Add FIXME for enumerating print providers > > I'd appreciate somebody with a CUPs and lpr setup ensuring the order > change doesn't cause regressions. It appears correct to me, but as the > code worked before even though it looked like it shouldn't I might be > wrong. Actually I don't see why we need a different name and devname we should just use devname for both entries instead. I think it's a hangover from some old code Your patch however looks wrong, you're adding a default printer with port LPR:LPT1, the spooler will try to print with the command lpr -PLPT1 which won't work. You really want to set the port to LPT1: Huw.

2 2

Re: REBAR: on a RB_SETBANDINFO message only redraw the rebar if something changed
by Dimitrie O. Paun 02 Jan '04

02 Jan '04

On January 2, 2004 10:50 am, Mike McCormack wrote: > This stops IE's toolbar from flickering when moving the mouse over links. Happy, happy, joy, joy... Thanks Mike!!! -- Dimi.

1 0

Re: lParam of WM_CREATE for MDI children
by Steven Edwards 02 Jan '04

02 Jan '04

Hello Dmitry, --- Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > applications use something like the following code in order to pass > a custom parameter to a newly created MDI child: <snip> > Any ideas how to proceed without breaking too much assumptions in > the current code? You may want to take a look at the ReactOS implementation of MDI as we have done quite a bit of work on this and shell32 of late to get the ReactOS Explorer working. I dont know if Filip or Martin has already fixed the MDI bugs but if so we should have something to merge when Alexandre gets back. Thanks Steven __________________________________ Do you Yahoo!? New Yahoo! Photos - easier uploading and sharing. http://photos.yahoo.com/

2 2

unknwn.h: unknwn.idl
by Boaz Harrosh 02 Jan '04

02 Jan '04

2 Questions 1) if I do "make depend" than edit unknwn.idl (or any other idl) than do "make" should a new unknwn.h be compiled? Well it does not. If I "cd include" and "make" than nothing is done either. only if I do "make unknwn.h" it will compile. 2) In order for ATL to compile I need below code in my unknwn.h file. I could not fined a way to do it with WIDL. I have looked in Microsoft (vc6) header/idl and it looks they had the same problem. And below code was added by hand. Now if the answer to Q1 is "No not done automatically" than I guess I can submit a patch for unknwn.h only. could I also submit a patch to include/Makefile.in to remove unknwn.idl from the list of idl files so it will not accidentally over-write unknwn.h? <unknwn.h snippet> ... DEFINE_GUID(IID_IUnknown, 0x00000000, 0x0000, 0x0000, 0xc0,0x00, 0x00,0x00,0x00,0x00,0x00,0x46); #if defined(__cplusplus) && !defined(CINTERFACE) #if !defined(WINE_NO_UUIDOF) #include <wine/uuidof.h> extern "C++" { #endif #ifdef ICOM_USE_COM_INTERFACE_ATTRIBUTE struct __attribute__((com_interface)) IUnknown #else struct IUnknown #endif { virtual HRESULT STDMETHODCALLTYPE QueryInterface( REFIID riid, void** ppvObject) = 0; virtual ULONG STDMETHODCALLTYPE AddRef( ) = 0; virtual ULONG STDMETHODCALLTYPE Release( ) = 0; #if !defined(WINE_NO_UUIDOF) template <class Q> HRESULT STDMETHODCALLTYPE QueryInterface(Q** pp) { return QueryInterface(__uuidof(Q), (void**)pp); } #endif }; #if !defined(WINE_NO_UUIDOF) } // extern "C++" #endif #else ... </unknwn.h snippet> I have tried below simple idl code but it will go to all the wrong places <bad unknwn.idl code> ... interface IUnknown { typedef [unique] IUnknown *LPUNKNOWN; HRESULT QueryInterface( [in] REFIID riid, [out, iid_is(riid)] void **ppvObject); ULONG AddRef(); ULONG Release(); cpp_quote("#if !defined(WINE_NO_UUIDOF)") cpp_quote("template <class Q>") cpp_quote("HRESULT STDMETHODCALLTYPE QueryInterface(Q** pp)") cpp_quote("{") cpp_quote(" return QueryInterface(__uuidof(Q), (void**)pp);") cpp_quote("}") cpp_quote("#endif") } cpp_quote("#if !defined(WINE_NO_UUIDOF)") cpp_quote("} /*extern C++*/") cpp_quote("#endif") ... </bad unknwn.idl code>

4 8

Missing exports?
by Joshua Walker 01 Jan '04

01 Jan '04

So I'm still stumbling through advapi32 and there seems to be some functions that were not exported. ANy reason why? For example, AccessCheckByType was but AccessCheckByTypeAndAuditAlarm, AccessCheckByTypeResultList, AccessCheckByTypeResultListAndAuditAlarm, and AccessCheckByTypeResultListAndAuditAlarmByHandle were not mentioned in the .spec file. Are these missed exports? Do they need to be at least stubbed? I know this all may seem bit anal, what with about a few thousand spec'ed APIs that need to be documented and all. I would just like to fill in the blankes as much as possable the first time through. I've already had to backtrack three times to add intresting comments I found important.(Function XYZ is only avilible on WinNT 3.1 or higher) It would be nice to at least have a fully spec'ed out DLL. -Joshua

6 6

Re: DMUSIC: my latest work
by Dimitrie O. Paun 01 Jan '04

01 Jan '04

On January 1, 2004 04:25 am, Rok Mandeljc wrote: > Hey everyone, > > I finally found some time to organise my dmusic work of last two months > in useful patch. Dmusic is now DX9 compatible, we have almost fully > implemented (but not working :( ) > IDirectMusicCollection/IDirectMusicInstrument, fully implemented > IDirectMusicContainer and almost completely (but fully working I believe > IDirectMusicLoader)... Nice! What would you say is the status of DMusic (70-80-90% complete?) > => oh and if somebody is interested in test programs I wrote & used and > some docs on dark sides of dmusic (written by myself ;)), mail me and > you'll get them in 24 hours ;) Shouldn't we get this into the tree somewhere? (either as comments in the code, or as documentation in the Devel Guide). Ditto for test program (not sure where it should go though...) > => and happy New Year everyone! Happy New Year to you too! -- Dimi.

1 0

New registry key adding patch
by Zimler Attila 01 Jan '04

01 Jan '04

Hi, I made the regedit program able to add new registry key (however, the key does not appear until next run of regedit in the browser tree - as I consulted it with Dimitrie, it will be handled later). The diff is made against todays cvs tree (as 2003 december 31). Attila PS: Dimitrie: what is the next step to do? diff -r -d -c -N wine/programs/regedit/edit.c wine.new_regkey/programs/regedit/edit.c *** wine/programs/regedit/edit.c 2003-12-12 04:08:59.000000000 +0000 --- wine.new_regkey/programs/regedit/edit.c 2003-12-31 14:36:44.000000000 +0000 *************** *** 17,22 **** --- 17,25 ---- * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ + /* Modified by Attila ZIMLER <hijaszu(a)hlfslinux.hu> on 28th of dec 2003. + - New key adding is now supported. + */ #define WIN32_LEAN_AND_MEAN /* Exclude rarely-used stuff from Windows headers */ *************** *** 91,96 **** --- 94,129 ---- return FALSE; } + BOOL CreateKey(HKEY hKey) + { + LONG lRet; + HKEY retKey; + char* keyName = 0; + unsigned int keyNum = 1; + + /* If we have illegal parameter return with operation failure */ + if (!hKey) return FALSE; + + /* try to find out a name for the newly create key */ + /* TODO: warning is issued because asprintf's implicit declaration, + I tried to declare it as + extern "C" ssize_t asprintf(char**, const char**, ...) + which is the format of this function, but it seems not helping. + Don't know why :( + */ + asprintf(&keyName, "new key"); + lRet = RegOpenKey(hKey, keyName, &retKey); + while (lRet == ERROR_SUCCESS) { + asprintf(&keyName, "new key %u", ++keyNum); + lRet = RegOpenKey(hKey, keyName, &retKey); + } + + lRet = RegCreateKey(hKey, keyName, &retKey); + + free(keyName); + return lRet == ERROR_SUCCESS; + } + BOOL ModifyValue(HWND hwnd, HKEY hKey, LPCTSTR valueName) { DWORD valueDataLen; diff -r -d -c -N wine/programs/regedit/framewnd.c wine.new_regkey/programs/regedit/framewnd.c *** wine/programs/regedit/framewnd.c 2003-12-12 04:08:59.000000000 +0000 --- wine.new_regkey/programs/regedit/framewnd.c 2003-12-31 14:38:34.000000000 +0000 *************** *** 469,474 **** --- 469,478 ---- case ID_EDIT_COPYKEYNAME: CopyKeyName(hWnd, _T("")); break; + case ID_EDIT_NEW_KEY: + if (CreateKey(hKey)) + RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath); + break; case ID_REGISTRY_PRINTERSETUP: /*PRINTDLG pd;*/ /*PrintDlg(&pd);*/ diff -r -d -c -N wine/programs/regedit/main.h wine.new_regkey/programs/regedit/main.h *** wine/programs/regedit/main.h 2003-12-12 04:08:59.000000000 +0000 --- wine.new_regkey/programs/regedit/main.h 2003-12-31 14:39:57.000000000 +0000 *************** *** 93,98 **** --- 93,99 ---- extern LPCTSTR GetItemPath(HWND hwndTV, HTREEITEM hItem, HKEY* phRootKey); /* edit.c */ + BOOL CreateKey(HKEY hKey); BOOL ModifyValue(HWND hwnd, HKEY hKey, LPCTSTR valueName); #endif /* __MAIN_H__ */

2 8

Renaming registry keys...
by Robert van Herk 01 Jan '04

01 Jan '04

Hi! Does anybody have a C algorithm to rename a registry section using the Win32 API? I need such a thing for winecfg, but Win32 doesn't seem to have a RegKeyRename api-call... Grtz, Robert

3 5

Just adding an entry in the.spec file makes somethin build?
by Joshua Walker 01 Jan '04

01 Jan '04

Are .spec files automahicly built? Adding an entry to the .spec file does what exactly? From my standpoint all it does is add an entry to the documentation thats generated by c2man.pl, but it's undocumentabale, not linked to anything, and just sits there. I'm assuming you *MUST* have a function, or a declration, or something the jive with the .spec file? On second thought, this is more of a functionallity question. Here's more on documentation... I wanted to say this after I finished documenting the API of a DLL, but it's more releivent here. Many people program open source for many reasons. I simply want to learn the Win32 API. I have no idea why, I guess I'm just cerious about how it works. As I am sitting here placing comments into code I am reminded of a short story in "The Hitchhiker's Guide to the Galaxy" In the story there was an alien who had immortility accidently placed upon him by way of a particle accelorator, a rubber band, and I think some tea... But I'm not too sure about that bit. Anyway he had a grand old time simply outliving the hell out of everyone. After a while he became biter an jaded, he needed something to do to bide his time and so he decided to insult the universe. The worst bit, and the part that he fought so hard to maintain, is that he decided to do it *Alphabectally* I feel much like this guy, I'm starting in advapi32.dll and methotcally working my way through it. At first I wanted to do an end-to-end API documentaion, but I'm hampered by things that arn't implmented yet. That's fine, I'll just do an end-to-end Wine API documentation instead. I do not have the skills to fill in code myself. I don't even have a test suite (Read:windows computer) to check myself against anyway. I have found that when I document the APIs, that the subs tend to stand out between the hyperlinks. It almost feels like they are saying "Look at me! Not only do I not fuction, but I can't get a lousy hyperlink either!" And so I think I have found another motivtion to do Open Source programming. Guilt. Yes, I am now panning to guilt people into impmentation. All those entries look soooo pretty it it wasn't for those ugly, black stubs in there. I would like to have the entire API in there, stubbed out, to simply enhance the guilt. But I shall just "do what's there" I just dispuse going through what I've written when I have an eppifiny of some sort. I have to do it again anyway as I need to link up some advapi32 calls to some ntdll calls. I just learnd that one was a front end to another... Anyway, I guess this is a rounds about way of saying this, but I'll just do what's there, and hopefully guilt others into implemtation ^_^ -Joshua P.S. If I find someone who has implemented something after I've gon through the DLL, only to find they didn't bother to make a simple documentation header for it.... Well, then I'd just be really sore....

2 1

Docs
by Ivan Leo Murray-Smith 01 Jan '04

01 Jan '04

Hi list, I've noticed this  in getting.sgml, I've recently changed a few things in it, but there isn't a cvs.sgml file, should this warning go? Ivan.

2 1

GetModuleFileName mysteries
by Ralf Juengling 01 Jan '04

01 Jan '04

I have some Windows code that uses GetModuleFileName in order to read some additional files at runtime that are expected at certain place relative to the executable. In Wine, GetModuleFileName doesn't work as intended, and I have trouble to track down the problem. I had to use winemaker's "wrap" option in order to work around initialization problems (C++ code). So the application, "memview.exe.so" is just a small wrapper which loads "memview.dll.so" via "LoadLibrary" and calls the dll's "WinMain". The startup script (a copy of wineapploader named "memview") determines the application's name to be "memview.exe" and thus executes "wine memview.exe". Under these circumstances, GetModulFileName yields "C:\WINDOWS\SYSTEM\memview.exe", which is not correct. If I alter the winapploader script so that wine gets called with "memview.exe.so" instead, GetModuleFileName yields "Z:\local\builts\phaeaco-20031216\src\memview\memview.exe", which is the correct path (but "memview.exe" doesn't exist). There is a second application which I built the very same way (i.e. using a small wrapper "phaeaco.exe.so" which loads the actual code contained in the DLL "phaeaco.dll.so"). This application also uses GetModuleFileName; here it always yields "C:\WINDOWS\SYSTEM\phaeaco.dll", no matter whether the application name given to wine by the wineapploader script is "phaeaco.exe" or "phaeaco.exe.so". This is a confusing picture. Could somebody point out what the expected result of GetModuleFileName is for this scenario (the full path to the dll, I guess) and how it comes about that it yields a path "C:\WINDOWS\SYSTEM\..."? I observed this with Wine-20031118, haven't tested more recent versions. Ralf -- Ralf Juengling <juenglin(a)cse.ogi.edu>

5 8

Happy 2004
by Ivan Leo Murray-Smith 31 Dec '03

31 Dec '03

Happy New Year from the Central European Time Zone! Ivan.

1 0

Re: Simple arguments check
by Alexandre Julliard 31 Dec '03

31 Dec '03

Mike Hearn <mike(a)theoretic.com> writes: > Index: dlls/shell32/pidl.c > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/pidl.c,v > retrieving revision 1.94 > diff -u -r1.94 pidl.c > --- dlls/shell32/pidl.c 4 Nov 2003 04:21:01 -0000 1.94 > +++ dlls/shell32/pidl.c 25 Dec 2003 19:32:48 -0000 > @@ -1234,10 +1234,19 @@ > LPSHELLFOLDER shellfolder; > > TRACE_(shell)("(pidl=%p,%p)\n",pidl,pszPath); > - pdump(pidl); > > - if (!pidl) return FALSE; > + if (!pidl) { > + ERR_(shell)("argument check failed: pidl == null\n"); > + return FALSE; > + } > + > + if (!pszPath) { > + ERR_(shell)("argument check failed: pszPath == null\n"); > + return FALSE; > + } The ERRs are useless. If Windows does a NULL check, then we should do one too, without any error message; if Windows doesn't, then we shouldn't check at all. -- Alexandre Julliard julliard(a)winehq.com

3 4

Re: MCI #4: Add support for many MCIWNDM_ messages and some MCI_ commands
by Dimitrie O. Paun 31 Dec '03

31 Dec '03

On December 30, 2003 11:48 am, Dmitry Timoshkov wrote: > + * Add support for all remaining MCI_ commands and MCIWNDM_ messages. > + * Add support for all MCIWNDF_ flags. An explicit list of MCI_ commands/MCIWNDM_ messages/MCIWNDF_ flags would be much appreciated (if it's under 30ish items). This would give a much better indication of the amount of work left to do. -- Dimi.

3 4

Re: PATCH: dlls/winmm/wineoss/audio.c
by Alexandre Julliard 31 Dec '03

31 Dec '03

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Tests by a FreeBSD user and discussions with one of the FreeBSD sound > maintainers confirmed that this is the right fix for that platform. > > I'm not sure whether you want to make this change in general, for all > platforms, so for now I have embedded it in an #if(n)def. I think we should do that on all platforms, yes. And you probably want to fix OSS_WaveInInit too. -- Alexandre Julliard julliard(a)winehq.com

2 1

Silly question, sloghtly off topic
by Joshua Walker 31 Dec '03

31 Dec '03

If you replace a win9x advapi32.dll with a winNT advapi32.dll, do you gain the extra security features? I'm guessing no... -Joshua

2 1

PATCH - winebrowser
by Chris Morgan 30 Dec '03

30 Dec '03

Has Rein's fix for mozilla and Ivan's additional browsers. Tried to clean the script up a little bit, could probably still use some work but I'm no script guru. Chris * tools/winebrowser, tools/wineinstall, tools/Makefile.in, winedefault.reg Chris Morgan <cmorgan(a)alum.wpi.edu> Add HKEY_LOCAL_MACHINE\software\classes\http\shell\open\command key and value. Winebrowser script. Makefile changes to install/remove script. Wineinstall should create a simlink from windows/winebrowser.exe to the location of winebrowser on the machine.

1 0

Re: Add support for some other MCI_ commands and implement mciSendCommandW
by Alexandre Julliard 30 Dec '03

30 Dec '03

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -84,7 +84,16 @@ BOOL VFWAPIV MCIWndRegisterClass(HINSTAN > { > WNDCLASSW wc; > > - wc.style = CS_VREDRAW | CS_HREDRAW | CS_DBLCLKS | CS_OWNDC; > + /* Since we are going to register a class belonging to MSVFW32 > + * and later we will create windows with a different hInstance > + * CS_GLOBALCLASS is needed. And because the second attempt > + * to register a global class will fail we need to test whether > + * the class was already registered. > + */ > + if (GetClassInfoW(MSVFW32_hModule, mciWndClassW, &wc)) > + return TRUE; > + This is not thread-safe; if you need to know why the class creation failed you should check the last error returned from RegisterClassW. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Allow regsvr32 to register multiple DLLs at once
by Alexandre Julliard 30 Dec '03

30 Dec '03

Mike Hearn <mike(a)theoretic.com> writes: > When you just get the urge to reregister your entire windows/system > directory... > > Mike Hearn <mike(a)theoretic.com> > Allow regsvr32 to register multiple DLLs even if some fail regsvr32 is a standard Windows program, we shouldn't invent new options that don't exist on Windows. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Re: Key exist query in registry
by Dimitrie O. Paun 30 Dec '03

30 Dec '03

> I call RefreshListView() but the key doesn't appear in > the list. Should we do some insert to the listview? Or > this could be a bug? Hold on, are you inserting a key or a value? Values appear in the listview, keys in the treeview. But I don't think there is a treeview refresh just yet, so it's a bit trickier. Maybe we should first handle values, it's easier, we can worry about keys after that... -- Dimi.

2 1

Re: option to ignore primary selection
by Mike Hearn 30 Dec '03

30 Dec '03

On Thu, 2003-12-18 at 05:00, Ulrich Czekalla wrote: > This patch adds an option (turned off by default) to restrict Wine to only > use the clipboard selection since it will never implement proper behaviour > for the primary selection (You'll never be able to select text with the > mouse). The kind of people who get confused by this will probably not alter the defaults in this way, or even understand what the option does. Perhaps it should be on by default, with power users who are willing to accept its half completeness willing to switch on support for PRIMARY themselves? thanks -mike

3 2

Re: Better fix for the GetTempFileName problem
by Alexandre Julliard 30 Dec '03

30 Dec '03

Mike Hearn <mike(a)theoretic.com> writes: > Index: files/file.c > =================================================================== > RCS file: /home/wine/wine/files/file.c,v > retrieving revision 1.197 > diff -u -r1.197 file.c > --- files/file.c 15 Dec 2003 20:15:20 -0000 1.197 > +++ files/file.c 25 Dec 2003 19:10:35 -0000 > @@ -922,7 +922,7 @@ > p = buffer + strlenW(buffer); > > /* add a \, if there isn't one and path is more than just the drive letter ... */ > - if ( !((strlenW(buffer) == 2) && (buffer[1] == ':')) > + if ( ((strlenW(buffer) == 2) && (buffer[1] == ':')) > && ((p == buffer) || (p[-1] != '\\'))) *p++ = '\\'; This is clearly not what was intended here, you'll need to investigate this some more (and write a test case). -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: shell32
by Alexandre Julliard 30 Dec '03

30 Dec '03

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > Changelog: > separated out 16 bit functions from control.c into control16.c Actually these are not 16 bit functions, they are exported from shell32. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Key exist query in registry
by Zimler Attila 30 Dec '03

30 Dec '03

Dimitrie O. Paun wrote: >>From: Zimler Attila <hijaszu(a)hlfslinux.hu> >> >> > > > >>How can I insert the newly created hKey to the keytree? >>(Because without this the newly created key only appears >>after restarting regedit:) >> >> > >In programs/regedit/framewnd.c, in function _CmdWndProc(), >just call RefreshListView() as it's done for > case ID_EDIT_MODIFY: >Not the most elegant, but good enough for now. > > > I see I onyl posted to you again :) I try to post it on the list but hitting reply doesn't do it automatically :). I call RefreshListView() but the key doesn't appear in the list. Should we do some insert to the listview? Or this could be a bug? Attila

1 0

Re: Re: Key exist query in registry
by Dimitrie O. Paun 30 Dec '03

30 Dec '03

> Should I then post my patch on how to insert a new key? > And later we do the treeview refresh? Yes, please do so. -- Dimi.

1 0

Re: Re: winemine2 winelib example
by Dimitrie O. Paun 30 Dec '03

30 Dec '03

> This was the first time that I learned about the > existence and purpose of winegcc. I couldn't find any > information in the Winelib user's guide > nor is there a man page. Is winegcc quite new? Is more > information available somewhere? Mea culpa. winegcc is relatively new, but this is no excuse for the lack of documentation. I should have fixed that some time ago, but Real Life (TM) cought up with me lately. However, the situation is not so bad. The vision behind winegcc is simple: if you can build your project with MinGW, simply change the defintion of the Makefile variables CC/CXX/CPP/WRC from gcc/g++/cpp/windres to winegcc/wineg++/winecpp/wrc and you should be all set. (I thrown winecpp in there for completeness, but very few projects will need to worry about it). Of course, things are not 100% perfect, but they are OK, and in theory there shoudn't be a need for a lot more documentation than what I have in this email :))) Let me know if you need a hand. -- Dimi.

1 0

Re: winemine2 winelib example
by Ralf Juengling 30 Dec '03

30 Dec '03

On Tue, December 23 2003 08:51 am, Dimitrie O. Paun wrote: > On December 23, 2003 09:03 am, Vincent Béron wrote: > > Not really. The problem in that case is that winemaker thinks every > > resource file needs to be compiled independantly, when there's really > > only one to compile in that case (as it includes the other ones). > > Fundamental problem is that winemaker just can't be so smart to > guess a perfect Makefile. I suggest you just write one manually, > and use winegcc to build, this way your Makefile is portable > between Wine and MinGW. This was the first time that I learned about the existence and purpose of winegcc. I couldn't find any information in the Winelib user's guide nor is there a man page. Is winegcc quite new? Is more information available somewhere? Thanks, Ralf

1 0

default wine browser
by Chris Morgan 30 Dec '03

30 Dec '03

In trying to install the United Devices application the installer prompts me to go to a website to get the msi installer. Wine doesn't have a HKEY_LOCAL_MACHINE\software\classes\http\shell\open\command key in the registery. I was thinking about making a shell script something along the lines of: if browserX exists browserX $1 else if browserY exists browserY $1 ... I would imagine most people have mozilla installed on their machines and we can check for konqueror, opera and other browsers. I've created a simple 'winebrowser' script, placed it in /usr/local/bin manually thus far, set the value for the above key to 'winebrowser %1' and symlinked /wine/system/ winebrowser.exe to /usr/local/bin/winebrowser. Sound reasonable? Comments? ;-) Chris

4 11

IE installer has moved
by Mike Hearn 30 Dec '03

30 Dec '03

This is the new location: http://bylands.dur.ac.uk/~mh/wine-ie/ Happy drinking....

1 0

winecfg
by Robert van Herk 30 Dec '03

30 Dec '03

Hi, Just to let you know: I started on the winecfg thingy officially now :-). This is the first time I encounter C Win32 code, and I'm loving it already :-S. Now I know why Windows is so unstable ;-). Grtz, Robert

2 1

Re: Re[2]: Yeah - our RichEDit needs some work
by Dimitrie O. Paun 29 Dec '03

29 Dec '03

> I have to note that richedit should also implement Text > Object Model, that is, ITextDocument, ITextServices etc. > (and to be really compatible with M$ one, it should be > based on them). Indeed. Now, if you are familiar with the richedit problem, can you come up with a list of tasks that will eventually lead to a full blown richedit control? It is a big task, if we break it into smaller, self contained ones (like the ones you mentioned) maybe someone will start working on it. -- Dimi.

2 1

Installing from an .inf file? (fwd)
by Kevin Atkinson 29 Dec '03

29 Dec '03

I was redirected to wine-devel. Attached is the .inf file if it would help. -- http://kevin.atkinson.dhs.org ---------- Forwarded message ---------- Date: Sat, 27 Dec 2003 14:50:48 -0500 (EST) From: Kevin Atkinson <kevina(a)gnu.org> To: wine-users(a)winehq.com Subject: Installing from an .inf file? Is there a way to install from a .inf file in wine. In particular I am trying to install the huffyuv codec. I tried this: wine rundll setupapi.dll,InstallHinfSection DefaultInstall 132 huffyuv.inf (After copying rundll into the fake windows directory) but it didn't seam to do anything. I got the command line from the install association a .inf file had in Win98SE. Is there a way to do this? You can get huffyuv from http://www.divx-digest.com/software/huffyuv.html -- http://kevin.atkinson.dhs.org _______________________________________________ wine-users mailing list wine-users(a)winehq.com http://www.winehq.com/mailman/listinfo/wine-users

2 1

Re[3]: Yeah - our RichEDit needs some work
by Saulius Krasuckas 29 Dec '03

29 Dec '03

On Mon, 29 Dec 2003, Phil Krylov wrote: > JW> http://www.nllgg.nl/Ted/ > > JW> I would toss it in myself, but I suck a coding. I > JW> wouldn't even know where to begin. > > I have to note that richedit should also implement Text Object Model, > that is, ITextDocument, ITextServices etc. (and to be really > compatible with M$ one, it should be based on them). one year ago i decided i would contribute in RTF/RichEd are to Wine. now after taking a look at this page http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… and after i scrolled down over it i think i wouldn't do that -- that's about a 3/4 of winword to implement! whoohoo 8-D

1 1

Re: Implement RegFlushKey
by Shachar Shemesh 29 Dec '03

29 Dec '03

Mike Hearn wrote: >This implementation is a little inefficient but without using a random >access binary db as Windows does (which I am not going to advocate) it's >the best we can do. > > > Ok, I'm going to be flamed for this, but I'm going to go ahead and ask. This is a request to understand, not a suggestion (yet?). Why not use a general purpose DB system? (postgresql, mysql, whatever) After all, the registry is just a tree shaped database. We can do that using standard SQL, and fall back to our current method if a proper DB is not found. Shachar -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/

8 10

Yeah - our RichEDit needs some work
by Subhobroto Sinha 29 Dec '03

29 Dec '03

;) Actually, I noticed this many times before(text not displaying at all in a RichEdit control..) I am one of those (un)fortunate enough to not have a real Windows, and often download Win32 freeware to see how WINE's doing from time to time... IMHO, one of the best tests are Steve Gibson's (www.grc.com) freeware tools - this guy writes in pure ASM. and thus we can be sure that his code will be the least messy (lesser MS stuff..) However, if you try his 'Wizmo' or 'DCOMObulator', you will see that the RichEdit textareas as blank ! Unfortunately, the guy does not release his source (though I have reason to believe he would to anyone asking for it..) You may try them out in WINE guys, they are REALLY small (small code - that's a rarity on Windows nowdays.. people nowdays do not even use Win32 SDK,leave alone ASM) Guess we really need some work at RichEdits... I posted this mainly because it seems Zimler Attila wants to help - so there you are (^-^) BTW: CodeWeavers have good support for RichEdit controls, but why does not WINE ? Regards Subhobroto Sinha

5 4

Re: default config file creation
by Ivan Leo Murray-Smith 29 Dec '03

29 Dec '03

> Should we be performing the config file check inside wine at startup? Already wine is a wrapper that starts wine-pthread or wine-kthread, and don't forget about performance. >For this config check should we do something like: >if no config -> copy over default config > >if windows drive doesn't exist -> create fake windows drive and setup dll/ >application symlinks? Exactly, can you think of anything more usable? Ivan.

1 0

Re: cabinet.Extract
by Gregory M. Turner 29 Dec '03

29 Dec '03

On Sunday 28 December 2003 02:53 pm, Stefan Leichter wrote: > Hello, > > during playing with ie5.5 installer i noticed that the installing of some > cab files failed directly after the extract call. Doing exactly the same > extract call with the same cabinet file and the same content of the first > parameter i got a crash with native cabinet dll. The debugger shows at the > end of the function a "ret 8" assembler comand. > This means to remove 8 words (not bytes) from the stack because the segment > attribute is set to 32 bit (the pop command right before the ret is done > for a 32 bit register and does not have the opcode 0x66 in front to change > the register length). > Therefore the function extract must have 4 parameters instead of two. > > The bad thing is that the installer throws an exception instead of > aborting. > > ChangeLog > -------------- > the function ectract has four parameters not two Hmm, sounds like you are more of a natural at deducing this stuff than I, so I am happy to defer to your judgement... but I am slightly surprised, as I vaguely recall convincing myself that I had verified that it was right. Since ie5setup was probably my test app, maybe I added arguments until I stopped seeing winedbg, and declared it to be a success :P ... or did someone else do this part? Can't remember. No objection -- if its an improvement in ie5setup, it's surely right. Just thinking "aloud". Thanks for debugging this. Out of curiosity, was it w98 or NT you were (not) emulating? -- gmt "It is to be the assent and ratification of the several States, derived from the supreme authority in each State, the authority of the people themselves. The act, therefore, establishing the Constitution, will not be a NATIONAL, but a FEDERAL act." --James Madison, Federalist No. 39

2 1

Re: cabinet.Extract
by Stefan Leichter 29 Dec '03

29 Dec '03

Hello Alexandre, please ignore the patch it is wrong. Looks like i have to learn more assembler. Bye Stefan ---------- Weitergeleitete Nachricht ---------- Subject: cabinet.Extract Date: Sonntag, 28. Dezember 2003 21:53 From: Stefan Leichter <Stefan.Leichter(a)camLine.com> To: Wine Patches <wine-patches(a)winehq.org> Hello, during playing with ie5.5 installer i noticed that the installing of some cab files failed directly after the extract call. Doing exactly the same extract call with the same cabinet file and the same content of the first parameter i got a crash with native cabinet dll. The debugger shows at the end of the function a "ret 8" assembler comand. This means to remove 8 words (not bytes) from the stack because the segment attribute is set to 32 bit (the pop command right before the ret is done for a 32 bit register and does not have the opcode 0x66 in front to change the register length). Therefore the function extract must have 4 parameters instead of two. The bad thing is that the installer throws an exception instead of aborting. ChangeLog -------------- the function ectract has four parameters not two -------------------------------------------------------

1 0

Question about replacing a stub...
by Joshua Walker 29 Dec '03

29 Dec '03

Hi all. On my ever winding quest to fill in the win32 API documentation, I have found, I think, an intresting issue. When the documentation is generated with c2man.pl, it checks the .spec file to see if the function is a stub or not. The problem is that if it is a stub, no documentation will be generated for that API. I've decieded to take it upon myself to "fill in the blankes" as it were, but I need to know if I'm doing this correctly. For my example I'm going to use the stubbed function "AdjustTokenGroups" that is found in avdapi32.dll. The fist thing I did was update the .spec file so c2man.pl will parse the function correctly. I changed @ stub AdjustTokenGroups to: @ stdcall AdjustTokenGroups (long long ptr long ptr ptr) That allows c2man to parse the function. So now all I need to do is add that function to security.c. I added the following. --------------------- /****************************************************** * AdjustTokenGroups [ADVAPI32.@] * * Adjust the group privileges of an open token handle. * */ BOOL WINAPI AdjustTokenGroups( HANDLE TokenHandle, BOOL ResetToDefault, PTOKEN_GROUPS NewState, DWORD BufferLength, PTOKEN_GROUPS PreviousState, PDWORD ReturnLength ) { } ------------------------- And whamo-blamo, the documentation is generated... Now, I'm not too hot on coding, did I just break something to get my API to document? Should I be adding a fixme? Should I be returning something even though it's an empty function? I didn't compile it to see if it worked.The AdjustTokenGroups.html file that was generated says "Not defined in a Wine header. The function is either undocumented, or missing from Wine." Is it ok to leave that right now? Should I me putting something in a header file somewhere? Just wondering. -Joshua

2 2

Re: Re: wchar_t on GNU and Win32 - two worlds apart !
by Subhobroto Sinha 29 Dec '03

29 Dec '03

The program runs on Windows just fine because Windows Unicode function expects wchar_t to be 2 bytes (unlike GNU's) which is what it gets.. So the program runs on wine correctly too... But I want the app to be a native ELF using GLibc's own Internal functions... I have assumed that the user may not have WINE Regards On Sun, 28 Dec 2003 Dan Kegel wrote : >Dan Kegel wrote: >>I'm way out of touch with Wine these days, but here's > >[ meant to say "my two bits"... obviously my mind is wandering... ] > >>1. If you want to get something useful done, switch to C. Mixing >>g++ and Winelib seems to be a bit tricky, and you might end up >>spending all your time on that instead of solving the problem you >>originally wanted to solve. >> >>2. If you insist on using C++: >>if the problem resists analysis, perhaps you could use Valgrind >>to help track down the problem. > >3. Compile with MS Visual C++. I run MSVC++ 4.0 on Wine just fine, >and I bet even newer versions will run the commandline versions >of the compilers ok on wine. > >#3 really is the best option, since then your app will >run fine both on Windows and on Wine... > >- Dan > >

3 2

(no subject)
by Kevin Atkinson 29 Dec '03

29 Dec '03

I am having a problem compiling a simple winelib program which relies on a dll which uses the stdcall calling convention. I used pexports on the dll avisynth_c.dll to created the spec and then edited the file to removed the leading underscore in the names (without that it would not link). That file is attached. Than with only "avisynth_c.h", "avs2yuv.cpp" and "libavisynth_c.def" in the current directory. I ran winemaker --console -iavisynth_c --single-target avs2yuv.exe . ./configure --with-wine=/opt/wine/ make then I copy the required DLL in the current directory and attempt to run it. But I get: ./avs2yuv err:module:import_dll No implementation for avisynth_c.dll.avs_create_script_environment imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_get_frame imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_get_video_info imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_invoke imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_release_value imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_release_video_frame imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_take_clip imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef Usage avs2yuv4mpeg <avsfile> <outfile> Does anyone know what is going on. Here is the output of make if it will help: sed -e 's,@bindir\@,/usr/local/bin,g' -e 's,@winelibdir\@,.,g' ./wineapploader.in >wineapploader || rm -f wineapploader LD_LIBRARY_PATH="/opt/wine//lib:$LD_LIBRARY_PATH" /opt/wine//bin/winebuild -o avs2yuv.exe.dbg.c --debug -C. avs2yuv.cpp gcc -c -I. -I/opt/wine//include/wine/windows -g -O2 -fPIC -D_REENTRANT -o avs2yuv.exe.dbg.o avs2yuv.exe.dbg.c g++ -c -I. -I/opt/wine//include/wine/windows -g -O2 -fpermissive -fno-for-scope -D_REENTRANT -o avs2yuv.o avs2yuv.cpp LD_LIBRARY_PATH="/opt/wine//lib:$LD_LIBRARY_PATH" /opt/wine//bin/winebuild -fPIC -o avs2yuv.exe.spec.c --exe avs2yuv.exe -mcui avs2yuv.o -L/opt/wine//lib/wine -lavisynth_c gcc -c -I. -I/opt/wine//include/wine/windows -g -O2 -fPIC -D_REENTRANT -o avs2yuv.exe.spec.o avs2yuv.exe.spec.c g++ -shared -Wl,-Bsymbolic -o avs2yuv.exe.so avs2yuv.o avs2yuv.exe.dbg.o avs2yuv.exe.spec.o -L/opt/wine//lib -lwine -lwine_unicode -lwine_uuid -lm test -f avs2yuv || install ./wineapploader avs2yuv I attached the zip file with the source and any files I thought were relevant. If required I can send additional files dll's in a private email (such as the required dll's). Wine version 20031212 built from source on a RedHat System. I had the exact same problem when I used the debs from unstable (also version 20031212) on a libranet system. Is this a bug, or am I doing something wrong? When I used a a version of avisynth_c.dll which used cdecl on all API functions -- without changing the .def or header files -- instead of stdlib I do not have this problem. Naturally I do not expect it to run since I didn't recompile my code with the proper header files. I discovered this by accident because the previous version used cdecl and I had some old dll laying around in a place wine was able to find. Can anyone help me get this working? Am I doing something wrong or is this a bug in wine? Thanks in advance. --- http://kevin.atkinson.dhs.org

4 26

Re: default config file creation
by Ivan Leo Murray-Smith 29 Dec '03

29 Dec '03

>I was wondering if it would make more sense during the compile process to take >the default configuration files, config, system.reg, user.reg and userdef.reg >and convert these to binary form and compile them into the wine binary >itself. We could detect the lack of these files at startup and install them >for the user. Very cool idea, it would increase usability a lot. You don't really need to compile the files, you can just install them in /usr/share/doc/wine-yyyymmdd/samples or something like that and copy them to $HOME/.wine if needed. )There wouldn't be any performance loss as these files are read at startup anyway.Wine could also create a fake c drive in the users home and create a link to it it needed. Ivan.

3 2

Re: wchar_t on GNU and Win32 - two worlds apart !
by Dan Kegel 29 Dec '03

29 Dec '03

Subhobroto Sinha wrote: > The program runs on Windows just find because Windows Unicode function expects wchar_t to be 2 bytes (ulike GNU's) > > So the program runs on wine correctly too... > > But I want the app to be a native ELF using GLibc's own Internal functions... > > I have assumed that the user may not have WINE What good is a start menu that reads windows .lnk files if the user doesn't have wine? - Dan

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel