- wine-devel - winehq.org

Re: Implement a typelib loader cache
by Alexandre Julliard 12 Aug '03

12 Aug '03

Mike Hearn <mike(a)theoretic.com> writes: > ChangeLog: > Implement a typelib loader cache You'll need to protect the list with a critical section. Also it's probably better to store the list directly in the typelib structure instead of allocating a separate object. -- Alexandre Julliard julliard(a)winehq.com

1 0

DRIVE_GetUnixCwd and drives other than the current one
by Troy Rollo 12 Aug '03

12 Aug '03

It appears that Wine is storing and using a "current directory" for each DOS drive. According to some testing we have just done on Windows 2000 and Windows 98, Windows only stores a current directory for the current drive. "But CMD.EXE seems to remember drives, and their children too", comes the reply. Well, sort of. The documentation for CreateProcess talks about environment variables used to hold the current directory for each drive, with an environment variable with a name of the form "=C:" having the value, say "C:\WINDOWS". That documentation suggests you must make sure all these environment variables are set if you construct a new environment block, and that you need to get the values of them using "GetFullPathName". Shock, horror, the Windows documentation is wrong. What actually happens is that CMD.EXE and COMMAND.COM independently set those environment variables when you change directories in those shells. SetCurrentDirectory has no effect on those environment variables - either in the current process or in child processes. It is the responsibility of the application to set them if it wants the children to have access to its current directory on drives other than its current drive. However, SetCurrentDirectory("D:") (assuming a starting point of drive "C") will read those environment variables to determine which directory of drive "D" to go to. You can even 'SetEnvironmentVariable("=D:", "\\foo")' to make the next 'SetCurrentDirectory("D:")' end up in "D:\foo". GetFullPathName also picks up the environment variable if the path requested is not on the current drive (although it also checks that the path is valid, so 'GetFullPathName("A:\\", ...)' will rattle drive A if drive A is empty). If there's no environment variable, both GetFullPathName and SetCurrentDirectory assume "x:\". If the drive in question is the current drive, SetCurrentDirectory and GetFullPathName both ignore the environment variables and use the value from GetCurrentDirectory. So, for example: // Start with no "=D:" variable in environment SetCurrentDirectory("d:\\bar"); SetCurrentDirectory("c:"); SetCurrentDirectory("d:"); // Current directory now d:\ SetCurrentDirectory("d:\\bar"); SetCurrentDirectory("c:"); SetEnvironmentVariable("=D:", "\\foo"); SetCurrentDirectory("d:"); // Current directory now "d:\\foo"; SetEnvironmentVariable("=D:", "\\bar"); SetCurrentDirectory("d:"); // Current directory still d:\\foo The Borland C++ run-time libraries have code in their chdir functions that sets these variables, but it's inside a "#if 0" section, presumably reflecting an attempt to be compatible with MSC. I'm not aware of anything that relies on this perverse behaviour, so whether Wine needs to be adjusted to mimic it may be an open question. It is probably of more interest to people who want to pass an environment block to CreateProcess. If you're doing that, ignore what the documentation says about including "=C:" & etc environment variables in the environment block - simply start with the environment block returned by GetEnvironmentBlock and make the desired changes, ensuring the block is sorted according to instructions I gave previously on one of the Cygwin mailing lists.

2 1

can't redirect stdout?!
by Dan Kegel 12 Aug '03

12 Aug '03

OK, so with the normal X11 driver, you can no longer redirect stdout from commandline apps under Wine; the output just vanishes if you try to send it to a file. That's rather unacceptable dain bramage, if you ask me. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

4 5

Re: dlopen libncurses.so in wineconsole
by Eric Pouech 12 Aug '03

12 Aug '03

Mike McCormack wrote: > > This patch doesn't include changes to configure. Run autoconf to > regenerate it... several comments to this needed patch: 1/ in configure.ac why not checking also for curses if ncurses isn't present ? BTW, you can also remove the ncurses library lookup in configure.ac, we no longer need it. 2/ in curses.c some of the functions we use in curses.c can in fact be macros in some curses' implementations. According to my doc, this includes initscr, intrflush, nodelay, noecho. So, you could pass LOAD_FUNCPTR a boolean not to fail if the symbol is not found (for those functions), and not #define initscr to p_initscr if initscr is already #define:d > + if( !WCCURSES_bind_libcurses() ) > + return FALSE; you'd better return init_failed from the enum instead of a boolean here A+ -- Eric Pouech

1 0

Is wine a debugger?
by Dan Timis 12 Aug '03

12 Aug '03

I am trying to load a security Windows dll that does not run under a debugger. When I load the dll I get a SIGTRAP, and then wine breaks in its debugger. My understanding is that if I run wine as opposed to winedbg I am not running under a debugger. But, if there is a crash or some other exception wine will start a debugger. I sent some memory dumps to the developer of the security dll, and he said that it behaves like it was running under a debugger. He's question was something like does wine have an always "on" debugger? I would appreciate any help. Thanks, Dan Timis Muse Research, Inc.

3 2

Re: Some advapi32 stubs
by Stefan Leichter 12 Aug '03

12 Aug '03

On Tuesday 12 August 2003 07:06, Mike McCormack wrote: > ChangeLog: > * stubs for advapi32 functions InitiateSystemShutdownEx, SetEntriesInAcl > and SetNamedSecurityInfo +@ stdcall InitiateSystemShutdownExA(wstr wstr long long long long) This looks wrong to me (wstr as parameter of A function) Bye Stefan

1 0

bidi support test program
by Shachar Shemesh 12 Aug '03

12 Aug '03

Hi all, Attached is a simple program to test whether the Win32 API supports BiDi reordering. Some packagers asked me for such a utility in the past, so they can make sure that their inclusion of ICU worked, and without forcing them to actually understand languages that are all Hebrew to them. I'm not sure whether it would be necessary to include this utility inside the Wine soure, or how to do so. This is not exactly a test, as a failure is totally justified under some circumstances. Shachar -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

1 0

Threading experts?
by Jason Edmeades 11 Aug '03

11 Aug '03

Hi, I seem to have found a recreatable threading problem and I am not convinced it it wines fault either. Are there any experts here who want to offer any advice on where to go to persue this please? Problem: 'wine appname' hangs when it creates one of its threads. The hang is inside pthread_create and control is never returned to the caller Environment uname -a returns kernel 2.4.21-0.13mdk, and its basically Mandrake Linux 9.1 with no updates. Wine is cvs as of today, configured with --with-nptl More info: Looking through an strace, I can see a difference between a working and failing case, and it would appear there is a timing issue inside the pthread routines. However, I would normally expect it far more likely that it is a wine bug than a kernel / threading bug, so I dont really know how to proceed. I can recreate this about 95% of the time with one app and one app only, so I really suspect it to be a wine problem, but I just cant see why. Here's a working case =============== (Note SY3 and SY4 are fixmes I added each side of the pthread_create) 394 issues a create thread. [pid 394] write(2, "fixme:thread:SYSDEPS_SpawnThread"..., 38fixme:thread:SYSDEPS_SpawnThread SY 3) = 38 [pid 394] rt_sigprocmask(SIG_SETMASK, NULL, [RTMIN], 8) = 0 [pid 394] write(12, "\240@4@\0\0\0\0\230,s@\240\177\v@\0000\20J\0\0\0\200\0"..., 148 <unfinished ...> : 398 is the pthread thread manager thread [pid 398] getppid() = 394 [pid 398] read(10, "\240@4@\0\0\0\0\230,s@\240\177\v@\0000\20J\0\0\0\200\0"..., 148) = 148 [pid 398] clone(child_stack=0x4a102bd0, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|0x21) = 400 : It wakes up 394 to indicate it can continue [pid 398] kill(394, SIGRTMIN) = 0 : [pid 394] <... write resumed> ) = 148 [pid 394] rt_sigprocmask(SIG_SETMASK, NULL, [RTMIN], 8) = 0 [pid 394] rt_sigsuspend([] <unfinished ...> *** sigsuspend gets back a SIGRTMIN to wake it up. [pid 394] --- SIGRTMIN (Unknown signal 32) @ 0 (0) --- [pid 394] <... rt_sigsuspend resumed> ) = -1 EINTR (Interrupted system call) [pid 394] sigreturn() = ? (mask now [RTMIN]) [pid 394] write(2, "fixme:thread:SYSDEPS_SpawnThread"..., 38fixme:thread:SYSDEPS_SpawnThread SY 4 Failing case ======== 394 issues a create thread. [pid 394] write(2, "fixme:thread:SYSDEPS_SpawnThread"..., 38fixme:thread:SYSDEPS_SpawnThread SY 3) = 38 [pid 394] rt_sigprocmask(SIG_SETMASK, NULL, [], 8) = 0 [pid 394] write(12, "\240@4@\0\0\0\0$&s@\240\177\v@\0000xJ\0\0\0\0\0\0\0\0`"..., 148 <unfinished ...> : 398 is the pthread thread manager thread [pid 398] <... poll resumed> [{fd=10, events=POLLIN, revents=POLLIN}], 1, 2000) = 1 [pid 398] getppid() = 394 [pid 398] read(10, "\240@4@\0\0\0\0$&s@\240\177\v@\0000xJ\0\0\0\0\0\0\0\0`"..., 148) = 148 [pid 398] clone(child_stack=0x4a782bd0, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|0x21) = 401 : It wakes up 394 to indicate it can continue [pid 398] kill(394, SIGRTMIN) = 0 : (Now for the difference...) [pid 394] <... write resumed> ) = 148 : vvv What is this, and why is it getting the signal [pid 394] --- SIGRTMIN (Unknown signal 32) @ 0 (0) --- [pid 394] sigreturn() = ? (mask now []) : vvv Since the signal is absorbed already, suspend just hangs forever. [pid 394] rt_sigprocmask(SIG_SETMASK, NULL, [], 8) = 0 [pid 394] rt_sigsuspend([] <unfinished ...> Any help? Its really annoying Jason

5 5

question about mouse_event
by dd jj 11 Aug '03

11 Aug '03

Hello, I have ported a windows code to linux using winemaker: it works fine on windows, but doesn't work on linux, Could anyone give some comments on this problem? THanks. Here's the code. #include <windows.h> int APIENTRY WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { // TODO: Place code here. mouse_event(MOUSEEVENTF_LEFTDOWN,0,0,0,0); mouse_event(MOUSEEVENTF_LEFTUP,0,0,0,0); return 0; } --------------------------------- Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software

3 3

Does anyone have prototypes for the following user32.dll functions?
by Jonathan Wilson 11 Aug '03

11 Aug '03

ok, here are the ones I still need: TranslateMessageEx UnlockWindowStation UpdatePerUserSystemParameters UserRegisterWowHandlers WCSToMBEx TileChildWindows ShowStartGlass SetConsoleReserveKeys SetCursorContents PrivateKDBreakPoint QuerySendMessage MBToWCSEx MB_GetString LockWindowStation LoadKeyboardLayoutEx GetInputDesktop GetAccCursorInfo FullScreenControl DrawFrame DdeGetQualityOfService ClientThreadSetup CascadeChildWindows

2 1

Re: Threading experts?
by puoti＠inwind.it 11 Aug '03

11 Aug '03

I had to use with-nptl to build winex pn Mandrake 9.1, the binarys did't work without that option. This wasn't necessarry on wine, but winex won't run without it. Dmitry wrote: I may be wrong, but according to the information posted to one of our support forums, support for NPTL was backported from 2.5 kernels by RedHat, and nobody else has support for NPTL in 2.4 kernel series. So, you shouldn't compile --with-nptl on Mandrake. -- Dmitry.

3 2

wrong keyboard layout
by Raul 11 Aug '03

11 Aug '03

couple years ago, when i sent the estonian layout patch, worked fine put now im using redhat 9 and detects wrong layout (Latin American keyboard layout) is there some changes that breaks the layout or im making something wrong? Raul

3 7

Does anyone have prototypes for the following user32.dll functions?
by Jonathan Wilson 11 Aug '03

11 Aug '03

All of them are exported by user32.dll from NT4SP6a CascadeChildWindows ClientThreadSetup DdeGetQualityOfService DrawCaptionTempA DrawCaptionTempW DrawFrame DrawMenuBarTemp EditWndProc FullScreenControl GetAccCursorInfo GetAppCompatFlags GetInputDesktop GetInternalWindowPos GetProgmanWindow GetTaskmanWindow KillSystemTimer LoadKeyboardLayoutEx LoadLocalFonts LoadRemoteFonts LockWindowStation MBToWCSEx MB_GetString MenuWindowProcA MenuWindowProcW PrivateExtractIconExA PrivateExtractIconExW PrivateKDBreakPoint QuerySendMessage RegisterLogonProcess RegisterSystemThread RegisterTasklist ScrollChildren SetConsoleReserveKeys SetCursorContents SetDeskWallpaper SetInternalWindowPos SetLogonNotifyWindow SetProgmanWindow SetSysColorsTemp SetSystemMenu SetSystemTimer SetTaskmanWindow SetWindowStationUser ShowStartGlass TileChildWindows TranslateAccelerator TranslateMessageEx UnlockWindowStation UpdatePerUserSystemParameters UserClientDllInitialize UserRealizePalette UserRegisterWowHandlers WCSToMBEx

2 1

Unable to print from wine
by Peter Stokes 11 Aug '03

11 Aug '03

Hi I downloaded the Mandrake wine-20030709-mdk9.1.i586.rpm and my main issue is still printing from an old 16 bit app. The previous MDK version 20030618 allowed me to pick a printer and select a print format. It then proceeded to print to my CUPS default printer with some of the information it was supposd to print, but not in the correct page size (lost the header and footer info off of the top/bottom of the page). This time when I try to pick a print format I get the following wine: Unhandled exception (thread 000a), starting debugger... err:seh:start_debugger Couldn't start debugger ("debugger/winedbg 8 112") (2) Read the Wine Developers Guide on how to set up winedbg or another debugger The app then completely hangs. So how do I use the debugger to get some useful info for you to look at? Thanks Peter

1 0

Stubs for BuildTrusteeWithSid(A/W)
by Mike McCormack 11 Aug '03

11 Aug '03

ChangeLog: * Stubs for BuildTrusteeWithSid(A/W) Index: dlls/advapi32/advapi32.spec =================================================================== RCS file: /home/wine/wine/dlls/advapi32/advapi32.spec,v retrieving revision 1.38 diff -u -r1.38 advapi32.spec --- dlls/advapi32/advapi32.spec 24 Jul 2003 00:01:16 -0000 1.38 +++ dlls/advapi32/advapi32.spec 11 Aug 2003 09:03:40 -0000 @@ -338,3 +338,6 @@ @ stub WmiSetSingleInstanceW @ stub WmiOpenBlock @ stub WmiCloseBlock +@ stdcall BuildTrusteeWithSidA(ptr ptr) +@ stdcall BuildTrusteeWithSidW(ptr ptr) + Index: dlls/advapi32/security.c =================================================================== RCS file: /home/wine/wine/dlls/advapi32/security.c,v retrieving revision 1.56 diff -u -r1.56 security.c --- dlls/advapi32/security.c 24 Jul 2003 00:01:16 -0000 1.56 +++ dlls/advapi32/security.c 11 Aug 2003 09:03:40 -0000 @@ -1334,3 +1334,20 @@ FIXME("stub!\n"); return ERROR_BAD_PROVIDER; } + +/****************************************************************************** + * BuildTrusteeWithSidA [ADVAPI32.@] + */ +VOID WINAPI BuildTrusteeWithSidA(PTRUSTEEA pTrustee, PSID pSid) +{ + FIXME("%p %p\n", pTrustee, pSid); +} + +/****************************************************************************** + * BuildTrusteeWithSidW [ADVAPI32.@] + */ +VOID WINAPI BuildTrusteeWithSidW(PTRUSTEEW pTrustee, PSID pSid) +{ + FIXME("%p %p\n", pTrustee, pSid); +} +

1 0

Wine CVS Build Error
by Casey McGinty 11 Aug '03

11 Aug '03

I'm trying to get Wine and/or Winex to build on my system with no luck. I get the same error in both releases, I was hoping someone would know how to fix this, or what I am doing wrong. I'm using GCC 3.2.3 and kerenl 2.4.21 on a Linux From Scratch distribution. The error output I get in Wine: gcc -s -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -D__WINESRC__ -DDLLDIR="\"/usr/local/lib/wine\"" -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -O3 -march=athlon-xp -fforce-addr -fomit-frame-pointer -funroll-loops -frerun-cse-after-loop -frerun-loop-opt -falign-functions=4 -o ldt.o ldt.c ldt.c: In function `modify_ldt': ldt.c:78: `SYS_modify_ldt' undeclared (first use in this function) ldt.c:78: (Each undeclared identifier is reported only once ldt.c:78: for each function it appears in.) make[2]: *** [ldt.o] Error 1 make[2]: Leaving directory `/tmp/wine-20030709/libs/wine' make[1]: *** [wine] Error 2 make[1]: Leaving directory `/tmp/wine-20030709/libs' make: *** [libs] Error 2 The error is basically the same in Winex, undefined SYS_modify_ldt. I tried searching for SYS_modify_ldt definition in my kernel sources and the Wine source and I failed to find anything. What gives ? I hope someone can help me with this. Thanks - Casey

2 1

Re: Add support for CS_NOCLOSE
by Alexandre Julliard 10 Aug '03

10 Aug '03

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Add support for CS_NOCLOSE. This is implemented already in MENU_InitSysMenuPopup; if it doesn't work right it should be fixed there. -- Alexandre Julliard julliard(a)winehq.com

2 7

Re: Implement a typelib loader cache
by Dmitry Timoshkov 10 Aug '03

10 Aug '03

"Mike Hearn" <mike(a)theoretic.com> wrote: > Implement a typelib loader cache, minor debug message improvements + for (entry = tlb_cache_tail; entry != NULL; entry = entry->next) + if (!strcmpW(entry->path, szPath)) { + TRACE("cache hit\n"); Shouldn't this be a case insensitive comparison? -- Dmitry.

2 2

Re: Status Update#2 Again
by Dmitry Timoshkov 10 Aug '03

10 Aug '03

"Tom" <twickline(a)skybest.com> wrote: + <li>ADD - RCPT4 ToDo and entries</li> Sorry, didn't notice it first time: it seems that RCPT4 should actually be RPCRT4. -- Dmitry.

1 0

missing #define in winuser.h
by Alfredo K. Kojima 09 Aug '03

09 Aug '03

The owner draw states in winuser.h do not include ODS_DEFAULT (among others), which is described in the documentation in MSDN: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… -- Alfredo

1 0

Re: Status Update - Lostwages
by Dmitry Timoshkov 09 Aug '03

09 Aug '03

"Tom" <twickline(a)skybest.com> wrote: > Here is a small update to the status pages. + <li>Remove - Some of the bullets from DierctX section</li> an apparent typo above -- Dmitry.

3 3

wine seti team
by puoti＠inwind.it 08 Aug '03

08 Aug '03

Is m$ does it, we must do it too. The Wine seti@home team can be found here. http://setiathome.ssl.berkeley.edu/stats/team/team_172471.html Microsoft also has a team, we are ...a bit behind, there stats are here http://setiathome.ssl.berkeley.edu/stats/team/team_28.html Will we catch up?

1 0

Seti@home
by puoti＠inwind.it 08 Aug '03

08 Aug '03

What about having a wine seti team?

1 0

Re: Small cleanup
by Alexandre Julliard 08 Aug '03

08 Aug '03

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > ChangeLog > Remove unused defines. The idea is to have the same defines as Windows; even though we don't actually need them at this point we might want to someday. -- Alexandre Julliard julliard(a)winehq.com

3 3

Re: partial implementation of msi.dll
by Mike McCormack 08 Aug '03

08 Aug '03

Gregory M. Turner wrote: > Hmm, that pure parser business... is that for reentrancy? Or is that a > side-effect of some larger "pureness"? > > If they aren't portably generated, just do it ahead of time -- betcha AJ will > have no problem checking in some pre-generated stuff so long as the sources > to regenerate them are available to those who have the right tools. The pureness is about reentrancy, though it maybe necessary so that two parsers don't have conflicting global variable names. I also thought about pre-generated parser code... that's probably a good idea if Alexandre agrees. >>2) make the database read/write - not immediately important, but >>necessary later > > > does MSI do that? I thought that was done by some funky tool... or does it > use msi.dll to do the work? There's some tools you can download from MSDN, however MSI.DLL does all the work of reading and writing the database. >>I don't have lots of time to work on this at the moment, so if somebody >>wants to have a go, I'm happy to help them out. > > > well considering I'm the only recipient of this, would I be the "somebody" you > have in mind? ;) (just kidding of course ... as for me, my plate is pretty > full right now, but I will of course take a look at it when I get the chance > and see if there's anything I can do to help. Since I need to brush up on my > parsing skills if I ever want to help Ove with widl, maybe I can find > something to do in that arena.) It's probably better that somebody who's looking for stuff to do does it, seeing you've got other stuff to do. I might do some work on it periodically, but it seems like it might be a fun project for somebody to take up. Mike

2 2

age of empires 1 trial uninstall script
by puoti＠inwind.it 07 Aug '03

07 Aug '03

The age of empires trial uninstaller writes a batch script to the c drive, then exits, the script :Repeat del "C:\Program Files\Microsoft Games\Age of Empires Trial\UNINSTAL.EXE" del "C:\Program Files\Microsoft Games\Age of Empires Trial\SETUPENU.DLL" if exist "C:\Program Files\Microsoft Games\Age of Empires Trial\UNINSTAL.EXE" goto Repeat if exist "C:\Program Files\Microsoft Games\Age of Empires Trial\SETUPENU.DLL" goto Repeat rmdir "C:\Program Files\Microsoft Games\Age of Empires Trial" rmdir "C:\Program Files\Microsoft Games" rmdir "C:\Program Files" rmdir "C:" del "\DelUS.bat" is meant to delete itself, but ti dosen'tas after the uninstall has finished, I find it in the fake c: directory. Running it under wcmd outputs this C:\>delus C:\>del "C:\Program Files\Microsoft Games\Age of Empires Trial\UNINSTAL.EXE" C:\Program Files\Microsoft Games\Age of Empires Trial\UNINSTAL.EXE :File Not Found C:\>del "C:\Program Files\Microsoft Games\Age of Empires Trial\SETUPENU.DLL" C:\Program Files\Microsoft Games\Age of Empires Trial\SETUPENU.DLL :File Not Found C:\>if exist "C:\Program Files\Microsoft Games\Age of Empires Trial\UNINSTAL.EXE" goto Repeat C:\>if exist "C:\Program Files\Microsoft Games\Age of Empires Trial\SETUPENU.DLL" goto Repeat C:\>rmdir "C:\Program Files\Microsoft Games\Age of Empires Trial" File not found C:\>rmdir "C:\Program Files\Microsoft Games" Directory is not empty C:\>rmdir "C:\Program Files" Directory is not empty C:\>rmdir "C:" Directory is not empty C:\>del "\DelUS.bat" Sharing violation C:\> The rmdir errors are normal, they aren't meant to do anything if they try to delete not-empty folders, but the del "DelUS.bat" instructions, (The self destruction mechanism of the script) gives a sharing violation error. This is a very trivial problem, the rest of the uninstall works, and (If it's there) the game directory is deleted successfully, so one only has to delete the script by hand, but it would at least look good if this was fixed before 1.0

1 0

propset.c: In function `DSPROPERTY_EnumerateW
by Peter Birch 07 Aug '03

07 Aug '03

The latest cvs code (08/06/2003 20:45:00 pst) will not compile - I get the following error: gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o propset.o propset.c propset.c: In function `DSPROPERTY_EnumerateW': propset.c:522: parse error before `*' propset.c:526: `wDescription' undeclared (first use in this function) propset.c:526: (Each undeclared identifier is reported only once propset.c:526: for each function it appears in.) propset.c:527: `wModule' undeclared (first use in this function) propset.c:528: `wInterface' undeclared (first use in this function) propset.c:550: parse error before `*' This is on Linux kernel 2.4.20 (i586), GCC 2.95.4 with the configure line: ./configure --prefix=/usr --sysconfdir=/etc --with-opengl --with-x This used to work, and the error amazes me because the exact same code appears in the source file several times before the error. Any ideas? Thanks.

2 3

Re: [antony@antgel.co.uk: .msi files]
by Robert Shearman 07 Aug '03

07 Aug '03

> Date: Fri, 1 Aug 2003 16:03:01 +0100 > From: Antony Gelberg <antony(a)antgel.co.uk> > To: wine-devel(a)winehq.com > Subject: [antony(a)antgel.co.uk: .msi files] > > Does Windows Installer work? Yes, I have installed MSN Messenger using it. > I've tried installing bout the 98 and 2K versions under wine, but only > get: > > cdrom $ /usr/local/bin/wine ./instmsiw.exe > fixme:win32:PE_CreateModule Security directory ignored > fixme:process:CreateProcessA (X:\IXP000.TMP\msiinst.exe,...): > NORMAL_PRIORITY_CLASS ignored This is your problem. Only the Win9x version of MSI works at the moment and only if your version is set to Win9x in your config file. I submitted a few patches a while ago to get the WinNT version a bit further but it needs a load of security functions which aren't implemented (properly) yet. There was talk a while ago about reimplementing MSI in Wine, but we rejected the idea on the grounds that it was undocumented, very complicated and not needed yet. > On another note, I'm really surprised that the wine-users list is so > quiet as it's such an important bit of software. I apologise for this. We do have a few developers that regularly post there (including me on occasions), it just seems you caught us at a busy moment. Rob

5 15

Re: Some suggestions on API database
by Dave Miller 07 Aug '03

07 Aug '03

A few updates to this project. First, I have completed work on a script which makes an export table. That is, it's completed if noone discovers a problem or feature that should be added. This table will have all windows versions in a row across the top, and dlls in a column down the left side. Each dll has an X for versions of windows - including wine which export that dll. The X is a link to one of the CGIs which queries for all APIs exported by that dll in that particular windows version. The script is currently generating the table and it seems it will take a good 8 hours or so to finish!! There is a HUGE number of dlls. I think some .ref files might not be from clean installs. If anyone can identify for certain dlls which are not part of windows please let me know so I can clean up the database and the table. You can check it's progress at http://24.229.94.2/export_table.html. I think when finished it could use some color, maybe a style sheet. Any other comments? The compare.cgi script now has a checkbox which toggles all output vs only differences as Dimi suggested. In case anyone noticed winnt40-sp6a queries did not return any results. The version field was truncated. I fixed it by dropping the 0. :) A windows NT 3.51 version has been added to the database. Juan Lang wrote: >Hi David--thanks for posting those! Here's my input: >Your list of APIs (from WINE, Windows versions) is not >likely to change terribly frequently. As such, I'd >suggest using your Perl script to pregenerate static >web pages that have some sought-after info. This >should cut down load on your box quite a bit. > >Perhaps there'll be debate on the most useful pages, >but personally I'd like to see: >- which DLLs exist under which versions of >Windows/WINE. I'm thinking a table which lists each >DLL (the union of all of them) in a row, and column >for each Windows version indicating whether it exists. >- for each DLL, which functions it exports under which >versions of Windows/WINE. > >Cheers, >--Juan > >__________________________________ >Do you Yahoo!? >Yahoo! SiteBuilder - Free, easy-to-use web site design software >http://sitebuilder.yahoo.com > > > >

1 0

bug in dlls/dplayx/version.rc drectx gurus please read.
by puoti＠inwind.it 07 Aug '03

07 Aug '03

I (Think) I've found a bug in dlls/dplayx/version.rc. As you can see from this bug report I submitted http://bugs.winehq.com/show_bug.cgi?id=1299 a few moths ago I discovered that m$ age of empires trial didn't run any more. Someone did some testing, and the result was that version 1.2 of version.rc worked, and version 1.3 didn't I did some testing and I discovered that the problem is in these two lines of code #define WINE_FILEVERSION 4,7,0,0 #define WINE_FILEVERSION_STR "4.7.0.0" Compiling wine with one of these two, or without both of them works perfectly, the game is quite playable, but if you compile with both (As in current CVS) when starting the game you get an error message saying that the game needs directx 6.1a I did send an email to the developer that sent the patch that adds these lines, but about 3 weeks have gone and I never got an answer. I don't think it's anything complex, the easy way is to just remove the 2 lines (Or one of them), but I suppose Lionel or some other directx developer could work out a better solution than that.

1 0

Re: Accept SIZE_MAXIMIZED as one of statuses of MDI windows
by Alexandre Julliard 07 Aug '03

07 Aug '03

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -1070,9 +1072,10 @@ STATUSBAR_WMSize (STATUSWINDOWINFO *info > width = parent_rect.right - parent_rect.left; > x = parent_rect.left; > y = parent_rect.bottom - infoPtr->height; > - MoveWindow (infoPtr->Self, parent_rect.left, > - parent_rect.bottom - infoPtr->height, > - width, infoPtr->height, TRUE); > + SetWindowPos(infoPtr->Self, HWND_TOP, > + parent_rect.left, parent_rect.bottom - infoPtr->height, > + width, infoPtr->height, SWP_NOZORDER); > + What is this change for? -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: partial implementation of msi.dll
by Gregory M. Turner 07 Aug '03

07 Aug '03

On Wednesday 06 August 2003 09:48 am, Mike McCormack wrote: > Hi, > > This is a partial implementation of the Microsoft Installer (msi.dll). > At the moment, it is capable of querying an MSI database with read only > SQL queries, but can't use it to install anything. > > Mike Cool! But "Micorosft Installer" might not be the most appropriate name for this implementation, eh? :P How about "Mike's Sexy Installer" ;) Having clearly delved into this deeper than most of us, how complete would you say the documentation for MSI is? What do you think is the future outlook of this work? -- gmt "Jesse Ventura took American politics and raised it to the level of professional wrestling." -- Argus Hamilton

2 1

Using Wine for Production Build Processes
by Bob Dixon 06 Aug '03

06 Aug '03

We currently support production build processes using both FreeBSD and Windows 2000 and we're interested in consolidating our builds on FreeBSD systems as much as possible. Our Windows builds currently run Visual Studio 6.0, 7.0, and 7.1 on Windows 2000 compute servers. There's an ongoing discussion about whether Wine is appropriate for trying to run these Windows builds. Rather than guessing or hacking around with this, I'd like to ask the experts. We're currently using some in-house tools that drive Visual Studio using a COM interface, vs using command-line compilers and nmake. Does it make sense to try to run these builds using Wine? Thanks! Bob Dixon

1 0

Re: PATCH - msvcrt.spec exports
by Alexandre Julliard 06 Aug '03

06 Aug '03

Steven Edwards <steven_ed4153(a)yahoo.com> writes: > This is untested on *nix build. With this we can build and link regression tests on Mingw again. > > Changelog: > Casper Hornstrup <chorns_at_users.sourceforge.net> > Fix export definition _onexit and atexit. This is wrong, _onexit and atexit are functions, not variables. The bug is in Mingw. -- Alexandre Julliard julliard(a)winehq.com

1 0

dlls/d3d8/device.c
by Gerald Pfeifer 06 Aug '03

06 Aug '03

I may be wrong, and I'm sorry if that's the case, but are you sure the following new code in dlls/d3d8/device.c does what you believe it does? if ((This->StateBlock->texture_state[Stage][D3DTSS_ALPHAARG1] == D3DTA_TEXTURE) && ((oldTxt == NULL) && (pTexture != NULL)) || ((pTexture == NULL) && (oldTxt != NULL))) { reapplyFlags |= REAPPLY_ALPHAOP; } && binds stronger than ||, so in fact the above boils down to (first line && second line) || third line while it occurs to me that you ment to achieve the following if ( This->StateBlock->texture_state[Stage][D3DTSS_ALPHAARG1] == D3DTA_TEXTURE) && ( ( oldTxt == NULL && pTexture != NULL ) || ( pTexture == NULL && oldTxt != NULL ) ) ) (Personally, I think it's also nicer to omit the parentheses around == and !=, but that's a different one.) Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 1

Re: Web: Press section update
by biggun from the sun 06 Aug '03

06 Aug '03

Hi, The following links from LinuxWorld may be broken, above of each there is their new location: ** The latest and greatest ways to run Windows desktop apps http://www.linuxworld.com/story/32684.htm ** How to Install Neverwinter Nights on Linux http://www.linuxworld.com/story/32654.htm ** Codeweaver's CrossOver Office is the best way to do the wrong thing http://www.linuxworld.com/story/32751.htm *** IMO, definitively broken WINE and the WINEmakers http://www.linuxworld.com/linuxworld/lw-1998-12/lw-12-corel.html Corel's CEO shares Linux vision http://www.linuxworld.com/linuxworld/expo/lw-wine.html Stephan _________________________________________________________________ Protect your PC - get McAfee.com VirusScan Online http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

1 0

re: __declspec(selectany)
by Dan Kegel 06 Aug '03

06 Aug '03

Boaz Harrosh (boaz(a)hishome.net) wrote: > background: > I have managed to compile ATL/WTL from MSVC6. > I will have available a public patch-file for patching ATL/WTL to > compile under wine, Once I have every thing running > > Question: > All symbols and functions declared __declspec(selectany) show up as > "duplicate symbols" errors on the linker. Eliminating it has the same > results. > > I have searched in google and the few lines I found is that GCC will > accept __declspec(selectany) if "-fms-extensions" is used. Well it will > accept it but will only ignore it all together. > > Does any body know how to properly merge duplicate definitions of > symbols in GCC? Yes, I think it's attribute((weak)). > (before I go and change the code) maybe a command line switch to the > compiler or linker can do the trick ? Part of the solution might be to apply the following patch to the gcc-3.3 source tree: Index: linux.h =================================================================== RCS file: /cvsroot/gcc/gcc/gcc/config/i386/linux.h,v retrieving revision 1.42 diff -u -d -u -r1.42 linux.h --- linux.h 15 Nov 2002 14:57:12 -0000 1.42 +++ linux.h 5 Aug 2003 21:33:39 -0000 @@ -82,6 +82,14 @@ builtin_define ("__ELF__"); \ builtin_define ("__gnu_linux__"); \ builtin_assert ("system=posix"); \ + builtin_define ("__stdcall=__attribute__((__stdcall__))"); \ + builtin_define ("__cdecl=__attribute__((__cdecl__))"); \ + builtin_define ("__declspec(x)=__attribute__((x))"); \ + if (!flag_iso) \ + { \ + builtin_define ("_stdcall=__attribute__((__stdcall__))"); \ + builtin_define ("_cdecl=__attribute__((__cdecl__))"); \ + } \ if (flag_pic) \ { \ builtin_define ("__PIC__"); \ but I'm sure more is needed; I haven't tested this at all. (gcc/doc/extend.texi would need updating, too, at least, and maybe whatever code implements -fms-extensions.) I suspect the folks who did the original ms-extensions for gcc never figured we'd be compiling Windows source code on Linux, but here we are... - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

7 9

wine in the press :)
by Tom 06 Aug '03

06 Aug '03

Hi, I just seen this on /. I though I would post the link here. http://www.eweek.com/article2/0,3959,1210083,00.asp Tom

7 8

Re: WaitForMultipleObjects loops forever if passed an array of size zero
by Alexandre Julliard 05 Aug '03

05 Aug '03

Troy Rollo <wine(a)troy.rollo.name> writes: > @@ -412,7 +412,7 @@ > { > int ret, cookie; > > - if (count > MAXIMUM_WAIT_OBJECTS) return STATUS_INVALID_PARAMETER_1; > + if (count > MAXIMUM_WAIT_OBJECTS || count <= 0) return > STATUS_INVALID_PARAMETER_1; This is wrong, 0 is a valid count, and shouldn't cause an infinite loop. You'll need to debug this some more. -- Alexandre Julliard julliard(a)winehq.com

6 12

HELP with IID_XXX
by Boaz Harrosh 05 Aug '03

05 Aug '03

There are tons of: EXTERN_C const IID_XXX all over the COM place. My Wine App compiles and links fine but when I try to run it. I get the error: /home/wine/bin/wine: cannot open builtin library for 'C:\WINDOWS\SYSTEM\wtlmdi.exe': ./wtlmdi.exe.so: undefined symbol: CLSID_HTMLDocument How can I know of all the undefined symbols in my wine-app before I try to run it. can one force the linker to list all undefined simbols? and on more question is there a ready made program to take a defenition of type: MIDL_INTERFACE(" FC4801A3-2BA9-11CF-A229-00AA003D7352" ) to: DEFINE_GUID( IID_IObjectWithSite, 0xFC4801A3,0x2BA9,0x11CF,0xA2,0x29,0x00,0xAA,0x00,0x3D,0x73,0x52) ; Free Life Boaz

1 0

Stuck with winelib + DLL import
by Martin Wilck 05 Aug '03

05 Aug '03

Hi, after a good while I had some time to look at my winelib project again. Last time I worked on it was last December, before the "import library" concept was introduced. I had to realize that winelib had changed so much that I couldn't make my code compile anymore. I tried all day to figure it out for myself, but it seems I'll need some guidance. This is what I have (strongly simplified): a DLL written in C++ and an App (also C++) importing that DLL. I want to compile both under winelib, and link everything together to get a working app. I fail miserably in setting this up with winemaker like I did it in the past. This is what I understood so far: - DLLs now need an associated ".def" file to be imported, - winebuild generates ".def" from ".spec", - winewrap/winegcc are the future way to go, but they don't support building DLLs yet. My problem is that I don't have a "spec" file for my DLL except the winemaker-generated one (which is just a zero-length dummy). I also have no "def" file, and because the DLL is C++, I have no clue how to write a spec or def file manually (name mangling). Actually, I'd rather avoid writing that stuff by hand. It would be fine to use static linking instead of a DLL (ie the equivalent of linking statically with a .lib file), but I have no clue how to do that either except to brutally link all object files together into a single executable. As long as no wrapper code is involved, it seems that I can avoid the problem by simply linking with unix ld.so. But I recall that this is utterly wrong. In short, I am clueless. Any hints appreciated. Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck@Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

1 0

Windows API db / find APIs missing for a given app
by David Miller 05 Aug '03

05 Aug '03

Recently I spent some time on this again and would like anyone interested in the database to take a look and email me comments. (What's good, how it can be better, and what features could be there, but aren't) Currently the web interface consists of a few forms which do the following: 1. Compare imports or exports between two windows versions. This will output all APIs imported or exported by a dll you specify along with which version exports that API. Example: you specify wine and windows95 as windows versions. Each API will say it is exported by wine only, win95 only, or both. It is color coded in the hope of making it slightly more readable. 2. Perform general queries. This just does SQL queries based on the criteria you specify. You can query by any or all fields. 3. Find unimplemented APIs for a given program. This locates all APIs imported by a specified application and outputs the ones which are unimplemented or stubs in wine. This is broken down by dll which the app tries to import from. Red APIs are not in wine spec files while blue APIs are listed as stubs in the spec files. There are only a couple of apps listed right now. Leave the application field empty for a complete list. I intend to make the output hyperlinks which will query for all apps importing that specific API. Maybe that will help find test cases when tracking down a bug. The forms are currently at http://24.229.94.2 Unfortunately I can't keep this as a permanent location. The PC is just too slow and the scripts really hog CPU. They do lots of SQL queries. :)

7 9

Crash in EnumMRUListA
by Duane Clark 05 Aug '03

05 Aug '03

Running MS Excel viewer, I seem to be able to crash it fairly easily when opening files. The is occurring in the apparently undocumented function EnumMRUListA, so I am not really sure what to expect here. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x40a231f0). In 32-bit mode. 0x40a231f0 (EnumMRUListA+0x88 [comctl32undoc.c:1056] in comctl32.dll.so): movl 0x0(%edi),%eax 1056 datasize = min( witem->size, nBufferSize ); Wine-dbg>bt Backtrace: =>0 0x40a231f0 (EnumMRUListA+0x88(hList=0x416c00b8, nItemPos=0x3, lpBuffer=0x405816a8, nBufferSize=0x800) [comctl32undoc.c:1056] in comctl32.dll.so) (ebp=40581230) 1 0x4097b3d9 (SHAddToRecentDocs+0x3c9(uFlags=0x2, pv=0x4058242c) [shellord.c:788] in shell32.dll.so) (ebp=40582414) 2 0x300c4151 (XLVIEW.EXE.EntryPoint+0xabc81 in XLVIEW.EXE) (ebp=40582530) 3 0x301851a2 (XLVIEW.EXE.EntryPoint+0x16ccd2 in XLVIEW.EXE) (ebp=40582950) 4 0x30047dae (XLVIEW.EXE.EntryPoint+0x2f8de in XLVIEW.EXE) (ebp=40582b94) 5 0x30046b30 (XLVIEW.EXE.EntryPoint+0x2e660 in XLVIEW.EXE) (ebp=40582c10) 6 0x300476cb (XLVIEW.EXE.EntryPoint+0x2f1fb in XLVIEW.EXE) (ebp=40582c44) 7 0x30047790 (XLVIEW.EXE.EntryPoint+0x2f2c0 in XLVIEW.EXE) (ebp=40582c68) 8 0x407de4f7 (WINPROC_wrapper+0x17 in user32.dll.so) (ebp=40582c8c) 9 0x407de582 (WINPROC_CallWndProc+0x82(proc=0x300476d2, hwnd=0x10021, msg=0x111, wParam=0x2001, lParam=0x0) [winproc.c:219] in user32.dll.so) (ebp=40582cbc) 10 0x407e492f (CallWindowProcW+0xcf(func=0x4086e3f4, hwnd=0x10021, msg=0x111, wParam=0x2001, lParam=0x0) [winproc.c:2928] in user32.dll.so) (ebp=40582cf0) 11 0x407c7bd2 (DispatchMessageW+0x11e(msg=0x40582dc0) [message.c:886] in user32.dll.so) (ebp=40582d34) 12 0x30043eae (XLVIEW.EXE.EntryPoint+0x2b9de in XLVIEW.EXE) (ebp=00000000)

2 1

__declspec(selectany)
by Boaz Harrosh 05 Aug '03

05 Aug '03

background: I have managed to compile ATL/WTL from MSVC6. I will have available a public patch-file for patching ATL/WTL to compile under wine, Once I have every thing running Question: All symbols and functions declared __declspec(selectany) show up as "duplicate symbols" errors on the linker. Eliminating it has the same results. I have searched in google and the few lines I found is that GCC will accept __declspec(selectany) if "-fms-extensions" is used. Well it will accept it but will only ignore it all together. Does any body know how to properly merge duplicate definitions of symbols in GCC? (before I go and change the code) maybe a command line switch to the compiler or linker can do the trick ? Free Life Boaz Harrosh

1 0

Thai Keyboard map Patch
by Supphachoke Suntiwichaya 05 Aug '03

05 Aug '03

Hi, This is a patch for Thai keyboard map. MrChoke -- Name : Supphachoke Suntiwichaya Email : MrChoke(a)opentle.org URL : http://www.opentle.org/~mrchoke/ Distribution : Linux TLE 5.0 (Andaman) OS : Linux 2.4.22-pre6-ac1 #1 พฤ. ก.ค. 24 16:45:01 ICT 2003 i686 GNU/Linux Uptime : 11:15am up 1 day, 2:40, 1 user, load average: 0.08, 0.18, 0.29 --- wine-20030709/dlls/x11drv/keyboard.c 2003-07-09 11:22:57.000000000 +0700 +++ wine-20030709/dlls/x11drv/keyboard.c-th 2003-08-05 09:29:24.000000000 +0700 @@ -646,6 +646,15 @@ "<>" }; +/*** Thai (Kedmanee) keyboard layout by Supphachoke Suntiwichaya <mrchoke(a)opentle.org> */ +static const char main_key_th[MAIN_LEN][4] = +{ + "`~_%","1!å+","2@/ñ","3#-ò","4$Àó","5%¶ô","6^ØÙ","7&Öß","8*€õ","9(µö","0)š÷","-_¢ø","=+ªù", + "qQæð","wWä\"","eEÓ®","rRŸ±","tTÐž","yYÑí","uUÕê","iIÃ³","oO¹Ï","pPÂ","[{º°","]}Å,", + "aA¿Ä","sSËŠ","dD¡¯","fFŽâ","gGà¬","hHéç","jJèë","kKÒÉ","lLÊÈ",";:Ç«","\'\"§.","\\|£¥", + "zZŒ(","xX»)","cCá©","vVÍÎ","bBÚ","nN×ì","mM·?",",<Á²",".>ãÌ","/?œÆ" +}; + /*** VNC keyboard layout */ static const WORD main_key_scan_vnc[MAIN_LEN] = { @@ -724,7 +733,7 @@ {"Israeli keyboard layout", &main_key_IL, &main_key_scan_qwerty, &main_key_vkey_qwerty}, {"VNC keyboard layout", &main_key_vnc, &main_key_scan_vnc, &main_key_vkey_vnc}, {"Greek keyboard layout", &main_key_EL, &main_key_scan_qwerty, &main_key_vkey_qwerty}, - + {"Thai (Kedmanee) keyboard layout", &main_key_th, &main_key_scan_qwerty, &main_key_vkey_qwerty}, {NULL, NULL, NULL, NULL} /* sentinel */ }; static unsigned kbd_layout=0; /* index into above table of layouts */

1 0

Re: Trackbar select range tweaks
by Dustin Navea 04 Aug '03

04 Aug '03

--- Duane Clark <dclark(a)akamail.com> wrote: > Dustin Navea wrote: > > ok thx, running on win2k sp2, the attached executable showed > > > > GetSystemMetrics(SM_CYCAPTION) = 19 > > > > Hmm, that's interesting. I'm running Win2K "Professional" SP3. Anyway, I > played around a bit and found out that if I login as administrator, then > GetSystemMetrics(SM_CYCAPTION) = 19, but if I login as dclark then > GetSystemMetrics(SM_CYCAPTION) = 20. Very strange ;) There is no visible > difference between the two accounts that I can see. In both cases, the > thumb is 21. > > I can get a different metric if I set Windows to use large fonts, and > that does increase the size of the trackbar thumb. That is odd.. Because when I ran that, I was running it on a user account on a computer that I did not have administrative access to.. here is the output on my home comp (w2k sp3) from my user acct: GetSystemMetrics(SM_CYCAPTION) = 19 admin acct in a min.. ===== -- Dustin Navea Minor Contributor, http://www.winehq.com Bugzilla Janitor, http://bugs.winehq.com Network Admin, irc://irc.blynk.net (down) __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

1 0

Re: [dx73b] Try3: Performance of texture states
by Gregory M. Turner 04 Aug '03

04 Aug '03

On Sunday 03 August 2003 05:02 am, Ann and Jason Edmeades wrote: > (Try#3 - Also fixes Operation Flashpoint problem which was introduced > AND includes the patch... oops!) My goodness... Flashpoint works? How long has that been? Good $*^!$#^@ work!! But: you should /not/ have told me this as I will be much less productive now. -- gmt "Microsoft is committed to making cabinet files an open technology" http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dncabsdk/h…

2 1

Profiling wine
by Mike Hearn 04 Aug '03

04 Aug '03

Hi, Is there any way to get measurements of where Wine is spending most of its time? I have a problem where typing text into the WebBrowser control is incredibly slow, but don't really have a clue where to start looking. A profiling tool would be handy about now...... thanks -mike

6 6

RE: Linking to _wtol function
by thomas.mertes＠gmx.at 04 Aug '03

04 Aug '03

"Robert Shearman" <R.J.Shearman_at_warwick.ac.uk> wrote: > I'd like to get people's opinions on how I should link to the _wtol function > from a Wine DLL. Should I: > > a) Link to NTDLL and use the function there > b) Link to MSVCRT and use the function there > c) Create a new function in unicode.h > d) Copy the function into my DLL a) and b) are equivalent. In dlls/msvcrt/msvcrt.spec _wtol is just a link to ntdll._wtol. I suggest you use a) since NTDLL is always present (in NT systems). If your program/dll should also run in DOS based systems you should use b). Btw. The wine implementation of the _wtol function is okay, so c) is not necessary. And code duplication d) is also not a good idea. > In that case should I reimplement _wtol in NTDLL function using strtolW? The > rest of the functions in wcstring.c call their libunicode versions, but this > one doesn't. This is wrong the only function in wcstring.c calling strtolW is _wcstol. As you can see in the changelog several months ago I implemented the functions _ultoa, _ltoa, _itoa, _ui64toa, _i64toa, _atoi64, _ultow, _ltow, _itow, _ui64tow, _i64tow, _wtol, _wtoi, _wtoi64. There are also test functions for this functions in the dlls/ntdll/tests directory. All this functions work correct and are documented. There is no reason to rewrite them for fun unless you find a bug. If you want to write little library functions, It is not necessary to rewrite something already working. Search for library functions in msvcrt. There are tons of unimplemented functions. Greetings Thomas Mertes -- COMPUTERBILD 15/03: Premium-e-mail-Dienste im Test -------------------------------------------------- 1. GMX TopMail - Platz 1 und Testsieger! 2. GMX ProMail - Platz 2 und Preis-Qualitätssieger! 3. Arcor - 4. web.de - 5. T-Online - 6. freenet.de - 7. daybyday - 8. e-Post

1 0

Strange code in misc/registry.c
by Lionel Ulmer 04 Aug '03

04 Aug '03

Hi all, Having lately some strange crashes when I start Wine with any --debugmsg command, I started to look at where the problem occured. >From my investigations, it came in the file misc/registry.c while loading 'system.1st' (yeah, I know, I should run in a no-Windows install, but well, my Wine installation is 6 years old and still working, so I won't change now :-) ). Anyway, the faulty function is '_strdupnA'. I added some traces and I have this : 0009:trace:reg:_strdupnA System\CurrentControlSet\Control\MediaProperties\PrivateProperties\Joystick (0x3c003f40) 79 0009:trace:reg:_strdupnA 0x3c003f90 This means that the string given as a parameter has the pointer '0x3c003f40', the length parameter is '79' and it returns '0x3c003f90'. It crashes later on at : 0009:trace:reg:_strdupnA System\CurrentControlSet\Control\MediaProperties\PrivateProperties\Joystick\OEM (0x3c003f90) 114 0009:trace:reg:_strdupnA 0x3c003418 So we give the '0x3c003f90' pointer (which is of length 79 as seen in the previous debug output) but (if you look at the code), will read 114 bytes from it (as the function uses 'memcpy' and not 'strncpy'). The attached patch fixes all crashes on my box, but well, as I am not very familiar with this code, sent it to wine-devel and not wine-patches for review by Registry gurus :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel