- wine-devel - winehq.org

Patch ntdll/kernel32: #27 take III, possible console regression
by Jukka Heinonen 22 Jun '03

22 Jun '03

It seems that this patch (ntdll/kernel32: #27 take III) makes console input handles use edge triggered semantics. Which means that these handles only signal when new input is queued and not when console input buffer has unread data. This breaks winedos console handling, which would have been rather easy to fix if I had not found out that MSDN quite clearly states that console input handles use level triggered semantics: http://msdn.microsoft.com/library/en-us/dllproc/base/synchronization_object…: Console input: Created when a console is created. The handle to console input is returned by the CreateFile function when CONIN$ is specified, or by the GetStdHandle function. Its state is set to signaled when there is unread input in the console's input buffer, and set to nonsignaled when the input buffer is empty. So, it looks like the kernel patch is wrong and introduces a regression. It could be that MSDN documentation is incorrect but I would like to see some test reports before I'm prepared to believe that. As far as I know, Win95 console handles really may use edge triggered semantics (or no signalling at all), but I think Wine consoles ought to follow NT semantics. -- Jukka Heinonen <http://www.iki.fi/jhei/>

2 1

unknown pseudo op
by Robert Lunnon 22 Jun '03

22 Jun '03

In dlls/glu32 winebuild keeps generating glu32_spec.c using a .half pseudo op for the ordinals, but gas knows nothing about a .half pseudo op. Cant even find this text in winebuild, .long seems to be used for listing ordinals. Can anyone give me a clue to this mystery (GCC 2.95.3 BTW)

1 0

GetTimeOfDay on Windows
by Steven Edwards 20 Jun '03

20 Jun '03

Hello, What do you think about me adding a case for GetTimeOfDay to libwine for the Windows port? I dont expect every case of it to be reimplemented from scratch and it seems that winsock2.h defines typedef struct timeval { long tv_sec; long tv_usec; } timeval; http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/wi… /* * Defines gettimeofday * * Based on timeval.h by Wu Yongwei * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2.1 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "config.h" #include "wine/port.h" #ifndef HAVE_GETTIMEOFDAY __inline int gettimeofday(struct timeval *tv, struct timezone *tz) #ifdef _WINDOWS { FILETIME ft; LARGE_INTEGER li; __int64 t; static int tzflag; if (tv) { GetSystemTimeAsFileTime(&ft); li.LowPart = ft.dwLowDateTime; li.HighPart = ft.dwHighDateTime; t = li.QuadPart; /* In 100-nanosecond intervals */ t -= EPOCHFILETIME; /* Offset to the Epoch time */ t /= 10; /* In microseconds */ tv->tv_sec = (long)(t / 1000000); tv->tv_usec = (long)(t % 1000000); } if (tz) { if (!tzflag) { _tzset(); tzflag++; } tz->tz_minuteswest = _timezone / 60; tz->tz_dsttime = _daylight; } return 0; #else /* !defined(_WINDOWS) */ errno = ENOSYS; return -1; #endif /* _WINDOWS */ #endif /* HAVE_GETTIMEOFDAY */ } __________________________________ Do you Yahoo!? SBC Yahoo! DSL - Now only $29.95 per month! http://sbc.yahoo.com

1 0

Re: [OPENGL] Compilation fixes on some b0rken headers
by Lionel Ulmer 20 Jun '03

20 Jun '03

On Fri, Jun 20, 2003 at 05:22:22AM +0200, Sylvain Petreolle wrote: > A 50k patch ?? Well, and so ? If I sent it as a compressed file, the 'all patches need to be readable junkies' will complain. And well, it's plain text, so even people with dial-up will download it pretty fast thanks to line compression :-) Lionel PS: '50 lines quoted for one line reply ?????' (and using the dreaded Outlook quoting convention) -- Lionel Ulmer - http://www.bbrox.org/

2 2

Re: ntdll/kernel32: #27 take II
by Alexandre Julliard 20 Jun '03

20 Jun '03

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > This is a second take at console handles in ntdll. It includes > corrections for latest Alexandre's remarks. Much better, thanks. Just a minor point: the server must not use INVALID_HANDLE_VALUE, the proper value for invalid handles in the server is 0. Also please don't make server calls inside server calls (like the ReleaseSemaphore call in write_console_input). -- Alexandre Julliard julliard(a)winehq.com

1 0

[D3D] Xvidmode and surface locking
by OverrideX 20 Jun '03

20 Jun '03

Ok, I recently started using System Shock 2 fullscreen with xvidmode enabled in my wine config, and here's something strange. When xvidmode is enabled, and I'm in a game and press esc to go to the menu, then esc again to return to the game, or load another save or go through a bulkhead/elevator and cause it to load another level, when it returns to the game the 3D area is completely black, though the HUD/inventory and brackets around items all shows up. This happens with a cvs from 2003-06-08 and also with a cvs from 2003-05-17, however if I don't patch 2003-05-17 with the surface locking the screen doesn't black when loading a saved game or moving between levels, etc. (of course then there's no hud or anything without the surface locking) So basically it's like you can only load 1 saved game, then the next area you go to or saved game you restore you need to save and restart the game for it to go away. Sorry I didn't notice this sooner when testing it out for you :) If you need any tracing done I'd be glad to, just tell me what ya need, also if you want a demo of ss2 I could give you a link to that too.... cheers -Dan -- OverrideX <overridex(a)punkass.com> GPG Key Fingerprint = 4AD5 CE9C D7C8 0069 BDD3 7F72 3AB2 642A 5A5D EB89 In spite of everything, I still believe that people are good at heart. -- Ann Frank

2 3

Wintab dll: Status report.
by Robert North 20 Jun '03

20 Jun '03

Ok, I've done some preliminary testing, and fixed obvious bugs that have arisen. What I found, and could fix: Sometimes a badly configured tablet can generate X errors on the XOpenDevice method. Fixed by ensuring tablet driver was functional. I don't know if the errors need to be caught, or not, but I think they were causing crashes. This is probably related to synchonous/asynchonous X modes. In Photoshop, an infinite loop in method FindOpenContext when attepting to traverse the wintab context chain. In Painter, a number of methods didn't handle NULL prameters properly, resulting in various crashes. Wintab uses NULL paramters to signify a query for size of available data, or to signify a request to flush the Wintab packet queue. Aric, I'm wondering if I should really be fixing these things, as these look like the kind of bugs Code Weavers will have fixed in the normal course of product support. After fixing these issues, The following remain: 1. Photoshop doesn't seem to respond to pressure. 2. Painter receives wintab events, but coordinates are extreme: only see lines from one side of drawing to another. 3. Maybe some further research into the errors from XOpenDevice. I'm not convinced it is a problem. Aric, are these the kind of bugs you were seeing with Painter? I'm suspicious of the Wintab packet building code, as it has to build a C data struct on the fly. Looking at the code though, I can't see anything that could be going wrong. It could also be a scaling issue, where the scales deduced from X are wrong (I remember being suspicious of some of the values returned by the wacom driver). I've got tons of trace code that runs as a wrapper round wintab on win98, and will move some of this into the wine impl for more testing. I hope this will help solve the remaining bugs. I think in the light of the crashing bugs, Aric's patch shouldn't go in as-is. If people want, I could post up a patch with the fixes I've added so far. That's all for now. -Rob.

3 3

Open Source POSIX Threads for Win32
by Zsolt Rizsanyi 19 Jun '03

19 Jun '03

Hi! I just run into a page about an OSS pthreads implementation on top of win32. I dont know if this can be useful for wine, but somebody may be interested... The url is: http://sources.redhat.com/pthreads-win32/ Regards Zsolt

2 1

GL under the render window
by Chris Seddon 19 Jun '03

19 Jun '03

I'm writing a 3d modelling/animation package and although I'm not writing a native port for linux I test the software with Wine for compatibility. I've recently wrote the OpenGL initialization code and noticed that when primitives are drawn, their actually drawn undernieth the rendering window. I'm running the latest (May 8) build of Wine with Red Hat 8/Gnome (both stock versions). When I call CreateWindow I use the static control as for the rendering window itself. Can you guys give me any tips on getting this working so all the data is rendered in the rendering window as opposed to the main program window. Thanks! Chris President/Programmer Vicious Software "Our Software Bytes!"(c)

2 1

Wine
by Sundaranathan S 19 Jun '03

19 Jun '03

Hi All, I have posted a question long back but no reply from anyone. So onceagain posting the same question please can anyone tell me client error:0: recvmsg: Bad address" error. is coming after installing wine. Also if there is any build or binaries for wine on solaris intel then please let me know. Please let me know what is the reason and also the possible solution. Thanks in advance. Please reply. thanks, -Sundaranathan SIP Technologies & Exports Ltd

3 4

PATCH - Split Comdlg32 print dialogs
by Steven Edwards 19 Jun '03

19 Jun '03

This is last patch that should create any new files. After this almost every Win16 function can be compiled out although quite a few of the internal and Win32 functions still call the Win16 api. I am starting to work on this now. Changelog: Split Win16/32 print dialog support. Index: Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/commdlg/Makefile.in,v retrieving revision 1.31 diff -u -r1.31 Makefile.in --- Makefile.in 16 Jun 2003 01:19:16 -0000 1.31 +++ Makefile.in 19 Jun 2003 15:40:15 -0000 @@ -28,7 +28,8 @@ colordlg16.c \ filedlg16.c \ finddlg.c \ - fontdlg16.c + fontdlg16.c \ + printdlg16.c RC_SRCS= rsrc.rc Index: printdlg.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/printdlg.c,v retrieving revision 1.65 diff -u -r1.65 printdlg.c --- printdlg.c 18 Jun 2003 03:30:41 -0000 1.65 +++ printdlg.c 19 Jun 2003 15:39:11 -0000 @@ -43,6 +43,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(commdlg); #include "cdlg.h" +#include "printdlg.h" /* This PRINTDLGA internal structure stores * pointers to several throughout useful structures. @@ -50,23 +51,6 @@ */ typedef struct { - LPDEVMODEA lpDevMode; - struct { - LPPRINTDLGA lpPrintDlg; - LPPRINTDLG16 lpPrintDlg16; - } dlg; - LPPRINTER_INFO_2A lpPrinterInfo; - LPDRIVER_INFO_3A lpDriverInfo; - UINT HelpMessageID; - HICON hCollateIcon; /* PrintDlg only */ - HICON hNoCollateIcon; /* PrintDlg only */ - HICON hPortraitIcon; /* PrintSetupDlg only */ - HICON hLandscapeIcon; /* PrintSetupDlg only */ - HWND hwndUpDown; -} PRINT_PTRA; - -typedef struct -{ LPDEVMODEW lpDevMode; struct { LPPRINTDLGW lpPrintDlg; @@ -145,7 +129,7 @@ * * Returns TRUE on success else FALSE */ -static BOOL PRINTDLG_GetDefaultPrinterNameA(LPSTR buf, DWORD len) +BOOL PRINTDLG_GetDefaultPrinterNameA(LPSTR buf, DWORD len) { char *ptr; @@ -215,7 +199,7 @@ * * Returns number of printers added to list. */ -static INT PRINTDLG_SetUpPrinterListComboA(HWND hDlg, UINT id, LPCSTR name) +INT PRINTDLG_SetUpPrinterListComboA(HWND hDlg, UINT id, LPCSTR name) { DWORD needed, num; INT i; @@ -1005,7 +989,7 @@ * PRINTDLG_ChangePrinter * */ -static BOOL PRINTDLG_ChangePrinterA(HWND hDlg, char *name, +BOOL PRINTDLG_ChangePrinterA(HWND hDlg, char *name, PRINT_PTRA *PrintStructures) { LPPRINTDLGA lppd = PrintStructures->dlg.lpPrintDlg; @@ -1540,127 +1524,10 @@ return TRUE; } - -/*********************************************************************** - * PRINTDLG_WMInitDialog [internal] - */ -static LRESULT PRINTDLG_WMInitDialog16(HWND hDlg, WPARAM wParam, - PRINT_PTRA* PrintStructures) -{ - LPPRINTDLG16 lppd = PrintStructures->dlg.lpPrintDlg16; - DEVNAMES *pdn; - DEVMODEA *pdm; - char *name = NULL; - UINT comboID = (lppd->Flags & PD_PRINTSETUP) ? cmb1 : cmb4; - - /* load Collate ICONs */ - PrintStructures->hCollateIcon = - LoadIconA(COMDLG32_hInstance, "PD32_COLLATE"); - PrintStructures->hNoCollateIcon = - LoadIconA(COMDLG32_hInstance, "PD32_NOCOLLATE"); - if(PrintStructures->hCollateIcon == 0 || - PrintStructures->hNoCollateIcon == 0) { - ERR("no icon in resourcefile\n"); - COMDLG32_SetCommDlgExtendedError(CDERR_LOADRESFAILURE); - EndDialog(hDlg, FALSE); - } - - /* load Paper Orientation ICON */ - /* FIXME: not implemented yet */ - - /* - * if lppd->Flags PD_SHOWHELP is specified, a HELPMESGSTRING message - * must be registered and the Help button must be shown. - */ - if (lppd->Flags & PD_SHOWHELP) { - if((PrintStructures->HelpMessageID = - RegisterWindowMessageA(HELPMSGSTRINGA)) == 0) { - COMDLG32_SetCommDlgExtendedError(CDERR_REGISTERMSGFAIL); - return FALSE; - } - } else - PrintStructures->HelpMessageID = 0; - - if (!(lppd->Flags & PD_PRINTSETUP)) { - /* We have a print quality combo box. What shall we do? */ - if (GetDlgItem(hDlg,cmb1)) { - char buf [20]; - - FIXME("Print quality only displaying currently.\n"); - - pdm = GlobalLock16(lppd->hDevMode); - if(pdm) { - switch (pdm->dmPrintQuality) { - case DMRES_HIGH : strcpy(buf,"High");break; - case DMRES_MEDIUM : strcpy(buf,"Medium");break; - case DMRES_LOW : strcpy(buf,"Low");break; - case DMRES_DRAFT : strcpy(buf,"Draft");break; - case 0 : strcpy(buf,"Default");break; - default : sprintf(buf,"%ddpi",pdm->dmPrintQuality);break; - } - GlobalUnlock16(lppd->hDevMode); - } else - strcpy(buf,"Default"); - SendDlgItemMessageA(hDlg,cmb1,CB_ADDSTRING,0,(LPARAM)buf); - SendDlgItemMessageA(hDlg,cmb1,CB_SETCURSEL,0,0); - EnableWindow(GetDlgItem(hDlg,cmb1),FALSE); - } - } - - /* FIXME: I allow more freedom than either Win95 or WinNT, - * which do not agree to what errors should be thrown or not - * in case nToPage or nFromPage is out-of-range. - */ - if (lppd->nMaxPage < lppd->nMinPage) - lppd->nMaxPage = lppd->nMinPage; - if (lppd->nMinPage == lppd->nMaxPage) - lppd->Flags |= PD_NOPAGENUMS; - if (lppd->nToPage < lppd->nMinPage) - lppd->nToPage = lppd->nMinPage; - if (lppd->nToPage > lppd->nMaxPage) - lppd->nToPage = lppd->nMaxPage; - if (lppd->nFromPage < lppd->nMinPage) - lppd->nFromPage = lppd->nMinPage; - if (lppd->nFromPage > lppd->nMaxPage) - lppd->nFromPage = lppd->nMaxPage; - - /* If the printer combo box is in the dialog, fill it */ - if (GetDlgItem(hDlg,comboID)) { - /* Fill Combobox - */ - pdn = GlobalLock16(lppd->hDevNames); - pdm = GlobalLock16(lppd->hDevMode); - if(pdn) - name = (char*)pdn + pdn->wDeviceOffset; - else if(pdm) - name = pdm->dmDeviceName; - PRINTDLG_SetUpPrinterListComboA(hDlg, comboID, name); - if(pdm) GlobalUnlock16(lppd->hDevMode); - if(pdn) GlobalUnlock16(lppd->hDevNames); - - /* Now find selected printer and update rest of dlg */ - name = HeapAlloc(GetProcessHeap(),0,256); - if (GetDlgItemTextA(hDlg, comboID, name, 255)) - PRINTDLG_ChangePrinterA(hDlg, name, PrintStructures); - } else { - /* else just use default printer */ - char name[200]; - BOOL ret = PRINTDLG_GetDefaultPrinterNameA(name, sizeof(name)); - - if (ret) - PRINTDLG_ChangePrinterA(hDlg, name, PrintStructures); - else - FIXME("No default printer found, expect problems!\n"); - } - HeapFree(GetProcessHeap(),0,name); - - return TRUE; -} - /*********************************************************************** * PRINTDLG_WMCommand [internal] */ -static LRESULT PRINTDLG_WMCommandA(HWND hDlg, WPARAM wParam, +LRESULT PRINTDLG_WMCommandA(HWND hDlg, WPARAM wParam, LPARAM lParam, PRINT_PTRA* PrintStructures) { LPPRINTDLGA lppd = PrintStructures->dlg.lpPrintDlg; @@ -3462,98 +3329,6 @@ ); return bRet; } - -/********************************************************************** - * - * 16 bit commdlg - */ - -/*********************************************************************** - * PrintDlgProc (COMMDLG.21) - */ -BOOL16 CALLBACK PrintDlgProc16(HWND16 hDlg16, UINT16 uMsg, WPARAM16 wParam, - LPARAM lParam) -{ - HWND hDlg = HWND_32(hDlg16); - PRINT_PTRA* PrintStructures; - BOOL16 res = FALSE; - - if (uMsg!=WM_INITDIALOG) { - PrintStructures = (PRINT_PTRA*)GetPropA(hDlg,"__WINE_PRINTDLGDATA"); - if (!PrintStructures) - return FALSE; - } else { - PrintStructures = (PRINT_PTRA*) lParam; - SetPropA(hDlg,"__WINE_PRINTDLGDATA",PrintStructures); - res = PRINTDLG_WMInitDialog16(hDlg, wParam, PrintStructures); - - if(PrintStructures->dlg.lpPrintDlg16->Flags & PD_ENABLEPRINTHOOK) { - res = CallWindowProc16( - (WNDPROC16)PrintStructures->dlg.lpPrintDlg16->lpfnPrintHook, - hDlg16, uMsg, wParam, (LPARAM)PrintStructures->dlg.lpPrintDlg16 - ); - } - return res; - } - - if(PrintStructures->dlg.lpPrintDlg16->Flags & PD_ENABLEPRINTHOOK) { - res = CallWindowProc16( - (WNDPROC16)PrintStructures->dlg.lpPrintDlg16->lpfnPrintHook, - hDlg16,uMsg, wParam, lParam - ); - if(LOWORD(res)) return res; - } - - switch (uMsg) { - case WM_COMMAND: { - /* We need to map those for the 32bit window procedure, compare - * with 32Ato16 mapper in winproc.c - */ - return PRINTDLG_WMCommandA( - hDlg, - MAKEWPARAM(wParam,HIWORD(lParam)), - LOWORD(lParam), - PrintStructures - ); - } - case WM_DESTROY: - DestroyIcon(PrintStructures->hCollateIcon); - DestroyIcon(PrintStructures->hNoCollateIcon); - /* FIXME: don't forget to delete the paper orientation icons here! */ - - return FALSE; - } - return res; -} - - -/*********************************************************************** - * PrintSetupDlgProc (COMMDLG.22) - */ -BOOL16 CALLBACK PrintSetupDlgProc16(HWND16 hWnd16, UINT16 wMsg, WPARAM16 wParam, - LPARAM lParam) -{ - HWND hWnd = HWND_32(hWnd16); - switch (wMsg) - { - case WM_INITDIALOG: - TRACE("WM_INITDIALOG lParam=%08lX\n", lParam); - ShowWindow(hWnd, SW_SHOWNORMAL); - return (TRUE); - case WM_COMMAND: - switch (wParam) { - case IDOK: - EndDialog(hWnd, TRUE); - return(TRUE); - case IDCANCEL: - EndDialog(hWnd, FALSE); - return(TRUE); - } - return(FALSE); - } - return FALSE; -} - /*********************************************************************** * PrintDlgExA (COMDLG32.@) --- /dev/null Thu Jun 19 11:40:24 2003 +++ printdlg.h Thu Jun 19 11:40:22 2003 @@ -0,0 +1,65 @@ +/* + * COMMDLG - Print Dialog + * + * Copyright 1994 Martin Ayotte + * Copyright 1996 Albrecht Kleine + * Copyright 1999 Klaas van Gend + * Copyright 2000 Huw D M Davies + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#ifndef _WINE_PRINTDLG_H +#define _WINE_PRINTDLG_H + +#define NONAMELESSUNION +#define NONAMELESSSTRUCT + +#include "cdlg.h" + +/* This PRINTDLGA internal structure stores + * pointers to several throughout useful structures. + * + */ +typedef struct +{ + LPDEVMODEA lpDevMode; + struct { + LPPRINTDLGA lpPrintDlg; + LPPRINTDLG16 lpPrintDlg16; + } dlg; + LPPRINTER_INFO_2A lpPrinterInfo; + LPDRIVER_INFO_3A lpDriverInfo; + UINT HelpMessageID; + HICON hCollateIcon; /* PrintDlg only */ + HICON hNoCollateIcon; /* PrintDlg only */ + HICON hPortraitIcon; /* PrintSetupDlg only */ + HICON hLandscapeIcon; /* PrintSetupDlg only */ + HWND hwndUpDown; +} PRINT_PTRA; + +/* Internal Functions + * Do not Export to other Apps or Dlls. + */ + +INT PRINTDLG_SetUpPrinterListComboA(HWND hDlg, UINT id, LPCSTR name); +BOOL PRINTDLG_ChangePrinterA(HWND hDlg, char *name, + PRINT_PTRA *PrintStructures); +BOOL PRINTDLG_GetDefaultPrinterNameA(LPSTR buf, DWORD len); +LRESULT PRINTDLG_WMCommandA(HWND hDlg, WPARAM wParam, + LPARAM lParam, PRINT_PTRA* PrintStructures); + +#endif /* _WINE_PRINTDLG_H */ + --- /dev/null Thu Jun 19 11:42:09 2003 +++ printdlg16.c Thu Jun 19 11:33:18 2003 @@ -0,0 +1,252 @@ +/* + * COMMDLG - Print Dialog + * + * Copyright 1994 Martin Ayotte + * Copyright 1996 Albrecht Kleine + * Copyright 1999 Klaas van Gend + * Copyright 2000 Huw D M Davies + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ +#include <ctype.h> +#include <stdlib.h> +#include <stdio.h> +#include <string.h> + +#define NONAMELESSUNION +#define NONAMELESSSTRUCT +#include "windef.h" +#include "winbase.h" +#include "wingdi.h" +#include "wine/wingdi16.h" +#include "winuser.h" +#include "wine/winuser16.h" +#include "commdlg.h" +#include "dlgs.h" +#include "wine/debug.h" +#include "cderr.h" +#include "winspool.h" +#include "winerror.h" + +WINE_DEFAULT_DEBUG_CHANNEL(commdlg); + +#include "printdlg.h" + +/*********************************************************************** + * PRINTDLG_WMInitDialog [internal] + */ +static LRESULT PRINTDLG_WMInitDialog16(HWND hDlg, WPARAM wParam, + PRINT_PTRA* PrintStructures) +{ + LPPRINTDLG16 lppd = PrintStructures->dlg.lpPrintDlg16; + DEVNAMES *pdn; + DEVMODEA *pdm; + char *name = NULL; + UINT comboID = (lppd->Flags & PD_PRINTSETUP) ? cmb1 : cmb4; + + /* load Collate ICONs */ + PrintStructures->hCollateIcon = + LoadIconA(COMDLG32_hInstance, "PD32_COLLATE"); + PrintStructures->hNoCollateIcon = + LoadIconA(COMDLG32_hInstance, "PD32_NOCOLLATE"); + if(PrintStructures->hCollateIcon == 0 || + PrintStructures->hNoCollateIcon == 0) { + ERR("no icon in resourcefile\n"); + COMDLG32_SetCommDlgExtendedError(CDERR_LOADRESFAILURE); + EndDialog(hDlg, FALSE); + } + + /* load Paper Orientation ICON */ + /* FIXME: not implemented yet */ + + /* + * if lppd->Flags PD_SHOWHELP is specified, a HELPMESGSTRING message + * must be registered and the Help button must be shown. + */ + if (lppd->Flags & PD_SHOWHELP) { + if((PrintStructures->HelpMessageID = + RegisterWindowMessageA(HELPMSGSTRINGA)) == 0) { + COMDLG32_SetCommDlgExtendedError(CDERR_REGISTERMSGFAIL); + return FALSE; + } + } else + PrintStructures->HelpMessageID = 0; + + if (!(lppd->Flags & PD_PRINTSETUP)) { + /* We have a print quality combo box. What shall we do? */ + if (GetDlgItem(hDlg,cmb1)) { + char buf [20]; + + FIXME("Print quality only displaying currently.\n"); + + pdm = GlobalLock16(lppd->hDevMode); + if(pdm) { + switch (pdm->dmPrintQuality) { + case DMRES_HIGH : strcpy(buf,"High");break; + case DMRES_MEDIUM : strcpy(buf,"Medium");break; + case DMRES_LOW : strcpy(buf,"Low");break; + case DMRES_DRAFT : strcpy(buf,"Draft");break; + case 0 : strcpy(buf,"Default");break; + default : sprintf(buf,"%ddpi",pdm->dmPrintQuality);break; + } + GlobalUnlock16(lppd->hDevMode); + } else + strcpy(buf,"Default"); + SendDlgItemMessageA(hDlg,cmb1,CB_ADDSTRING,0,(LPARAM)buf); + SendDlgItemMessageA(hDlg,cmb1,CB_SETCURSEL,0,0); + EnableWindow(GetDlgItem(hDlg,cmb1),FALSE); + } + } + + /* FIXME: I allow more freedom than either Win95 or WinNT, + * which do not agree to what errors should be thrown or not + * in case nToPage or nFromPage is out-of-range. + */ + if (lppd->nMaxPage < lppd->nMinPage) + lppd->nMaxPage = lppd->nMinPage; + if (lppd->nMinPage == lppd->nMaxPage) + lppd->Flags |= PD_NOPAGENUMS; + if (lppd->nToPage < lppd->nMinPage) + lppd->nToPage = lppd->nMinPage; + if (lppd->nToPage > lppd->nMaxPage) + lppd->nToPage = lppd->nMaxPage; + if (lppd->nFromPage < lppd->nMinPage) + lppd->nFromPage = lppd->nMinPage; + if (lppd->nFromPage > lppd->nMaxPage) + lppd->nFromPage = lppd->nMaxPage; + + /* If the printer combo box is in the dialog, fill it */ + if (GetDlgItem(hDlg,comboID)) { + /* Fill Combobox + */ + pdn = GlobalLock16(lppd->hDevNames); + pdm = GlobalLock16(lppd->hDevMode); + if(pdn) + name = (char*)pdn + pdn->wDeviceOffset; + else if(pdm) + name = pdm->dmDeviceName; + PRINTDLG_SetUpPrinterListComboA(hDlg, comboID, name); + if(pdm) GlobalUnlock16(lppd->hDevMode); + if(pdn) GlobalUnlock16(lppd->hDevNames); + + /* Now find selected printer and update rest of dlg */ + name = HeapAlloc(GetProcessHeap(),0,256); + if (GetDlgItemTextA(hDlg, comboID, name, 255)) + PRINTDLG_ChangePrinterA(hDlg, name, PrintStructures); + } else { + /* else just use default printer */ + char name[200]; + BOOL ret = PRINTDLG_GetDefaultPrinterNameA(name, sizeof(name)); + + if (ret) + PRINTDLG_ChangePrinterA(hDlg, name, PrintStructures); + else + FIXME("No default printer found, expect problems!\n"); + } + HeapFree(GetProcessHeap(),0,name); + + return TRUE; +} + +/********************************************************************** + * + * 16 bit commdlg + */ + +/*********************************************************************** + * PrintDlgProc (COMMDLG.21) + */ +BOOL16 CALLBACK PrintDlgProc16(HWND16 hDlg16, UINT16 uMsg, WPARAM16 wParam, + LPARAM lParam) +{ + HWND hDlg = HWND_32(hDlg16); + PRINT_PTRA* PrintStructures; + BOOL16 res = FALSE; + + if (uMsg!=WM_INITDIALOG) { + PrintStructures = (PRINT_PTRA*)GetPropA(hDlg,"__WINE_PRINTDLGDATA"); + if (!PrintStructures) + return FALSE; + } else { + PrintStructures = (PRINT_PTRA*) lParam; + SetPropA(hDlg,"__WINE_PRINTDLGDATA",PrintStructures); + res = PRINTDLG_WMInitDialog16(hDlg, wParam, PrintStructures); + + if(PrintStructures->dlg.lpPrintDlg16->Flags & PD_ENABLEPRINTHOOK) { + res = CallWindowProc16( + (WNDPROC16)PrintStructures->dlg.lpPrintDlg16->lpfnPrintHook, + hDlg16, uMsg, wParam, (LPARAM)PrintStructures->dlg.lpPrintDlg16 + ); + } + return res; + } + + if(PrintStructures->dlg.lpPrintDlg16->Flags & PD_ENABLEPRINTHOOK) { + res = CallWindowProc16( + (WNDPROC16)PrintStructures->dlg.lpPrintDlg16->lpfnPrintHook, + hDlg16,uMsg, wParam, lParam + ); + if(LOWORD(res)) return res; + } + + switch (uMsg) { + case WM_COMMAND: { + /* We need to map those for the 32bit window procedure, compare + * with 32Ato16 mapper in winproc.c + */ + return PRINTDLG_WMCommandA( + hDlg, + MAKEWPARAM(wParam,HIWORD(lParam)), + LOWORD(lParam), + PrintStructures + ); + } + case WM_DESTROY: + DestroyIcon(PrintStructures->hCollateIcon); + DestroyIcon(PrintStructures->hNoCollateIcon); + /* FIXME: don't forget to delete the paper orientation icons here! */ + + return FALSE; + } + return res; +} + + +/*********************************************************************** + * PrintSetupDlgProc (COMMDLG.22) + */ +BOOL16 CALLBACK PrintSetupDlgProc16(HWND16 hWnd16, UINT16 wMsg, WPARAM16 wParam, + LPARAM lParam) +{ + HWND hWnd = HWND_32(hWnd16); + switch (wMsg) + { + case WM_INITDIALOG: + TRACE("WM_INITDIALOG lParam=%08lX\n", lParam); + ShowWindow(hWnd, SW_SHOWNORMAL); + return (TRUE); + case WM_COMMAND: + switch (wParam) { + case IDOK: + EndDialog(hWnd, TRUE); + return(TRUE); + case IDCANCEL: + EndDialog(hWnd, FALSE); + return(TRUE); + } + return(FALSE); + } + return FALSE; +}

1 0

igowin graphical glitches
by Mark Dufour 19 Jun '03

19 Jun '03

Hello! I'm trying to locate the source of some graphical glitches in Igowin, a nice 9x9 Go program (download: http://www.smart-games.com/igo.html, screenshot with glitches attached,) but since someone here might know directly what the problem is, I'd better ask here first.. (to be honest, I already tried to find out and miserably failed :-)) Problem 1: Go stones should be round, not square. The program uses the following functions to draw a stone: trace:bitblt:BitBlt hdcSrc=0x840 0,0 24 bpp->hdcDest=0x834 76,83 37x37x24 rop=8800c6 trace:bitblt:BitBlt hdcSrc=0x844 0,0 24 bpp->hdcDest=0x834 76,83 37x37x24 rop=ee0086 So, first it wants to create a black hole in the board (0x8800c6 = SCRAND,) using a mask at 0x840 and then fit a stone at 0x844 in the hole (0xee0086 = SRCPAINT (OR)). I disabled the second operation, but this gave me a round hole, not a square one.. forcing a SRCCOPY on the first one also gives a square hole, so maybe something goes wrong with creating the mask image.. but as I'm not really sure about this, does anyone here have an idea where the problem might be? Problem 2: Shadows shouldn't have funky colors. As far as I can see, one SRCPAINT is used for drawing a shadow: trace:bitblt:BitBlt hdcSrc=0x83c 83,90 24 bpp->hdcDest=0x834 83,90 30x30x24 rop=ee0086 I haven't thought about this yet, as this didn't get me very far on problem 1.. :-) oh, I use Gentoo and Wine CVS. thanks for any help! Mark Dufour. -- This is why Python is often called "executable pseudocode." - Bruce Eckel

2 1

Debugging 2....
by Auge Mike 19 Jun '03

19 Jun '03

Hi All, Yesterday, I was trying to debug WINE. But Ive been surprised when I saw (while using stepi): 0x08048700 in _init . . 0x08048706 in _dl_runtime_resolve . . 0x4000b014 in fixup . . 0x4000b022 in _dl_build_local_scope . 0x40006ec0 in _dl_lookup_symbol_internal 0x40006cd0 in _dl_unload_cache_internal *Why I got such thing? *Another question is when wine_initial_task is being called? Yours, _________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail

2 1

Missing Bugzilla Descriptions
by Dustin Navea 18 Jun '03

18 Jun '03

Hey guys i was browsing thru BugZilla and I noticed that most if not all of the bugs between 853-1349 are missing their descriptions.. Possibly from the software update? Either way, I'm still around every now and then, although I'm not subscribed to any lists, so if anyone replies, please CC me __________________________________ Do you Yahoo!? SBC Yahoo! DSL - Now only $29.95 per month! http://sbc.yahoo.com

5 5

Wintab: beginning to investigate Aric's patch from April.
by Robert North 18 Jun '03

18 Jun '03

Ok, I've just managed to start looking into Aric's Wintab32 patch from April 23rd. I've been extremely busy (more so than I expected) since then, on a small Java contract. So I've missed my goal of looking into Aric's code in 3 weeks. (Apologies Aric) But anyway, I'm starting to look into it. The first thing I'm seeing is a crash in the WTInfo() wintab call with Painter 5. Will look into this further, and attempt to fix. Aric: Ever had this? I'll investigate further before posting up any significant details, as I suspect the fix is trivial. Infact, has anyone else looked into this patch? I haven't looked any further into Aric's other problems with Painter, as this WTInfo() error prevents Painter from even starting! More importantly, I'd like to know why it didn't make it into the CVS? Did the patch slip behind the filing cabinet (as they do ;-)? Or was there a more substantive reason to reject the patch? I think Mike Hearn mentioned something about it's size (v. large)? Aric, Alexandre: do you want me to want me to re-subimt the patch, once I've got WTInfo() working? I've also noticed that it doesn't update Wine's autoconf file to look for the XInput X extension, as is done to support other dlls that use X extensions. I assume this should be added. Just to touch base with Aric: Has anyone done any more work in Code Weavers on this? That's all for now. -Rob.

2 2

#include "windows.h" versus #include <windows.h>
by Gerald Pfeifer 18 Jun '03

18 Jun '03

The following most certainly cannot be right: % grep windows.h .../wine/programs/notepad/*.c .../wine/programs/notepad/License_En.c:#include "windows.h" .../wine/programs/notepad/dialog.c:#include <windows.h> .../wine/programs/notepad/license.c:#include "windows.h" .../wine/programs/notepad/main.c:#include <windows.h> Should this generally be "windows.h" or <windows.h>? (I suppose the former.) Anybody going to unify this? Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/

3 4

Sound3D problems
by Rok Mandeljc 18 Jun '03

18 Jun '03

Hmm... it seems that none of 3d sound apps that used to work work anymore; all crashing when trying to get ds3dl->dsb->dsound->nrofbuffers in clause: for (i = 0; i < ds3dl->dsb->dsound->nrofbuffers; i++) There were come great changes in dsound lately (especially in buffers i think). Is this the source of problems? Or is it lack of CriticalSection stuff (I don't really understand them, so I didn't bother with them when I was writing it)? -- Rok Mandeljc <rok.mandeljc(a)gimb.org> "All that is gold does not glitter, Not all those who wander are lost; The old that is strong does not wither, Deep roots are not reached by the frost. From the ashes a fire shall be woken, A light from the shadows shall spring; Renewed shall be blade that was broken, The crownless again shall be king." -- J.R.R. Tolkien

2 1

[DSOUND?] SMP problem workaround, more info
by OverrideX 18 Jun '03

18 Jun '03

Hi again, Ok so I've found a workaround (not a great one..) for the deadlock I experience running System Shock 2 in wine using a SMP box. I've also tried another game in wine, Jedi Knight 2 which does not deadlock, I'm guessing it has to do with how ss2 is calling sounds, since it seems directly related to dsound underruns, and dsound_main.c says in the todo it's missing critical section locking in some parts of it's code, and it's critical section timeouts with the same address, and different tid's that are in the log when the deadlock occurs. (see older thread for more info....) I decided I needed to try a new kernel, 2.5.70 to see if it was something with my kernel - and I also had an idea of how to work around it. The kernel upgrade still deadlocked, but 2.5.70 has the ability to set hard cpu affinity, so by restricting all the wine processes to only using cpu1, the deadlock disappears - obviously this should be fixed in the code rather than working around it like this, but I can't trace it since it doesn't happen when the game plays slow. It seems like it only happens when the game is playing at a good pace and two or more sounds are about to play at the same time. I hope someone knows what needs to be fixed for this without too much more info, as I'm only a novice coder. But until then I'll do some heavy reading on how wine works and see if I can figure it out myself... cheers -Dan -- OverrideX <overridex(a)punkass.com> GPG Key Fingerprint = 4AD5 CE9C D7C8 0069 BDD3 7F72 3AB2 642A 5A5D EB89 It is difficult to legislate morality in the absence of moral legislators.

2 2

Re: Graphics Problem
by Robert Shearman 17 Jun '03

17 Jun '03

Rob Hughes said: > make[2]: Entering directory `/usr/src/wine/dlls/opengl32' > gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include > -D_REENTRANT -fPIC -D__WINESRC__ -Wall -mpreferred-stack-boundary=2 > -gstabs+ -Wpointer-arith -g -O2 -o opengl_ext.o opengl_ext.c > opengl_ext.c:12: redefinition of `GLintptrARB' > /usr/X11R6/include/GL/gl.h:67: `GLintptrARB' previously declared here > opengl_ext.c:13: redefinition of `GLsizeiptrARB' > /usr/X11R6/include/GL/gl.h:68: `GLsizeiptrARB' previously declared here > make[2]: *** [opengl_ext.o] Error 1 > make[2]: Leaving directory `/usr/src/wine/dlls/opengl32' > make[1]: *** [opengl32] Error 2 > make[1]: Leaving directory `/usr/src/wine/dlls' > make: *** [dlls] Error 2 > > This is with cvs as of this morning and NVIDIA 43.63 drivers. > It appears as though a CVS commit 4 days ago added those types. Perhaps Lionel could have a look at these errors? Rob

1 0

Re: PATCH: dlls/cabinet/fdi.c
by Gregory M. Turner 17 Jun '03

17 Jun '03

On Tuesday 17 June 2003 03:42 am, Gerald Pfeifer wrote: > This patch removes an unused variable introduced by the recent changes > to this file and thus avoids the following warning: > - cab_UBYTE buf[64], buf2[256] /* for modification [snip] > + cab_UBYTE buf[64] /* for modification by call back fn */ ; Was going to use that as the user-modifiable buffer for the cabinet name in the "Next Cabinet" notification callback, which I never implemented, as it's part of the split cabinets puzzle. I promise this warning will go away with my next patch. Sorry about that, I've been known to give others an earful for leaving warnings lying around, so I will not complain if the patch is applied, although this would create a trivial merge situation for me, as the variable will probably have to be revived again in my next patch. Also, the patch is incorrect, buf2 only, not buf, is for modification by the callback, so if we kill the variable, we should also kill the comment. My apologies for the superfluous warning! -- "Socialism in general has a record of failure so blatant that only an intellectual could ignore or evade it." -- Thomas Sowell gmt

2 1

Re: ntdll/kernel32: #27
by Alexandre Julliard 17 Jun '03

17 Jun '03

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > - this patch partially implements this scheme. It's partial because > console handles are still handled by wineserver. Their value is > however obfuscated so that we can track their real usage. IMO you shouldn't need to have any obfuscation code in the server at all. If you need that, something is wrong with the design. > - next step would mean implementing the console handle management > outside of wineserver (likely in wineconsole) I'm not convinced we really need that; IMO it's OK to keep them in the server, as long as we can identify them as console handles from the client. -- Alexandre Julliard julliard(a)winehq.com

2 6

Re: Dmusic interfaces
by Rok Mandeljc 17 Jun '03

17 Jun '03

Hi everyone. Sorry for not contributing anything to dmusic in a while, but I'm currently busy with final exams... As I can see, more work was done on it :) > Is anyone of you working on Dmusic interfaces ? > Now doing test with Dxdiag doesnt work, > it says "No such interface" when trying to create a IDirectPerformance > object. This problem can be fixed with adding a if (IsEqualGUID(lpcGUID, &IID_IDirectMusicPerformance) || IsEqualGUID(lpcGUID, &IID_IDirectMusicPerformance8)) in DMUSIC_CreateDirectMusicPerformance8 (at the time being, there's check for IID_IDirectMusicPerformance8 only). But even with this added, dxdiag creates interface, calls some functions and then crashes (though I have no idea why). I was looking at code and i wonder if it's ok to allocate memory for interfaces like this: segment = (IDirectMusicSegmentImpl*)HeapAlloc(GetProcessHeap(),0,sizeof(IDirectMusicImpl)); I mean, it's IDirectMusicSegmentImpl, why using size of IDirectMusicImpl then? (or this doesn't matter?) Another thing... does anyone of you know how to write effective chunk loading function (it will be needed sooner or later since most dmusic objects are stored in files)? -- Rok Mandeljc <rok.mandeljc(a)gimb.org> "All that is gold does not glitter, Not all those who wander are lost; The old that is strong does not wither, Deep roots are not reached by the frost. From the ashes a fire shall be woken, A light from the shadows shall spring; Renewed shall be blade that was broken, The crownless again shall be king." -- J.R.R. Tolkien

2 1

TTYDRV woes :/
by Kye Lewis 17 Jun '03

17 Jun '03

Heyas, Firstly, (for those of you who really care - or who even have a clue who I am.)... I'm back again, and ready for some wine action :) Anyway.... I'm having a bit of a problem with *running* wine stuff - more specifically TTYDRV... I'm getting lots of messages like "fixme:ttydrv:TTYDRV_CreateWindow (10045): stub" (obviously with different actual functions blah blah...) And I have no idea... And yes, before you ask, I am running this in X :) - I've tried CVS, i've tried compiling from a tar.gz, i've tried RPM's, and all seem to produce the same result. I'm using the latest nVidia drivers (from www.nvidia.com) if that would make any difference. Anyone else experienced this problem? Thanks, Kye Lewis ========================= kye(a)lewislan.id.au or, if that doesn't work: kyethespy(a)softhome.net will!

2 1

Re: TypeLib containment refcounting
by Alexandre Julliard 17 Jun '03

17 Jun '03

Mike Hearn <mike(a)theoretic.com> writes: > ChangeLog: > When providing a TypeInfo object, inc/dec the refcount so that programs > don't call GetContainingTypeLib and crash as the container has been > destroyed. This doesn't look right, you increment the refcount on every GetTypeInfo but only decrement when the typeinfo object is destroyed. -- Alexandre Julliard julliard(a)winehq.com

5 10

RPMs and fake windows drive
by Mike Hearn 17 Jun '03

17 Jun '03

Hi, How many of the RPMs up on the download section create a fake windows drive? If the answer is all of them, then we should probably remove the part of the howto that tells people to manually create their drive, as it causes confusion in newbies who don't understand why they are told in one place that they need it, and told in another that they don't. -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

1 0

vfat utf8 read problems
by olivier 17 Jun '03

17 Jun '03

Hello, I'm using environment with gtk 2.x..x - gnome 2.x.x e.g. RedHat 9. gtk 2.x work (only) with charset UTF-8. I share documents on a vfat disk. To see correctly the file name with gnome, I must use the utf8 option in the fstab. But in this case, I can't see the files bigger than 8 chars with the Wine DialogFileOpen. Sorry for my poor English. Regards, Olivier the windebug messages: -------------------------------------------------- err:dosfs:DRIVE_ReadSuperblock Couldn't open device for drive I: ! (not available, symlink not valid or no permission) Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '.wine/config' err:dosfs:DRIVE_GetLabel Invalid or unreadable superblock on (I:). err:dosfs:DRIVE_ReadSuperblock Couldn't open device for drive I: ! (not available, symlink not valid or no permission) Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '.wine/config' Invalid or unreadable superblock on (I:). Maybe not FAT?

1 0

Re: Re: [DMUSIC07] more
by fenix＠club-internet.fr 17 Jun '03

17 Jun '03

Hi >> PS: Christian with your last patch dmusic crash when WinMM is disabled (no >> sound drivers => DirectSoundCreate8 returns an error) >> >Ok, I will do more checks. :) >But how do you disable WinMM explicitely? By removing the driver >name in the config file? "Drivers" = "" >Bye, >Christian Regards, Raphael

1 0

Re: [DMUSIC07] more
by Christian Costa 17 Jun '03

17 Jun '03

> Message du 17/06/03 02:30 > De : Raphaël Junqueira <fenix(a)club-internet.fr> > A : wine-patches(a)winehq.com > Copie à : Christian Costa <titan.costa(a)wanadoo.fr>, Rok Mandeljc <rok.mandeljc(a)gimb.org> > Objet : [DMUSIC07] more > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > Changelog: > - add IDirectMusicContainer support in > IDirectMusicLoader8Impl::LoadObjectFromFile > - don't use IDirectMusicSegment*Impl when IDirectMusicSegment*8Impl can be > used instead (avoir code duplication) > > Regards, > Raphael > > PS: Christian with your last patch dmusic crash when WinMM is disabled (no > sound drivers => DirectSoundCreate8 returns an error) > Ok, I will do more checks. But how do you disable WinMM explicitely? By removing the driver name in the config file? Bye, Christian

1 0

Not to bring up a (probably) long-dead subject, but...
by Dustin Navea 17 Jun '03

17 Jun '03

I was looking thru the archives of WWN and found this: Tony Lambregts submitted a patch that added a new filesystem type: Some program (VirtualDub) checks the fsname returned by GetVolumeInformation, to find the name of the file system, when it needs to write files that are larger than 2GB. It refuses to create the file when we return FAT but will successfully write the file when NTSF is returned. Change Log: add configuration option to report NTFS as the file system type for a drive. Mike Hearn thought it might just be a good idea to always return NTFS if asked. Andreas Mohr disagreed and felt the whole concept was flawed: -snip- >From there the discussion delved into exactly what type of filesystems Windows knows about. There was some speculation on exactly how and when they differ. For example, what type of filesystem is reported on DVD's? Tony summed it up: So we The way I see it Windows knows about the following file systems. CDFS, FAT, FAT23, NTFS and HPFS. HPFS is irrelevent. CDFS covers all CD like Media. FAT will deal with all drives less that 2 GB. NTFS can be used with drive over 10MB. FAT32 can be ignored. -end- I just figured that you should know that the best bet would be to have wine return vfat instead of fat or ntfs, as fat == fat16 which has a 2 GB limit, while vfat == fat32 which has a 4 GB limit.. This is actually referenced on microsoft's website (although I couldnt give you the exact address) and can also be found on winnetmag.com thru google.. As always I'm not subscribed to the list, so please CC me with any replies.. __________________________________ Do you Yahoo!? SBC Yahoo! DSL - Now only $29.95 per month! http://sbc.yahoo.com

1 0

wIntegrate on Linux: continued....
by cartel＠cryptocracy.hn.org 17 Jun '03

17 Jun '03

Hey All, Still working on getting wIntegrate running under Linux. I'm running into problems running the program either in builtin mode or with native dlls. Here are the dlloverrides that I'm trying: -dll WSOCK32.DLL=native -dll WS2_32.DLL=native -dll NETAPI32.DLL=native -dll ADVAPI32.DLL=native -dll OLEAUT32.DLL=native -dll OLEPRO32.DLL=native -dll OLE32.DLL=native -dll RPCRT4.DLL=native -dll COMCTL32.DLL=native -dll COMDLG32.DLL=native -dll SHLWAPI.DLL=native -dll IMM32.DLL=native -dll IMM32.DLL=native Running with -debugmsg +fixme, I get the following interesting messages: fixme:file:DeviceIoControl Unimplemented control 256 for VxD device VNETBIOS fixme:file:DeviceIoControl Unimplemented control 256 for VxD device NWLINK Once the app starts and I attempt to create a connection, I get this feedback: [Connecting to 127.0.0.1...] [Windows Sockets error 183] Am I correct in interpreting this (net helpmsg 183) in that wine is attempting to create a pipe that already exists? If I take the other approach and run wInteg with no dll overrides (builtin mode), i get the following messages fixme:ole:CoRegisterMessageFilter stub fixme:ole:CFProxy_QueryInterface Unhandled interface: {00000126-0000-0000-c000-000000000046}fixme:ole:CFProxy_QueryInterface Unhandled interface: {00020400-0000-0000-c000-000000000046}fixme:ole:PIPE_GetNewPipeBuf Could not open named pipe \\.\pipe\WINE_OLE_StubMgr_00000013, le is 2err:ole:StdMarshalImpl_UnmarshalInterface Failed to get an rpc channel buffer for {00000001-0000-0000-c000-000000000046}fixme:ole:CoUnmarshalInterface Failed to Unmarshal the interface, 80004005? fixme:ole:CoCreateInstance no classfactory created for CLSID {4fbf4bd9-a454-11d1-ab39-00a024709830}, hres is 0x80004005 This is what prompted me to try running the app in native mode (since this message goes away if im using native ole dlls.) When running in builtin mode and creating a connection, wInteg sits on the [Connecting to 127.0.0.1] message. But netstat -nap reports: tcp 12 0 127.0.0.1:1220 127.0.0.1:23 ESTABLISHED 8079/wine Of note is that wInteg uses an ActiveX control called wWinSock.ocx. This is in keeping with its modular approach to transports (having plugins for PicLan, Novell etc). Correct me if I'm wrong, but from the error messages concerning OLE, I'm thinking that my problem lies with an incomplete implementation of OLE (or at least ActiveX controls) in Wine. Specifically, I beleive the actual problem is that the wWinSock object is not receiving a signal from Wine that tells it that the connection has been opened. Anybody have any further suggestions/comments? Thanks Tom

2 1

Re: Resend PATCH - setupapi add support for both Windows and Unix style line endings to setupapi parser
by Alexandre Julliard 17 Jun '03

17 Jun '03

Steven Edwards <Steven_Ed4153(a)yahoo.com> writes: > Does this need to be changed or is there something else wrong with > this patch? This shouldn't be needed AFAICT, \r should already be treated as a space character. There may be another bug here though, do you have an example file showing the problem? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Resend PATCH - setupapi add support for both Windows and Unix style line endings to setupapi parser
by Todd Vierling 17 Jun '03

17 Jun '03

On Mon, 16 Jun 2003, Steven Edwards wrote: : Does this need to be changed or is there something else wrong with this : patch? : - return (ptr >= parser->end || *ptr == CONTROL_Z || *ptr == '\n'); : + return (ptr >= parser->end || *ptr == CONTROL_Z || *ptr == '\n' || : (*ptr == '\r'&& *(ptr + 1) == '\n')); Could overrun the buffer by looking one char too far if the last character of the file is '\r'. -- -- Todd Vierling <tv(a)pobox.com>

1 0

Dmusic interfaces
by Sylvain Petreolle 17 Jun '03

17 Jun '03

Is anyone of you working on Dmusic interfaces ? Now doing test with Dxdiag doesnt work, it says "No such interface" when trying to create a IDirectPerformance object. I did a look through the source and noticed that Dll(Un)RegisterServer are stubs. fixme:ole:CoCreateInstance no instance created for interface {07d43d03-6523-11d2-871d-00600893b1bd} of class {d2ac2881-b39b-11d1-8704-00600893b1bd}, hres is 0x80004002 ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: Winefile : French translation
by Alexandre Julliard 16 Jun '03

16 Jun '03

Sylvain Petreolle <spetreolle(a)yahoo.fr> writes: > Changelog: > Add French Translation, finish English translation. > > (no unwanted easter egg in this one ;)) No but it looks like the accents didn't make it through... or was this deliberate? -- Alexandre Julliard julliard(a)winehq.com

2 3

Re: wine/dlls/ntdll critsection.c
by Mike Hearn 16 Jun '03

16 Jun '03

On Mon, 16 Jun 2003 14:36:22 -0500, Sir Alexandre Julliard scribed thus: > Log message: > Mike Hearn <mike(a)theoretic.com> > Add the ID of the blocking thread to the error message. Hi Alexandre, I'm wondering what the best way to try and make Wines output less scary is, as the MESSAGE() parts of this patch were not merged. Was the message not phrased right, or do you think that the console output is an inappropriate place to put such things? Alternatively, as Lionel pointed out, it may be that people think they are not necessary, as the only people who can do anything about it will understand the message anyway. thanks -mike

2 2

Re: Bidi B4
by Shachar Shemesh 16 Jun '03

16 Jun '03

Hi Alexander, Please let me know if my patch series was rejected, and if so, why. If your'e just not over the backlog yet, I appologize for the noise. Shachar Shachar Shemesh wrote: > Apply against previous patches, using -p1 > > Changelog: > Shachar Shemesh <winecode(a)shemesh.biz> > > * Fix compilation errors when ICU library is not available. > -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

1 0

Re: [DINPUT] Some more dinput stuff
by Lionel Ulmer 16 Jun '03

16 Jun '03

> As your patch is a little malformed and conflicts with mine (a big one) > i send my patch merged with yours, can you look if all is correct. Why did you not send a patch against a tree patched with Christian's ? And moreover, it seems you have another patch lying around (the one adding the IDirectInputDevice2A interface to the QueryInterface call). The problem is not the Changelog one, it's just that it's now really hard to do any code review with these kinds of stuff as change are accumulating :-/ Lionel -- Lionel Ulmer - http://www.bbrox.org/

3 5

dlls/dmusic/dmusic_misc.c revision 1.3
by Gerald Pfeifer 16 Jun '03

16 Jun '03

I'm afraid the following change to dlls/dmusic/dmusic_misc.c revision 1.3 date: 2003/06/13 18:59:51; author: julliard; state: Exp; lines: +113 -9 Raphael Junqueira <fenix(a)club-internet.fr> - always use IDirectMusicPerformance8Impl instead of IDirectMusicPerformanceImpl (as the first inherits from the second) - implement many Loader, AudioPath and Performance8 stubs - fix the class factory - more debug traces - for now IDirectMusicLoader8::LoadObjectFromFile always returns not supported format - fix the IDirectMusicPerformance8::Init (many crashes) - implementation of IDirectMusicPerformance8InitAudio is causing the following warning: dmusic_misc.c:260: warning: passing arg 2 of `IDirectMusicPerformanceImpl_SetGraph' from incompatible pointer type Could someone more familiar with this have a look at what's wrong? Thanks, Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/

2 1

Re: [GDI] GetObject fails on buffer=NULL
by Alexandre Julliard 16 Jun '03

16 Jun '03

Kelly Leahy <kellyleahy(a)swbell.net> writes: > @@ -60,6 +64,9 @@ > INT (*pGetObjectW)( HGDIOBJ handle, void *obj, INT count, LPVOID > buffer ); > BOOL (*pUnrealizeObject)( HGDIOBJ handle, void *obj ); > BOOL (*pDeleteObject)( HGDIOBJ handle, void *obj ); > + INT (*pGetObjectSizeA)( HGDIOBJ handle, void *obj ); > + INT (*pGetObjectSizeW)( HGDIOBJ handle, void *obj ); > + INT (*pGetObjectSize16)( HGDIOBJ handle, void *obj ); You should put the fix directly in the pGetObject[AW] functions, instead of adding new functions that don't correspond to anything in the Windows API. Even though this is an internal interface it should be kept as similar as possible to the exported interface. -- Alexandre Julliard julliard(a)winehq.com

2 1

Debugging ... ?
by Auge Mike 16 Jun '03

16 Jun '03

Hi all, How can i debug wine itself? I don't want to debug the win32 application, i want to debug the whole wine while it is running? Thanx in advance, Yours, _________________________________________________________________ MSN 8 with e-mail virus protection service: 2 months FREE* http://join.msn.com/?page=features/virus

2 1

Re: [D3D] Some execute buffers rewrites + misc fixes
by Christian Costa 15 Jun '03

15 Jun '03

Hi, Sorry, for a unknown reason my wine-devel delivery had been disabled. I enabled it but I've just seen your posts in the archives... > Some comments on 'small' parts... I will have to commit the patch on > my tree > to try to understand the resulting code to understand it better [:-)] >> + if ( IsEqualGUID( &IID_IDirectDrawSurface, riid ) || >> + IsEqualGUID( &IID_IDirectDrawSurface2, riid ) || >> + IsEqualGUID( &IID_IDirectDrawSurface3, riid ) ) { >> + IDirectDrawSurface7_AddRef(ICOM_INTERFACE(This->surface, >> IDirectDrawSurface7)); >> + *obp = ICOM_INTERFACE(This->surface, IDirectDrawSurface3); >> + TRACE(" Return IDirectDrawSurface3 interface %p\n", *obp); >> + return S_OK; >> + } >> + if ( IsEqualGUID( &IID_IDirectDrawSurface3, riid ) || >> + IsEqualGUID( &IID_IDirectDrawSurface7, riid ) ) { + >> IDirectDrawSurface7_AddRef(ICOM_INTERFACE(This->surface, >> IDirectDrawSurface7)); >> + *obp = ICOM_INTERFACE(This->surface, IDirectDrawSurface7); >> + TRACE(" Return IDirectDrawSurface7 interface %p\n", *obp); >> + return S_OK; >> + } > > Well, it's a bit strange to have 'IID_IDirectDrawSurface3' twice, no > [:-)] ? This seems like the Copy/Paste syndrom [:-)] >> /* We only support the BLT with DEPTH_FILL for now */ >> - if (This->ddraw_owner->d3d != NULL) { >> + if ((dwFlags & DDBLT_DEPTHFILL) && This->ddraw_owner->d3d != >> NULL) { >> if (This->ddraw_owner->d3d->current_device != NULL) { >> >> This->ddraw_owner->d3d->current_device->clear(This->ddraw_owner->d3d->current_device, >> >> 0, NULL, /* Clear the whole screen */ > > Did you add this check here because some game were actually doing a > 'normal' > blit on the ZBuffer ? Yes! From a ZBuffer surface to another... Don't remember the game though... (because it crashed in another part of wine) > What happens in this case ? When doing the standard blit, the app set the DDBLT struct pointer to NULL so without the check this simply crashes when accessing the depthfill member of the structure. > Moreover, you could also add here (which I forgot to do in my patch), > support for the 'dst locking rectangle' in case an application tries to > clear only part of the buffer (see example in the Blt overide function in > d3ddevice/mesa.c for the 'Colorfill' case). Yes this can be done as well. [:-)] > Well, I have a comment... But it's in a part of the code that will be so > rarely used that it could be completely thrown away anyway [:-)] Sure, It's barely used. [:-)] > Basically, you are doing the full projection (without doing the clipping > though) in software... And this does not go well at all with lighting. Yes, there is no lighting yet. > This is why I choose in the previous code to only do the world > transformation to > NOT impact at all lighting (and it worked for Twist AFAIK). So I am > wondering why you choose to go all the way and did not do exactly as I > did > (basically, only do the WORLD transform and set only the PROJ / VIEW one > using the D3D7 API and set the WORLD to Identity as we already did the > transform). Because the world transformation introduced the W coordinate which cannot be passed to drawing functions. But well, this coordinate should be always be 1 after the world transformation so we can ommit it. >Even better would have been to have reused fully our VertexBuffer code and > our (hacky [:-)] ) TransformVertices code. Oh! Well I forgot this hack... [;-)] Bye Christian

2 2

CVS - builtin,native load order failing
by Guy Harrison 15 Jun '03

15 Jun '03

Hi Folks, FreeBSD-4.7, (yes, --prefix=/all) ... [snip] 0009:trace:module:MODULE_GetLoadOrder got standard wildcard "b,n" for "mfc42.dll" 0009:trace:heap:RtlFreeHeap (0x5c2c0000,00000002,5c2c1768): returning TRUE 0009:trace:module:load_dll Trying built-in 'C:\windows\system\mfc42.dll' 0009:err:module:BUILTIN32_dlopen failed to load .so lib for builtin mfc42.dll: Cannot open "/all/lib/wine/mfc42.dll.so" 0009:warn:module:load_dll Loading of builtin DLL C:\windows\system\mfc42.dll failed (status -1073741702). 0009:warn:module:load_dll Failed to load module 'C:\windows\system\mfc42.dll'; status=-1073741702 0009:trace:heap:RtlFreeHeap (0x5c2c0000,00000002,5c2c0c40): returning TRUE 0009:err:module:import_dll Loading module (file) MFC42.DLL (which is needed by C:\app\Paint Shop Pro\PSP.EXE) failed (error -1073741702). [snip] I'll leave it to you guys to decide if this is correct... --- wine/dlls/ntdll/loader.c.ORIGINAL Sun Jun 15 04:05:58 2003 +++ wine/dlls/ntdll/loader.c Sun Jun 15 16:30:36 2003 @@ -1084,7 +1084,7 @@ return nts; } - if (nts != STATUS_NO_SUCH_FILE) + if (nts != STATUS_PROCEDURE_NOT_FOUND) { WARN("Loading of %s DLL %s failed (status %ld).\n", filetype, filename, nts); ...or if 'nts' was wrong in the first place. -- Guy Harrison swamp-dog(a)ntlworld.com

1 0

Executables icons
by BiGgUn 15 Jun '03

15 Jun '03

Hi, I wonder why icons located in an executable are not viewable in GetOpenFileName ? I had a look to the source code (dlls/shell32/folder.c and dlls/shell32/classes.c) and saw that a search is made in the registry. But this search failed because my system.reg doesn't have the queried entry ( [Software\\Classes\\.exe]). I noticed that the winedefault.reg doesn't have the queried entry also. When this search fails, a default icon is applied. By manually adding this entry in system.reg, it is still not possible to get the executables icons :-\ I also saw that [Software\\Classes\\.exe\\DefaultIcon] is also queried. Even if i manually add this entry again, it's not successfull. I think i've missed something in these entries definition but i don't know what. Anyway, by forcing the code to look inside executable for icons, they finally appear :) But it's better to find another solution. How registry should be setted up (system.reg / winedefault.reg) ? Do we need to review the code (adding special case for exe files) ? Stephan P.S.: Excuse me if i bother you with my questions.

3 4

Regarding wine
by Sundaranathan S 15 Jun '03

15 Jun '03

Hi All, Can anyone help me out in solving my problem that arises after installing wine in my machine. I installed wine in my machine. After installing i ran wine command it throws "wine client error:0: recvmsg: Bad address" error. Please let me know what is the reason and also the possible solution. Thanks in advance. thanks, -Sundaranathan SIP Technologies & Exports Ltd -- "Live as if to die tomorrow. Learn as if to live forever."

1 0

Re: Stubbed some interfaces for the FilterGraph CLSID.
by Sylvain Petreolle 15 Jun '03

15 Jun '03

Your latest patch to winedefault.reg was done in the old registry format. Could you submit another ? This makes regedit complain actually. +[Software\\CLASSES\\CLSID\\{E436EBB3-524F-11CE-9F53-0020AF0BA770}] 1032641842 [...] +[Software\\CLASSES\\CLSID\\{E436EBB3-524F-11CE-9F53-0020AF0BA770}\\InprocServer32] 1032641842 ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: CoState should be thread local (move pUnkState into TLS)
by Robert Shearman 14 Jun '03

14 Jun '03

> From: Mike Hearn <mike(a)theoretic.com> > To: wine-patches(a)winehq.org > Date: 14 Jun 2003 22:53:02 +0100 > Reply-To: wine-devel(a)winehq.com > > > ChangeLog: > CoState storage should be thread local <snip> > +static DWORD dwUnkStateSlot = 0; /* TLS slot used to the store > the UnkState, see CoSetState */ Please use the APARTMENT structure defined by Ove Kaaven recently (in compobj_private.h), so that: 1. We keep all of the apartment data together 2. Don't use up a TLS slot unnecessarily Thanks, Rob

1 0

The Matrix DVD installer hangs
by Gerhard W. Gruber 14 Jun '03

14 Jun '03

Some days ago there was a patch for fixing installer hangs. I just tried to install from The Matrix DVD and the installer starts, but hangs after it a short while running. -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

1 0

CoSetState
by Mike Hearn 14 Jun '03

14 Jun '03

Can anybody enlighten me as to what this is supposed to do? It appears to be undocumented, or at least if it's on MSDN it's not where it should be and Google/MSDN Search can't find it. In particular, if you run RhymBox with native oleaut32,rpcrt4 but builtin ole32, shortly after calling this function it appears to crash. If I remove the Release() call, it no longer crashes but seems to freeze the chat window. Looking at the source, all it seems to do is store the passed IUnknown in a global var, with a note that it should be thread local. That doesn't seem to be a very useful function to have, so it must do more than that. Anybody? I think I'm going to try and make it thread local.... thanks -mike

1 0

Re: DEVENUM.DLL Implementation
by Robert Shearman 14 Jun '03

14 Jun '03

> Date: Mon, 9 Jun 2003 23:59:01 +0200 > From: Lionel Ulmer <lionel.ulmer(a)free.fr> > To: wine-devel(a)winehq.com > Subject: Re: DEVENUM.DLL Implementation > > Alexandre, Robert, > > Do you have any idea why this patch was never comitted to Wine ? It's probably best to ask Alexandre about this, but it either slipped through the cracks (and I didn't want to submit it again until I was completely happy with it) or it was due to depending on other unimplemented behaviour (IFilterMapper interface). > Maybe this > will prevent me to do 'quartz,devenum=n' and only 'quartz=n' to get movies > in some applications :-) It should work alright if you can get the patch to apply properly, but IIRC a few changes conflict with it. I still have a few things I'd like to improve (like using DirectSound functions to enumerate the DirectSound devices available) and I will submit another patch when this is done in a couple of weeks. As for the future, work on Quartz shouldn't be too hard to do. A minimal working system would be a File Source 'codec', video and audio renderers and the graph builder, along with my device enumerator implementation. Rob

5 6

Re: Process termination & exit code
by Alexandre Julliard 14 Jun '03

14 Jun '03

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > as reported by Igor Sysoev on WD, exit process code wasn't properly > implemented on *BSD > it appeared (thanks Igor for all the testings and traces) that after > terminate_process request was issued, the client/server pipe got > closed because the running thread was actually killed, erasing the > exit_code that terminate_process had set. > This patch actually fixes it. I don't think we need a new thread state just for that; how about something like this? Index: server/process.c =================================================================== RCS file: /home/winehq/opt/cvs-commit/wine/server/process.c,v retrieving revision 1.104 diff -u -p -r1.104 process.c --- server/process.c 18 Mar 2003 05:04:33 -0000 1.104 +++ server/process.c 13 Jun 2003 23:18:03 -0000 @@ -688,7 +688,7 @@ void kill_process( struct process *proce while (thread) { struct thread *next = thread->proc_next; - thread->exit_code = exit_code; + if (exit_code) thread->exit_code = exit_code; if (thread != skip) kill_thread( thread, 1 ); thread = next; } Index: server/request.c =================================================================== RCS file: /home/winehq/opt/cvs-commit/wine/server/request.c,v retrieving revision 1.79 diff -u -p -r1.79 request.c --- server/request.c 28 Mar 2003 00:36:12 -0000 1.79 +++ server/request.c 13 Jun 2003 23:18:04 -0000 @@ -382,7 +382,7 @@ int receive_fd( struct process *process if (ret > 0) fprintf( stderr, "Protocol error: process %p: partial recvmsg %d for fd\n", process, ret ); - kill_process( process, NULL, 1 ); + kill_process( process, NULL, (ret > 0) ); } else { -- Alexandre Julliard julliard(a)winehq.com

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel