- wine-devel - winehq.org

Re: small ctl3d fix
by Dmitry Timoshkov 15 Feb '03

15 Feb '03

"Rok Mandeljc" <rokmandeljc(a)hotmail.com> wrote: > > > Dmitry's patch doesn't fix my problem, because app call only > > > Ctl3dIsAutoSubclass and it expects it to be true. > > > > > > ChangeLog: > > > Changed default internal ctl3d auto subclass flag from false to true > > > > My test shows that after a successful Ctl3dRegister() > Ctl3dIsAutoSubclass() > > returns FALSE. Therefore your patch is wrong and you have to investigate > > what sequence of ctl3d calls in your application makes it return TRUE. > > > > -- > > Dmitry. > > > > like i said, it calls only Ctl3dIsAutoSubclass() and expects true, otherwise > it starts debugger. what if it should be set true for default and > Ctl3dRegister sets it to false? No, my test shows that by default it's set to FALSE. If you can't investigate it yourself for any reason please send a +relay compressed bz2 log (not more than 500 Kb) to me (*not* to the list) showing the real behaviour of your application. Thanks. -- Dmitry.

1 0

Treeview Icons now broken builtin too
by Uwe Bonnes 15 Feb '03

15 Feb '03

Hallo, some time ago, I reported, that in Xilinx Webpack some Icons associated with a treeview where distorted, when using the native commctrl dlls, but all right when using builtin dlls. With the recent updates, now builtin behaves like native and shows distorted Icons. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: small ctl3d fix
by Dmitry Timoshkov 15 Feb '03

15 Feb '03

"Rok Mandeljc" <rokmandeljc(a)hotmail.com> wrote: > Dmitry's patch doesn't fix my problem, because app call only > Ctl3dIsAutoSubclass and it expects it to be true. > > ChangeLog: > Changed default internal ctl3d auto subclass flag from false to true My test shows that after a successful Ctl3dRegister() Ctl3dIsAutoSubclass() returns FALSE. Therefore your patch is wrong and you have to investigate what sequence of ctl3d calls in your application makes it return TRUE. -- Dmitry.

1 0

Patch Manager
by Fabian Cenedese 15 Feb '03

15 Feb '03

Hi I have never supplied patches myself. But I read all the mails about how to submit patches. I saw on the wxWindows page that they have a Patch- Manager. Mainly just a form to enter all necessary data. Maybe something like that could be useful here too. http://sourceforge.net/tracker/?group_id=9863&atid=309863&func=add bye Fabi

4 3

VC++ nmake not working with Wine 20030115 when it worked with 200208xx
by J. Grant 14 Feb '03

14 Feb '03

Hi, Calling nmake from /wcmd/ used to work, now it does not. I can't see why not, here is the debugger ouput if anyone knows whats wrong I'd be happy to hear! Breakpoint 1 at 0x40009bd0 (_end+0x37fae414) *** Invalid address 0x40011f80 (_end+0x37fb67c4) <snip> Unhandled exception: unimplemented function msvcrt.dll.__p__pgmptr called in 32- bit code (0x40733056). In 32-bit mode. 0x40733056 (__wine_unimplemented+0x56 [msvcrt.spec.c:47] in msvcrt.dll.so): jmp 0x40733050 (__wine_unimplemented+0x50 [msvcrt.spec.c:47] in msvcrt.dll.so) 47 for (;;) RtlRaiseException( &rec ); Wine-dbg> There are a few unknown functions with "__p__pgmptr" void __wine_stub_msvcrt_dll_122(void) { __wine_unimplemented("__p__pgmptr"); } I'm not sure why this problem occures now, when it worked before. Comments welcome Regards JG

5 16

Non-applied patches
by Shachar Shemesh 14 Feb '03

14 Feb '03

Hi Alexandre, I'm just trying to understand whether you are still trying to fight the backlog, my patches fell through the cracks, or that you decided not to apply them. I am referring to: http://www.winehq.com/hypermail/wine-patches/2003/01/0399.html and http://www.winehq.com/hypermail/wine-patches/2003/01/0401.html If the last option, please explain what is wrong with them. Sh. P.S. A simple mail saying "I'm still fighting the backlog, I'll let you know when I've covered all the submitted patches" will suffice, as far as I'm concerned. -- Shachar Shemesh Open Source integration consultant http://www.consumer.org.il/sun/

2 2

Re: Listview delete column zero
by Duane Clark 14 Feb '03

14 Feb '03

Duane Clark wrote: > While the MSDN specifically says that column zero should not be deleted, > it does in fact work on WinNT, and at least one app depends on it. On > WinNT, deleting column zero deletes the last column of items but the > first header. Since no app will ever depend on that bizarre behavior, > we just delete the last column including the header. > I probably should have mentioned why the app deletes column zero. It repeatedly deletes column zero, testing the returned Boolean until it gets false, and then it starts inserting new columns. So it ends up completely replacing the listview contents.

2 2

edit control bug - EM_LIMITTEXT does not work
by Felipe W Damasio 14 Feb '03

14 Feb '03

Hi, When you try to limit the maximum chars accepted in an edit control by doing something like this: SendMessage(hwndEdit, EM_LIMITTEXT, 10, 0); Wine simply ignores it, and let the user type more than 10 (in this example) characters. This looks bad, because the user could eventually overflow the allocated memory for the dialog, making the program crash. Cesar Mello (mello(a)elipse.com.br) coded a little program to show this limitation: ftp://ftp.elipse.com.br/pub/about1/about1-src.tar.gz I just created a bug entry on bugs.winehq: http://bugs.winehq.com/show_bug.cgi?id=1280 Could someone help me with this? Thanks a lot and kind regards, Felipe

1 0

Re: For your consideration, here's a preview of some new seh_try_macros-type
by Rolf Kalbermatter 14 Feb '03

14 Feb '03

Dan Kegel <dank(a)kegel.com> wrote: >Alexandre Julliard wrote: >> There are people building Wine with the Sun compiler. Also it makes >> sense for at least some dlls to allow building them with MSVC to test >> them under Windows. And in general using different compilers is a good >> way to shake out bugs from the code. > >I always build my conformance tests both in the normal way >and standalone with msvc. >IMHO every executable and DLL we do should run on Windows, too, >if it doesn't absolutely have to make Unix system calls. I regularly compile some of the DLLs under MSVC. The current state of DLLs is so that the non core DLLs compile usually almost fine but linking is a quite big issue I haven't fully tackled. If I link with the MSCV libs I get often undefined imports and linking with MSVC generated import libs from Wine source requires some hand work, as the MSVC IDE only generates the import lib AFTER the entire DLL has been successfully created, so you get sort of a catch 22 situation. Another issue is that most of the DLLs are not yet in a state where they can possibly be put into a current Windows installation, without causing all sorts of crashes and weird problems. The interdependencies between DLLs in a W2K installation is really enormous and a lot of functions in the Wine DLLs are not yet implemented or not fully complient. Rolf Kalbermatter

2 1

DirectSound problems
by Matthieu Foillard 14 Feb '03

14 Feb '03

It seems that there is a bug with DirectSound. Using Half-life, when i start the console, it goes into un infinite loop : $ /usr/bin/wine --debugmsg +dsound Program\ Files/Half-Life/hl.exe -- -opengl -game cstrike -windowed -console -noipx 2> /tmp/log it says : ... warn:dsound:DSOUND_MixCancelAt (0x403f6318, 0), buf_mixpos=25296 trace:dsound:IDirectSoundBufferImpl_Unlock (0x403f6318,0x403f6410,65536,(nil),0):stub trace:dsound:IDirectSoundBufferImpl_Lock (0x403f6318,0,65536,0x40760064,0x40760054,0x4076005c,0x40760058,0x00000000) at 60129 trace:dsound:IDirectSoundBufferImpl_Lock ->65536.0 trace:dsound:IDirectSoundBufferImpl_Lock locking prebuffered region, ouch warn:dsound:DSOUND_MixCancelAt (0x403f6318, 0), buf_mixpos=25296 trace:dsound:IDirectSoundBufferImpl_Unlock (0x403f6318,0x403f6410,65536,(nil),0):stub trace:dsound:IDirectSoundBufferImpl_Lock (0x403f6318,0,65536,0x40760064,0x40760054,0x4076005c,0x40760058,0x00000000) at 60129 trace:dsound:IDirectSoundBufferImpl_Lock ->65536.0 trace:dsound:IDirectSoundBufferImpl_Lock locking prebuffered region, ouch ... Over and over and the game console is "lock". If I disable sound (by comment out oss driver in ~/.wine/config) it works fine. I have this problem using both oss and arts driver. Sometimes after some times, it works and the game console unlocks and all goes fine. Sometimes i wait for a long time and it never works. i have an es1370 sound card, kernel 2.4.20, /dev/dsp0 and /dev/dsp1 are both working. It seems that the game menu use /dev/dsp1 and the game itself (e.g. the console) uses /dev/dsp0. I can't explain this. Thanks for your help mgf -- Matthieu Foillard <m.foillard(a)taktile.com> tel : 0146090496 - gsm : 0686574170 pgp : 0x1609654F

1 0

Re: wine/dlls/comctl32 listview.c
by Rein Klazes 14 Feb '03

14 Feb '03

On Tue, 11 Feb 2003 16:17:31 -0600, you wrote: > Modified files: > dlls/comctl32 : listview.c > > Log message: > Dimitrie O. Paun <dpaun(a)rogers.com> > Compute matrix of first paint when we actually have some items > (problem first spotted & debugged by Duane Clark). This causes a rgeression in newsbin. The listview with the headers do not update during a "retrieve all headers". Until something else triggers a redraw, eg uncover window pane. From then everything works as expected. Rein. -- Rein Klazes rklazes(a)xs4all.nl

3 3

named pipes still broken?
by Dan Kegel 14 Feb '03

14 Feb '03

Is it just me, or are named pipes broken for other people, too? In my tests, Wine can create named pipes, but the reading side can't open them. (Even without my recent changes to sync.c which added filename checking.) - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

Re: 2GB visible partition size
by Duane Clark 14 Feb '03

14 Feb '03

Tony Lambregts wrote: > Alexandre Julliard wrote: >> >>Well, yes, if we really need to change the fstype it should be a >>generic option that allows all types to be specified, not just >>NTFS. And it shouldn't overload the existing "type" parameter, it >>should be a separate entry. >> > OK. I guess my biggest problem with this is that the most obvious name > for this entry is "Filesytem" which is already used <g>. Since the parameter of interest is specifically named "fsname" rather than "fstype" or "Filesystem", perhaps that should be the configurable parameter name. I would think that would eliminate any confusion.

2 1

For your consideration, here's a preview of some new seh_try_macros-type stuff...
by Gregory M. Turner 14 Feb '03

14 Feb '03

Let me know what you think of these. So far, I like them better than the original versions, although in solving some limitations of the old macros, I've created some new ones. This version avoids ({ }) entirely, in favor of Ove's original thought, which was to use __LINE__; therefore, putting multiple __(finally|except) clauses in the same line probably breaks. Otherwise, these are better macros. They are slightly more easily understood (although still pretty darn confusing, especially in the debugger), probably more resiliant against compiler optimizations, and have much less awful performance. Best of all, they ought to properly re-raise exceptions after executing finally clauses. There is some cruft in there, btw, which will be fixed before I submit anything to patches. They still break break/continue, of course, since they still rely on __TRY / __EXCEPT blocks to do the dirty-work. You can run the original seh_macros.c test against these successfully, except for the "absurdly nested" ones which use macros and presumably would fail quite dramatically due to __LINE__ duplications. FWIW, compared to the degree of "pressing need" for these macros, I have already spent way too much time on them... But the old ones kind of sucked, and, frankly, it's a fun semantic puzzle that requires pusing the limits of good old cpp just a _bit_ further than may have been intended ... so, here it is. Note that I'm declaring a variable in the header file here. I guess, I should fix this by creating an internal API in ntdll? I never quite figured out whether global non-static variables in a dll are thread-local, or what... (same for lexically scoped static ones -- real clueless here, and building a new system so I don't have much doco's at my fingertips ATM) Sooo.... Anyone want to help me decide what's the best way to get a thread-local global variable instantiated? Probably, my previous attempt with TlsAlloc was semantically correct, but that was /way/ too fat a solution, I'd like something much quicker if its at all possible. Otherwise this won't be threadsafe, which seems like a bad call, esp. since such code will probably end up being used to guard against unacceptable resource leakage.. warning, cut-and-pasted this patch in chunks so it might be bugged... should be clear enough how to duplicate, however, if it fails... --- ../wine.vanilla/include/wine/exception.h 2003-01-29 21:50:14.000000000 -0600 +++ ./include/wine/exception.h 2003-02-09 01:33:45.000000000 -0600 @@ -21,8 +21,12 @@ #ifndef __WINE_WINE_EXCEPTION_H #define __WINE_WINE_EXCEPTION_H +/* WRC can't find setjmp.h. Does it not check /usr/include? */ +#if (!(defined(__WRC__))) + #include <setjmp.h> #include "windef.h" +#include "excpt.h" /* The following definitions allow using exceptions in Wine and Winelib code * @@ -59,6 +63,16 @@ * You can use them to leave a __EXCEPT block though. * * -- AJ + * + * Now we can implement the __try/__except/__finally magic of VC++ as standard (?) macros. + * this is a "good enough" implementation, it's incomplete, but should suffice for most uses. + * + * The macros require some symbols to be found in ntdll.dll.so, so link with that DLL if you + * use them. + * + * If you are using VC++ and this header, #define USE_COMPILER_EXCEPTIONS before you include it. + * + * -gmt */ /* Define this if you want to use your compiler built-in __try/__except support. @@ -146,8 +160,90 @@ extern DWORD __wine_finally_handler( PEXCEPTION_RECORD record, EXCEPTION_FRAME *frame, CONTEXT *context, LPVOID pdispatcher ); + +#if (!defined(NO_VC_SEH_MACROS)) + +#ifndef _WINE_ALREADY_DEFINED_SEH_MACROS__ +#define _WINE_ALREADY_DEFINED_SEH_MACROS__ + +/* fixme: should be renamed since these are used for except too */ +typedef void (*__p_seh_finally_executer) (); +typedef void (*__p_seh_dotry_executer) (__p_seh_finally_executer); +__p_seh_finally_executer __thread_outermost_handler_ptr; + +#define __SEH_LINEUNIQ_CAT2(x,y) __SEH_LINEUNIQ_ ## y ## x +#define __SEH_LINEUNIQ_CAT1(x,y) __SEH_LINEUNIQ_CAT2(x,y) + +#define __SEH_LINEUNIQ_NULLMACRO(x) x +#define __SEH_LINEUNIQ_MAGIC_LINE __SEH_LINEUNIQ_NULLMACRO( __LINE__ ) + +#define __SEH_LINEUNIQ_ID(x) __SEH_LINEUNIQ_CAT1( __SEH_LINEUNIQ_MAGIC_LINE , x ) + +#define __try \ + do { \ + void dotry(__p_seh_finally_executer fin) { \ + __label__ __seh_macro_exit_spot; \ + auto WINE_EXCEPTION_FILTER(__wine_seh_macro_exception_handler); \ + __TRY { \ + { \ + +#define __finally \ + } \ + __seh_macro_exit_spot: \ + if (0) goto __seh_macro_exit_spot; \ + } __EXCEPT( __wine_seh_macro_exception_handler ) { \ + } __ENDTRY \ + (*fin)(); \ + WINE_EXCEPTION_FILTER(__wine_seh_macro_exception_handler) { \ + (*fin)(); \ + return EXCEPTION_CONTINUE_SEARCH; \ + } \ + } \ + goto __SEH_LINEUNIQ_ID(DETOUR); \ + __SEH_LINEUNIQ_ID(RETOUR): \ + dotry( __thread_outermost_handler_ptr ); \ + } while (0); \ + goto __SEH_LINEUNIQ_ID(AFTERFINALLY); \ + auto void __SEH_LINEUNIQ_ID(Finally_Executer) (); \ + __SEH_LINEUNIQ_ID(DETOUR): \ + __thread_outermost_handler_ptr = & __SEH_LINEUNIQ_ID(Finally_Executer); \ + goto __SEH_LINEUNIQ_ID(RETOUR); \ + __SEH_LINEUNIQ_ID(AFTERFINALLY): ; \ + void __SEH_LINEUNIQ_ID(Finally_Executer) () + +#define __except(...) \ + } \ + __seh_macro_exit_spot: \ + if (0) goto __seh_macro_exit_spot; \ + } __EXCEPT( __wine_seh_macro_exception_handler ) { \ + (*fin)(); \ + } __ENDTRY \ + WINE_EXCEPTION_FILTER(__wine_seh_macro_exception_handler) { \ + return ( __VA_ARGS__ ); \ + } \ + } \ + goto __SEH_LINEUNIQ_ID(DETOUR); \ + __SEH_LINEUNIQ_ID(RETOUR): \ + dotry( __thread_outermost_handler_ptr ); \ + } while (0); \ + goto __SEH_LINEUNIQ_ID(AFTEREXCEPT); \ + auto void __SEH_LINEUNIQ_ID(Except_Executer) (); \ + __SEH_LINEUNIQ_ID(DETOUR): \ + __thread_outermost_handler_ptr = & __SEH_LINEUNIQ_ID(Except_Executer); \ + goto __SEH_LINEUNIQ_ID(RETOUR); \ + __SEH_LINEUNIQ_ID(AFTEREXCEPT): ; \ + void __SEH_LINEUNIQ_ID(Except_Executer) () + +#define __leave goto __seh_macro_exit_spot + +#endif /* _WINE_ALREADY_DEFINED_SEH_MACROS__ */ + +#endif /* NO_VC_SEH_MACROS */ + #endif /* USE_COMPILER_EXCEPTIONS */ +#endif /* __WRC__ */ + static inline EXCEPTION_FRAME * WINE_UNUSED __wine_push_frame( EXCEPTION_FRAME *frame ) { #if defined(__GNUC__) && defined(__i386__) -- gmt

4 6

wcmd autoexec.bat?
by J. Grant 14 Feb '03

14 Feb '03

Hello I have been testing wcmd to automate some process I used to use on win98. However I can not find the autoexec.bat for wcmd? Currently the wcmd shell starts up with no prompt, this has to be corrected in my batch files. prompt $p$g etc. Wine seems to have 2 autoexec.bat's but does not seem to ever use them. /var/lib/wine/autoexec.bat never seems to be executed. Neither is the one I created in my fake c drive (/home/now3d/.wine/c/autoexec.bat) Is this issue known? are their any workarounds? Regards JG

3 4

Keyboard shortcut to disable DXGrab?
by Matthew Toseland 14 Feb '03

14 Feb '03

What would be involved in implementing a keyboard shortcut (ideally configurable) to temporarily disable DXGrab, when playing a game in a window? If such a thing was done, would it be accepted into the source? -- Matthew Toseland toad@amphibian.dyndns.org/amphibian@users.sourceforge.net Full time freenet hacker. http://freenetproject.org/ Freenet Distribution Node (temporary) at http://amphibian.dyndns.org:8889/ahNdJC6opVw/ ICTHUS.

1 0

Re: popupmenu itemsize
by Uwe Bonnes 14 Feb '03

14 Feb '03

>>>>> "Christian" == Christian Kristukat <semmel(a)hoc.net> writes: Christian> Hi, I suspect that this again is a dirty patch but it helps Christian> in working with Microcal Origin. Maybe a more skilled person Christian> than me finds the real origin of this problem. At one point Christian> in the program a popup menu opens but only the items' width Christian> is calculated correctly, the height is not, in fact it is Christian> equal zero. For that case I added an arbitrarily chosen Christian> height of 12 points and it works fine. Here's the patch: ... Christian> lpitem->rect.bottom += 12; + Nagic constants mostly are evil? It the "12" perhaps related to some SYSPARAMS? ... Christian> PS: By the way: every cvs operation (update, diff) hangs Christian> after processing the last directory. However it seems to be Christian> complete and pressing CTRL-C seems not to corrupt Christian> anything. Any ideas? Are you using rhlx01.fht-esslingen.de? Andi works on that problem then. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 2

suspended threads acquiring synchronization objects
by Peter Hunnisett 14 Feb '03

14 Feb '03

Howdy, we've discovered that windows seems to not allow suspended threads to acquire synchronization objects, which make really really good sense, while wine does. I've attached a simple test case, the code for the test case and a ReWind licensed patch for the problem. Would people have a look at the patch and let me know if it's the best way to fix it, or if I've missed anything? Thanks, Peter peter(a)transgaming.com

3 2

Error in the server thread id fix
by Bill Medland 13 Feb '03

13 Feb '03

Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers? As a result ACCPAC for Windows' main desktop process shuts down after about a minute, but leaves various other processes running. I'll have a look at it but I don't know how successful I'll be. -- Bill Medland ACCPAC International, Inc. medbi01(a)accpac.com Corporate: www.accpac.com Hosted Services: www.accpaconline.com

4 7

2GB visible partition size
by J. Grant 13 Feb '03

13 Feb '03

Hello, I noticed there is a 2GB visible partition size. This seems to be like FAT16, however I am running on ext3, is there a config option I can set to remove this limit? Regards JG

4 5

Looking for information on implemented API's in wine
by David Miller 13 Feb '03

13 Feb '03

I am ready to begin work on the actual database aspect of cross referencing the windows dlls. As part of the database I would like to include the status of a given API in wine so it will be possible to do things like query for all unimplemented APIs in a given dll. The first questions I have are whether or not I can depend on the spec files to give a complete list, and can someone either point me to documentation on the spec files or explain everything I need to know in order to determine the status of APIs defined there?

1 0

CreateNamedPipe questions
by Dan Kegel 13 Feb '03

13 Feb '03

Oddly enough, it looks like it's ok to pass NULL as the filename to CreateNamedPipe. Anyone know what programs do that, and why? Here's a patch that makes our CreateNamedPipe check for legal filenames (or NULL). It should probably allow forward slashes... The patch also adds a quickie regression test, but I still have to use late binding for CreateNamedPipe (or is it ok for the test to fail on win9x?). Would this test have caught the recent named pipe breakage? If not, what would I need to add? Comments welcome; I'll send it to wine-patches after addressing any feedback. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: dlls/kernel/sync.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/sync.c,v retrieving revision 1.26 diff -u -p -u -r1.26 sync.c --- dlls/kernel/sync.c 25 Oct 2002 21:02:30 -0000 1.26 +++ dlls/kernel/sync.c 13 Feb 2003 07:47:27 -0000 @@ -508,6 +508,8 @@ HANDLE WINAPI CreateNamedPipeW( LPCWSTR { HANDLE ret; DWORD len = name ? strlenW(name) : 0; + static const WCHAR leadin[] = {'\\','\\','.','\\','P','I','P','E'}; + int i; TRACE("(%s, %#08lx, %#08lx, %ld, %ld, %ld, %ld, %p)\n", debugstr_w(name), dwOpenMode, dwPipeMode, nMaxInstances, @@ -516,7 +518,13 @@ HANDLE WINAPI CreateNamedPipeW( LPCWSTR if (len >= MAX_PATH) { SetLastError( ERROR_FILENAME_EXCED_RANGE ); - return 0; + return INVALID_HANDLE_VALUE; + } + /* FIXME: can name really be NULL?! */ + if (name && strncmpiW(name, leadin, sizeof(leadin)/sizeof(leadin[0]))) + { + SetLastError( ERROR_INVALID_NAME ); + return INVALID_HANDLE_VALUE; } SERVER_START_REQ( create_named_pipe ) { Index: dlls/kernel/tests/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/kernel/tests/Makefile.in,v retrieving revision 1.6 diff -u -p -u -r1.6 Makefile.in --- dlls/kernel/tests/Makefile.in 4 Oct 2002 17:42:27 -0000 1.6 +++ dlls/kernel/tests/Makefile.in 13 Feb 2003 07:47:27 -0000 @@ -17,6 +17,7 @@ CTESTS = \ generated.c \ locale.c \ path.c \ + pipe.c \ process.c \ thread.c --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ dlls/kernel/tests/pipe.c 2003-02-12 23:44:20.000000000 -0800 @@ -0,0 +1,109 @@ +/* + * Unit tests for named pipe functions in Wine + * + * Copyright (c) 2002 Dan Kegel + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <stdlib.h> +#include <stdio.h> +#include <time.h> + +#ifndef STANDALONE +#include "wine/test.h" +#else +#include <assert.h> +#define START_TEST(name) main(int argc, char **argv) +#define ok(condition, msg) assert(condition) +#endif + +#include <windef.h> +#include <winbase.h> +#include <winerror.h> +#include <wtypes.h> + +#define PIPENAME "\\\\.\\PiPe\\tests_" __FILE__ + +void test_CreateNamedPipeA(void) +{ + HANDLE hnp; + HANDLE hFile; + const char obuf[] = "Bit Bucket"; + char ibuf[32]; + DWORD written; + DWORD gelesen; + + /* Bad parameter checks */ + hnp = CreateNamedPipeA("not a named pipe", + PIPE_ACCESS_DUPLEX, PIPE_TYPE_BYTE|PIPE_WAIT, + /* nMaxInstances */ 1, + /* nOutBufSize */ 1024, + /* nInBufSize */ 1024, + /* nDefaultWait */ NMPWAIT_USE_DEFAULT_WAIT, + /* lpSecurityAttrib */ NULL); + + ok(hnp == INVALID_HANDLE_VALUE && GetLastError() == ERROR_INVALID_NAME, + "CreateNamedPipe should fail if name doesn't start with \\\\.\\pipe"); + +#if 0 /* Evidently it's ok in windows to pass NULL as the pipe name! */ + hnp = CreateNamedPipeA(NULL, + PIPE_ACCESS_DUPLEX, PIPE_TYPE_BYTE|PIPE_WAIT, + 1, 1024, 1024, NMPWAIT_USE_DEFAULT_WAIT, NULL); + ok(hnp == INVALID_HANDLE_VALUE && GetLastError() == ERROR_INVALID_NAME, + "CreateNamedPipe should fail if name is NULL"); +#endif + + /* Functional checks */ + + hnp = CreateNamedPipeA(PIPENAME, + PIPE_ACCESS_DUPLEX, PIPE_TYPE_BYTE|PIPE_WAIT, + /* nMaxInstances */ 1, + /* nOutBufSize */ 1024, + /* nInBufSize */ 1024, + /* nDefaultWait */ NMPWAIT_USE_DEFAULT_WAIT, + /* lpSecurityAttrib */ NULL); + ok(hnp != INVALID_HANDLE_VALUE, "CreateNamedPipe failed"); + + hFile = CreateFileA(PIPENAME, GENERIC_READ|GENERIC_WRITE, 0, + NULL, OPEN_EXISTING, 0, 0); + ok(hFile != INVALID_HANDLE_VALUE, "CreateFile failed"); + if (hFile == INVALID_HANDLE_VALUE) + return; + + /* Make sure we can read and write a few bytes in both directions*/ + memset(ibuf, 0, sizeof(ibuf)); + ok(WriteFile(hnp, obuf, sizeof(obuf), &written, NULL), "WriteFile"); + ok(written == sizeof(obuf), "write file len"); + ok(ReadFile(hFile, ibuf, sizeof(obuf), &gelesen, NULL), "ReadFile"); + ok(gelesen == sizeof(obuf), "read file len"); + ok(memcmp(obuf, ibuf, written) == 0, "content check"); + + memset(ibuf, 0, sizeof(ibuf)); + ok(WriteFile(hFile, obuf, sizeof(obuf), &written, NULL), "WriteFile"); + ok(written == sizeof(obuf), "write file len"); + ok(ReadFile(hnp, ibuf, sizeof(obuf), &gelesen, NULL), "ReadFile"); + ok(gelesen == sizeof(obuf), "read file len"); + ok(memcmp(obuf, ibuf, written) == 0, "content check"); + + CloseHandle(hFile); + CloseHandle(hnp); +} + +START_TEST(pipe) +{ + test_CreateNamedPipeA(); +} +

3 4

Fix for Treeview Regression in Putty, winamp, et al.
by Drew "DanteAliegri" Ogle 13 Feb '03

13 Feb '03

Putty and winamp use dialogs which contain treeviews. When the treeview code sets values to be passed to the callback function, it decides there if it is returning to A or W. When it is returning to a dialog, it returns a W, however, when the user code which the dialog calls is an A function, it excepts TVN_*A, when the treeview code is sending TVN_*W. The most logical place to test for this, was in DefDlgProcW, which then modifies the code when it finds a) the msg to be WM_NOTIFY b) the lParam to be non-null c) the code to be of W form d) the code to be of a TVN_ type. As this is my second real patch, any comments are welcome :) -Dante Index: windows/defdlg.c =================================================================== RCS file: /home/wine/wine/windows/defdlg.c,v retrieving revision 1.29 diff -u -r1.29 defdlg.c --- windows/defdlg.c 14 Jan 2003 19:29:15 -0000 1.29 +++ windows/defdlg.c 13 Feb 2003 05:39:00 -0000 @@ -395,12 +395,22 @@ LRESULT WINAPI DefDlgProcW( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) { BOOL result = FALSE; + BOOL forWide = FALSE; WNDPROC dlgproc; + /* make sure we only change TVN_ codes. */ + if( msg == WM_NOTIFY && lParam && ((LPNMHDR)lParam)->code & 0x30 ) + forWide = TRUE; SetWindowLongW( hwnd, DWL_MSGRESULT, 0 ); if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) { + /* if call was meant for a W funcition, but the callback + * is really an A function, change the code from a W code + * to a A code. + **/ + if( forWide && (WINPROC_GetProcType( dlgproc) == WIN_PROC_32A )) + ((LPNMHDR)lParam)->code += 0x31; /* Call dialog procedure */ result = CallWindowProcW( dlgproc, hwnd, msg, wParam, lParam ); /* 16 bit dlg procs only return BOOL16 */

2 2

Re: wine-devel digest, Vol 1 #1689 - 17 msgs
by ATMRD＠aol.com 13 Feb '03

13 Feb '03

Hey, > I am running Gnome on a variant of FreeBSD called Darwin. It shoudln't matter what window manager your running be it Apple's Aqua, or Gnome or KDE, as long as the X11, libraries are installed, because regardless Darwin is still the core of the OS. > Darwin runs > on PPC architecture opposed to x86 architecture. My question is can > Wine run on this variant of FreeBSD? Theoritically Wine should run on any version of FreeBSD, however due to Darwin's arhicteture, allthough it is FreeBSD based,which does not use the ELF format but isntead the Mach-O, wine does not work correctly or at all to my knowledge. > Can I download the source and > build Wine for my system? You can try, but I dont think it will work with out major modification to some of the core libs wich are X86 dependant. If for some reason it does I'd be dilighted to hear about it. There is a project called darwine, at http://darwine.sf.net, you can find more information about running wine on Darwin there. Hope this helps ~Sanjay Connare.

1 0

Re: [ros-kernel] Cool!
by Steven Edwards 13 Feb '03

13 Feb '03

Thought you guys might like to see this. We are making major progress on 3rd party drivers --- Ge van Geldorp <ge(a)gse.nl> wrote: > Attached is a screen capture of GDITEST.EXE. You might think "what's so > cool about that, gditest has been running for a while now". Well, look > again. Note the lines starting in the top-left and running to the bottom > and right side. They're in real RGB(64, 64, 128), not in the gray to > which they're mapped when you're running on a 16 color VGA display! > > The screen capture was taken from ReactOS running in a VMware virtual > machine, using the 3rd party VMware 16 bit per pixel video driver. > > It will take me some more time to finish this. Although GDITEST.EXE > works, WINHELLO.EXE doesn't yet. There is some cleanup still to be done > and I need to do some more testing to make sure I didn't break the > existing VGA video drivers (VGAMP.SYS/VGADDI.DLL). However, I think > support for at least some 3rd party video drivers is within reach now. > > G� van Geldorp. > > ATTACHMENT part 2 image/gif name=gditest.gif __________________________________________________ Do you Yahoo!? Yahoo! Shopping - Send Flowers for Valentine's Day http://shopping.yahoo.com

1 0

RegisterHotKey help needed
by Robert Reif 13 Feb '03

13 Feb '03

I have a program that uses RegisterHotKey and UnregisterHotKey. Is anyone working on implementing this or does anyone have any pointers on how to implement this myself? Thanks, Bob.

1 0

X11 Clipboard implementation
by Mike Hearn 12 Feb '03

12 Feb '03

Hi all, I've been poking around inside the wine clipboard system, in an attempt to make it properly compliant with the agreed upon specs over at http://www.freedesktop.org/standards/clipboards.txt At the moment, Wine mixes up CLIPBOARD and PRIMARY, which is not a good idea. Ideally, Wine would work like GTK, Qt, Mozilla and all the rest do, which is to keep CLIPBOARD for ctrl-c, ctrl-v type operations, and primary for selected text/middle click. When you select some text in say notepad, both CLIPBOARD and PRIMARY are grabbed, which is wrong, only primary should be grabbed. In a similar fashion, when you select Edit | Copy only CLIPBOARD should be grabbed. Currently, selecting text in Wine doesn't do anything (at least, not in notepad). So, the obvious way to fix that would be to introduce a new Wine-specific API, that lets the Wine controls call SetSelectedText or something, which then interfaces with X. So, I think x11drv/clipboard.c should be changed to basically eliminate references to PRIMARY, as without the ability to deal with middle clicks and grab-on-select, Wine has no business changing that selection. Therefore my questions are: 1) Should I try and hack up a patch to stop wine using PRIMARY? 2) What are the rules governing new wine specific APIs. I know the DLL Separation work is supposed to eliminate them, but there are no FAQs anywhere on it that I can see, could somebody explain this please? thanks -mike -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

6 9

those stupid diff scripts again...
by Gregory M. Turner 12 Feb '03

12 Feb '03

Here's my latest versions of winetreediff and winetreediff_excl. I'm not sure anybody but me is actually using these, but since I have fixed several bugs and added some features.... here you go. License is bugroff as usual. -- gmt "Once a nation becomes a democracy, the whole purpose of government changes. Instead of the government's goal being that of guaranteeing liberty, equal justice, private property, and voluntary exchange, the government embarks on the impossible task of achieving economic equality, micromanaging the economy, and protecting citizens from themselves and all their activities. The destruction of the wealth-building process, which is inherent in a free society, is never anticipated. Once it's realized that it has been undermined, it is too late to easily reverse the attacks against limited government and personal liberty." -- Ron Paul

1 0

PATCH: Get rid of superfluous dup() and close() calls.
by Martin Wilck 12 Feb '03

12 Feb '03

patch: dup.diff Get rid of superfluous dup() and close() calls. Modified files: dlls/kernel/comm.c | 25 ------------------ dlls/ntdll/file.c | 2 - dlls/ntdll/virtual.c | 5 --- dlls/winsock/socket.c | 68 +------------------------------------------------- files/file.c | 15 ----------- files/smb.c | 1 include/async.h | 1 scheduler/client.c | 1 Comment: The dup() in wine_server_handle_to_fd() requires dozens of close() calls spread over the wine code. I think this is confusing and error-prone (close() calls are easily forgotten, leading to rapid fd leak - actually, when looking through the code, I found a number of functions where I had expected a close(), but it was lacking). Moreover, I can't see why that dup() is necessary (any more). If there are still some points in the code where the dup() is really required, I strongly recommend to insert explicit dup()s in the respective functions after calling wine_server_handle_to_fd(). I have carried out a number of IO intensive tests with no problems. I'd like people to test the COMM port stuff, though, and watch the number of file descriptors. Other IO- and Network-bound tests would be very welcome. If this is absolutely dumb, please tell me why. Forwarding to wine-devel, 'cause it's pretty intrusive. Index: dlls/kernel/comm.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/comm.c,v retrieving revision 1.68 diff -u -r1.68 comm.c --- dlls/kernel/comm.c 25 Oct 2002 21:02:30 -0000 1.68 +++ dlls/kernel/comm.c 24 Jan 2003 14:13:32 -0000 @@ -516,7 +516,6 @@ return FALSE; } result = ioctl(fd,TIOCSBRK,0); - close(fd); if (result ==-1) { TRACE("ioctl failed\n"); @@ -556,7 +555,6 @@ return FALSE; } result = ioctl(fd,TIOCCBRK,0); - close(fd); if (result ==-1) { TRACE("ioctl failed\n"); @@ -598,7 +596,6 @@ if (tcgetattr(fd,&port) == -1) { COMM_SetCommError(handle,CE_IOE); - close(fd); return FALSE; } @@ -670,7 +667,6 @@ if (!direct) if (tcsetattr(fd, TCSADRAIN, &port) == -1) { - close(fd); COMM_SetCommError(handle,CE_IOE); return FALSE; } else @@ -685,7 +681,6 @@ else result = TRUE; } - close(fd); return result; } @@ -726,7 +721,6 @@ tcflush(fd,TCOFLUSH); if(flags&PURGE_RXCLEAR) tcflush(fd,TCIFLUSH); - close(fd); return 1; } @@ -782,8 +776,6 @@ handle, lpStat->cbInQue, lpStat->cbOutQue); } - close(fd); - COMM_GetCommError(handle, errors); COMM_SetCommError(handle, 0); @@ -817,7 +809,6 @@ FIXME("handle %p not found?\n",handle); return FALSE; } - close(fd); return TRUE; } @@ -916,7 +907,6 @@ if ((tcgetattr(fd,&port)) == -1) { int save_error = errno; COMM_SetCommError(handle,CE_IOE); - close( fd ); ERR("tcgetattr error '%s'\n", strerror(save_error)); return FALSE; } @@ -1023,7 +1013,6 @@ COMM_SetCommError(handle,IE_BAUDRATE); - close( fd ); ERR("baudrate %ld\n",lpdcb->BaudRate); return FALSE; } @@ -1089,7 +1078,6 @@ #endif default: COMM_SetCommError(handle,IE_BAUDRATE); - close( fd ); ERR("baudrate %ld\n",lpdcb->BaudRate); return FALSE; } @@ -1132,7 +1120,6 @@ port.c_iflag &= ~INPCK; } else { COMM_SetCommError(handle,IE_BYTESIZE); - close( fd ); ERR("Cannot set MARK Parity\n"); return FALSE; } @@ -1143,7 +1130,6 @@ port.c_iflag &= ~INPCK; } else { COMM_SetCommError(handle,IE_BYTESIZE); - close( fd ); ERR("Cannot set SPACE Parity\n"); return FALSE; } @@ -1151,7 +1137,6 @@ #endif default: COMM_SetCommError(handle,IE_BYTESIZE); - close( fd ); ERR("Parity\n"); return FALSE; } @@ -1173,7 +1158,6 @@ break; default: COMM_SetCommError(handle,IE_BYTESIZE); - close( fd ); ERR("ByteSize\n"); return FALSE; } @@ -1188,7 +1172,6 @@ break; default: COMM_SetCommError(handle,IE_BYTESIZE); - close( fd ); ERR("StopBits\n"); return FALSE; } @@ -1219,12 +1202,10 @@ if (tcsetattr(fd,TCSANOW,&port)==-1) { /* otherwise it hangs with pending input*/ int save_error=errno; COMM_SetCommError(handle,CE_IOE); - close( fd ); ERR("tcsetattr error '%s'\n", strerror(save_error)); return FALSE; } else { COMM_SetCommError(handle,0); - close( fd ); return TRUE; } } @@ -1262,10 +1243,8 @@ int save_error=errno; ERR("tcgetattr error '%s'\n", strerror(save_error)); COMM_SetCommError(handle,CE_IOE); - close( fd ); return FALSE; } - close( fd ); #ifndef __EMX__ #ifdef CBAUD speed= (port.c_cflag & CBAUD); @@ -1465,7 +1444,6 @@ else { r = (1 == write(fd, &chTransmit, 1)); - close(fd); } return r; @@ -1593,7 +1571,6 @@ FIXME("tcsetattr on fd %d failed!\n",fd); return FALSE; } - close(fd); return TRUE; } @@ -1619,7 +1596,6 @@ if(fd<0) return FALSE; result = ioctl(fd, TIOCMGET, &mstat); - close(fd); if (result == -1) { WARN("ioctl failed\n"); @@ -1702,7 +1678,6 @@ ovp = (async_commio*) HeapAlloc(GetProcessHeap(), 0, sizeof (async_commio)); if(!ovp) { - close(fd); return FALSE; } Index: dlls/ntdll/file.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/file.c,v retrieving revision 1.20 diff -u -r1.20 file.c --- dlls/ntdll/file.c 7 Jan 2003 20:36:28 -0000 1.20 +++ dlls/ntdll/file.c 24 Jan 2003 14:13:35 -0000 @@ -237,8 +237,6 @@ } while ( (result == -1) && ((errno == EAGAIN) || (errno == EINTR)) ); - close( fd ); - if (result == -1) { return IoStatusBlock->u.Status = NTFILE_errno_to_status(errno); Index: dlls/ntdll/virtual.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/virtual.c,v retrieving revision 1.4 diff -u -r1.4 virtual.c --- dlls/ntdll/virtual.c 7 Jan 2003 20:36:28 -0000 1.4 +++ dlls/ntdll/virtual.c 24 Jan 2003 14:13:39 -0000 @@ -736,13 +736,11 @@ VIRTUAL_SetProt( view, ptr + sec->VirtualAddress, size, vprot ); } - close( fd ); *addr_ptr = ptr; return STATUS_SUCCESS; error: if (ptr != (char *)-1) munmap( ptr, total_size ); - close( fd ); return status; } @@ -1408,7 +1406,6 @@ } res = map_image( handle, unix_handle, base, size_low, header_size, shared_fd, shared_size, removable, addr_ptr ); - if (shared_fd != -1) close( shared_fd ); if (!res) *size_ptr = size_low; return res; } @@ -1484,12 +1481,10 @@ res = STATUS_NO_MEMORY; goto error; } - if (unix_handle != -1) close( unix_handle ); *size_ptr = size; return STATUS_SUCCESS; error: - if (unix_handle != -1) close( unix_handle ); if (ptr != (void *)-1) munmap( ptr, size ); return res; } Index: dlls/winsock/socket.c =================================================================== RCS file: /home/wine/wine/dlls/winsock/socket.c,v retrieving revision 1.117 diff -u -r1.117 socket.c --- dlls/winsock/socket.c 23 Jan 2003 21:20:36 -0000 1.117 +++ dlls/winsock/socket.c 24 Jan 2003 14:13:51 -0000 @@ -336,7 +336,6 @@ if ( ( (access & GENERIC_READ) && (*flags & FD_FLAG_RECV_SHUTDOWN ) ) || ( (access & GENERIC_WRITE) && (*flags & FD_FLAG_SEND_SHUTDOWN ) ) ) { - close (fd); WSASetLastError ( WSAESHUTDOWN ); return -1; } @@ -578,7 +577,6 @@ else wsfds16->fd_array[j++] = wsfds16->fd_array[i]; } - close(fd); lfd[i] = -1; } } @@ -593,24 +591,6 @@ return num_err; } -static void fd_set_unimport( void* wsfds, int lfd[], BOOL b32 ) -{ - if ( wsfds ) - { -#define wsfds16 ((ws_fd_set16*)wsfds) -#define wsfds32 ((WS_fd_set*)wsfds) - int i, count = (b32) ? wsfds32->fd_count : wsfds16->fd_count; - - for( i = 0; i < count; i++ ) - if ( lfd[i] >= 0 ) - close(lfd[i]); - - TRACE("\n"); -#undef wsfds32 -#undef wsfds16 - } -} - static int do_block( int fd, int mask ) { fd_set fds[3]; @@ -1417,7 +1397,6 @@ SetLastError(_get_sock_error(s, FD_ACCEPT_BIT)); /* FIXME: care about the error? */ } - close(fd); SERVER_START_REQ( accept_socket ) { req->lhandle = SOCKET2HANDLE(s); @@ -1516,7 +1495,6 @@ ws_sockaddr_free(uaddr,name); } } - close(fd); } else { @@ -1613,7 +1591,6 @@ { SetLastError(wsaErrno()); } - close(fd); } else { @@ -1622,7 +1599,6 @@ return SOCKET_ERROR; connect_success: - close(fd); _enable_event(SOCKET2HANDLE(s), FD_CONNECT|FD_READ|FD_WRITE, FD_WINE_CONNECTED|FD_READ|FD_WRITE, FD_CONNECT|FD_WINE_LISTENING); @@ -1690,7 +1666,6 @@ res=0; } ws_sockaddr_free(uaddr,name); - close(fd); } else { @@ -1755,7 +1730,6 @@ { res=0; } - close(fd); } else { @@ -1820,12 +1794,10 @@ } else { if (getsockopt(fd, (int) level, optname, optval, optlen) == 0 ) { - close(fd); return 0; } SetLastError((errno == EBADF) ? WSAENOTSOCK : wsaErrno()); } - close(fd); } return SOCKET_ERROR; } @@ -1966,7 +1938,6 @@ if (numInt < 0) { ERR ("Unable to open /proc filesystem to determine number of network interfaces!\n"); - close(fd); WSASetLastError(WSAEINVAL); return (SOCKET_ERROR); } @@ -1976,7 +1947,6 @@ if (!WSAIOCTL_GetInterfaceName(i, ifName)) { ERR ("Error parsing /proc filesystem!\n"); - close(fd); WSASetLastError(WSAEINVAL); return (SOCKET_ERROR); } @@ -1988,7 +1958,6 @@ if (ioctl(fd, SIOCGIFADDR, &ifInfo) < 0) { ERR ("Error obtaining IP address\n"); - close(fd); WSASetLastError(WSAEINVAL); return (SOCKET_ERROR); } @@ -2006,7 +1975,6 @@ if (ioctl(fd, SIOCGIFBRDADDR, &ifInfo) < 0) { ERR ("Error obtaining Broadcast IP address\n"); - close(fd); WSASetLastError(WSAEINVAL); return (SOCKET_ERROR); } @@ -2024,7 +1992,6 @@ if (ioctl(fd, SIOCGIFNETMASK, &ifInfo) < 0) { ERR ("Error obtaining Subnet IP address\n"); - close(fd); WSASetLastError(WSAEINVAL); return (SOCKET_ERROR); } @@ -2059,7 +2026,6 @@ if (ioctl(fd, SIOCGIFFLAGS, &ifInfo) < 0) { ERR ("Error obtaining status flags for socket!\n"); - close(fd); WSASetLastError(WSAEINVAL); return (SOCKET_ERROR); } @@ -2079,14 +2045,12 @@ default: { WARN("\tunsupported WS_IOCTL cmd (%08lx)\n", dwIoControlCode); - close(fd); WSASetLastError(WSAEOPNOTSUPP); return (SOCKET_ERROR); } } /* Function executed with no errors */ - close(fd); return (0); } else @@ -2242,14 +2206,11 @@ { /* AsyncSelect()'ed sockets are always nonblocking */ if (*argp) { - close(fd); return 0; } SetLastError(WSAEINVAL); - close(fd); return SOCKET_ERROR; } - close(fd); if (*argp) _enable_event(SOCKET2HANDLE(s), 0, FD_WINE_NONBLOCKING, 0); else @@ -2279,11 +2240,9 @@ } if( ioctl(fd, newcmd, (char*)argp ) == 0 ) { - close(fd); return 0; } SetLastError((errno == EBADF) ? WSAENOTSOCK : wsaErrno()); - close(fd); } return SOCKET_ERROR; } @@ -2309,7 +2268,6 @@ { if (listen(fd, backlog) == 0) { - close(fd); _enable_event(SOCKET2HANDLE(s), FD_ACCEPT, FD_WINE_LISTENING, FD_CONNECT|FD_WINE_CONNECTED); @@ -2437,7 +2395,6 @@ else wsfds16->fd_array[j++] = wsfds16->fd_array[i]; } - if( fd >= 0 ) close(fd); exceptfd[i] = -1; } if( b32 ) @@ -2449,9 +2406,6 @@ } return highfd; } - fd_set_unimport(ws_readfds, readfd, b32); - fd_set_unimport(ws_writefds, writefd, b32); - fd_set_unimport(ws_exceptfds, exceptfd, b32); if( ws_readfds ) ((WS_fd_set*)ws_readfds)->fd_count = 0; if( ws_writefds ) ((WS_fd_set*)ws_writefds)->fd_count = 0; if( ws_exceptfds ) ((WS_fd_set*)ws_exceptfds)->fd_count = 0; @@ -2553,7 +2507,7 @@ if ( !iovec ) { err = WSAEFAULT; - goto err_close; + goto error; } for ( i = 0; i < dwBufferCount; i++ ) @@ -2617,15 +2571,11 @@ *lpNumberOfBytesSent = n; HeapFree ( GetProcessHeap(), 0, iovec ); - close ( fd ); return 0; err_free: HeapFree ( GetProcessHeap(), 0, iovec ); -err_close: - close ( fd ); - error: WARN (" -> ERROR %d\n", err); WSASetLastError (err); @@ -2725,7 +2675,6 @@ }else{ if (!convert_sockopt(&level, &optname)) { SetLastError(WSAENOPROTOOPT); - close(fd); return SOCKET_ERROR; } if (optname == SO_LINGER && optval) { @@ -2755,7 +2704,6 @@ WARN("SO_RCVTIMEO for %d bytes: assuming unixism\n", optlen); } else { WARN("SO_RCVTIMEO for %d bytes is weird: ignored\n", optlen); - close(fd); return 0; } } @@ -2774,7 +2722,6 @@ WARN("SO_SNDTIMEO for %d bytes: assuming unixism\n", optlen); } else { WARN("SO_SNDTIMEO for %d bytes is weird: ignored\n", optlen); - close(fd); return 0; } } @@ -2782,17 +2729,14 @@ } if(optname == SO_RCVBUF && *(int*)optval < 2048) { WARN("SO_RCVBF for %d bytes is too small: ignored\n", *(int*)optval ); - close( fd); return 0; } if (setsockopt(fd, level, optname, optval, optlen) == 0) { - close(fd); return 0; } SetLastError(wsaErrno()); - close(fd); } else SetLastError(WSAENOTSOCK); return SOCKET_ERROR; @@ -2859,7 +2803,6 @@ err = WS2_register_async_shutdown ( s, fd0, ASYNC_TYPE_READ ); if ( err ) { - close ( fd0 ); goto error; } } @@ -2868,7 +2811,6 @@ err = WS2_register_async_shutdown ( s, fd1, ASYNC_TYPE_WRITE ); if ( err ) { - close ( fd1 ); goto error; } } @@ -2878,10 +2820,8 @@ if ( shutdown( fd, how ) ) { err = wsaErrno (); - close ( fd ); goto error; } - close(fd); } _enable_event( SOCKET2HANDLE(s), 0, 0, clear_flags ); @@ -4006,7 +3946,7 @@ if ( !iovec ) { err = WSAEFAULT; - goto err_close; + goto error; } for (i = 0; i < dwBufferCount; i++) @@ -4070,16 +4010,12 @@ *lpNumberOfBytesRecvd = n; HeapFree (GetProcessHeap(), 0, iovec); - close(fd); _enable_event(SOCKET2HANDLE(s), FD_READ, 0, 0); return 0; err_free: HeapFree (GetProcessHeap(), 0, iovec); - -err_close: - close (fd); error: WARN(" -> ERROR %d\n", err); Index: files/file.c =================================================================== RCS file: /home/wine/wine/files/file.c,v retrieving revision 1.177 diff -u -r1.177 file.c --- files/file.c 11 Jan 2003 21:03:18 -0000 1.177 +++ files/file.c 24 Jan 2003 14:13:59 -0000 @@ -333,7 +333,6 @@ else if (((access & GENERIC_READ) && (flags & FD_FLAG_RECV_SHUTDOWN)) || ((access & GENERIC_WRITE) && (flags & FD_FLAG_SEND_SHUTDOWN))) { - close (fd); SetLastError ( ERROR_PIPE_NOT_CONNECTED ); return -1; } @@ -1755,7 +1754,6 @@ return !register_new_async (&ovp->async); error: - close (fd); return FALSE; } @@ -1813,12 +1811,10 @@ if ( (overlapped==NULL) || NtResetEvent( overlapped->hEvent, NULL ) ) { TRACE("Overlapped not specified or invalid event flag\n"); - close(unix_handle); SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } - close(unix_handle); overlapped->InternalHigh = 0; if(!FILE_ReadFileEx(hFile, buffer, bytesToRead, overlapped, NULL, overlapped->hEvent)) @@ -1835,7 +1831,6 @@ } if (flags & FD_FLAG_TIMEOUT) { - close(unix_handle); return FILE_TimeoutRead(hFile, buffer, bytesToRead, bytesRead); } switch(type) @@ -1856,7 +1851,6 @@ &highOffset, FILE_BEGIN)) && (GetLastError() != NO_ERROR) ) { - close(unix_handle); return FALSE; } } @@ -1872,7 +1866,6 @@ off_t offset = OVERLAPPED_OFFSET(overlapped); if(lseek(unix_handle, offset, SEEK_SET) == -1) { - close(unix_handle); SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } @@ -1886,7 +1879,6 @@ FILE_SetDosError(); break; } - close( unix_handle ); if (result == -1) return FALSE; if (bytesRead) *bytesRead = result; return TRUE; @@ -1998,7 +1990,6 @@ return !register_new_async (&ovp->async); error: - close (fd); return FALSE; } @@ -2037,12 +2028,10 @@ if ( (overlapped==NULL) || NtResetEvent( overlapped->hEvent, NULL ) ) { TRACE("Overlapped not specified or invalid event flag\n"); - close(unix_handle); SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } - close(unix_handle); overlapped->InternalHigh = 0; if(!FILE_WriteFileEx(hFile, buffer, bytesToWrite, overlapped, NULL, overlapped->hEvent)) @@ -2075,7 +2064,6 @@ &highOffset, FILE_BEGIN)) && (GetLastError() != NO_ERROR) ) { - close(unix_handle); return FALSE; } } @@ -2086,7 +2074,6 @@ return FALSE; if (overlapped) { - close(unix_handle); SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } @@ -2098,7 +2085,6 @@ off_t offset = OVERLAPPED_OFFSET(overlapped); if(lseek(unix_handle, offset, SEEK_SET) == -1) { - close(unix_handle); SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } @@ -2115,7 +2101,6 @@ FILE_SetDosError(); break; } - close( unix_handle ); if (result == -1) return FALSE; if (bytesWritten) *bytesWritten = result; return TRUE; Index: files/smb.c =================================================================== RCS file: /home/wine/wine/files/smb.c,v retrieving revision 1.16 diff -u -r1.16 smb.c --- files/smb.c 24 Jan 2003 00:54:58 -0000 1.16 +++ files/smb.c 24 Jan 2003 14:14:02 -0000 @@ -1532,7 +1532,6 @@ if(total>=bytesToRead) break; } - close(fd); if(bytesRead) *bytesRead = total; Index: include/async.h =================================================================== RCS file: /home/wine/wine/include/async.h,v retrieving revision 1.5 diff -u -r1.5 async.h --- include/async.h 4 May 2002 18:37:08 -0000 1.5 +++ include/async.h 24 Jan 2003 14:14:02 -0000 @@ -72,7 +72,6 @@ ovp->next = ovp->prev = NULL; - close( ovp->fd ); if( ovp->event != INVALID_HANDLE_VALUE ) NtSetEvent( ovp->event, NULL ); Index: scheduler/client.c =================================================================== RCS file: /home/wine/wine/scheduler/client.c,v retrieving revision 1.92 diff -u -r1.92 client.c --- scheduler/client.c 31 Oct 2002 03:41:56 -0000 1.92 +++ scheduler/client.c 24 Jan 2003 14:14:05 -0000 @@ -436,7 +436,6 @@ */ } - if ((fd != -1) && ((fd = dup(fd)) == -1)) return STATUS_TOO_MANY_OPENED_FILES; *unix_fd = fd; return STATUS_SUCCESS; } -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck@Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

8 17

User/Sysparams tests failing
by Sylvain Petreolle 12 Feb '03

12 Feb '03

make[3]: Entre dans le répertoire `/home/wine/dlls/user/tests' ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so class.c && touch class.ok ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so generated.c && touch generated.ok ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so sysparams.c && touch sysparams.ok sysparams.c:173: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=Wallpaper, testValue=, value=C:\My Documents\Mes images\Sans titre Could you have a look at this ? ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: winedos/int10 clearscreen fix
by Jukka Heinonen 12 Feb '03

12 Feb '03

> I've had issues with a console program not clearing the screen when it's > supposed to. I've traced the problem down to dlls/winedos/int10.c function > DOSVM_Int10Handler() with and AH reg of 0x0b. Are you sure you found the right place to fix? According to interrupt documentation, 0x0b subfunction 0x00 is supposed to only set background color. It is possible that the subfunction also clears screen but I would like you to make sure that this is the real place missing clear screen. One place that is certain to have missing clear screen is entering text mode. Right now VGA emulation does not do this; VGA_SetAlphaMode should have a boolean flag that tells whether clear screen is desired or not and this flag should be set according to VGA mode bit 7 (or some VESA mode flag). I suspect that this is what is really causing the bug you have observed. Perhaps you should check whether this is the case? I will try to make a patch that fixes clear screen bug when entering text mode but it might take a few days (and it might be that this is not an issue here, anyway). -- Jukka Heinonen <http://www.iki.fi/jhei/>

3 3

Re: some ntdll functions (part 1: functions) [Virus checked]
by Tony Lambregts 12 Feb '03

12 Feb '03

thomas.mertes(a)t-mobile.at wrote: > > Hello > > Here are implementations of some ntdll functions. > I have tested the functions a lot on w2k (see part2: tests). > > Changelog: > > * dlls/ntdll/ntdll.spec, dlls/ntdll/large_int.c, > dlls/ntdll/rtl.c, dlls/ntdll/rtlstr.c, > include/winternl.h: > Thomas Mertes <thomas.mertes(a)t-mobile.at> > - Implement RtlCharToInteger, RtlExtendedMagicDivide, > RtlUpperChar, > RtlInt64ToUnicodeString, RtlIntegerToChar, > RtlIntegerToUnicodeString, > RtlLargeIntegerToChar, RtlUnicodeStringToInteger and > RtlUpcaseUnicodeChar > - Use toupperW instead of toupper in RtlCompareUnicodeString > > Greetings > Thomas Mertes > Two things. One - No HTML Please. Two - Patches should be inline (so they can be read) http://www.winehq.org/docs/wine-devel/patches.shtml -- Tony Lambregts

1 0

Re: PATCH: dlls/comctl32/listview.c -- warning removal
by Dimitrie O. Paun 12 Feb '03

12 Feb '03

On Wed, 12 Feb 2003, Gerald Pfeifer wrote: > Or we could simply remove the two assert()s, as we have an ERR() there > anyway. No, the assert()s are there with a purpose. Please leave them in. -- Dimi.

1 0

Partial fix for TVN_SELCHANGED
by Drew "DanteAliegri" Ogle 12 Feb '03

12 Feb '03

This fixes the putty and the winamp dialog problems, except for the inital load. I'll have to look at that. interestingly, when WM_SELCHANGEDW is set to TVN_SELCHANGEDA in the treeview call, those work perfectly, so I suppose this patch may not be complete. What the problem is is that the W gets sent to DefDlgProc32, because it is a W call, but the programs treeview hanlder isn't always W. So, you have to check that here and then adjust the code. -Dante Index: windows/defdlg.c =================================================================== RCS file: /home/wine/wine/windows/defdlg.c,v retrieving revision 1.29 diff -u -r1.29 defdlg.c --- windows/defdlg.c 14 Jan 2003 19:29:15 -0000 1.29 +++ windows/defdlg.c 12 Feb 2003 14:00:56 -0000 @@ -395,12 +395,17 @@ LRESULT WINAPI DefDlgProcW( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) { BOOL result = FALSE; + BOOL forWide = FALSE; WNDPROC dlgproc; + if( msg == WM_NOTIFY && lParam && ((LPNMHDR)lParam)->code & 0x30 ) + forWide = TRUE; SetWindowLongW( hwnd, DWL_MSGRESULT, 0 ); if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) { + if( forWide && (WINPROC_GetProcType( dlgproc) == WIN_RPOC_32A )) + ((LPNMHDR)lParam)->code += 0x30; /* Call dialog procedure */ result = CallWindowProcW( dlgproc, hwnd, msg, wParam, lParam ); /* 16 bit dlg procs only return BOOL16 */

1 0

dlls/msvcrt/locale.c:544: warning: unsigned int format, LCID arg (arg 5)
by Gerald Pfeifer 12 Feb '03

12 Feb '03

Hi, the following patch to dlls/msvcrt/locale.c revision 1.15 date: 2003/02/11 22:11:17; author: julliard; state: Exp; lines: +15 -0 Marcus Meissner <marcus(a)jet.franken.de> Implemented __crtLCMapStringA. causes the following warning on FreeBSD 4.7 using GCC 2.95.4: locale.c: In function `__crtLCMapStringA': locale.c:544: warning: unsigned int format, LCID arg (arg 5) Would you mind having a look? Thanks, Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/

1 0

Back ;)
by fenix＠club-internet.fr 12 Feb '03

12 Feb '03

Yes, i just see Alexandre is back, we can "flood" him again with patches :) really good job (34 patches merged in 4h), Raphael

1 0

Bugreport: Altgr key and Euro key problem
by Sylvain Petreolle 12 Feb '03

12 Feb '03

===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

CreateNamedPipe error values?
by Dan Kegel 12 Feb '03

12 Feb '03

I wrote a humble beginning of a conformance test for named pipes, in hopes of preventing regressions like the one which is currently breaking Installshield installs (or was last I checked). Later it's going to verify that named pipes like the ones Wine uses internally (e.g. in ole32/rpc.c) actually work, For now I thought I'd just make sure we return the right error code if you pass a bogus filename to CreateNamedPipe. But, um, we don't return any error code; we happily succeed. Can somebody who has Windows Server run this little test, and tell me what it outputs? You can build it as part of the wine test suite, or standalone with the commands call \vcvars32.bat cl /D STANDALONE /D _X86_ /D _M_IX86 /D WIN32 /D _WINDOWS pipe.c Thanks, Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 0a1,61 > /* > * Unit tests for named pipe functions in Wine > * > * Copyright (c) 2002 Dan Kegel > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > * License as published by the Free Software Foundation; either > * version 2.1 of the License, or (at your option) any later version. > * > * This library is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, write to the Free Software > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > */ > > #include <stdlib.h> > #include <stdio.h> > #include <time.h> > > #ifndef STANDALONE > #include "wine/test.h" > #else > #include <assert.h> > #define START_TEST(name) main(int argc, char **argv) > #define ok(condition, msg) assert(condition) > #endif > > #include <windef.h> > #include <winbase.h> > #include <winerror.h> > #include <wtypes.h> > > void test_CreateNamedPipeA(void) > { > HANDLE hnp; > char filename[MAX_PATH]; > > sprintf(filename, "not a named pipe name"); > hnp = CreateNamedPipeA(filename, > PIPE_ACCESS_DUPLEX, PIPE_TYPE_BYTE|PIPE_READMODE_BYTE|PIPE_WAIT, > /* nMaxInstances */ 1, > /* nOutBufSize */ 1024, > /* nInBufSize */ 1024, > /* nDefaultWait */ 1000, > /* lpSecurityAttrib */ NULL); > > printf("h %p, err %ld\n", hnp, GetLastError()); > ok(hnp == INVALID_HANDLE_VALUE && GetLastError() == ERROR_INVALID_NAME, > "CreateNamedPipe should fail if name doesn't start with \\\\.\\pipe"); > } > > START_TEST(pipe) > { > test_CreateNamedPipeA(); > } >

4 3

seg fault in exception handler running starcraft?
by SodaPop 12 Feb '03

12 Feb '03

Starcraft crashes for me with the 20030115 wine release, every time I try to actually start playing a map. The wine debugger isn't invoked when the crash happens, I just get a 'Segmentation fault' message and control is returned to my shell. Some wine threads are still running however, as the music keeps playing and the main starcraft window does redraws as needed. Here is the backtrace from regular gdb: #0 0x00000000 in ?? () #1 0x400be693 in EXC_CallHandler (record=0x40691c10, frame=0x40691d80, context=0x406918ac, dispatcher=0x40691848, handler=0, nested_handler=0x400be5d0 <EXC_RaiseHandler>) at exception.c:117 #2 0x400be9b9 in EXC_RtlRaiseException (rec=0x40691c10, context=0x406918ac) at exception.c:213 #3 0x400cdd99 in __wine_call_from_32_regs () from /usr/local/lib/libntdll.dll.so #4 0x400be8b5 in RtlRaiseException () from /usr/local/lib/libntdll.dll.so #5 0x40aa31ec in __wine_stub_rpcrt4_dll_314 () at rpcrt4.spec.c:356 #6 0x788f6974 in ?? () #7 0x788f31b8 in ?? () #8 0x788f5a65 in ?? () #9 0x7ca0ac41 in ?? () #10 0x7ca09194 in ?? () #11 0x4091640f in CryptAcquireContextA (phProv=0x40691f60, pszContainer=0x1502b5f0 "Blizzard_Storm", pszProvider=0x1502b600 "Microsoft Base Cryptographic Provider v1.0", dwProvType=1, dwFlags=8) at crypt.c:332 #12 0x1500f568 in ?? () Please let me know if you need any additional data, I'll try to scrape it out of the debugger. This happens both with starcraft versions 1.00 and 1.05 patched. Broodwar is not installed. Please cc me, I normally only read the archives and am not subscribed. -dennis T

2 1

cvs wine + win2k ole + installshield = unhappy
by Dan Kegel 12 Feb '03

12 Feb '03

I'm trying to run a particular installer made with Installshield on cvs wine without any Windows DLLs. This used to work (on a different machine, with who knows what other changes). Now I just get an empty InstallShield wizard frame, and then it hangs. Hrmph. Maybe installshield wants some new spiffy ole stuff. Now, this machine dual-boots with win2k, so I thought I'd try native dlls for a few things: $ cd ~/c/windows/system $ cp /dos/c/WINNT/system/stdole.tlb . $ cp /dos/c/WINNT/system32/compobj.dll . $ cp /dos/c/WINNT/system32/storage.dll . $ cp /dos/c/WINNT/system32/ole{2,32}.dll . $ cd ~/c/temp/disk1 $ ~/wine/wine --dll compobj,storage,ole,ole2,ole32=n Setup.exe Unfortunately, that crashes. Rerunning with +relay > log 2>&1, and doing egrep 'fixme|^wine|^Unhand' log, I see: fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE fixme:seh:check_resource_write Broken app is writing to the resource data, enabling work-around fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE fixme:win:GetProcessWindowStation (void): stub fixme:win:GetThreadDesktop (9): stub fixme:win32:GetUserObjectInformationW (0x1 2 0x406817cc 64 0x4068181c),stub! fixme:win32:GetUserObjectInformationW (0x1 2 0x4068178c 64 0x4068181c),stub! fixme:ole:RPCRT4_NdrClientCall2 (pStubDec == ^0x77a7abc8,pFormat = ^0x77a7ac1a,...): semi-stub fixme:ntdll:NtOpenThreadToken (0xfffffffe,0x00000004,0x00000001,0x4068181c): stub fixme:advapi:SetThreadToken ((nil), (nil)): stub (NT impl. only) fixme:ntdll:NtOpenProcessToken (0xffffffff,0x00000008,0x40681828): stub fixme:ntdll:NtQueryInformationToken (0xcafe,1,0x406817d0,52,0x40681824): stub fixme:advapi:LookupAccountSidW ((null),sid=0x406817d8,0x40681724,0x40681830(80),0x403c61d8,0x4068182c(80),0x40681820): semi-stub fixme:advapi:SetThreadToken ((nil), 0xcafe): stub (NT impl. only) fixme:ole:RPCRT4_NdrClientCall2 (pStubDec == ^0x77a8c4b8,pFormat = ^0x77a8c572,...): semi-stub fixme:ntdll:NtOpenThreadToken (0xfffffffe,0x00000004,0x00000001,0x40681898): stub fixme:advapi:SetThreadToken ((nil), (nil)): stub (NT impl. only) fixme:advapi:SetThreadToken ((nil), 0xcafe): stub (NT impl. only) wine: Unhandled exception, starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x77a539ca). There are enough fixmes there that I can believe something crucial isn't implemented yet. Here's the last few lines of relay, plus the backtrace: fixme:advapi:SetThreadToken ((nil), 0xcafe): stub (NT impl. only) 00000009:Ret advapi32.SetThreadToken() retval=00000000 ret=77a5e17f 00000009:Call kernel32.CloseHandle(0000cafe) ret=77a5e186 00000009:Ret kernel32.CloseHandle() retval=00000000 ret=77a5e186 00000009:Call ntdll.RtlLeaveCriticalSection(77b32b68) ret=77a5db8f 00000009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=77a5db8f 00000009:Call kernel32.GetCurrentProcessId() ret=77a5b6a5 00000009:Ret kernel32.GetCurrentProcessId() retval=00000008 ret=77a5b6a5 00000009:Call kernel32.OpenEventA(001f0003,00000000,4068187c "MSFT.VSA.COM.DISABLE.8") ret=77a5b6cc 00000009:Ret kernel32.OpenEventA() retval=00000000 ret=77a5b6cc 00000009:Call kernel32.OpenEventA(00100002,00000000,77a5b6f4 "MSFT.VSA.IEC.STATUS.6c736db0") ret=77a5b6e1 00000009:Ret kernel32.OpenEventA() retval=00000000 ret=77a5b6e1 00000009:Call ntdll.RtlLeaveCriticalSection(77b333c0) ret=77b295c0 00000009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=77b295c0 00000009:Call ntdll.RtlEnterCriticalSection(77b326a0) ret=77a51d8e 00000009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=77a51d8e wine: Unhandled exception, starting debugger... ... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x77a539ca). In 32-bit mode. 0x77a539ca (OLE32.DLL.StringFromCLSID+0x137 in C:\WINDOWS\SYSTEM\OLE32.DLL): movw 0x0(%edx),%dx Backtrace: =>0 0x77a539ca (OLE32.DLL.StringFromCLSID+0x137 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=40681858) 1 0x77a5b2be (OLE32.DLL.CoRegisterMessageFilter+0x324 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=406818ac) 2 0x77a7e5f0 (OLE32.DLL.CoCreateGuid+0x1114 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=406818e4) 3 0x77a7d103 (OLE32.DLL.CoFreeUnusedLibraries+0x45b in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=406818fc) 4 0x77a6f555 (OLE32.DLL.OleCreateEx+0x1305 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=4068194c) 5 0x77a58359 (OLE32.DLL.CoCreateInstance+0x3ca1 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=40681b94) 6 0x77a582ca (OLE32.DLL.CoCreateInstance+0x3c12 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=40681bb0) 7 0x77a54518 (OLE32.DLL.CoCreateInstanceEx+0x223 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=4068231c) 8 0x77a5431d (OLE32.DLL.CoCreateInstanceEx+0x28 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=40682344) 9 0x77a546ea (OLE32.DLL.CoCreateInstance+0x32 in C:\WINDOWS\SYSTEM\OLE32.DLL) (ebp=40682374) 10 0x00403a0f (Setup.exe.EntryPoint+0x1eb5 in C:\temp\Disk1\Setup.exe) (ebp=406823ec) 11 0x0040258b (Setup.exe.EntryPoint+0xa31 in C:\temp\Disk1\Setup.exe) (ebp=40682448) 12 0x004022c4 (Setup.exe.EntryPoint+0x76a in C:\temp\Disk1\Setup.exe) (ebp=406828a4) 13 0x00401ff9 (Setup.exe.EntryPoint+0x49f in C:\temp\Disk1\Setup.exe) (ebp=40682e34) 14 0x00401be6 (Setup.exe.EntryPoint+0x8c in C:\temp\Disk1\Setup.exe) (ebp=40682e9c) 15 0x4009dd90 (start_process+0x21c [process.c:564] in libntdll.dll.so) (ebp=40682f38) 16 0x400a212d (call_on_thread_stack+0x1d(func=0x4009db74) [sysdeps.c:171] in libntdll.dll.so) (ebp=40682ff4) 17 0x400a22c0 (SYSDEPS_CallOnStack+0x14 in libntdll.dll.so) (ebp=00000000) I'd be happy to send a better log or implement some small missing call if someone wants to point me in the right direction. - Dan

9 16

winedos/int10 clearscreen fix
by Ulrik Mikaelsson 12 Feb '03

12 Feb '03

Hi I've had issues with a console program not clearing the screen when it's supposed to. I've traced the problem down to dlls/winedos/int10.c function DOSVM_Int10Handler() with and AH reg of 0x0b. I've added code for clearing the screen with the specified color, as well as added a method for doing a total clearscreen to vga.c and vga.h. It's only tested for textmode and propably won't work for anything else so I think the fixme should be left for anyone who's up for the task. A patch is attached, please feel free to comment before i submit to wine-patches. Regards Ulrik

1 0

dos4gw saga continues
by Enrico Horn 11 Feb '03

11 Feb '03

Hi, here are two things I find interesting about dos4gw: 1.it will allocate 1 para of memory than resize to available memory allocate another para of memory(this doesnt fail although all memory should be already allocated) and resize it to available memory(which is zero!?) 2. does a close file by handle with handle value 0xffff do something special dos4gw does this too and it fails because there is no handle value 65535. any ideas Enrico Horn farmboy1(a)subdimension.com

2 1

Re: wine/dlls/ntdll exception.c
by Gregory M. Turner 11 Feb '03

11 Feb '03

On Tuesday 11 February 2003 03:56 pm, Alexandre Julliard wrote: > ChangeSet ID: 7195 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2003/02/11 15:56:59 > > Modified files: > dlls/ntdll : exception.c > > Log message: > Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> > Added FIXME on stub exception. > > Patch: http://cvs.winehq.com/patch.py?id=7195 > > Old revision New revision Changes Path > 1.51 1.52 +2 -1 wine/dlls/ntdll/exception.c uh-oh, I sense a flood coming on! WB Alexandre! -- gmt "Once a nation becomes a democracy, the whole purpose of government changes. Instead of the government's goal being that of guaranteeing liberty, equal justice, private property, and voluntary exchange, the government embarks on the impossible task of achieving economic equality, micromanaging the economy, and protecting citizens from themselves and all their activities. The destruction of the wealth-building process, which is inherent in a free society, is never anticipated. Once it's realized that it has been undermined, it is too late to easily reverse the attacks against limited government and personal liberty." -- Ron Paul

1 0

Re: [DInput] Tribes fix...
by Ove Kaaven 11 Feb '03

11 Feb '03

man, 2003-02-10 kl. 23:21 skrev Lionel Ulmer: > Hi all, > > With this patch, Tribes1 now likes our DInput driver. > > Lionel (who waits for his beer when he will visit Sweden :-) ) > > Changelog: > Implement EnumObjects for the keyboard device > strcpy(ddoi.tszName, "a"); /* This should be better handled :-/ */ Perhaps the right way to do this would be something like GetKeyNameTextA(((i & 0x7f) << 16) | ((i & 0x80) << 17), ddoi.tszName, sizeof(ddoi.tszName));

2 1

err:keyboard:X11DRV_ToUnicode Please report
by Duane Clark 11 Feb '03

11 Feb '03

Originally discovered (as far as I know) by Paul McNett and mentioned in bug 1264, typing a shift-tab in an app under Wine generates the message: err:keyboard:X11DRV_ToUnicode Please report: no char for keysym FE20 (ISO_Left_Tab) : err:keyboard:X11DRV_ToUnicode (virtKey=9,scanCode=F,keycode=17,state=1) So here is a report.

1 0

Where oh where has Alexander gone?
by Shachar Shemesh 11 Feb '03

11 Feb '03

Hi, The last commit to wine has been done almost two weeks ago. I understood from half an email that Dimi wrote that Alexander was away from the Internet (away for almost two weeks! *shudder*). Anyone knows where, when and what? Is all ok? -- Shachar Shemesh Open Source integration consultant http://www.consumer.org.il/sun/

2 1

Treeview Error.
by Drew "DanteAliegri" Ogle 11 Feb '03

11 Feb '03

I've found the problem, but I'm not sure how to fix it. Just to explain the error, putty and some other things that use treeviews stopped working. The treeview would appear, but content to its left would not. The problem is this: in TREEVIEW_DoSelectItem of dlls/comctl32/treeview.c sends a TVN_SELCHANGINGW and then a TVN_SELCHANGEDW, however putty at least, is looking for a TVN_SELCHANGED , which compiles to a TVN_SELCHANGEDA. Changing these there restores putty and winamp's preference dialog to the way they worked before. What needs to happen then, is somewhere we know that we are calling into a A callback, so we can change the TVN_SELCHANGEDW code to TVN_SELCHANGEDA.

1 0

NamedPipe conformance tests
by Dan Kegel 11 Feb '03

11 Feb '03

A couple questions: 1. Is anyone working on NamedPipe conformance tests? If not, I'd be happy to try. (Might be a challenge to scare up a Server version of Windows, so initially I'd just write the tests on Wine, and make sure they compiled with winelib and with vc++.) 2. Since CreateNamedPipe is only available on Server versions of Windows, we need a way to avoid running the test on non-server versions. Er, I suppose checking for the presence of CreateNamedPipe would be the way to go :-) I at first tried detecting the Windows version, but that's far too hairy. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

3 2

Wine, FreeBSD, and PPC
by ArchAngel_Nix 11 Feb '03

11 Feb '03

I am running Gnome on a variant of FreeBSD called Darwin. Darwin runs on PPC architecture opposed to x86 architecture. My question is can Wine run on this variant of FreeBSD? Can I download the source and build Wine for my system? Will Wine work with other processor architectures, or only x86? Thanks for the help. -Mike Holley- mike(a)holleyinc.com

3 2

Re: Windows API (What I have so far)
by Brian Vincent (C) 11 Feb '03

11 Feb '03

> Also not that the resulting display is as ugly as an airport. This was, > in fact, on purpose. If you view the source of the HTML, you will find > that it was meant to be styled with a CSS, and thus contain no > formating directives, but do contain "class" directives. I added a stylesheet and in comes out looking slightly less ugly than an airport. More like a large, urban train station. But that probably has more to do with the colors I used than anything else. Rather than update your perl script, I'll just give some simple directions: 1) edit the top of the html output to include this: <HTML><HEAD> <LINK href="style.css" type=text/css rel=STYLESHEET> </HEAD> <BODY> (and you might want to add </BODY></HTML> at the end for good measure) 2) Then create the file style.css containing these lines: body { margin:0px; background-color:#660000; scrollbar-face-color: #DA7923; scrollbar-shadow-color: #80705D; scrollbar-highlight-color: #80705D; scrollbar-3dlight-color: #CEC6BC; scrollbar-darkshadow-color: #B8AA9A; scrollbar-track-color: #B8AA9A; scrollbar-arrow-color: #80705D; } td {vertical-align:top; font-family: Arial, Helvetica, sans-serif; font-size: 12px; color: #333} td.middle {vertical-align:middle} td.CyclicDepend {background-color: #111} a {text-decoration: none; font-family: Arial, Helvetica, sans-serif; font-size: 12px;color:#c60} a:hover {font-family: Arial, Helvetica, sans-serif; font-size: 12px;color:#fff} H1 {font-family: Arial, Helvetica, sans-serif;font-size: 13px;font-weight: bold;color: #993300;} ------- Brian Vincent vincentb(a)coppercolorado.com

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel