- wine-devel - winehq.org

smatch, something like the Stanford Checker
by Michael Stefaniuc 11 Feb '03

11 Feb '03

Hello, i always dreamed to have something like the Stanford Checker for Wine and some days ago i've seen on freshmeat smatch http://smatch.sourceforge.net/ . It's a project from KernelJanitors and it seems usefull, at least it's worth an entry on Dimi's janitorial page. A short description: Smatch is basicaly a patch to gcc-3.1.1 that makes the gcc dump out it's internal represantation of the code and a set of perl modules/scripts to ease the parsing of the dumped code. Most of the perl scripts are for the Linux Kernel but writing new scripts seems to be easy. I wrote (well, mostly adapted an existing script for the kernel) one script http://people.redhat.com/mstefani/wine/smatch/enter_leave.pl (if we decide to adopt smatch it should probably go to $wine/tools/smatch/) to find code path with missing LeaveCriticalSection's. Scripts to find some other usefull things like fd, DC, GDI obejects leaks should be easy to write. Comments? bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Re: revised direct sound capture patches
by Dmitry Timoshkov 11 Feb '03

11 Feb '03

"Robert Reif" <reif(a)earthlink.net> wrote: > wineoss.diff starts to add support for a real direct sound capture > driver. It also > changes the capture fragment size but this still needs tuning for best > performance. > @@ -534,11 +536,11 @@ > #ifdef EMULATE_SB16 > ossdev->in_caps.wMid = 0x0002; > ossdev->in_caps.wPid = 0x0004; > - strcpy(ossdev->in_caps.szPname, "SB16 Wave In"); > + strncpy(ossdev->in_caps.szPname, "SB16 Wave In",MAXPNAMELEN-1); > #else > ossdev->in_caps.wMid = 0x00FF; /* Manufac ID */ > ossdev->in_caps.wPid = 0x0001; /* Product ID */ > - strcpy(ossdev->in_caps.szPname, "OpenSoundSystem WAVIN Driver"); > + strncpy(ossdev->in_caps.szPname, "OpenSoundSystem WAVIN Driver",MAXPNAMELEN-1); Why do you need these changes? MAXPNAMELEN in include/mmsystem.h is defined as #define MAXPNAMELEN 32 /* max product name length (including NULL) */ so it's perfectly correct to use strcpy here. -- Dmitry.

2 2

Windows API script updated
by David Miller 10 Feb '03

10 Feb '03

I've updated my script to output imported_api.html which lists all of the dlls and the specific APIs imported from other dlls. Hopefully that is a bit more useful than just which dlls are imported. There is a sample output here: http://home.ptd.net/~compsol/imported_api.gz It is about 800kb gzipped. It was 7MB before compressing. :) If anyone is interested, the script is attached again. You'll need to run with -parse to get this HTML. Now, should exported APIs somehow be part of the HTML as well?

1 0

WS_EX_TRANSPARENT bug
by Felipe W Damasio 10 Feb '03

10 Feb '03

Hi, First of all, I'd like to thank Tony Lambregts and Sander van Leeuwen for helping me. Tony: Since I tested and saw that Sander's patch fixed, I closed the bug. That patch should definitely enter on mainline! Anyway, I'm here to report another bug: CreateWindow's flag WS_EX_TRANSPARENT doesn't do anything. Cesar Mello did a little example program which uses this flag: Both source and an executable are available here: ftp://ftp.elipse.com.br/pub/transp/transp-exe.tar.gz ftp://ftp.elipse.com.br/pub/transp/transp-source.tar.gz I'll enter this bug on bugzilla right away. Does anyone can help me with this? Thanks, Felipe

4 4

AppDB updated
by Andreas Mohr 10 Feb '03

10 Feb '03

Hi all, I just (well, not "just": more like a matter of a whole week or so) committed about 170 or so new entries to the AppDB, thus reaching a count of 1523 distinct applications. I guess I'm feeling really exhausted now... Anyway, have fun browsing the site at http://appdb.winehq.org ! Andreas Mohr

5 4

press: International Herald Tribune review
by Dan Kegel 10 Feb '03

10 Feb '03

The review was of a Linux distro, but one of the big failings the reviewer cited was the inability to run "the Oxford English Dictionary on CD-ROM". http://www.iht.com/articles/86157.html --------- PARIS For several years now I have thought longingly about Linux, the power-to-the-people operating system that is said to be as stable as a rock, open and free and the embodiment of everything good in the world - in short, the exact opposite of Microsoft's Windows, both technically and politically. ... Early on, Lindows had claimed that it would be able to run all Windows programs, and it came with a utility called WINE that was supposed to make this miracle occur. In fact, it can run some Windows programs, Office 2000, for example, but can't run others, like Office XP. In general, the more sophisticated the Windows program, the less likely that WINE/Lindows is going to be able to run it. Lindows has changed its position. They've realized that trying to piggyback on Windows programs is a recipe for frustration, and WINE is no longer part of Lindows. The current view, Schwartzman said, is that "if there's a Linux alternative, you're going to have a better experience." ... I use GotoMyPC all of the time to access my home computer from other places. It doesn't work with Linux. I have the Oxford English Dictionary on CD-ROM, which I also use all of the time. It, too, does not work with Linux. There are too many programs for which there is no Linux alternative. . Lindows is a bold and commendable effort to challenge the Microsoft hegemony and make computers cheaper. Unfortunately, it fails. ---------- -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

SW_SHOWMINIMIZED bug
by Felipe W Damasio 10 Feb '03

10 Feb '03

Hi, SW_SHOWMINIMIZED has a weird bug: The application, when restored, goes blank and have to be killed and re-started to work again. This looks like an internal loop inside wine, or a wrong XLib flag being set. Cesar Mello (mello(a)elipse.com.br) wrote a little app to test it, and both the source and an executable are available for download here: ftp://ftp.elipse.com.br/pub/showWindow/showWindow-exe.tar.gz ftp://ftp.elipse.com.br/pub/showWindow/showWindow-src.tar.gz Can anybody help me with this? This seems to be critical, because to app does not work anymore untill it is re-started. I'll add an entry to bugs.winehq.com now. Thank you and kind Regards, Felipe

1 1

Started playing with Wineserver on mingw/cygwin again
by Steven Edwards 10 Feb '03

10 Feb '03

well I made it serial.c before I had to run to work. I'm having good luck getting alot of the objects to compile so far I've only had to kill file.c, ptrace.c, request.c and select.c. Getting this to build and run on Windows is going to be a bitch =) gettimeofday, fork and all of fd and networking is going to be the hard part. I've started a tempory header to see what will need to be implemented in libwine if we want to get wineserver up and running on Windows without cygwin. Cygwin still really needed get/setthreadcontext (hint, hint) Thanks Steven /* I kill'd file.c, ptrace.c, request.c, select.c * * get/set thread context still needs to be done for Mingw and Cygwin * * main.c needs a lot of work */ /* object.h and async.h */ struct timeval{ int tv_sec; int tv_usec; }; /* debugger.c */ #define SIGTRAP NULL /* file.c - doesnt work */ #define O_NONBLOCK 0 #define POLLIN 0 #define POLLOUT 0 #define POLLIN 0 #define POLLOUT 0 /* main.c */ #define SIGPIPE NULL #define SIGHUP NULL #define SIGQUIT NULL /* named_pipe.c */ #define PF_UNIX NULL #define SOCK_STREAM NULL /* object.c */ #define POLLERR 0 #define POLLHUP 0 __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

22 54

Re: SMATCH: add missing LeaveCriticalSection
by Dan Kegel 10 Feb '03

10 Feb '03

Michael Stefaniuc wrote: > on some error path the critical section wasn't released. > Found with smatch's help. I'm impressed. Didn't know smatch could detect this kind of thing in Wine code. For those who haven't heard of smatch, see http://smatch.sf.net - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

2 1

IPCWorkshop
by Dan Kegel 10 Feb '03

10 Feb '03

There's a fun little test app (with source) called IPCWorkshop at http://www.codeproject.com/threads/ipcworkshop.asp I noticed it probably needs a Sleep(500) in its Mailslot receive loop, and a lot of its stuff doesn't seem to work on my Windows Me system, but its "filemapping" and "mailslots" modes do seem to work on Windows Me. (Oddly, "Clipboard" doesn't work for me on Windows Me. This app is fairly new, maybe it's still a bit buggy.) None of its modes seem to work on Wine. Not sure why. In server mode, it never redraws, so the GUI is messed up somehow. I'm sure this app triggers several Wine bugs. Anyway, if anyone's looking for simple test apps that exercise various IPC methods, this one might be worth checking out. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

visual studio 6 not happy?
by Dan Kegel 10 Feb '03

10 Feb '03

wine cvs doesn't run visual studio 6 especially happily. Building a simple app fails with "Error executing rc.exe". I wonder if this is another example of that named pipe failure... it certainly is calling PeekNamedPipe to beat the band, and http://www.microsoft.com/msj/0698/win320698.htm says that vcspawn.exe (used to run external processes) probably uses named pipes to communicate with msdev. Guess it's back to the commandline for me. Yep, exporting a makefile and building with nmake works better. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

Windows API (What I have so far)
by David Miller 09 Feb '03

09 Feb '03

I thought a few of you might be interested in the current status of this script, so here is an update. I will attach a copy in case anyone wants to test it, or add functionality or fixes. I'd be interested in the results of any tests, especially if you discover any parsing errors. It is far from complete, but at this stage does the following: - Scan a given path, locating all dll files - Generate an HTML map of dll imports only (sorted, lowercase, stripped of paths) - dumpbin /import and dumpbin /export on all dll files and save the results in imports.txt and exports.txt respectively - parse imports.txt as follows, and save the results in imported_api.txt: DLL name imported DLL imported API - parse exports.txt as follows, and save the results in exported_api.txt: DLL name exported API Future plans: - Create a matrix of data currently in HTML map - Generate HTML cross reference of all imported/exported API - Implement dumping of data into a database (Something queryable, but what?) - Detect and report unimplemented APIs in wine

4 8

More on the Treeview
by Drew "DanteAliegri" Ogle 09 Feb '03

09 Feb '03

also, when I replaced the comctl32 with a native, it didn't fix the problem, so I'd think its safe to say that the error is occuring outside comctl32.. -Dante

1 0

Tried to install Red Alert - Yuri's Revenge
by David.Goodenough＠DGA.co.uk 09 Feb '03

09 Feb '03

and it failed. The installer said that comctl32.dll was too old, did I want a new one, so I said no. They it said that DirectX was a level 0 (well actually a long list of 00.00s), and asked if I wanted to install what looked like version 4 (although the docs with the CD say that it will install 8.0a). When I said no to that the installer quit. This was a Debian unstable system, which is using the latest Wine.deb. So how is it detecting the age of comctl32, and how should I convince it that the dll really is up to date, and do I need to install the front bits of DirectX in order to use the support that Wine is now increasingly providing, or should Wine be advertising its DirectX support differently. This is the first time I have tried to install a DirectX program on the machine, and I do not know quite how I should proceed. Thanks in advance David

2 1

Treeview Regression
by Drew "DanteAliegri" Ogle 09 Feb '03

09 Feb '03

There has been a treeview regression, since at least 20030115, I assumed someone would take it up, but noone has. I will try to fix it, but a rather simple testcase ( ~200 lines of C ) is at http://open-socket.dyndns.org/~dante/treeview-testcase.tar.bz2 What appears to be happening, is when the dialog recieves a message that is WM_NOTIFY , it excpets the lparam to 1) be LPNMHDR, and lparam->code to be TVN_SELCHANGED. the lparam->code that wine appears to be returning is 0. -Dante

1 0

Crash in MSVCRT_type_info_name
by Uwe Bonnes 09 Feb '03

09 Feb '03

Hallo, Altera Quartus crashes soon after start when run with builtin msvcrt: 00000009:Call msvcrt.?name@type_info@@QBEPBDXZ(00000062) ret=407ec69a trace:msvcrt:MSVCRT_type_info_name trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x402a680b trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=0000006a I didn't see where the argument(00000062) comes from. Any ideas? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

IDA regression again :-)
by Lionel Ulmer 09 Feb '03

09 Feb '03

Hi all, Seems that with latest CVS, the ncurses driver 'added' a lot of regressions to IDA... The biggest gripe is that the mouse support is VERY flaky (I can click some times but once it stops working, it seems that I cannot do anymore with it). As I do not know exactly how to select stuff in the GUI using only the keyboard (which seems flaky too as the Backspace and Delete key seem not really to work), I am a bit stuck. How could one help debug this relatively crucial application to help in some D3D / OpenGL investigations ? Lionel PS: we REALLY should be able to use the old slow as hell graphical driver as a fallback.... -- Lionel Ulmer - http://www.bbrox.org/

2 3

Good source of test case source?
by Dan Kegel 09 Feb '03

09 Feb '03

Source code downloaded from any *.microsoft.com server is copyright Microsoft, and they would not take kindly to us using it in our regression test suite, I'm sure. I hope I speak for everyone here when I say it seems important to carefully obey the letter of the law when it comes to avoiding copyright issues that might taint our efforts. So where should a developer go to find good code snippets when writing Wine regression or compliance tests, without running afoul of copyright laws? One possibility is http://www.codeproject.com. Their submission page, http://www.codeproject.com/info/submit.asp, quite clearly states: "If you post to CodeProject then you retain copyright of your article and code. You also give CodeProject permission to use it in a fair manner and also permit all developers to freely use the code in their own applications. ... You are more than welcome to submit code that is already published at another site, provided you own the copyright on that article, and provided you have not given the other site exclusive rights to your article." That sounds like code at CodeProject is fair game. Do other (smarter) people agree? I ask, of course, because I'd like to make sure it'll be ok to submit a testcase based partly on CodeProject code. Thanks, Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

Error installing iKernel.exe: (0x1400)
by Dan Kegel 09 Feb '03

09 Feb '03

This is something I see frequently. Here's my little FAQ about it: When running an Installshield 6 installer: If you get the error "Error installing iKernel.exe: (0x1400)" at any point, it's probably because there are leftover processes from a previous try. You can verify this with the command $ ps augxw | grep wine If that command shows old copies of wine running your setup, you need to kill them before you can run the setup program. If there are no other Wine programs running, you can kill them all with the command $ killall wine If you're also running Wine programs you care about, you'll have to kill off the old Setup instances one by one using kill and the individual PIDs (or perhaps Wine's spiffy Task Manager, which doesn't exist yet). Then repeat the ps to make sure the old wines are gone. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

2 1

Re: Implement font glyph rotation
by Huw D M Davies 08 Feb '03

08 Feb '03

On Thu, Feb 06, 2003 at 09:50:57AM -0500, Warren_Baird(a)cimmetry.com wrote: > > > > ChangeLog: > > Add support for font glyph rotation in GetGlyphOutline. > > Description: > > Fixed bad angle conversion from tenths of degree to FT_Fixed on > big-endian machines. > > Fixed bad calculation of the gmCellIncY bounding box field > in the case of a rotation. (just imagine what you would get > as result from "-(vec.y+63) >> 6" when vec.y is zero... what > we expect really is zero, not -1). > > Fixed wrong rotation matrix used to transform the outline. > > Rotate each point of the outline before it gets converted > by FTVectorToPOINTFX in the GGO_NATIVE case. > > Warren Baird : Warren_Baird(a)cimmetry.com > Dave Belanger > > diff -ur clean/wine/dlls/gdi/freetype.c wine/dlls/gdi/freetype.c > --- clean/wine/dlls/gdi/freetype.c 24 Jan 2003 15:12:16 -0000 1.1.1.3 > +++ wine/dlls/gdi/freetype.c 28 Jan 2003 18:37:34 -0000 > @@ -1510,7 +1510,7 @@ > if(font->orientation) { > FT_Matrix matrix; > matrix.xx = matrix.yy = pFT_Cos(angle); > - matrix.xy = -pFT_Sin(angle); > + matrix.xy = pFT_Sin(angle); > matrix.yx = -matrix.xy; > > pFT_Outline_Transform(&ft_face->glyph->outline, &matrix); Hi, Are you sure about this hunk? Iirc there was a vesion of FreeType that incorrectly swapped the meaning of matrix.xy and matrix.yx, but as I understand it this has now been corrected. Which version of FreeType have you been using? We could probably add a run time check to work around this bug if need be. Huw.

1 0

Re: Map "MS Sans Serif" font -> "Microsoft Sans Serif"
by Huw D M Davies 08 Feb '03

08 Feb '03

On Wed, Feb 05, 2003 at 06:32:09PM -0500, Warren_Baird(a)cimmetry.com wrote: > > > > ChangeLog: > > Added a fixed alias mapping "MS Sans Serif" -> "Microsoft Sans Serif". > > Description: > > Some excel documents expect to be able to load an "MS Sans Serif" > font and were getting "Microsoft Sans Serif" instead. > Why don't you add a font substitution to the registry? Under HKLM\\Software\\Microsoft\\Windows NT\\CurrentVersion\\FontSubstitutes something of the form "MS Sans Serif"="Microsoft Sans Serif" should work. Huw.

1 0

Re: Underline and strikethrough support
by Huw D M Davies 08 Feb '03

08 Feb '03

On Wed, Feb 05, 2003 at 06:18:50PM -0500, Warren_Baird(a)cimmetry.com wrote: > > > ChangeLog: > > Add support for underline and strikethrough font in XRender. > > Description: > > Use lfUnderline or lfStrikeOut logical font field in > X11DRV_XRender_ExtTextOut to determine if we should draw a > line using TSXDrawLine across or under the font that just got > rendered. Hi, The problem with this code is that it won't work for rotated text. Also the line widths and positions should be obtained using from the OUTLINETEXTMETRICS structure. Huw.

1 0

Re: Fix module entry deallocation in MODULE_DecRefCount
by Warren_Baird＠cimmetry.com 08 Feb '03

08 Feb '03

>the fix doesn't seem the right one... could you post a -debugmsg >+file,+module of what really happens here The places I've seen it happen are in parts of a large and complicated program - I'll see if I can find a simple test case that repros the problem and post a trace here. But I can give you more details on what I found happening... After calling LoadLibrary("foo") there were two entries for library foo in the MODULE_modref_list. When you unloaded the library the first entry found was removed, but the 2nd entry remained, but the memory behind it didn't exist any more. If you tried to load the library again, the loading code would find the entry in the modref list and try to reuse it, and immediately segfault... I seem to recall that the first entry had the correct path to the library, and the send entry had "C:\windows\system\foo.dll" or something like that... Note that I've only observed this on a sparc/solaris system - it may be due to a pecularity of the way libs are loaded there... If I can repro it with a simple enough case to generate a reasonably sized log, I'll post it here, hopefully tomorrow... Warren

2 1

OLE speed, builtin vs. native
by Dan Kegel 08 Feb '03

08 Feb '03

I'm testing an Installshield 6 setup program tonight against wine-20030115 remotely over a 1Mbit/sec link. Running native $ wine SETUP.EXE takes 1 minute 40 seconds to put up the main dialog. With the DLL overrides $ wine --dll compobj,storage,ole,ole2,ole32,oleaut32,rpcrt4=n SETUP.EXE it takes 1 minute 10 seconds. So our OLE seems to be noticably slower. I imagine we'll fix that up before 1.0. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

Various Visual FoxPro bug reports filed
by Paul McNett 07 Feb '03

07 Feb '03

Hello, I just filed 5 bug reports (1263-1267) regarding various issues with Microsoft Visual FoxPro. These represent some of the most obvious issues, but I'm sure I'll find more as I move my Visual FoxPro development over to Linux from Windows. I have a demo Visual FoxPro application that demonstrates these issues and a few more that I haven't reported in BugZilla yet. You can get this app from my site at: http://www.paulmcnett.com/vfp/testwine/ I'll be updating this app as new issues are discovered and old ones resolved. I'll now take this opportunity to thank everyone here for making Wine what it is today: you are giving me the ability to move off of Windows completely and yet still use my favorite development environment. Kudos to everyone involved! -- Paul McNett - p(a)ulmcnett.com Hollister, California, USA

1 0

145 Gnu Makefiles for all Petzold Programs
by John Kopplin 07 Feb '03

07 Feb '03

I have just completed 145 Gnu makefiles that allow the free MinGW (Gnu) Compiler to compile and execute all of the example programs which Charles Petzold describes in his "Programming Windows Fifth Edition" book, which is the standard reference book on Microsoft's WIN32 API. I freely distribute these 145 makefiles in a .ZIP file, along with an installation program that will copy them into Petzold's directory structure, from my web page at: http://www.computersciencelab.com/Petzold.htm Only 5 of the 145 programs require user intervention to compile with the Gnu compiler, which is not bad for porting that many programs to a new compiler, especially given Microsoft's lax adherence to standards. I would be very pleased if these makefiles would help with the development of the Wine emulator. John Kopplin _________________________________________________________________ Tired of spam? Get advanced junk mail protection with MSN 8. http://join.msn.com/?page=features/junkmail

2 1

To select or LBS_NOSEL...
by Ferenc Wagner 07 Feb '03

07 Feb '03

Hello, can anybody think of a way that a listbox with LBS_NOSEL style can still highlight a row, return meaningful values for LB_GETCURSEL and in general behave exatly like a selectable one? This is the behaviour I see under Win 95 and XP (using Spy++), and what I can achieve under Wine by unsetting the LBS_NOSEL attribute in LISTBOX_Create. What's going on? MSDN tells what you'd expect... I would be grateful for any insight. I hope to create some test program soon, but since I've never coded Windows GUIs it will probably take some time and brain cells. Feri.

1 0

Listview problems
by Dan Kegel 07 Feb '03

07 Feb '03

I've already sent this to Dimi, but... the demo http://msdn.microsoft.com/downloads/samples/internet/commctrl/vlistvw/defau… doesn't work very well with Wine at the moment. It demonstrates the LVS_OWNERDATA variant of a listview. I built it with msvc6. The default view looks ok, but if you pick a different view, the fun starts... "large icons" seem to all be drawn on top of each other. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

2 3

edit control bug
by Felipe W Damasio 07 Feb '03

07 Feb '03

Hi, I'm porting a software using winelib and found a (at least I think so) serious bug with the edit control: When you put a lot of text in an edit control and then begins to backspace them, the app simply seg faults. I'm using wine-20030115 but also tried wine-20021031, and both have this bug. Both the source and the executable for test are available here: ftp://elipse.com.br/pub/EditControl/about1-src.tar.gz ftp://elipse.com.br/pub/EditControl/about1-exe.tar.gz Yeah, I stole the example from Petzold's book....so please enter help->about to see the dialog :) Can anyone help with this? Is this a known wine bug? I did the usual google search but couldn't fine any reference of this. But if is: Is somebody working on it? Or will anyone work on this? And can I help? Thanks for any help you can give me (please CC me). Felipe

3 5

Re: RtlUpperChar (was: some ntdll functions) [Virus checked]
by thomas.mertes＠t-mobile.at 06 Feb '03

06 Feb '03

Dan Kegel <dank(a)kegel.com> wrote: > That looks like a horrible kludge. Before we settle on > something like this, we should probably consult the > people on the unicode mailing list to see what they > suggest. This is not what I suggest. Please read my complete mail. I wrote: I did a test on w2k trying to convert all chars between 0 and 255. The result was: Just 'a' .. 'z' are converted to 'A' .. 'Z', all other characters remain unchanged. I switched the machine between 'EN' (English) and 'DE' (German) and no difference. My test Function is: static void test_RtlUpperChar(void) { int i; CHAR ch; CHAR upper_ch; CHAR expected_upper_ch; for (i = 0; i <= 255; i++) { ch = (CHAR) i; upper_ch = pRtlUpperChar(ch); if (ch >= 'a' && ch <= 'z') { expected_upper_ch = ch - 'a' + 'A'; } else { expected_upper_ch = ch; } /* if */ ok(upper_ch == expected_upper_ch, "RtlUpperChar('%c') has result '%c', expected '%c'", ch, upper_ch, expected_upper_ch); } /* for */ } ... and this test passed really under native w2k. Greetings Thomas

2 1

WineConf 2003
by Dan Kegel 06 Feb '03

06 Feb '03

How about we hold it as a satellite conference to LinuxTag, Karlsruhe, Germany, 10-13 July 2003? LinuxTag is a very big, very cool event. See http://www.linuxtag.org/2003/en/conferences/cfp.html - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

4 5

Re: Fix module entry deallocation in MODULE_DecRefCount
by Eric Pouech 06 Feb '03

06 Feb '03

Warren_Baird(a)cimmetry.com wrote: > > > ChangeLog: > > Fix module entry deallocation in MODULE_DecRefCount. > > Description: > > Also decrement the reference count on any other libraries with > exactly the same short name since two module entries are being > allocated when we load the library. Maybe the real fix here would > be to ensure that a module entry is allocated no more than once > but we couldn't figure out how to do that. the fix doesn't seem the right one... could you post a -debugmsg +file,+module of what really happens here A+ -- Eric Pouech

1 0

Re: RtlUpperChar (was: some ntdll functions) [Virus checked]
by thomas.mertes＠t-mobile.at 06 Feb '03

06 Feb '03

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > <thomas.mertes(a)t-mobile.at> wrote: > > > RtlUpperChar does not take the locale into account. It always convertes > > just > > 'a' .. 'z' and nothing else. > > > > Is this the right direction or did I miss something? > > No, that's not right. We really need to convert to unicode first, then > upper case unicode character and convert the result back to ansi. See > the ReactOS source for reference (at the first glance it closely enough > matches NTDLL asm code). I have not seen the asm code. I just do tests on w2k (see my other mail). ReactOS is ok but not my measurement. These tests suggest that the right implementation would be: CHAR WINAPI RtlUpperChar( CHAR ch ) { if (ch >= 'a' && ch <= 'z') { return ch - 'a' + 'A'; } else { return ch; } } I was not able to find any other behaviour under w2k. RtlUpperString also just converts 'a' .. 'z' to 'A' .. 'Z'. In my opinion RtlUpperChar and RtlUpperString are low level functions which do not know anything about locales / codepages. But the ntdll (and msvcrt) functions toupper and _toupper should know about locales / codepages (may be they should use the solution below). BTW: My other implementation did it the ReactOS way and is not a 'horrible kludge': CHAR WINAPI RtlUpperChar( CHAR ch ) { WCHAR wch; wch = toupperW(((WCHAR) ch) & 0xff); if (wch >> 8) { return ch; } else { return (CHAR) wch; } } According to my information: When you do not have multibyte chars (as it is here), you just set the upper byte to 0. Just look close: ((WCHAR) ch) & 0xff is necessary because CHAR is signed and ((WCHAR) ch) would sign extend (which is wrong). I did a test with the 'horrible kludge' on wine and it worked fine (The ISO Latin 1 charaters got converted in the right way). Greetings Thomas

2 1

Re: Fixes for makepath
by Dimitrie O. Paun 06 Feb '03

06 Feb '03

On Thu, 6 Feb 2003 Warren_Baird(a)cimmetry.com wrote: > - TRACE("got %s %s %s %s\n", drive, directory, > - filename, extension); > + char tmpPath[MAX_PATH]; > + TRACE("got %s %s %s %s\n", > + drive ? drive : "", > + directory ? directory : "", > + filename ? filename : "", > + extension ? extension : ""); Please use debugstr_a instead, like so: TRACE("got %s %s %s %s\n", debugstr_a(drive), debugstr_a(directory)... -- Dimi.

1 0

Re: Winspool errors with notepad
by Sylvain Petreolle 06 Feb '03

06 Feb '03

trace:winspool:AddPrinterA ((null),2,0x407c2c1c): stub trace:winspool:DEVMODEdupAtoW trace:winspool:AddPrinterW (L"",2,0x4026ac58) Following these debug messages, we see that the name of the server on which the server is installed changes fromNULL to "". Currently we dont support remote printers and the the name must be NULL otherwise the function fails. It lies into wine/dlls/winspool/info.c : if(pName != NULL) { ERR("pName = %s - unsupported\n", debugstr_w(pName)); SetLastError(ERROR_INVALID_PARAMETER); return 0; The file was updated to avoid HEAP_strdupAtoW calls. Matthew, could you look at this ? ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

4 7

Re: Implement SelectPalette and RealizePalette in mfdrv
by Dmitry Timoshkov 06 Feb '03

06 Feb '03

<Warren_Baird(a)cimmetry.com> wrote: > diff -ur clean/wine/objects/palette.c wine/objects/palette.c > --- clean/wine/objects/palette.c Wed Jan 29 15:31:13 2003 > +++ wine/objects/palette.c Fri Jan 31 12:47:21 2003 > @@ -674,6 +674,7 @@ > } > if (!(dc = DC_GetDCPtr( hdc ))) return 0; > prev = dc->hPalette; > + if (dc->funcs->pSelectPalette) hpal = dc->funcs->pSelectPalette( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ here hpal is zeroed out. > dc->physDev, hpal, FALSE ); > dc->hPalette = hpal; ^^^^^^^^^^^^^^^^^^^ 1. The above code chunk always sets dc->hPalette to zero in the case of metafile dc. 2. It seems that most of your all patches are wrapped by your mailer. 3. Some of your patches use C++ comments. 4. Some of your patches use a C++ style of declaring variables in the arbitrary place of the function. Please fix all of the above and resend the affected patches. Thanks. -- Dmitry.

1 0

RE: WineConf 2003
by Patrik Stridvall 06 Feb '03

06 Feb '03

> LinuxTag is my favorite so far, fwiw, as > 1) it looks fairly well organized and interesting in its own right Yes, this is of course both good and bad. Good because it is as you said intresting, bad because we might lose the Wine focus. This is that IMHO happend at LinuxKongress in Erlangen (2000?). Sure it was a very nice social gathering and I enjoyed it very much but compared to WineConf 2002 in San Diego it didn't really amount to very much. Productively speaking that is. While I personnally are very likely to show up anyway, we really should carefully plan what we should do, not just take it as is comes as happend at LinuxKongress 2000. > 2) it's not freezing cold like Espoo in February would be True. It is quite cold here in Sweden right now and Finland is usually colder. :-) > 3) it's in a German-speaking country (I didn't learn my Grandma's > Finnish too well, but I did learn my Grandpa's German!) True. However the biggest use of I had of the little German I know was reading the menu at the resturant. :-) You will do fine with just English. > 4) it's the least likely of the bunch to conflict with the > arrival of my first kid on 31 July, the first day of the > Edinburgh event :-) 5) "The 9th Annual International LinuxTag will take place at the Convention Center in the Messe at Karlsruhe, Germany. Karlsruhe is located in the southern part of Germany near Heidelberg and can be easily reached via Frankfurt International Airport and by rail." Since AFAIK most European major airports (and quite a few minor airports) have flights to Frankfurt it will presumably be easier and cheaper traveling to than most of the alternatives. Please note if somebody wishes to speak at the conferance: "Abstract submission deadline: February 21, 2003"

1 0

Compile Error in d3d8
by Uwe Bonnes 06 Feb '03

06 Feb '03

Hallo, since about last week, wine compilation stops in d3d8: > device.o: In function `DrawPrimitiveI': > /home/bon/tmp/wine/compile/wine/dlls/d3d8/device.c:535: undefined reference to `glMultiTexCoord3f' > /home/bon/tmp/wine/compile/wine/dlls/d3d8/device.c:516: undefined reference to `glMultiTexCoord2f' > /home/bon/tmp/wine/compile/wine/dlls/d3d8/device.c:416: undefined reference to `glMultiTexCoord3f' I did a "make distclean" and the problem persists. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 3

Re: Opengl Glide
by Kristoffer Ericson 06 Feb '03

06 Feb '03

Greetings, I'm hoping we are nearing a solution, with so many people involved =) http://bugs.winehq.com/show_bug.cgi?id=1234 has been updated with logfiles and my small info. http://bugs.winehq.com/show_bug.cgi?id=1254 has been created with my info and logfiles. What other log files do you want? Best wishes >From: Lionel Ulmer <lionel.ulmer(a)free.fr> >To: Kristoffer Ericson <kristoffer_e1(a)hotmail.com> >CC: wine-devel(a)winehq.com >Subject: Re: Opengl Glide >Date: Wed, 5 Feb 2003 23:24:16 +0100 > > > Guilty as charged, been working on this thing for quite some time now. > >Well, can't find your bug report again... The latest open on Wine + Tribes >is not from you. > > > just send me the www link and i will upload the logs. > >If you can't find the bug anymore, raise two new ones (we will close the >old >ones when we find them :-) ). > >Or rather use this one for the dinput problem : > > http://bugs.winehq.com/show_bug.cgi?id=1234 > >If you can do for me the trace I asked at the end I would be happy :-) > > > Any idea, why Tribes don't detect opengl? i'm not familiar with any >other > > game that does this. Although i know that Tribes didn't support Opengl > > nativly but it added it with a patch later on. > >Well, for this, create a new bug and attach the +opengl,+relay,+x11drv log >I >requested. > > Lionel > >-- > Lionel Ulmer - http://www.bbrox.org/ _________________________________________________________________ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail

1 0

RtlUpperChar (was: some ntdll functions) [Virus checked]
by thomas.mertes＠t-mobile.at 06 Feb '03

06 Feb '03

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > > IMHO RtlUpperChar has nothing to do for unicode chars. > > Is there a way to use Wine internal code page to do the conversion without > > converting to unicode and back? > > Wine has only unicode case conversion tables and currently there is no way > to avoid forth and back conversions. My solution for this is: /************************************************************************** * RtlUpperChar (NTDLL.@) */ CHAR WINAPI RtlUpperChar( CHAR ch ) { WCHAR wch; wch = toupperW(((WCHAR) ch) & 0xff); if (wch >> 8) { return ch; } else { return (CHAR) wch; } } This would mean: Some ISO Latin 1 characters would be converted additionally to 'a' .. 'z'. I did a test on w2k trying to convert all chars between 0 and 255. The result was: Just 'a' .. 'z' are converted to 'A' .. 'Z', all other characters remain unchanged. I switched the machine between 'EN' (English) and 'DE' (German) and no difference. May be this was the wrong place to switch the locale / code pages ... My guess is: RtlUpperChar does not take the locale into account. It always convertes just 'a' .. 'z' and nothing else. Is this the right direction or did I miss something? Greetings Thomas

3 2

controls\edit.c
by Dietrich_Teickner＠t-online.de 06 Feb '03

06 Feb '03

Hi , I have found, the undo_buffer_size for the realoated undo_buffer in controls\edit.c was invalid remembered, it was one to high (alloc_size/sizeof(WCHAR)). It must be alloc_size/sizeof(WCHAR) - 1. After second realloc and many(32) delete backwards was the word after the undo_buffer overwritten. Has the first allocated undo_buffer_size the VALUE from 15, so is the VALUE from undo_buffer_size after reallocation 32, not 31. Dietrich (from odin) /********************************************************************* * * EDIT_MakeUndoFit * * Try to fit size + 1 bytes in the undo buffer. * */ static BOOL EDIT_MakeUndoFit(EDITSTATE *es, UINT size) { UINT alloc_size; if (size <= es->undo_buffer_size) return TRUE; TRACE("trying to ReAlloc to %d+1\n", size); alloc_size = ROUND_TO_GROW((size + 1) * sizeof(WCHAR)); if ((es->undo_text = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, es->undo_text, alloc_size))) { es->undo_buffer_size = alloc_size/sizeof(WCHAR) - 1; ------------------------------------------------------------------> return TRUE; } else { WARN("FAILED ! We now have %d+1\n", es->undo_buffer_size); return FALSE; } }

1 0

remote app problem: menus go away at wrong time
by Dan Kegel 06 Feb '03

06 Feb '03

I was sitting at my wife's XP machine with a spare five minutes, and it suddently came to me that I haven't done enough remote testing of Wine. So I ran wcmd cygwin startx ssh -X mybox ssh mylaptop wine spyxx.exe just to see how well wine would work via two ssh hops on top of x on top of cygwin on top of winxp. First issue: you can't use the menus with the mouse! Sure, they'll pop up, but when you move the mouse down to one of the menu items, the menu goes away. It decides the user really wanted to highlight the toolbar, or something. Before you say "Aw, nobody'll do that", consider that LTSP is getting a lot more popular... and last week a local small business owner I know asked me to help set up diskless Linux workstations to run his existing Windows apps. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

4 6

Re: fix generation of PolyPolygon in mfdrv
by Dan Kegel 06 Feb '03

06 Feb '03

Warren, thanks for taking the time to submit all those patches! - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

Re: move palettes from GDI heap to system heap
by Michael Stefaniuc 05 Feb '03

05 Feb '03

On Wed, Feb 05, 2003 at 06:30:21PM -0500, Warren_Baird(a)cimmetry.com wrote: > > > > ChangeLog: > > Allocate palette objects on the large heap instead of the GDI heap > to avoid GDI heap saturation. This is already in CVS. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: Opengl Glide
by Kristoffer Ericson 05 Feb '03

05 Feb '03

Hey, Guilty as charged, been working on this thing for quite some time now. just send me the www link and i will upload the logs. Any idea, why Tribes don't detect opengl? i'm not familiar with any other game that does this. Although i know that Tribes didn't support Opengl nativly but it added it with a patch later on. Best wishes >From: Lionel Ulmer <lionel.ulmer(a)free.fr> >To: Kristoffer Ericson <kristoffer_e1(a)hotmail.com> >CC: wine-devel(a)winehq.com >Subject: Re: Opengl Glide >Date: Wed, 5 Feb 2003 18:21:53 +0100 > >Out of curiosity : are you the guy who submitted the Tribes 1 bug on WineHQ >about input and stuff ? > >If not, could you raise a bug (or two, one for input the other for OpenGL) >so that we could go back and forth on these issues more easily than by mail >on the devel list ? > > > * As soon as any key is pressed, wine quits > > = Fix with native dinput.dll version dx4->dx6 > >For this I would need a --debugmsg +dinput,+seh trace of the problem. THe >debugger won't work due to the 'LL hooks' problem, but let's hope that it >will be enough. > > > * Opengl isn't detected and impossible to choose > > = Currently no fix, although it works to use glidewrappers. Don't know > > what Tribes uses to detect opengl. > >For this, a +relay,+opengl,+x11drv log would be needed. > > > My other question is this, if i want to use glide (got a voodoo3) how do >i > > enable and use this in wine? > > > > Do i do a ./configure --enable-glide or --with-glide ? > > And so on.. > >If should be used automagically and not need any configure stuff. > > Lionel > >-- > Lionel Ulmer - http://www.bbrox.org/ _________________________________________________________________ STOP MORE SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=features/junkmail

2 1

Re: Code Duplication
by Brian Vincent (C) 05 Feb '03

05 Feb '03

>During my work to clean up the Unicode -> ascii cross-calls I have >noticed some A:W pairs where both are implemented in essentially the >same way. Would it be sensible in these case to make the A function into >a call to the W one, to reduce code size, or would I be wasting my time. This was discussed back in Novemeber: http://www.winehq.com/news/?view=143#Avoiding%20ASCII/Unicode%20Function%20D uplication Follow the "Archive" link for the thread. If I remember correctly there was no right or wrong thing to do - it depended on the case. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

font metrics II
by Scott Jackson 05 Feb '03

05 Feb '03

ok, here's a better question: since my Japanese fonts don't puke under X11 (but do under wine :-P ), is there any way I can get wine to ignore certain directories of fonts?? This would help b/c wine crashes on one of my Kappa fonts. Thanks! -- "De-fault! The two sweetest words in the English language." -- Homer Simpson Get Gaim for unix or win32 systems! gaim.sourceforge.net Scott "Action" Jackson - scott_j(a)ajackson.org

2 1

{G|S}etThreadContext question
by Rein Klazes 05 Feb '03

05 Feb '03

hi, I am trying to add some support for the floating point unit to winedbg. I have one question to the experts. The debugger code gets/sets the CPU registers through a {G|S}etThreadContext() from the server, adding the flag CONTEXT_FLOATING_POINT should make sure to include the FP registers. This doesn't work because the server code clears the CONTEXT_FLOATING_POINT flag at some point (see attached patch). My patch is simply preventing this, but it may well be that the FP registers should be available at this point. So is this the correct fix? Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 3

CVS Compile error.
by Patrik Båt 05 Feb '03

05 Feb '03

Hello people out there! Im trying to compile the cvs source of WINE and gets error: gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -mpreferred-stack-boundary=2 -fno-keep-static-consts -D__int8=char -D__int16=short -D__int32=int "-D__int64=long long" -fPIC -D__WINE__ -fshort-wchar -D_REENTRANT -I/usr/X11R6/include -o dpnet_main.o dpnet_main.c cc1: Invalid option `-fshort-wchar' make[2]: *** [dpnet_main.o] Error 1 make[2]: Leaving directory `/root/winecvs/wine/dlls/dpnet' make[1]: *** [dpnet/libdpnet.so] Error 2 make[1]: Leaving directory `/root/winecvs/wine/dlls' make: *** [dlls] Error 2 Is it anyone ho have a clue? I updated the CVS source today, 2003-02-05 (YYYY-MM-DD). ./configure dosen't complaine... My system is: Linux 2.4.20, Debian 3.0 unstable. -- Patrik Båt <patrik(a)researchelectronics.se> Research Electronics AB

4 7

Re: CVS Compile error.
by Patrik Båt 05 Feb '03

05 Feb '03

hello, testing som stuff here.... root@lightning:~/winecvs/wine# gcc -fshort-wchar test.c cc1: Invalid option `-fshort-wchar' root@lightning:~/winecvs/wine# with 2.54 and root@lightning:~/winecvs/wine# gcc -fshort-wchar test.c root@lightning:~/winecvs/wine# cat test.c #include <stdio.h> int main() { printf("hello!"); } with 3.0 -- Patrik Båt <patrik.bat(a)home.se>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel