- wine-devel - winehq.org

Re: prevent dereferencing null
by Dimitrie O. Paun 14 Jan '03

14 Jan '03

On January 9, 2003 07:08 pm, Bill Medland wrote: > + if (!tpinfo->chanbuf) { > + ERR("tpinfo has no Rpc Channel Buffer\n"); > + return 0; > + } Is this expected behaviour? If so, there's no need for the ERR msg. If not, there's no need for the test, we need to fix the root cause... -- Dimi.

3 4

patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by liu spider 14 Jan '03

14 Jan '03

Thanks to Dmitry Timoshkov. This patch is the second edition, adopted his suggestions. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW GetFileTitleA now is a call to GetFileTitleW (The patch seems to be ignored without any comments. Could anyone give some clues on how to improve this patch? thanks.) liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com Index: dlls/commdlg/filetitle.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/filetitle.c,v retrieving revision 1.12 diff -u -r1.12 filetitle.c --- dlls/commdlg/filetitle.c 31 May 2002 23:25:45 -0000 1.12 +++ dlls/commdlg/filetitle.c 12 Jan 2003 07:09:56 -0000 @@ -3,6 +3,7 @@ * * Copyright 1994 Martin Ayotte * Copyright 1996 Albrecht Kleine + * Copyright 2003 liuspider * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -24,10 +25,10 @@ #include "winbase.h" #include "winnls.h" #include "commdlg.h" +#include "wine/unicode.h" +#include "winternl.h" #include "wine/debug.h" -#include "heap.h" /* Has to go */ - WINE_DEFAULT_DEBUG_CHANNEL(commdlg); #include "cdlg.h" @@ -38,19 +39,39 @@ */ short WINAPI GetFileTitleA(LPCSTR lpFile, LPSTR lpTitle, UINT cbBuf) { - int i, len; + int ret; + UNICODE_STRING strWFile, strWTitle; + RtlCreateUnicodeStringFromAsciiz(&strWFile, lpFile); + RtlCreateUnicodeStringFromAsciiz(&strWTitle,lpTitle); + ret = GetFileTitleW(strWFile.Buffer, strWTitle.Buffer, cbBuf * sizeof(WCHAR)); + if (!ret){ + WideCharToMultiByte( CP_ACP, 0, strWTitle.Buffer, -1, lpTitle, cbBuf, NULL, NULL ); + } + RtlFreeUnicodeString( &strWFile ); + RtlFreeUnicodeString( &strWTitle ); + return ret; +} + +/*********************************************************************** + * GetFileTitleW (COMDLG32.@) + * + */ +short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) +{ + int i, len; + WCHAR brkpoint[] = {'*','[',']'}; TRACE("(%p %p %d); \n", lpFile, lpTitle, cbBuf); if(lpFile == NULL || lpTitle == NULL) return -1; - len = strlen(lpFile); + len = strlenW(lpFile); if (len == 0) return -1; - if(strpbrk(lpFile, "*[]")) + if(strpbrkW(lpFile, brkpoint)) return -1; len--; @@ -70,34 +91,14 @@ if(i == -1) i++; - TRACE("---> '%s' \n", &lpFile[i]); + TRACE("---> '%s' \n", debugstr_w(&lpFile[i])); - len = strlen(lpFile+i)+1; + len = strlenW(lpFile+i)+1; if(cbBuf < len) return len; - strncpy(lpTitle, &lpFile[i], len); + strncpyW(lpTitle, &lpFile[i], len); return 0; -} - - -/*********************************************************************** - * GetFileTitleW (COMDLG32.@) - * - */ -short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) -{ - LPSTR file = HEAP_strdupWtoA(GetProcessHeap(), 0, lpFile); /* Has to go */ - LPSTR title = HeapAlloc(GetProcessHeap(), 0, cbBuf); - short ret; - - ret = GetFileTitleA(file, title, cbBuf); - - if (cbBuf > 0 && !MultiByteToWideChar( CP_ACP, 0, title, -1, lpTitle, cbBuf )) - lpTitle[cbBuf-1] = 0; - HeapFree(GetProcessHeap(), 0, file); - HeapFree(GetProcessHeap(), 0, title); - return ret; }

1 0

Re: tests for GetPrinterDriverDirectoryA
by Francois Gouget 14 Jan '03

14 Jan '03

On Mon, 13 Jan 2003, Stefan Leichter wrote: > Am Montag 13 Januar 2003 18:42 schrieben Sie: > > On Sun, 12 Jan 2003, Stefan Leichter wrote: > > > Am Sonntag 12 Januar 2003 02:43 schrieben Sie: [...] > > > > However it fails on Wine: > > > > info.c:25: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:30: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:34: Test failed: expected result == 0, got 18 > > > > info.c:35: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:48: Test failed: expected result != 0, got 0 > > > > info.c:71: Test failed: expected result != 0, got 0 > > after this patch wine will fix the errors listed above Yep, that works. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

Re: Help with /?? stuff
by Alberto Massari 13 Jan '03

13 Jan '03

At 20.24 10/01/2003 +0200, Shachar Shemesh wrote: >Alberto Massari wrote: > >[...] >> >>BTW, do you need any help on this task? > >"Need" is a strong term. I can complete the task on my own, but your help >will be most welcome (in other words, if there is another aread of Wine >that needs your attention and noone seems to be working on, that would be >a better use of everyone's time). If you want to help with wineboot, I >think the best place to start is with the "win.ini" processing, and then >to port Andy's function to run whole "run" keys to the new prog. > >If you do decide to help with wineboot, please email me in private when >starting to work on each activity, to prevent "competition" on writing >stuff in. Unfortunately I'm currently fully booked on trying to fix the bugs that prevent ole32 and shell32 from working with IE6; but installing IE6 needs a working wineboot, so, whenever I succeed in the first task, I will start working on wineboot. Alberto

3 11

what does __leave do?
by Greg Turner 13 Jan '03

13 Jan '03

Could someone run the following code under a microsoft compiler for me, and let me know the result? main() { int x = 0; __try { x = 1; __leave; } __finally { x = 2; } printf("x was %d\n", x); } thanks, -- gmt "If everyone is thinking alike then somebody isn't thinking." --George S. Patton

2 2

Sysparams registry tests
by Francois Gouget 13 Jan '03

13 Jan '03

Here are the failing user32/sysparams registry tests on Win95, Win98 and NT4. sysparams.c:676:testing SPI_{GET,SET}MENUDROPALIGNMENT sysparams.c:161: Test failed: Wrong value in registry: subKey=Software\Microsoft\Windows NT\CurrentVersion\Windows, valName=MenuDropAlignment, testValue=1, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Software\Microsoft\Windows NT\CurrentVersion\Windows, valName=MenuDropAlignment, testValue=0, value= -> on Win9x this is in Control Panel\desktop sysparams.c:711:testing SPI_{GET,SET}DOUBLECLKWIDTH sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickWidth, testValue=0, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickWidth, testValue=10000, value= -> on Win9x this is in Control Panel\desktop sysparams.c:741:testing SPI_{GET,SET}DOUBLECLKHEIGHT sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickHeight, testValue=0, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickHeight, testValue=10000, value= -> on Win9x this is in Control Panel\desktop sysparams.c:644:testing SPI_{GET,SET}ICONTITLEWRAP sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Desktop\WindowMetrics, valName=IconTitleWrap, testValue=1, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Desktop\WindowMetrics, valName=IconTitleWrap, testValue=0, value= -> on NT4 this is in Control Panel\Desktop Notice how this is not even a clean separation between NT OSes and Win9x ones: Win9x aligns with XP for SPI_SETICONTITLEWRAP but not NT4, while for the other settings it's the opposite. Anyway, is it worth keeping these tests? That is making sure that SPI_xxx stores the setting in the registry key we expect? Do we know of applications that depend on these specific settings? If not then I will just submit a patch to remove these checks. Or maybe Wine should store these settings in all known locations? Note that I already removed these tests for SPI_ICONHORIZONTALSPACING and SPI_ICONVERTICALSPACING because for these Windows does not even always store the same value: sometimes it's the value we provide but most of the time that value seems to be multiplied by -15 (resulting in the negative number!). And the -15 changes to anothe value if you change the icon size. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

1 0

Re: user32.SendMessageCallback
by Alexandre Julliard 13 Jan '03

13 Jan '03

"Robert Shearman" <R.J.Shearman(a)warwick.ac.uk> writes: > ChangeLog: > - Fix SendMessageCallback so that it works in all cases now You can't do it that way, the callback has to be called in the context of the thread that sent the message. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: tests for GetPrinterDriverDirectoryA
by Francois Gouget 13 Jan '03

13 Jan '03

On Tue, 7 Jan 2003, Stefan Leichter wrote: > Hello, > > here are some tests for GetPrinterDriverDirectoryA. They should pass on NT4 > and hopefully win95 too. Thanks to Francois Gouget for testing. I see this test has not been committed yet... I tested it and it works on Win95, Win98, NT4 and XP. It's a much better score than some other tests... However it fails on Wine: info.c:25: Test failed: pcbNeeded set to 18 instead of 19 info.c:30: Test failed: pcbNeeded set to 18 instead of 19 info.c:34: Test failed: expected result == 0, got 18 info.c:35: Test failed: pcbNeeded set to 18 instead of 19 info.c:48: Test failed: expected result != 0, got 0 info.c:71: Test failed: expected result != 0, got 0 The easy solution is to just wrap the relevant tests in a 'todo_wine'. The better one is to fix Wine... Or if the fix is too long to do, wrap with todo_wine now so the test can be committed now, and then fix Wine and remove the relevant todo_wine statements after each fix. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

2 2

Re: Re: The version info patches + d3d question
by fenix＠club-internet.fr 13 Jan '03

13 Jan '03

----Message d'origine---- >Date: Mon, 13 Jan 2003 16:04:10 +0100 >De: Lionel Ulmer <lionel.ulmer(a)free.fr> >A: fenix(a)club-internet.fr >Copie à: farmboy1(a)subdimension.com, wine-devel(a)winehq.com >Sujet: Re: The version info patches + d3d question > >> >the problem is they dont run even with the patches because they cant get >> >version info from d3dim.dll and probably other d3d dlls. >> >since wine doesnt have these dlls how can wine give these programs the needed >> >info or is it planned to split ddraw in a ddraw and a d3d component? >> >> actually, we are speaking about d3d architecture, but it will be possible to implement d3dim.dll (minors d3d calls) into near future using the "new" codebase. >> And d3d component (for version 3..7) is contained into ddraw.dll > >I don't even know WHAT d3dim.dll is :-) What does it contain for API ? d3dim.dll - D3DFree - D3DMalloc - D3DRealloc - Direct3DCreateDevice - Direct3DCreateTexture - Direct3DGetSWRastZPixFmts - Direct3DCreate - Direct3D_HALCleanUp - FlushD3DDevices2 - FlushD3DDevices - PaletteAssociateNotify - PaletteUpdateNotify - SurfaceFlipNotify d3dim700.dll - D3DFree - D3DMalloc - D3DRealloc - Direct3DCreateDevice - CreateTexture - D3DBreakVBLock - D3DTextureUpdate - DestroyTexture - Direct3DCreate - Direct3D_HALCleanUp - FlushD3DDevices - GetLOD - GetPriority - PaletteAssociateNotify - PaletteUpdateNotify - SetLOD - SetPriority - SurfaceFlipNotify >I know about D3DRM.DLL (that won't be supported) for the 'retained mode' API >but I thought that all 'immediate mode' API was in ddraw.dll and not in a >separate library. yes, you are right. d3dim is only some utilities functions and interfaces for d3d immediate mode. (with d3d8 most of the code of d3dim and d3dxof was moved into d3dx8) >Why not first test with an empty DLL with just the version ressources in it >and see if it's enough ? maybe with only emtpy stubs now :) > Lionel Raphael

1 0

Re: The version info patches + d3d question
by fenix＠club-internet.fr 13 Jan '03

13 Jan '03

----Message d'origine---- >De: Enrico Horn <farmboy1(a)subdimension.com> >A: wine-devel(a)winehq.com >Sujet: The version info patches + d3d question >Date: Mon, 13 Jan 2003 14:47:31 +0100 > >Hi, Hi, >The patches add version info to directx libraries. >some games(for instance lucasarts games) wont run without finding a valid >version of the directx files. thanks, maybe you can do the same for d3d8 :) >the problem is they dont run even with the patches because they cant get >version info from d3dim.dll and probably other d3d dlls. >since wine doesnt have these dlls how can wine give these programs the needed >info or is it planned to split ddraw in a ddraw and a d3d component? actually, we are speaking about d3d architecture, but it will be possible to implement d3dim.dll (minors d3d calls) into near future using the "new" codebase. And d3d component (for version 3..7) is contained into ddraw.dll >Have fun >Enrico Regards, Raphael

2 1

The version info patches + d3d question
by Enrico Horn 13 Jan '03

13 Jan '03

Hi, The patches add version info to directx libraries. some games(for instance lucasarts games) wont run without finding a valid version of the directx files. the problem is they dont run even with the patches because they cant get version info from d3dim.dll and probably other d3d dlls. since wine doesnt have these dlls how can wine give these programs the needed info or is it planned to split ddraw in a ddraw and a d3d component? Have fun Enrico

1 0

Direct3D/OpenGL compilation error
by Francois Gouget 13 Jan '03

13 Jan '03

One of the machines I compile on from time to time is an old RedHat 6.2 which is nice because it still has glibc 2.1.3 so the binaries it produces work on all Linux distributions. Anyway, the latest Wine does not compile anymore on that machine. I get: gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -g -O2 -Wall -gstabs+ -fPIC -D__WINESRC__ -D_REENTRANT -o device.o device.c device.c: In function `SOURCEx_RGB_EXT': device.c:859: `GL_SOURCE2_RGB_EXT' undeclared (first use in this function) device.c:859: (Each undeclared identifier is reported only once device.c:859: for each function it appears in.) device.c:860: `GL_SOURCE0_RGB_EXT' undeclared (first use in this function) device.c:861: `GL_SOURCE1_RGB_EXT' undeclared (first use in this function) device.c:869: warning: control reaches end of non-void function device.c: In function `OPERANDx_RGB_EXT': device.c:872: `GL_OPERAND2_RGB_EXT' undeclared (first use in this function) device.c:873: `GL_OPERAND0_RGB_EXT' undeclared (first use in this function) device.c:874: `GL_OPERAND1_RGB_EXT' undeclared (first use in this function) device.c:882: warning: control reaches end of non-void function device.c: In function `SOURCEx_ALPHA_EXT': device.c:885: `GL_SOURCE2_ALPHA_EXT' undeclared (first use in this function) device.c:886: `GL_SOURCE0_ALPHA_EXT' undeclared (first use in this function) device.c:887: `GL_SOURCE1_ALPHA_EXT' undeclared (first use in this function) device.c:895: warning: control reaches end of non-void function device.c: In function `OPERANDx_ALPHA_EXT': device.c:898: `GL_OPERAND2_ALPHA_EXT' undeclared (first use in this function) device.c:899: `GL_OPERAND0_ALPHA_EXT' undeclared (first use in this function) device.c:900: `GL_OPERAND1_ALPHA_EXT' undeclared (first use in this function) device.c:908: warning: control reaches end of non-void function device.c: In function `IDirect3DDevice8Impl_SetTextureStageState': device.c:3312: `GL_PREVIOUS_EXT' undeclared (first use in this function) device.c:3314: `GL_PRIMARY_COLOR_EXT' undeclared (first use in this function) device.c:3318: `GL_CONSTANT_EXT' undeclared (first use in this function) device.c:3350: `GL_COMBINE_ALPHA_EXT' undeclared (first use in this function) device.c:3350: `GL_COMBINE_RGB_EXT' undeclared (first use in this function) device.c:3409: `GL_RGB_SCALE_EXT' undeclared (first use in this function) device.c:3423: `GL_ADD_SIGNED_EXT' undeclared (first use in this function) So is it just that the OpenGL headers on that machine are hopelessly out of date (mesa 3.3) or is there some configure test that can/should be done? Note that if I compile with --without-opengl Wine compiles ok so it's not so bad. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

1 0

Developers current e-mail addresses listed in authors.ent
by Tom Wickline 13 Jan '03

13 Jan '03

I am getting ready to update the WINE Packagers Guide See : http://www.winehq.com/Docs/wine-pkg/ And the first thing that I noticed was Andreas & Marcus e-mail address were incorrect. So I then looked at : http://cvs.winehq.com/cvsweb/~checkout~/wine/documentation/authors.ent?rev=… And found that alot of other's were different from my Address Book. I have listed them below Current is what is now there current address in the *authors.ent* file. And below is the addresses that is listed in my address book. There are also a couple DOA addresses listed in this file and there at the bottom. I dont want to change this file and not have people's e-mail correct! So can everyone look over the file and let me know if your e-mail needs to be changed ?? Also a couple people below have multiable addresses can you let me know what address you want listed. Tom Current = ovek(a)winehq.com Ove Kaaven <ovek(a)arcticnet.no Ove Kaaven <ovehk(a)ping.uio.no ovek <ovek(a)transgaming.com --- Current = Marcus.Meissner(a)caldera.de Marcus Meissner <marcus(a)jet.franken.de Marcus Meissner <mm(a)lst.de ---- Current = amohr(a)codeweavers.com Andreas Mohr <andi(a)rhlx01.fht-esslingen.de --- Current = Speeddymon(a)yahoo.com Dustin Navea <Speeddymon(a)sbcglobal.net --- Current = dimi(a)cs.toronto.edu "Dimitrie O. Paun" <dpaun(a)rogers.com --- Current = juergen.schmied(a)metronet.de juergen schmied <juergen.schmied(a)debitel.net DOA addresses Should I leave them or remove them ?? douglas-ridgway "ridgway(a)winehq.com"> john-sheets "jsheets(a)codeweavers.com">

2 2

Re: Bug Fix With Delay load function in Shell32 (version2)
by Dimitrie O. Paun 12 Jan '03

12 Jan '03

On January 12, 2003 12:08 pm, Robert Shearman wrote: > Index: shellole.c Please make your patches relative to wine's root. > -HINSTANCE hShellOle32 = 0; > +HINSTANCE g_hShellOle32 = 0; /* global handle to ole32.dll */ Also, please do not introduce ugly naming conventions like the above, especially when the style the DLL is written in does not call for it. In general, we have none of these conventions in Wine, and it's preferable to just avoid them. We have a bunch of others though. :) -- Dimi.

1 0

Re: FreeBSD Compilation Fix
by Dimitrie O. Paun 12 Jan '03

12 Jan '03

On January 11, 2003 09:00 pm, Jared Goldberg wrote: > Index: dlls/dsound/tests/dsound.c > =================================================================== > RCS file: /home/wine/wine/dlls/dsound/tests/dsound.c,v > retrieving revision 1.3 > diff -r1.3 dsound.c > 20a21,23 > > >#if defined(__FreeBSD__) > >#include <stdlib.h> > >#else > > 21a25 > > >#endif Uniffied diffs please: cvs diff -u or diff -u See: http://www.winehq.org/development/#patches In this case, I suggest you just include stdlib.h without any ifdefs. It's a standard header, it should exist on all systems. -- Dimi.

1 0

Re: Shell Ordinals
by j.schmied＠t-online.de 12 Jan '03

12 Jan '03

Hi! We have a problem here... win9x and winnt have a very different set of ordinal functions exported. We have to decide what we support. At the moment most ordinals functions are win9x style. We should never mix both cases since then both explorer won't run. I think we don't have any chance to get the win9x explorer running. A long time ago I did a lot of explorer debugging and the nt4 explorer was nearly running since it's not as much involved into the booting of the system as the win9x one. So I would suggest to change the ordinals into the nt ones. It would cause some 9x only functions to be removed. The change of shell32.spec should be done in one go. PS: Since I recently started to do some shell32 work again: Who is doing what at the moment? Bye Juergen > > This includes a few ordinals used by explorer and desk.cpl > There seems to be a conflict between SHLocalAlloc/Free and the ordinals I > have made stubs for (on Win2k SP3 shell32.dll), but I have no way of knowing > which ordinal (if any) SHLocalAlloc/Free should be. > > ChangeLog: > - Implement some PropertySheetExtArray ordinals > - Add some stubs used by explorer > > Rob > -- juergen.schmied(a)debitel.net FAX über T-Online Fax&Fon: 01805 060 334 316 35 (12Cent/Min)

2 1

Re: conformance test for ShellExecute
by Francois Gouget 12 Jan '03

12 Jan '03

On Sun, 29 Dec 2002, Dan Kegel wrote: > Well, the puny little beginnings of one, anyway. > (I'll improve this later. Still, it already > catches a difference between Windows and Wine, > so it's worth committing as is.) I tested it on Win95, Win98, NT4 and XP and it worked on all platforms. However, since it currently fails in Wine should should enclose the test in a 'todo_wine' and resubmit it. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

1 0

patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by liu spider 12 Jan '03

12 Jan '03

Thanks to Dmitry Timoshkov. This patch is the second edition, adopted his suggestions. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW make GetFileTitleA a wrapper of GetFileTitleW liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

1 0

Re: wine/programs/wineboot wineboot.c Makefile.in
by Shachar Shemesh 11 Jan '03

11 Jan '03

Alexandre Julliard wrote: >ChangeSet ID: 6997 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2003/01/11 15:02:50 > >Modified files: > programs/wineboot: wineboot.c Makefile.in > >Log message: > Shachar Shemesh <wine-patches(a)sun.consumer.org.il> > Implemented the "pending rename" registry processing. > >Patch: http://cvs.winehq.com/patch.py?id=6997 > >Old revision New revision Changes Path > 1.2 1.3 +158 -3 wine/programs/wineboot/wineboot.c > 1.1 1.2 +1 -1 wine/programs/wineboot/Makefile.in > > > > Hi Alexander, Two points about the differences between the version I submitted and the version that made it in. 1. If you are going to reject the printing of "Windows is finishing to install your programs..." closing message, at least also remove the starting message (lines 105 and 106 of version 1.3 of the file). 2. The reason I added the cast on the free line was to remove a compilation warning. If you made sure the warning doesn't happen by changing somewhere else in the code, that's, of course, fine. Otherwise there is a warning when compiling (I am currently doing a clean compile to make sure whether that happens on my system). Shachar

3 5

Re: MciWave: some small cleanups
by Francois Gouget 11 Jan '03

11 Jan '03

On Sat, 11 Jan 2003, Eric Pouech wrote: > see changelog for the details [...] > Name: mciwave > ChangeLog: > License: X11 Actually the changelog is a bit short... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

2 1

Re: [D3D8 - 1] resend of Jason Texture work + many fixes
by Raphaël Junqueira 11 Jan '03

11 Jan '03

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Saturday 11 January 2003 01:27, Raphaël Junqueira wrote: > Hi again, I forgot to say with this patch now: - - i have run successfully the NVIDIA Effects Browser 3.0 (http://developer.nvidia.com/view.asp?IO=NVEffectsBrowser_3) with many effects as Aniso (http://developer.nvidia.com/view.asp?IO=Anisotropic_Lighting) or membrane_lighting (http://developer.nvidia.com/view.asp?IO=membrane_lighting) in pure vertex shader software emulation - - Warcraf3 Demo begin to run - - SplinterCell Demo now complain about stencil support anyone have other Dx8 games demos for testing (simple if possible) ? > Thanks > Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+H2hKp7NA3AmQTU4RAvalAJ9v746sFf+RiEGzC/Vuv1NBnprAsQCaAwdQ WiIc/yV8HbZe0iw3CwJoFuE= =He8Q -----END PGP SIGNATURE-----

2 2

C++ and winedbg: testers wanted
by Eric Pouech 11 Jan '03

11 Jan '03

as some folks have already noticed, loading ELF modules with C++ compilation units gave a zillion of traces while parsing debug info in winedbg this patch should silence this type of output it won't however add the C++ ABI to the debugger: heavy C++ debugging will require gdb (and also DwarfII debug info; stabs is so broken in this respect) on the C++ front, what should be possible is: - every class should be seen as a regular structures - non virtual methods will be available as functions (of course, this will be seen as a regular parameter, and functions will be seen as undecorated names... this may recall to some of us the old good days of cfront ;-) anyway, as gcc has some discrepencies it its stabs output in its version, I'd like to get some feedback of people loading C++ info into winedbg I already tested gcc 3.2 and 2.96, but results from 2.95, 3.0 and 3.3 would be appreciated TIA A+ -- Eric Pouech Name: wd_stabs ChangeLog: - added experimental parsing for C++ code (but winedbg doesn't support C++ ABI) - now loading symbols for included files License: X11 GenDate: 2003/01/11 17:14:34 UTC ModifiedFiles: programs/winedbg/stabs.c AddedFiles: =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/programs/winedbg/stabs.c,v retrieving revision 1.3 diff -u -u -r1.3 stabs.c --- programs/winedbg/stabs.c 29 Sep 2002 18:35:31 -0000 1.3 +++ programs/winedbg/stabs.c 11 Jan 2003 17:14:30 -0000 @@ -31,6 +31,8 @@ * available (hopefully) from http:\\sources.redhat.com\gdb\onlinedocs */ +#define WITH_CPP_STABS_PARSING 1 + #include "config.h" #include <sys/types.h> @@ -269,13 +271,13 @@ if (**x=='(') { (*x)++; /* '(' */ - filenr=strtol(*x,x,10); /* <int> */ + filenr=strtol(*x,x,10); /* <int> */ (*x)++; /* ',' */ - subnr=strtol(*x,x,10); /* <int> */ + subnr=strtol(*x,x,10); /* <int> */ (*x)++; /* ')' */ } else { filenr = 0; - subnr = strtol(*x,x,10); /* <int> */ + subnr = strtol(*x,x,10); /* <int> */ } return DEBUG_FileSubNr2StabEnum(filenr,subnr); } @@ -343,14 +345,58 @@ if (*ptd->ptr++ != ';') return -1; /* ';' */ return 0; } +#ifdef WITH_CPP_STABS_PARSING +static inline int DEBUG_PTS_ReadMethodInfo(struct ParseTypedefData* ptd, + struct datatype* dt) +{ + char* tmp; + + if (*ptd->ptr++ == ':') + { + if (!(tmp = strchr(ptd->ptr, ';'))) return -1; + ptd->ptr = tmp + 1; + + } + if (!(*ptd->ptr >= '0' && *ptd->ptr <= '9')) return -1; + ptd->ptr++; + if (!(ptd->ptr[0] >= 'A' && *ptd->ptr <= 'D')) return -1; + ptd->ptr++; + if (*ptd->ptr++ != '.') return -1; + if (*ptd->ptr != ';') + { + while (*ptd->ptr) + { + /* some GCC versions (2.96 for example) really spit out wrongly defined + * stabs... in some cases, the methods are not correctly handled + * so just swallow the garbage until either .; (end of method) + * or ;; (end of struct) are found + */ + if (ptd->ptr[0] == '.' && ptd->ptr[1] == ';') + { + ptd->ptr++; + break; + } + if (ptd->ptr[0] == ';' && ptd->ptr[1] == ';') + break; + ptd->ptr++; + } + } + + return 0; +} +#endif -static inline int DEBUG_PTS_ReadAggregate(struct ParseTypedefData* ptd, struct datatype* sdt) +static inline int DEBUG_PTS_ReadAggregate(struct ParseTypedefData* ptd, + struct datatype* sdt) { int sz, ofs; char* last; struct datatype* adt; int idx; int doadd; +#ifdef WITH_CPP_STABS_PARSING + BOOL inMethod; +#endif sz = strtol(ptd->ptr, &last, 10); if (last == ptd->ptr) return -1; @@ -366,29 +412,67 @@ while (*ptd->ptr != ';') { /* agg_name : type ',' <int:offset> ',' <int:size> */ idx = ptd->idx; + if (DEBUG_PTS_ReadID(ptd) == -1) return -1; /* Ref. TSDF R2.130 Section 7.4. When the field name is a method name * it is followed by two colons rather than one. */ - if (*ptd->ptr == ':') ptd->ptr++; + if (*ptd->ptr == ':') + { + ptd->ptr++; +#ifdef WITH_CPP_STABS_PARSING + { + char* psemic = strchr(ptd->ptr, ';'); + char* psharp = strchr(ptd->ptr, '#'); + if (!psharp || psharp > psemic) + { + struct datatype* dt = NULL; + /* FIXME: hack... this shall be a ctor */ + if (DEBUG_PTS_ReadTypedef(ptd, NULL, &dt) == -1) return -1; + if (DEBUG_PTS_ReadMethodInfo(ptd, dt) == -1) return -1; + if (*ptd->ptr++ != ';') return -1; + ptd->idx = idx; + continue; + } + } + inMethod = TRUE; + } + else + { + inMethod = FALSE; +#endif + } + if (DEBUG_PTS_ReadTypedef(ptd, NULL, &adt) == -1) return -1; if (!adt) return -1; - if (*ptd->ptr++ != ',') return -1; - if (DEBUG_PTS_ReadNum(ptd, &ofs) == -1) return -1; - if (*ptd->ptr++ != ',') return -1; - if (DEBUG_PTS_ReadNum(ptd, &sz) == -1) return -1; - if (*ptd->ptr++ != ';') return -1; + if (*ptd->ptr != ',') + { +#ifdef WITH_CPP_STABS_PARSING + if (!inMethod) +#endif + return -1; + ptd->ptr++; + } + else + { + ptd->ptr++; + if (DEBUG_PTS_ReadNum(ptd, &ofs) == -1) return -1; + if (*ptd->ptr++ != ',') return -1; + if (DEBUG_PTS_ReadNum(ptd, &sz) == -1) return -1; + if (*ptd->ptr++ != ';') return -1; - if (doadd) DEBUG_AddStructElement(sdt, ptd->buf + idx, adt, ofs, sz); + if (doadd) DEBUG_AddStructElement(sdt, ptd->buf + idx, adt, ofs, sz); + } ptd->idx = idx; } ptd->ptr++; /* ';' */ return 0; } -static inline int DEBUG_PTS_ReadEnum(struct ParseTypedefData* ptd, struct datatype* edt) +static inline int DEBUG_PTS_ReadEnum(struct ParseTypedefData* ptd, + struct datatype* edt) { int ofs; int idx; @@ -405,7 +489,8 @@ return 0; } -static inline int DEBUG_PTS_ReadArray(struct ParseTypedefData* ptd, struct datatype* adt) +static inline int DEBUG_PTS_ReadArray(struct ParseTypedefData* ptd, + struct datatype* adt) { int lo, hi; struct datatype* rdt; @@ -463,14 +548,17 @@ /* then the real definitions */ switch (*ptd->ptr++) { case '*': +#ifdef WITH_CPP_STABS_PARSING + case '&': +#endif new_dt = DEBUG_NewDataType(DT_POINTER, NULL); if (DEBUG_PTS_ReadTypedef(ptd, NULL, &ref_dt) == -1) return -1; DEBUG_SetPointerType(new_dt, ref_dt); break; - case 'k': /* 'const' modifier */ - case 'B': /* 'volatile' modifier */ - /* just kinda ignore the modifier, I guess -gmt */ - if (DEBUG_PTS_ReadTypedef(ptd, NULL, &new_dt) == -1) return -1; + case 'k': /* 'const' modifier */ + case 'B': /* 'volatile' modifier */ + /* just kinda ignore the modifier, I guess -gmt */ + if (DEBUG_PTS_ReadTypedef(ptd, NULL, &new_dt) == -1) return -1; break; case '(': ptd->ptr--; @@ -588,7 +676,8 @@ case 31: basic = DT_BASIC_LONGLONGINT; break; case 32: basic = DT_BASIC_ULONGLONGINT; break; default: - DEBUG_Printf(DBG_CHN_MESG, "Unsupported integral type (%d/%d)\n", lo, sz); + DEBUG_Printf(DBG_CHN_MESG, + "Unsupported integral type (%d/%d)\n", lo, sz); return -1; } if (!(new_dt = DEBUG_GetBasicType(basic))) { @@ -598,6 +687,35 @@ if (*ptd->ptr++ != ';') return -1; } break; +#ifdef WITH_CPP_STABS_PARSING + case '#': + new_dt = DEBUG_NewDataType(DT_FUNC, NULL); + if (*ptd->ptr == '#') + { + ptd->ptr++; + if (DEBUG_PTS_ReadTypedef(ptd, NULL, &ref_dt) == -1) return -1; + DEBUG_SetPointerType(new_dt, ref_dt); + if (*ptd->ptr++ != ';') return -1; + + } + else + { + struct datatype* cls_dt; + struct datatype* pmt_dt; + + if (DEBUG_PTS_ReadTypedef(ptd, NULL, &cls_dt) == -1) return -1; + if (*ptd->ptr++ != ',') return -1; + if (DEBUG_PTS_ReadTypedef(ptd, NULL, &ref_dt) == -1) return -1; + DEBUG_SetPointerType(new_dt, ref_dt); + while (*ptd->ptr++ == ',') + { + if (DEBUG_PTS_ReadTypedef(ptd, NULL, &pmt_dt) == -1) return -1; + } + } + if (DEBUG_PTS_ReadMethodInfo(ptd, new_dt) == -1) return -1; + + break; +#endif default: DEBUG_Printf(DBG_CHN_MESG, "Unknown type '%c'\n", ptd->ptr[-1]); return -1; @@ -647,11 +765,15 @@ if ((ptd.ptr = strchr(ptr, ':'))) { ptd.ptr++; if (*ptd.ptr != '(') ptd.ptr++; +#ifdef WITH_CPP_STABS_PARSING + /* most of type definitions take one char, except Tt */ + if (*ptd.ptr != '(') ptd.ptr++; +#endif ret = DEBUG_PTS_ReadTypedef(&ptd, typename, &dt); } if (ret == -1 || *ptd.ptr) { - DEBUG_Printf(DBG_CHN_MESG, "failure on %s at %s\n", ptr, ptd.ptr); + DEBUG_Printf(DBG_CHN_MESG, "Failure on %s at %s\n", ptr, ptd.ptr); return FALSE; } @@ -729,7 +851,7 @@ strtabinc = 0; stabbuff[0] = '\0'; - for(i=0; i < nstab; i++, stab_ptr++ ) + for (i = 0; i < nstab; i++, stab_ptr++) { ptr = strs + (unsigned int) stab_ptr->n_un.n_name; if( ptr[strlen(ptr) - 1] == '\\' ) @@ -944,7 +1066,7 @@ } #endif - if( *ptr == '\0' ) + if( *ptr == '\0' ) /* end of N_SO file */ { /* * Nuke old path. @@ -1004,7 +1127,7 @@ stabbuff[0] = '\0'; #if 0 - DEBUG_Printf(DBG_CHN_MESG, "%d %x %s\n", stab_ptr->n_type, + DEBUG_Printf(DBG_CHN_MESG, "0x%02x %x %s\n", stab_ptr->n_type, (unsigned int) stab_ptr->n_value, strs + (unsigned int) stab_ptr->n_un.n_name); #endif @@ -1044,7 +1167,7 @@ nsym = symtab->sh_size / sizeof(*symp); strp = (char *) (addr + strtab->sh_offset); - for(i=0; i < nsym; i++, symp++) + for (i = 0; i < nsym; i++, symp++) { /* * Ignore certain types of entries which really aren't of that much @@ -1165,7 +1288,7 @@ } if (stabsect == -1 || stabstrsect == -1) { - DEBUG_Printf(DBG_CHN_WARN, "no .stab section\n"); + DEBUG_Printf(DBG_CHN_WARN, "No .stab section\n"); goto leave; } @@ -1181,7 +1304,7 @@ dil = DIL_LOADED; } else { dil = DIL_ERROR; - DEBUG_Printf(DBG_CHN_WARN, "bad stabs\n"); + DEBUG_Printf(DBG_CHN_WARN, "Couldn't read correctly read stabs\n"); goto leave; } @@ -1350,7 +1473,9 @@ if (filename == NULL) return DIL_ERROR; if (DEBUG_FindModuleByName(filename, DMT_ELF)) return DIL_LOADED; +#ifndef WITH_CPP_STABS_PARSING if (strstr (filename, "libstdc++")) return DIL_ERROR; /* We know we can't do it */ +#endif dil = DEBUG_ProcessElfFile(filename, load_offset, dyn_addr); /* if relative pathname, try some absolute base dirs */ @@ -1383,6 +1508,7 @@ for (lm_addr = (u_long)dbg_hdr->r_map; lm_addr; lm_addr = (u_long)lm.l_next) { if (!DEBUG_READ_MEM_VERBOSE((void*)lm_addr, &lm, sizeof(lm))) return FALSE; + if (lm.l_addr != 0 && DEBUG_READ_MEM_VERBOSE((void*)lm.l_addr, &ehdr, sizeof(ehdr)) && ehdr.e_type == ET_DYN && /* only look at dynamic modules */

1 0

Re: patch for "GetFileTitleW: illegal call to GetFileTitleA"
by Dmitry Timoshkov 11 Jan '03

11 Jan '03

"liu spider" <liuspider(a)yahoo.com> wrote: > this is a patch to get rid of W->A calls: > GetFileTitleW: illegal call to GetFileTitleA > + ret = GetFileTitleW(lpwstrFile, lpwstrTitle, cbBuf); > + HeapFree(GetProcessHeap(), 0, lpwstrTitle); > + HeapFree(GetProcessHeap(), 0, lpwstrFile); > + return ret; > +} It would be a good idea to translate the result from unicode to ANSI. One more suggestion: RtlCreateUnicodeStringFromAsciiz is supposed to reduce trouble of conversion ASCIIZ strings to unicode. -- Dmitry.

2 1

Some ddraw / GDI palette problem
by Lionel Ulmer 11 Jan '03

11 Jan '03

Hi all, In 'old' D3D games, a lot of textures are created paletted... And each of these texture has its own DDraw palette object. And thus each has some GDI memory allocated. This means that after some time, we run out of GDI Heap space due to all these palettes created there : trace:ddraw:Main_DirectDraw_CreatePalette (0x4038ff48)->(00000044,0x406b1340,0x406b1978,(nil)) trace:palette:CreatePalette entries=256 err:local:LOCAL_GetBlock not enough space in GDI heap 01b7 for 1052 bytes Now that problem is fixed in one game (it was due to some bad reference counting is some D3D code fixed in patch 79), but if ever it happens in yet another game, is it possible to increase this space ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Re: Help with /?? stuff
by John K. Hohm 11 Jan '03

11 Jan '03

> > Alberto Massari wrote: > > I guess Wine is converting the NULL into \?? to be able to store it as > > a string. Shachar Shemesh wrote: > You guessed wrong. The leading \?? is there under both Wine and Windows > 2000, and in both cases there is ALSO a NULL. As neither Wine nor > Windows 2000 then accepts that as a valid path, I'll just remove it. I > was just wondering whether anyone knows why Windows 2000 puts that extra > stuff in (it's obvious why wine does that - to be compatible). I'm not sure about \??, but see this excerpt from MSDN Re CreateFile: lpFileName [in] Pointer to a null-terminated string that specifies the name of the object to create or open. In the ANSI version of this function, the name is limited to MAX_PATH characters. To extend this limit to 32,767 wide characters, call the Unicode version of the function and prepend "\\?\" to the path. For more information, see Naming a File. Windows 95/98/Me: This string must not exceed MAX_PATH characters.

3 2

Re: PATCH - Check/Define for vsnprintf/_vsnprintf
by Dimitrie O. Paun 11 Jan '03

11 Jan '03

On January 10, 2003 07:47 pm, Steven Edwards wrote: > Changelog: (porting fix for Mingw/Windows) > check for vsnprintf and _vsnprintf > define vsnprintf with _vsnprintf Alexandre, why don't we link with oldnames.lib in Windows, and get rid of all these tests? -- Dimi.

4 4

shlwapi.dll from Wine regression tests on Windows 2000 SP3
by Steven Edwards 11 Jan '03

11 Jan '03

I did a compare of windows shlwapi with WINEs shlwapi. With Windows 2000 SP3 shlwapi.dll we get - C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe clist clist: 236 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe generated generated: 25 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe path path.c:92: Test failed: Expected ?query=x&return=y, but got query=x&return=y path: 33 tests executed, 0 marked as todo, 1 failure. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe shreg shreg.c:171: Test failed: (44,43) shreg.c:183: Test failed: (2) shreg.c:195: Test failed: (14,43) shreg.c:196: Test failed: (2) shreg.c:204: Test failed: Expected ERROR_MORE_DATA shreg.c:205: Test failed: () shreg.c:206: Test failed: () shreg.c:207: Test failed: (1,43) shreg.c:218: Test failed: (44,43) shreg.c:262: Test failed: didn't open copy shreg: 40 tests executed, 0 marked as todo, 10 failures. C:\Documents and Settings\Administrator\Desktop\test> With the current WINE shlwapi on Windows 2000 we get C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe clist clist: 236 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe generated generated: 25 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe path fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected localhost, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected 21, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected foo, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected bar, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected http, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar@localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected ?query=x&return=y, but got x☺� path: 33 tests executed, 0 marked as todo, 24 failures. C:\Documents and Settings\Administrator\Desktop\test> C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe shreg shreg.c:171: Test failed: (44,43) shreg.c:195: Test failed: (44,43) shreg.c:205: Test failed: () shreg.c:206: Test failed: () shreg.c:207: Test failed: (44,43) shreg.c:218: Test failed: (44,43) shreg.c:262: Test failed: didn't open copy shreg: 37 tests executed, 0 marked as todo, 7 failures. C:\Documents and Settings\Administrator\Desktop\test> __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

1 0

dx8 Patches - Question
by Ann and Jason Edmeades 11 Jan '03

11 Jan '03

Just a question, I noticed some of the dx8 patches are not applied - Is it due to the Chrismas backlog where Alexander took a very well deserved break, or because they have slipped through the cracks (or are there problems with them)? Will it help to resubmit them based off the current cvs since there were about 4 chained together each based off the previous one? Jason

3 3

wine/ole error on Mingw32/MSYS
by Steven Edwards 11 Jan '03

11 Jan '03

Platform is a older MSYS and GCC (3.1 something I think). I'm still getting settled in from getting tied-down so I cant test this on the latest mingw-current. only on dial-up here for now =(. Anyway any idea about this? Thanks Steven $ make gcc -c -I. -I. -I../include -I../include -DWINE_NOWINSOCK -Wall -mpreferred-sta ck-boundary=2 -gstabs+ -D__WINESRC__ -D_REENTRANT -o dx8guid.o dx8guid.c In file included from dx8guid.c:26: ../include/winuser.h:2396: unnamed fields of type other than struct or union are not allowed ../include/winuser.h:2409: unnamed fields of type other than struct or union are not allowed make: *** [dx8guid.o] Error 1 __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

3 2

Re: msvcrt: stubs for chsize, dup, dup2
by Steven Edwards 11 Jan '03

11 Jan '03

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > These are needed by the inline functions in the header. > > ChangeLog > Create stubs for chsize, dup, and dup2. I think chsize and ftruncate do the same thing so is there anyway to forward the call for chsize to ftruncate on platforms that have it? I added a configure check for this a while back because windows doesnt have ftruncate and makedep needs it. __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

1 0

[RFC] msvcrt: defines break C++ code
by Dimitrie O. Paun 10 Jan '03

10 Jan '03

Folks, We have a lot of code in msvcrt headers like so: #define umask _umask #define unlink _unlink #define write _write This breaks C++ that define a write method in a header, and then implement it like so: #include <io.h> void MyClass::write(...) { write(...); } I suggest we turn those defines into inlines, like this: inline int write(int fd, const void* ptr, unsigned int size) { return _write(fd, ptr, size); } Any other solutions? -- Dimi.

4 6

Windows 2000 conformance test update
by Dave Miller 10 Jan '03

10 Jan '03

Here are three updates for the status page. I think user32/sysparams passed for me previously. C:\winetests>kernel32_test.exe path path.c:514: Test failed: GetLongPathNameA: wrong return code, 97 instead of 42 path.c:881:TMP=C:\DOCUME~1\davidm\LOCALS~1\Temp path.c:892:TMP=C:\WINNT path.c:902:TMP=C:\ path.c:912:TMP=C: path: 1730 tests executed, 0 marked as todo, 1 failure. C:\winetests>urlmon_test generated generated: 4 tests executed, 0 marked as todo, 0 failures. C:\winetests>user32_test sysparams sysparams.c:184:testing SPI_{GET,SET}BEEP sysparams.c:306:testing SPI_{GET,SET}MOUSE sysparams.c:374:testing SPI_{GET,SET}BORDER sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=1, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=0, value= sysparams.c:139: Test failed: Missed a message: change_counter=2 sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=7, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=20, value= sysparams.c:406:testing SPI_{GET,SET}KEYBOARDSPEED sysparams.c:139: Test failed: Missed a message: change_counter=2 sysparams.c:440:testing SPI_ICONHORIZONTALSPACING sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=101, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=32, value= sysparams.c:480:testing SPI_{GET,SET}SCREENSAVETIMEOUT sysparams.c:515:testing SPI_{GET,SET}SCREENSAVEACTIVE sysparams.c:555:testing SPI_{GET,SET}KEYBOARDDELAY sysparams.c:590:testing SPI_ICONVERTICALSPACING sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=101, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=32, value= sysparams.c:635:testing SPI_{GET,SET}ICONTITLEWRAP sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=1, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=0, value= sysparams.c:670:testing SPI_{GET,SET}MENUDROPALIGNMENT sysparams.c:707:testing SPI_SETDOUBLECLKWIDTH sysparams.c:738:testing SPI_SETDOUBLECLKHEIGHT sysparams.c:770:testing SPI_SETDOUBLECLICKTIME sysparams.c:817:testing SPI_SETMOUSEBUTTONSWAP sysparams.c:880:testing SPI_{GET,SET}DRAGFULLWINDOWS sysparams.c:915:testing SPI_{GET,SET}WORKAREA sysparams.c:953:testing SPI_{GET,SET}SHOWSOUNDS sysparams.c:997:testing SPI_{GET,SET}DESKWALLPAPER sysparams: 318 tests executed, 0 marked as todo, 12 failures.

1 0

Re: wine/dlls/comcat regsvr.c comcat_main.c
by Dimitrie O. Paun 10 Jan '03

10 Jan '03

On January 10, 2003 12:48 am, John K. Hohm wrote: > + CLSID const *clsid; /* NULL for end of list */ [...] > + { NULL } /* list terminator */ Why not terminate the list with a NULL pointer to the struct instead, it's simpler and more idiomatic... -- Dimi.

2 1

Re: Wine, Mozilla & IE ?
by Francois Gouget 10 Jan '03

10 Jan '03

On Fri, 10 Jan 2003, Dan Kegel wrote: [...] > I don't know the particulars, but I do know that g++'s > ABI only very recently stabilized. ^^^^^^^^^^^^^^^^^^^^^^^^ Isn't that a contradiction in terms? [...] > (There was one little ABI tweak between 3.2 and 3.3, > and there may be more later, but they probably > won't break many apps.) That too seems incompatible with something declared 'stable'. Not that I have anything against C++, I like OO programming. But these g++ compatibility issues have been like a cold shower. <rant class="my opinion only"> >From the point of vue of an ISV, distributing a Wine binary is already enough trouble with the C library changing their internal implementation (which of course they are absolutely free to do since it's *internal*) and FreeType breaking backwards compatibility in minor releases, but if ISVs also have to deal with g++ changing their ABI on a regular basis... Well, I guess ISVs could always compile these libraries with Visual C++ and ship them as Windows dlls and thus benefit from a stable and Wine compatible ABI... </rant> -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

3 4

Readfile on a duplicated pipe hangs
by Uwe Bonnes 10 Jan '03

10 Jan '03

Hallo, Marcus sent me patches that made Altera quartus install. Thanks. Now running the package hangs in the way it communicates with created processes. Here is what happens in my understanding: M: Masterprocess C: Childprocess M: CreatePipe -> handle_read + handle_write M: DuplicateHandle handle_read -> handle_read_dup M: CloseHandle (handle_read) M: Call CreateProcessA with handle_write as hstderr M: Return Createprocess M: CloseHandle (handle_write) M: Call Readfile (handle_read_dup) C: initializes, executes and exit M: Return Readfile retval=00000001 M: Endless loop of Call Readfile (handle_read_dup) retval=00000001 MSDN says, that ReadFile should fail on an anonymous pipe, if the othe end has close. With following patch, the application starts up. Feedback welcome. Index: wine/server/pipe.c =================================================================== RCS file: /home/wine/wine/server/pipe.c,v retrieving revision 1.24 diff -u -r1.24 pipe.c --- wine/server/pipe.c 30 May 2002 20:12:58 -0000 1.24 +++ wine/server/pipe.c 10 Jan 2003 20:28:43 -0000 @@ -141,6 +141,13 @@ static int pipe_get_info( struct object *obj, struct get_file_info_reply *reply, int *flags ) { + struct pipe *pipe = (struct pipe *)obj; + assert( obj->ops == &pipe_ops ); + if (!pipe->other) + { + set_error( STATUS_PIPE_BROKEN ); + return -1; + } if (reply) { reply->type = FILE_TYPE_PIPE; -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: Wine, Mozilla & IE ?
by Dan Kegel 10 Jan '03

10 Jan '03

Dan Kegel wrote: > With gcc 3.2 and later, shared libraries > produced by g++ will have a stable ABI, > and different machines (with different versions > of gcc >= 3.2) will produce compatible shared libraries. I forgot to mention: this also means that you can mix and match shared libraries produced by *other* c++ compilers, not just gcc! See http://www.linuxbase.org/spec/refspecs/ http://www.codesourcery.com/cxx-abi/ http://www.armdevzone.com/EABI/CppABI.html http://gcc.gnu.org/gcc-3.2/c++-abi.html http://www.intel.com/software/products/compilers/clin/clinux.htm and, for a bit of solaris history wrt c++ abis, http://forte.sun.com/s1scc/articles/CC_abi/CC_abi.html -- Dan Kegel Linux User #78045 http://www.kegel.com

1 0

Re: Clean up OSS_Wave{In,Out}Init
by Eric Pouech 10 Jan '03

10 Jan '03

Francois Gouget wrote: > > This modifies OSS_Wave{In,Out}Init to report the exact capabilities of > the OSS driver. The new code does not try to use SNDCTL_DSP_SETFMTS > since some (old) cards may support 16bit or stereo audio at some sample > rates but not other (higher) rates. It now also reports the 48kHz and > 96kHz formats if they are supported. given the susceptibility of some OSS implementations, I'd suggest reimplementing the test loop as: for fmt for channels for rates if open succeeds 1/ flag format as supported 2/ close device endif endfor endfor endfor this would also put us out of danger if the device doesn't accept changing its mode on the fly A+ -- Eric Pouech

1 0

Re: widl patch
by Greg Turner 10 Jan '03

10 Jan '03

On Wednesday 08 January 2003 12:31 pm, Ove Kaaven wrote: > Feel free to recompile the .idl files after applying this patch... > it's not necessary, but sooner or later someone is going to try what > I'm currently trying... to compile MIDL-generated proxy/stub code > with Wine headers. Indeed, I am doing this now with my RPC test. I'm not sure we are targeting the same stuff, however. You can see my work-in-progress in the K patchseries, which only has one (rejected) "official" patch: K01. Actually, what I'm really trying to do is mix and match. I want the .h header to be generated by widl, and the _s.c and _c.c stubs to be generated by MIDL. wire_marshall should be a barrel of laughs ;) Maybe after I get this batch working I'll whip up some tests for 'ya that use it. I encounter the following gaps: o widl doesn't generate forward declarations for MIDL_user_allocate and MIDL_user_free, should be trivial to fix. o widl doesn't parse the implicit_handle stuff in the .acf, which cause MIDL to put an extern declaration in for the handle. o RpcTry/Except/etc. Ugh, what a $&^@$*% train wreck. More-or-less unfixable, and not widl's fault anyhow. ATM I may hack around this using some evil, incorrect, and, frankly, downright offensive macros. Long term, of course, I'm interested in seeing exception handling souce-compatibility in wine... perhaps, winegcc, or some cousin, could parse VC++ __try & family and generate wine-compatible __TRY & family to match? Given the freedom to parse/generate, regardless of the implementation specifics, it becomes a surmountable problem IMO. Otherwise, it works perfectly. Good work! Any chance either of the first two points will be fixed soon? This would leave me with only one inelegant hack (two if calling MIDL counts), and an otherwise tolerable build process. Thanks, -- gmt "It does not take a majority to prevail ... but rather an irate, tireless minority, keen on setting brushfires of freedom in the minds of men." --Samuel Adams, Patriot

3 5

Kaleidagraph demo
by Jos van den Oever 10 Jan '03

10 Jan '03

Hello Wine developers, The one program holding back linux adoption in my lab is the application Kaleidgraph. Kaleidagraph is a graphing application that is avaibable for Windows and Macintosh. I've been trying to use Kaleidgraph with wine (wine-20021219) without a windows installation on the computer. The installation works pretty well: Kaleigraph is installed, only the installer does not exit cleanly but not until it asks about displaying the readme file. Running Kaleidagraph does give quite a few problems. The problems seem to arise from bugs and not missing features in wine. One bug for example is, that almost all menu entries are listed twice ("File Edit Gallery ... Windows Edit Gallery ... Windows Help"). I'd like to help in making this program run by testing with the CVS version and submitting bugs. However, I think it would be easier if someone more experienced looks at the program first and irons out the biggest problems, because they are instantly obvious when you try to run the program with wine. There is a demo version of Kaleidagraph that can be downloaded for free from www.kaleidagraph.com. Best regards, Jos

2 3

Possible bug?
by Mike Hearn 10 Jan '03

10 Jan '03

Hi, I think this code in menu.c, BOOL WINAPI SetMenuItemInfoA(HMENU hmenu, UINT item, BOOL bypos, const MENUITEMINFOA *lpmii) { if ((lpmii->fType & (MF_HILITE|MF_POPUP)) || (lpmii->fState)) { /* QuickTime does pass invalid data into SetMenuItemInfo. * do some of the checks Windows does. */ WARN("Bad masks for type (0x%08x) or state (0x%08x)\n", lpmii->fType,lpmii->fState ); return FALSE; } .... is buggy, because it checks the type and state even when fMask doesn't indicate that these fields are being used. It was added by Marcus Meissner at LinuxTag in 2001 which is why I'm confused, the bug I'm playing with/learning how to debug with is a regression and didn't exist a few months ago, yet that code has been in Wine for some time. Could somebody more experienced than me please look over the description of the MENUITEMINFO struct: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/WinU… and the SetMenuItemInfo call: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/WinU… .. and tell me if I'm reading this situation correctly? I don't think it should be returning false like this when fMask is 6, ie MIIM_ID | MIIM_SUBMENU. It'd only take a minute, promise :) -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

1 0

Re: Re: Re: html browser for wine (khtml)
by fenix＠club-internet.fr 10 Jan '03

10 Jan '03

Hi again, ----Message d'origine---- >Sujet: Re: Re: html browser for wine (khtml) >De: Mike Hearn <m.hearn(a)signal.qinetiq.com> >A: fenix(a)club-internet.fr >Copie à: m.hearn(a)signal.dera.gov.uk, hetz(a)witch.dyndns.org, >Date: 10 Jan 2003 09:47:41 +0000 > >> As i know, khtml support most of the IE-isms (for compatibility, try to actve "IE support" in konqueror). >> And for ActiveX, it must be simply supported by a khtml plugin (as crossover plugin do) > >If only it were that simple. Rather ironically the thing that led to me Wine in the first place was that >I needed to use features of an ActiveX control that were only available under IE. Same problem here :) > Although it would also (in theory) >work in Mozilla or Konq as well, in practice they didn't support rich enough plugin interfaces for host scripting >merge (where the plugin hooks into the browsers script interpreter and partially merges them together). Hence I now >sometimes need to use IE under Linux. http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/kparts/browserextension.h?… -> LiveConnectExtension is for scripting Interface (kjs and JAVA support use it so it will be sufficient for ActiveX/ActiveScript) (I have played with it a long time ago for a mini-basic scripting support) >There are lots of IEisms that I doubt Konq replicates. ActiveX controls are sometimes a lot more complex than just >displaying some controls on a page, they can actually integrate with IE to quite an impressive extent. maybe but all ActiveX i have seen are only embeded plugins or code who: - sometimes modify html rendering (ex: embeding directx panel, ...) - do some windows calls And i don't see what you cannot do with konq plugins. >For instance: > >- DirectX filters hmm, problem here, DirectShow and DirectMedia are not supported by wine yet ( it's at end on my todo list :) ). >- DHTML Behaviours if you talk by unsupported specific IE-DHTML behaviors by kthml ... we have to see if we can easily extend khtml parser without forking kthml code (i haven't see how parser interact with plugins) Maybe asking khtml people if its possible integrating more IE-isms compat in kthml ... >- ActiveScript (needs a vbscript interpreter as well as a JS interpreter) >- ActiveX data binding >- .NET integration .NET integration is difficult because it can use SOAP and somes XMLs stupid things :( >and so on. I expect upstream khtml could get 80% of the way there, but the remaining 20% would require tight >integration with Wine and some extensive code changes. >-- >Mike Hearn <m.hearn(a)signal.qinetiq.com> >QinetiQ - Malvern Technology Center > Raphael

1 0

Re: Re: html browser for wine (khtml)
by fenix＠club-internet.fr 10 Jan '03

10 Jan '03

Hi, ----Message d'origine---- >Sujet: Re: html browser for wine (khtml) >De: Mike Hearn <m.hearn(a)signal.qinetiq.com> >A: hetz(a)witch.dyndns.org >Copie à: dpaun(a)rogers.com, wine-devel(a)winehq.com >Date: 10 Jan 2003 09:14:54 +0000 <snip> >About duplication - I think it's probably most likely that the best course would be >to copy the KHTML source into the Wine tree, because I'd expect modifications would >be needed in order to support all the IEisms that will crop up in regular usage of >the WebBrowser control. KHTML out of the box won't, and never will support ActiveX, >IE specific markup or any of the other proprietary stuff MS threw in for fun during >the browser wars. The KDE team would rightly reject such patches from being integrated >into upstream. As i know, khtml support most of the IE-isms (for compatibility, try to actve "IE support" in konqueror). And for ActiveX, it must be simply supported by a khtml plugin (as crossover plugin do) >thanks -mike >-- >Mike Hearn <m.hearn(a)signal.qinetiq.com> >QinetiQ - Malvern Technology Center Raphael

2 1

html browser for wine (khtml)
by Hetz Ben Hamo 10 Jan '03

10 Jan '03

Hi, Yesterday, Apple released their web browser - Safari. The license is LGPL and the code is based on KDE's KHTML rendering engine. Whats the difference? now you don't need QT, so license wise - it's kosher ;) Thanks, Hetz

5 9

Re: getting started
by Dimitrie O. Paun 10 Jan '03

10 Jan '03

On January 10, 2003 01:14 am, Glen Kaukola wrote: > All they have is C++ code. So maybe I should go with my > original plan of compiling stuff with visual studio and seeing if it > runs under wine. Or do you have any other suggestions? Compiling stuff with visual studio is a first step. But it should be very simple to do a Makefile for the examples, how many files do you have in one example? Here is an example Makefile that you can use under mingw: (let me know if it doesn't work, I just typed it inline here, no testing) >--------------- cut here ------------------------< CC = gcc # change this to winegcc under Wine CXX = g++ # change this to wineg++ under Wine RC = windres # change this to wrc under Wine # There six lines will change between examples TARGET = sample1.exe #name of the executable SRCS = file1.cpp file2.cpp ... RSRC = res1.rc res2.rc ... # If you need to add defines, add them to CPPFLAGS # CPPFLAGS, INCDIRS, LIBDIRS, and LIBS may change between examples CPPFLAGS = # add stuff here like -D_WIN32_IE=0x0400 CFLAGS = -mno-cygwin -W -Wall -g -gstabs+ -fno-exceptions -fno-rtti LDFLAGS = -mno-cygwin -mwindows INCDIRS = # add stuff there like -I../include LIBDIRS = # add stuff like -L../lib LIBS = -lcomctl32 # we'll need to add more libs in here for sure OBJ = $(SRCS:.c=.o) $(RSRC:.c=.o) %.o : %.rc $(RC) $(CPPFLAGS) $< $@ %.o : %.cpp $(CXX) $(CFLAGS) $(CPPFLAGS) $(INCDIRS) -c -o $@ $< %.o : %.c $(CC) $(CFLAGS) $(CPPFLAGS) $(INCDIRS) -c -o $@ $< $(TARGET): $(OBJS) $(CXX) $(LDFLAGS) $(LIBDIRS) $(LIBS) -o $@ $(OBJS) # A few nice targets all: $(TARGET) clean: rm -f $(TARGET) $(OBJS) >--------------- cut here ------------------------< It's not hard, just look in the .dsp project to see what you need to put in these variables. -- Dimi.

2 1

[Fwd: Re: getting started]
by Glen Kaukola 10 Jan '03

10 Jan '03

Dimitrie O. Paun wrote: > Compiling under the SDK using MS tools gives us little value. We already > know that works. If you don't want to spend the cash on MSVC (and not make > MS any richer :)), and are willing to invest some time into it, I suggest > the following path: > 1. Get the latest mingw 2.0 distribution from http://www.mingw.org > 2. Modify the makefiles that come in the book to work with GNU make, > and the mingw tool chain. Make sure you use forward slashes (/)! :) > 3. Build on Windows with your newly created Makefiles, and verify > that everthing runs under Windows just fine. > 4. If you feel like it, document what steps you took to convert the > makefiles. Maybe we'll put that on the Winelib page, to help > others in the future. > 5. Take the exact same Makefiles you used under Windows, change > 3 lines in them (CC=winegcc, CXX=wineg++, WINDRES=wrc), and > try to compile under Linux. Use the latest Wine tree, and > you should have native Linux apps. If you get errors in this > step, they are Wine error, please report them, and let's try > to fix them. This is the real value of this exercise. > 6. Once everything builds, run the apps, and make sure they run fine. > If they have problems, and you feel brave, let the debugging begin! > > Welcome to the team! > Well I've gotten MinGW and sorta learned my way around it. But now, my problem is that neither of my windows programming books has makefiles of any sort. All they have is C++ code. So maybe I should go with my original plan of compiling stuff with visual studio and seeing if it runs under wine. Or do you have any other suggestions?

2 1

Expected name, id, length or ordinal error
by John Westerman 10 Jan '03

10 Jan '03

Hi Everybody, I'm currently trying to compile the basic Win32 "Hello world" project that VC6 generates for you using Wine. Currently I'm running winemaker like this: winemaker --nomfc -I/usr/local/wine/include -L/usr/local/wine/lib -ikernel32.lib -iuser32.lib -igdi32.lib -iwinspool.lib -icomdlg32.lib -iadvapi32.lib -ishell32.lib -iole32.lib -ioleaut32.lib -iuuid.lib -iodbc32.lib -iodbccp32.lib /home/john/hello I've also added the header files that would have been found in the StdAfx.h to my main.cpp. This is because Winemaker wouldn't build with StdAfx.h in the directory, so I deleted it. This is the error I now get when I run make ./hellotest.spec:8: Expected name, id, length or ordinal My hellotest.spec looks like this: name hellotest type win32 mode guiexe init WinMain rsrc hellotest.res import kernel32.lib import user32.lib <- line of failure Any Ideas? Thanks in Advance, John Westerman

2 1

PATCH - Define needed flags when building for Mingw
by Steven Edwards 10 Jan '03

10 Jan '03

Dont know if this is right or not as you all know I think configure is a little whore. =P Maybe this should go somewhere else. I have about 12 or 13 other things that need to be fixed when building WINE for Mingw and MSYS and I am tired of doing ./configure CFLAGS="-D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK" Maybe someone can suggest a better way rather than -DWINE_NOWINSOCK? Thanks Steven Changelog: add defines for Mingw cvs diff -u configure Index: configure =================================================================== RCS file: /home/wine/wine/configure,v retrieving revision 1.387 diff -u -r1.387 configure --- configure 9 Jan 2003 06:04:33 -0000 1.387 +++ configure 10 Jan 2003 04:55:54 -0000 @@ -11973,7 +11973,8 @@ case $host_os in mingw32*) - CRTLIBS="-lmsvcrt" ;; + CRTLIBS="-lmsvcrt" ; + CFLAGS="=$CFLAGS -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK" ; esac cvs diff -u configure.ac Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.119 diff -u -r1.119 configure.ac --- configure.ac 9 Jan 2003 06:04:33 -0000 1.119 +++ configure.ac 10 Jan 2003 04:56:29 -0000 @@ -857,7 +857,8 @@ AC_SUBST(CRTLIBS,"") case $host_os in mingw32*) - CRTLIBS="-lmsvcrt" ;; + CRTLIBS="-lmsvcrt" ; + CFLAGS="=$CFLAGS -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK" ; esac dnl **** Get the soname for libraries that we load dynamically **** __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

2 2

DirectSound and i810 soundcards
by Francois Gouget 10 Jan '03

10 Jan '03

There is a problem with Directsound and i810 soundcards. The test I just sent to wine-patches illustrates it very well. Basically sounds are being played too fast. Here's my understanding of the problem (if my memory and understanding of the logs is correct): When DSound initializes it create a primary sound buffer and invokes winmm to actually get access to a sound device. The default format of the primary buffer is 22050x16x2 (i.e. 22050Hz, 16 bit sound, stereo). This means the device it's going to get will be handled by msacm.drv which will be responsible for performing the conversions on the fly. However during the primary buffer creation DSDB_MapPrimary gets invoked in wineoss and does an mmap of the hardware sound buffer. So when we then play sound in a secondary sound buffer, this sound gets mixed into the primary buffer, but because of the mmap this then goes straight to the sound card with no further conversion. So you end up with a chipmunk sound effect since you play a 22050x16x2 sound at 48000x16x2. I will try to make more tests to confirm this but does it seem to make sense? Should I look in some other direction? Any suggestion about a fix? If you have an i810 soundcard you can reproduce by doing the following: * apply "Add WINETEST_INTERACTIVE" from wine-patches * apply "Add 'audiophile' DirectSound tests" from wine-patches * cd dlls/dsound/tests * make * WINETEST_INTERACTIVE=1 ../../../tools/runtest -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so dsound.c (you can also set WINETEST_DEBUG=2 to get more debug info about the test's buffer management, though this is probably not relevant here) Alternately, you can download the latest Windows test binaries from my site (http://fgouget.free.fr/wine/winetests.zip) and run them using Wine, or on Windows: set WINETEST_INTERACTIVE=1 dsound_test dsound Actually I would be interested in the results of this test on Windows: * the test tone is usually played three times. Are all three, and especially the first one, at the right pitch? * what is the output of the test? I'm interested in reported capabilities as stated by Windows and Wine for instance (to determine whether the primary buffer is emulated for instance). * what is the primary buffer's default format? 22050x16x2? (that's not supported by the sound card!) * does the winmm test work? set WINETEST_INTERACTIVE=1 winmm_test wave * in particular, what happens when the test tone is played with WAVE_FORMAT_DIRECT on Windows? (except Win9x platforms which don't support that flag) -- Francois Gouget fgouget(a)codeweavers.com

3 8

Problem in dlls/ddraw/dsufrace/main.c
by Sylvain Petreolle 10 Jan '03

10 Jan '03

Trying to run Revolt Demo, the program halts saying DDERR_NOTFOUND in Main_DirectDrawSurface_GetAttachedSurface Looking in the source, we see that : found=NULL; for (surf = This->attached; surf != NULL; surf = surf->next_attached){ ... // surf is not modified into that if (...) found=surf; } if (found == NULL) { TRACE("Did not find any valid surface\n"); return DDERR_NOTFOUND; } Looks like the only possible return value of this is DDERR_NOTFOUND, because of the for(...; surf !=NULL ; ...) Or am I writing complete bullshit ? ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus in Matrix, chapter 15. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 9

Re: Registering DLL's
by John K. Hohm 09 Jan '03

09 Jan '03

Alexandre said: > Part of it should be done with DllRegisterServer, the rest can be > handled by the .inf script. And I think it's OK to add the necessary > DllRegisterServer entry points even if the native dll doesn't have > them. I'm glad you feel that way. I created bug 1117, "Make all Wine OLE DLLs self-registerable", and have been working on an implementation. For some reason I can't accept the bug; though I've tried several times, it stays at UNCONFIRMED. What to do about DLLs like ole32.dll that have a native DllRegisterServer but no corresponding DllUnregisterServer? I'm inclined to include it for completeness, though it's unlikely that anyone would ever want to unregister such a basic system DLL. I posted my idea for representing the registration data, accidentally from "jhohm(a)happyhappy.dyndns.org" rather than my usual "jhohm(a)acm.org" (see http://www.winehq.com/hypermail/wine-devel/2002/11/1409.html), but I haven't gotten any responses, not even "looks fine" or "you are a moron". I guess I'll just start submitting patches, then.

4 11

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel