- wine-devel - winehq.org

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?
by Patrik Stridvall 10 Aug '01

10 Aug '01

> Patrik Stridvall <ps(a)leissner.se> writes: > > > This will give us all the advantages of the "macros" > without any typecasts > > that could > > possibly hide a type error. > > > > What do you say? > > I don't like it. I think windowsx.h should not be used at all in Wine; > it only obfuscates things by making it harder to see what's really > going on. Obfuscates what? The only thing the "macros" do is that it hides the way the parameters are marshalled. That is totally unintresting for almost all Wine developers. Like the Win16/Win32 thunking code you don't have to know how it works, you just call the appropriate functions. The same with the stdcall calling convention most API functions use. You add WINAPI before the function and you don't care how it works. It is the somebody else problem and you trust that they know what they are doing. So please explain what the use of FORWARD_* macros obfuscates for I really can't see it. AFAICS it is much better to use the FORWARD_ macros (especially with my hack to make them truely type safe). They are just a function like any other. Why look up how the parameters are marshalled when you can call a function FORWARD_* that not only does it, but does it in a type safe way. If you call the function with the wrong parameters you are very likely to get type errors. If you marshall the parameters in the wrong way it is almost 100% certain that the compiler will say nothing. Microsoft introduced the windowsx.h macros for a reason and while without inline functions the current implementation of the FORWARD_* macros was the best they could do, it was at least better than nothing since it at least handled the parameter marshalling even if it wasn't 100% type safe. Another things to think about: What is the difference between calling {Set,Get}WindowText functions and calling the FORWARD_WM_{GET,SET}TEXT macros? Answer: No difference at all except that you can easily do a PostMessage instead of a SendMessage if you wish. Of course I'm not suggesting that we should call the FORWARD_WM_{GET,SET}TEXT instead of {Set,Get}WindowText, but in most cases no appropriate functions exists and FORWARD_* macros will at least do the marshalling of parameters and if we implement my version of them also type safe. > Besides, the FORWARD_* macros are not really meant to be > used to send messages, they are meant to help receiving messages, so I > don't think we should abuse them that way. No, that is what the HANDLE_* macros are for. The FORWARD_* macros are for sending (or forwarding) messages. Speaking of which the HANDLE_* macros could find uses in COMCTL32 and other similar DLL:s to provide a type safe receiving of messages. I don't even think we will have to do as a proposed for the FORWARD_* to make them truely type safe.

1 0

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?
by Alexandre Julliard 10 Aug '01

10 Aug '01

Patrik Stridvall <ps(a)leissner.se> writes: > This will give us all the advantages of the "macros" without any typecasts > that could > possibly hide a type error. > > What do you say? I don't like it. I think windowsx.h should not be used at all in Wine; it only obfuscates things by making it harder to see what's really going on. Besides, the FORWARD_* macros are not really meant to be used to send messages, they are meant to help receiving messages, so I don't think we should abuse them that way. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?
by Patrik Stridvall 10 Aug '01

10 Aug '01

> Patrik Stridvall <ps(a)leissner.se> writes: > > > So the question is: > > Should we use the FORWARD_WM_* macros to avoid typecasts > > (or rather avoid visable typecast) or should we not? > > If not how should we fix the problems? > > I think it's better to avoid that. Hiding the typecasts in the macros > doesn't really make things cleaner IMO. This is a case where the API > design forces us to use a typecast, so we might as well make it > explicit. True, but be aware of the macros often use a double type cast like (LPARAM)(HWND). I'm not sure this is really helpful, since I guess it will reveal but a few type error if any at all. Also note that the macros also takes care of MAKEWPARAM and MAKELPARAM stuff so it makes the code a little more readable. Anyway, never mind. We could be a little more clever than the macros permit that if we like. See below. > Note that for the specific case of WM_GET/SETTEXT, it would be much > better to use Get/SetWindowText which will do correct type checks. True. They was just an example. They are a few more with similar problems but they are few (less than 10 IIRC). I guess we can worry about them later. > But > for messages that don't have a corresponding function we have to do > the typecast. As the macros work now, yes. But we could extend the "macros" to be a little more clever than that. Take for example one of the more advanced macros #define FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ (void)(fn)((hwnd), (fDoubleClick) ? WM_LBUTTONDBLCLK : WM_LBUTTONDOWN, (WPARAM)(UINT)(keyFlags), MAKELPARAM((x), (y))) We could quite easily write it like: #define _FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ (void)(fn)((hwnd), (fDoubleClick) ? WM_LBUTTONDBLCLK : WM_LBUTTONDOWN, (WPARAM)(UINT)(keyFlags), MAKELPARAM((x), (y))) #if defined(__WINE__) && defined(__GNUC__) extern inline void _WINE_FORWARD_WM_LBUTTONDOWN(HWND hwnd, BOOL fDoubleClick, int x, int y, UINT keyFlags, WNDPROC *fn) { /* return */ _FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, *fn); } #define FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ _WINE_FORWARD_WM_LBUTTONDOWN((hwnd), (fDoubleClick), (x), (y), (keyFlags), &(fn)) #else #define FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ _FORWARD_WM_LBUTTONDOWN((hwnd), (fDoubleClick), (x), (y), (keyFlags), (fn)) #endif Or something like that. I'm not even sure the __WINE__ is needed. I not sure that any Winelib application could possibly misuse the macros in such a way that the result is not semantically the same (type warnings/errors excluded of course). Note that it is quite easy to write script that automatically does this to avoid subtle bugs especially since the correct (almost) prototype is already before each macro. Like in the case above: /* void Cls_OnLButtonDown(HWND hwnd, BOOL fDoubleClick, int x, int y, UINT keyFlags) */ This will give us all the advantages of the "macros" without any typecasts that could possibly hide a type error. What do you say? Note that we don't have to implement the solution above right now either. Using the macros as they are will not gain us very much (except possible a cleaner looking code), true. However when we implement the type safe "macros" as described above we will immediately find any and all type errors concerning such code. Anway fixing windowsx.h to look like above will not be very difficult either so there is no real reason to wait is it? PS. As hinted above this will also work with most (all?) Winelib applications that happends to use the windowsx.h macros and enable the finding of subtle type errors in such applications.

1 0

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT warni ngs?
by Alexandre Julliard 10 Aug '01

10 Aug '01

Patrik Stridvall <ps(a)leissner.se> writes: > So the question is: > Should we use the FORWARD_WM_* macros to avoid typecasts > (or rather avoid visable typecast) or should we not? > If not how should we fix the problems? I think it's better to avoid that. Hiding the typecasts in the macros doesn't really make things cleaner IMO. This is a case where the API design forces us to use a typecast, so we might as well make it explicit. Note that for the specific case of WM_GET/SETTEXT, it would be much better to use Get/SetWindowText which will do correct type checks. But for messages that don't have a corresponding function we have to do the typecast. -- Alexandre Julliard julliard(a)winehq.com

1 0

RFC: Should we use the macros in windowsx.h to fix -DSTRICT warni ngs?
by Patrik Stridvall 10 Aug '01

10 Aug '01

This is not primarily a patch it is a RFC. I have experimented a bit with fixing the strict warnings. I have a few patch that I haven't submitted yet partly because I'm not 100% sure how all warnings should be fixed. Anyway, one large class of warnings is the ones cause by the window messaging functions. Like the one below: SendMessageW(lphc->hWndEdit, WM_SETTEXT, 0, (LPARAM)empty_stringW); This one unlike others this one does cause any warning with -DSTRICT because of the ugly cast, but the principle is the same. The only good way to fix this kind of problems that I can see is to use the FORWARD_WM_* macros in include/windowsx.h to write it like: FORWARD_WM_SETTEXT(lphc->hWndEdit, empty_stringW, SendMessageW); This works fine because the FORWARD_WM_SETTEXT macro look like this: #define FORWARD_WM_SETTEXT(hwnd, lpszText, fn) \ (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCTSTR)(lpszText)) Actually I lied this special case will not work fine since FORWARD_WM_SETTEXT uses TCHAR and friends. But that is not so important for the general principle. See below. Anyway, in some meaning the macros only hides the casts, but can casts really be avoided? We must cast to {W,L}PARAM at some time mustn't we? And the macros in windowsx.h is not that bad they cast to the correct type before the cast to {W,L}PARAM. This might help to find some bugs. Perhaps rewriting to macros as inline functions might help to? So the question is: Should we use the FORWARD_WM_* macros to avoid typecasts (or rather avoid visable typecast) or should we not? If not how should we fix the problems? And if we decide to use them, is patches like the one below to include/windowsx.h that fixes the TCHAR and friend problem acceptable or should we solve such problems in another way? PS. Alexandre: Feel free to apply the patch below if you agree. ---8<--- * include/windowsx.h: Include files used internally by Wine can't use the types TCHAR and friends. ---8<--- Index: wine/include/windowsx.h =================================================================== RCS file: /home/wine/wine/include/windowsx.h,v retrieving revision 1.7 diff -u -u -r1.7 windowsx.h --- wine/include/windowsx.h 2001/01/10 22:42:35 1.7 +++ wine/include/windowsx.h 2001/08/10 12:43:18 @@ -714,17 +714,37 @@ #define FORWARD_WM_ENABLE(hwnd, fEnable, fn) \ (void)(fn)((hwnd), WM_ENABLE, (WPARAM)(BOOL)(fEnable), 0L) +/* void Cls_OnSetTextA(HWND hwnd, LPCSTR lpszText) */ +#define HANDLE_WM_SETTEXTA(hwnd, wParam, lParam, fn) \ + ((fn)((hwnd), (LPCSTR)(lParam)), 0L) +#define FORWARD_WM_SETTEXTA(hwnd, lpszText, fn) \ + (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCSTR)(lpszText)) + +/* void Cls_OnSetTextW(HWND hwnd, LPCWSTR lpszText) */ +#define HANDLE_WM_SETTEXTW(hwnd, wParam, lParam, fn) \ + ((fn)((hwnd), (LPCWSTR)(lParam)), 0L) +#define FORWARD_WM_SETTEXTW(hwnd, lpszText, fn) \ + (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCWSTR)(lpszText)) + /* void Cls_OnSetText(HWND hwnd, LPCTSTR lpszText) */ -#define HANDLE_WM_SETTEXT(hwnd, wParam, lParam, fn) \ - ((fn)((hwnd), (LPCTSTR)(lParam)), 0L) -#define FORWARD_WM_SETTEXT(hwnd, lpszText, fn) \ - (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCTSTR)(lpszText)) +#define HANDLE_WM_SETTEXT WINELIB_NAME_AW(HANDLE_WM_SETTEXT) +#define FORWARD_WM_SETTEXT WINELIB_NAME_AW(FORWARD_WM_SETTEXT) + +/* INT Cls_OnGetTextA(HWND hwnd, int cchTextMax, LPSTR lpszText) */ +#define HANDLE_WM_GETTEXTA(hwnd, wParam, lParam, fn) \ + (LRESULT)(DWORD)(int)(fn)((hwnd), (int)(wParam), (LPSTR)(lParam)) +#define FORWARD_WM_GETTEXTA(hwnd, cchTextMax, lpszText, fn) \ + (int)(DWORD)(fn)((hwnd), WM_GETTEXT, (WPARAM)(int)(cchTextMax), (LPARAM)(LPSTR)(lpszText)) + +/* INT Cls_OnGetTextW(HWND hwnd, int cchTextMax, LPWSTR lpszText) */ +#define HANDLE_WM_GETTEXTW(hwnd, wParam, lParam, fn) \ + (LRESULT)(DWORD)(int)(fn)((hwnd), (int)(wParam), (LPWSTR)(lParam)) +#define FORWARD_WM_GETTEXTW(hwnd, cchTextMax, lpszText, fn) \ + (int)(DWORD)(fn)((hwnd), WM_GETTEXT, (WPARAM)(int)(cchTextMax), (LPARAM)(LPWSTR)(lpszText)) /* INT Cls_OnGetText(HWND hwnd, int cchTextMax, LPTSTR lpszText) */ -#define HANDLE_WM_GETTEXT(hwnd, wParam, lParam, fn) \ - (LRESULT)(DWORD)(int)(fn)((hwnd), (int)(wParam), (LPTSTR)(lParam)) -#define FORWARD_WM_GETTEXT(hwnd, cchTextMax, lpszText, fn) \ - (int)(DWORD)(fn)((hwnd), WM_GETTEXT, (WPARAM)(int)(cchTextMax), (LPARAM)(LPTSTR)(lpszText)) +#define HANDLE_WM_GETTEXT WINELIB_NAME_AW(HANDLE_WM_GETTEXT) +#define FORWARD_WM_GETTEXT WINELIB_NAME_AW(FORWARD_WM_GETTEXT) /* INT Cls_OnGetTextLength(HWND hwnd) */ #define HANDLE_WM_GETTEXTLENGTH(hwnd, wParam, lParam, fn) \

1 0

wine+mirc /rename confusiion bug
by mdew 10 Aug '01

10 Aug '01

make a empty file..place it the mirc dir... /rename y:\fake_windows\mirc\text.txt c:\mirc\text2.txt *** /rename: unable to rename 'y:\fake_windows\mirc\text.txt' to 'c:\mirc\text2.txt' $ ls text* -al -rw-r--r-- 1 mdew mdew 6 Aug 10 22:33 text.txt -rw-r--r-- 1 mdew mdew 6 Aug 10 22:36 text2.txt complains about it...yet it actually does it. -- id: 9DF3262C key fingerprint: B556 04DA CFD9 78DD 9215 A970 8196 FB6D 9DF3 262C

1 0

trouble with fonts (old, old problem)
by Mike McCormack 10 Aug '01

10 Aug '01

Hi All, i've got a problem with fonts in Netscape that's been around for a long time, while i've tried several times, unsuccessfully, to fix. When netscape 4.77 first loads, then loads an arbitary page, everything (text, buttons, comboboxes) is rendered incorrectly. If i go to another page, then hit the Back button, the page that was originally rendered incorrectly is now correct. All further renderings are correct for all pages. In my investigations (some time ago), i found that : * font enumeration functions returned different things on the first and second load of the same page. * i could correct the problem by changing the default ansi fixed font to helvetica i suspect that the wine loads extra X11 fonts between the first and second page viewings... but i don't know much about font handling in wine. i'll make some screen shots if anybody is interested. Any ideas? Mike ------------------------------------------ mailto:Mike_McCormack@start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

Font scaling in PSDRV_EnumDeviceFonts
by Ian Pilcher 10 Aug '01

10 Aug '01

Can anyone point me to the Win32 API that ultimately calls the subject function? I'm trying to understand why it scales fonts to a 200 logical unit (I think) character cell. Is this completely arbitrary? Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

Re: wineserver.pid
by Alexandre Julliard 09 Aug '01

09 Aug '01

Andreas Mohr <a.mohr(a)mailto.de> writes: > Hi all, > > some guy was running several different versions of wineservers for one > account via wrapper scripts. > And of course he had a hell of a hard time figuring out which wineserver to > kill for which application ;-) Why would you want to do that? Just kill the app and it will die on its own (and save everything too). I don't think encouraging people to kill the wineserver is a good idea. -- Alexandre Julliard julliard(a)winehq.com

1 0

winelib application debugging
by Vitaly Kuznetsov 09 Aug '01

09 Aug '01

Is there currently any way to debug winelib application? I read winedbg doc, but there are only samples for windows executables. -- Vitaly AKA Vitty mailto: vitty(a)dts.ru NetMail:2:5015/133.41

2 1

Today's CVS hangs on startup
by Ian Pilcher 09 Aug '01

09 Aug '01

The good news is that --debugmsg +all actually stops producing anything. Hopefully someone can look at the output below and figure out what's going on. Anyone else seen this? ... 080689c0:trace:dosfs:DOSFS_FindUnixName (/home/pilcher/wine,Eudora\EUDORA.EXE) -> Eudora (EUDORA) 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:heap:HeapFree (403a0000,00000002,403c36c8): returning TRUE 080689c0:trace:dosfs:DOSFS_FindUnixName /home/pilcher/wine/Eudora,EUDORA.EXE 080689c0:trace:heap:HeapAlloc (403a0000,00000002,0000022c): returning 403c36c8 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:dosfs:DOSFS_FindUnixName (/home/pilcher/wine/Eudora,EUDORA.EXE) -> EUDORA.EXE (EUDORA.EXE) 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:heap:HeapFree (403a0000,00000002,403c36c8): returning TRUE 080689c0:trace:dosfs:DOSFS_GetFullName returning /home/pilcher/wine/Eudora/EUDORA.EXE = C:\EUDORA\EUDORA.EXE 080689c0:trace:string:lstrcpynA (0x405f68e8, "C:\\EUDORA\\EUDORA.EXE", 260) 080689c0:trace:string:lstrcpynA (0x405f68ea, "/Eudora/EUDORA.EXE", 258) 080689c0:trace:module:GetModuleFileName16 01cf -> 'C:\Eudora\EUDORA.EXE' 080689c0:trace:heap:HeapAlloc (403a0000,00000002,0000004c): returning 403c3480 080689c0:trace:reg:NtOpenKey (0x80000002,L"Software\\Wine\\Wine\\Config\\AppDefaults",f003f,0x405f6820) 080689c0: open_key( parent=-2147483646, access=000f003f, name=L"Software\\Wine\\Wine\\Config\\AppDefaults" ) Open key ERROR 080689c0: open_key() = OBJECT_NAME_NOT_FOUND { hkey=0 } 080689c0:trace:reg:NtOpenKey <- 0x0000 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"display",(nil),(nil),0x405f68f0,0x405f6818=268) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"display",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"display" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"Managed",(nil),(nil),0x405f68e8,0x405f6814=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"Managed",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"Managed" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"Desktop",(nil),(nil),0x405f68e8,0x405f6810=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"Desktop",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"Desktop" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"DXGrab",(nil),(nil),0x405f68e8,0x405f680c=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"DXGrab",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"DXGrab" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"UseDGA",(nil),(nil),0x405f68e8,0x405f6808=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"UseDGA",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"UseDGA" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"ScreenDepth",(nil),(nil),0x405f68e8,0x405f6804=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"ScreenDepth",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"ScreenDepth" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"Synchronous",(nil),(nil),0x405f68e8,0x405f6800=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"Synchronous",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"Synchronous" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0: close_handle( handle=32 ) 080689c0: close_handle() = 0 { fd=-1 } 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

[Fwd: Re: x11drv port to win32 possible ?]
by Ian Pilcher 09 Aug '01

09 Aug '01

Rudi De Vos wrote: > > The intention is to create a dll that exports the winapi graphic > functions for X11: X11DRV_CreateWindow,X11DRV_InitKeyboard,.. > see x11drv.spec. > Someone can correct me if I'm wrong, but I believe that Wine's built-in graphics drivers -- x11drv, ttydrv, and wineps -- interface with Wine's GDI code in a non-standard way. Alexandre has made some changes in this area recently, but I don't believe they've changed that fundamental fact. So to do what you're proposing, you would first have to modify Wine's GDI code to support one of Microsoft's 32-bit graphics driver interfaces. (Different Microsoft 32-bit OSes have different driver interfaces, BTW.) You could then update x11drv to use this interface. As Patrik pointed out, this is really outside the scope of the Wine project, but I do think that it would be valuable. In addition to the reasons you give above, it would be helpful in improving both the Wine driver code and the Wine GDI code. -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

RE: x11drv port to win32 possible ?
by Patrik Stridvall 09 Aug '01

09 Aug '01

[You know you replied in private? Hmm, it doesn't seem to be private. Including list again, others might be intrested] > Perhaps the subject needed to be > X11drv insite function port to win32 possible ? I'm not sure this new title makes it clearer. But never mind. > A graphic driver would display the full desktop and not a single > application. True. > And wine is not needed to display anything. > This is currently used with the sunpci (intel coprocessor card in the > sparc boxes). > The video driver display the pc-screen as a xwindows or native on a > second monitor. I'm not sure I quite with you, but never mind, see below. > I want to create equivalent functions, but it seems that the functions > (X11DRV_...) make also use of the ntdll, userdll ... > I just want to know if it would be possible to recompile the > x11drv part > against the native dlls ( on win32 ). > Not the full x11drv, but only the functions mentioned in the > x11drv.spec > file. So I would be able to change the functions in win32 source code > and recompile with the X11DRV_.. functions. Possible, perhaps. However to me it just seems like a silly hack to use the X11DRV_ functions for that or at least to use them directly. Anyway, so what you really want to be able to compile Windows source code to a Windows binary that instead of using normal USER/GDI instead uses Wine's version of USER/GDI that using the X11DRV displays the application's Window(s) on a X-Terminal? Hmm. Intresting idea. Well, yes that would be possible to do with Wine, at least in theory. There is a lot a practical problems to be resolved for that to work. Just getting the non-core parts (especially USER/GDI and X11DRV) to compile and link to a DLL with the Windows headers will be an effort by itself. Actually getting it to work will be even worse, The USER (and to a lesser part even GDI) seems, eventhough I guess they can be made not to, to use the Wine server for some things, with means that you will either have to fix that or emulate the Wine server on Windows. It is propably not that hard to emulate it, but quite a lot of work regardless. Then you have the issue of getting the Windows versions of COMCTL32 and COMDLG32 DLL:s and similar DLL:s using your special versions of USER32 and GDI32 and not the Windows ones. I'm not sure Windows can be made to support this at all. It depends on exactly how library loading work. Hmm, perhaps it would be possible to "hook" LoadLibrary somehow. Anyway, I'm sorry to say that it will currently not, with the state Wine is now, be possible to do that without an enormous effort. Despite this I'm happy to say that I think it will be possible some day. However not until past Wine 1.0 or perhaps not even past Wine 1.x. Nice idea though.

1 0

RE: x11drv port to win32 possible ?
by Patrik Stridvall 09 Aug '01

09 Aug '01

> Has anyone already try to compile it with VC++. > > Using the win32X11 port from http://sources.redhat.com/win32-x11/ and > microsoft visual C++ 6.0 I was able to compile some parts: tsx11 and > wineclipsrv.exe. > > The intention is to create a dll that exports the winapi graphic > functions for X11: X11DRV_CreateWindow,X11DRV_InitKeyboard,.. > see x11drv.spec. > > 1)If we can compile that dll, can we recompile a win32 app so it > runs on a pc and display on a X-terminal? > 2)Can multiple users run the same app on win95/98 and display on diff > X-terminals? I think what I think you are proposing is currently entirely out of the scope of the Wine project. Wine is currently not designed for this. Compiling some of the non-core DLL:s like COMCTL32, COMDLG32 and others might be meaningful for test purposes, but the core stuff like the is simply not possible and it is not needed since Windows already has its own implementation of them that can used in the testing the non-core DLL:s. In short, what you are proposing is intresting but it has currently little to do with the Wine project. What you want to do is the write a Windows "graphic card" driver that display the result on an X-Terminal. While you certainly can (and are indeed legally allowed to do) use part of the x11drv to do this, I think most of the X11DRV is to high level to be useful. Sure someday when your "graphic card" driver works good we might consider redesigning Wine to use the Windows "graphic card" driver interface, but it will certainly not not be done before Wine 1.0 or even Wine 1.x. Perhaps Wine 2.0 might be a good point to merge such things with Wine, assuming of course that you or somebody else implements such a thing and releases it under an acceptable license (preferably the Wine license, the new one that is).

2 1

x11drv port to win32 possible ?
by Rudi De Vos 09 Aug '01

09 Aug '01

HI, Has anyone already try to compile it with VC++. Using the win32X11 port from http://sources.redhat.com/win32-x11/ and microsoft visual C++ 6.0 I was able to compile some parts: tsx11 and wineclipsrv.exe. The intention is to create a dll that exports the winapi graphic functions for X11: X11DRV_CreateWindow,X11DRV_InitKeyboard,.. see x11drv.spec. 1)If we can compile that dll, can we recompile a win32 app so it runs on a pc and display on a X-terminal? 2)Can multiple users run the same app on win95/98 and display on diff X-terminals? thxs Rudi

1 0

x11drv port to win32 possible ?
by Rudi De Vos 09 Aug '01

09 Aug '01

HI, Has anyone already try to compile it with VC++. Using the win32X11 port from http://sources.redhat.com/win32-x11/ and microsoft visual C++ 6.0 I was able to compile some parts: tsx11 and wineclipsrv.exe. The intention is to create a dll that exports the winapi graphic functions for X11: X11DRV_CreateWindow,X11DRV_InitKeyboard,.. see x11drv.spec. 1)If we can compile that dll, can we recompile a win32 app so it runs on a pc and display on a X-terminal? 2)Can multiple users run the same app on win95/98 and display on diff X-terminals? thxs Rudi

1 0

Re: Rewrite AFM parsing code
by Dmitry Timoshkov 09 Aug '01

09 Aug '01

"Ian Pilcher" <ian.pilcher(a)home.com> wrote: > Log message: > Ian Pilcher <ian.pilcher(a)home.com> > WINEPS: rewrite and separate AFM parsing code (no more [afmfiles]) [...] > +inline static BOOL IsWinANSI(LONG uv) > +{ > + if ((0x0020 <= uv && uv <= 0x007e) || (0x00a0 <= uv && uv <= 0x00ff) || > + (0x2018 <= uv && uv <= 0x201a) || (0x201c <= uv && uv <= 0x201e) || > + (0x2020 <= uv && uv <= 2022)) ^^^^ Shouldn't it be 0x2022? -- Dmitry.

2 1

Re: Remove redundant implementations
by Alexandre Julliard 09 Aug '01

09 Aug '01

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Remove redundant implementation of __get_cs,__get_ds,__get_es, > __get_fs,__get_gs,__get_ss,__set_fs,__set_gs. These are here to support compilers that don't have gcc-style inline assembly. This is admittedly a theoretical issue at this point, but there shouldn't be any harm in keeping them around just in case. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Remove redundant implementations
by Alexandre Julliard 09 Aug '01

09 Aug '01

"Dmitry Timoshkov" <dmitry(a)baikal.ru> writes: > Perhaps they should be protected from compiling under gcc? Why would you want that? They could conceivably be useful even with gcc in case it decides not to use the inline version. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: CS_PARENTDC with WS_CLIPSIBLINGS
by Alexandre Julliard 08 Aug '01

08 Aug '01

Ladislav Sladecek <lsla(a)post.cz> writes: > The function is called like this: > > 0806c1c8:Call GDI.38: ESCAPE(0x0000,0x000d,0x0000,0x00000000,0657:e8f4) ret=0ff7:4428 ds=1207 > > The in_data pointer is null but the code assigns to it, thats why it > crashes. I think that the result should be assigned to the output parameter. Yes of course, stupid typo on my part. Thanks for spotting it. -- Alexandre Julliard julliard(a)winehq.com

1 0

Some strange code in configure.in
by Lionel Ulmer 08 Aug '01

08 Aug '01

Hi all, By looking at some guy's config.log, I found out this in configure.in : dnl Check for GLU32 library. AC_CHECK_LIB(GLU,glBegin, X_PRE_LIBS="$X_PRE_LIBS -lGLU" GLU32FILES='$(GLU32FILES)' GLU32_DLL=glu32 ,, $X_LIBS $X_PRE_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS ) My question is why do we test for 'glBegin' in GLU and not something better like, say, 'gluLookAt' ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

Re: CS_PARENTDC with WS_CLIPSIBLINGS
by Alexandre Julliard 08 Aug '01

08 Aug '01

Ladislav Sladecek <lsla(a)post.cz> writes: > 2) The real reason for the crash is that the application calls Escape16 with > hdc equal to 0 and function equal to GETPRINTINGOFFSET. I do not understand > why, they did not even start to print. Maybe, this is an undocumented windows > function? After I temporarily disabled Escape16, the application began to > work. It's not supposed to crash even if the hdc is invalid. Do you have a backtrace of the crash? > 4) To fix Escape16, the 16bit printer driver is necessary. I need printing > either. I will try to work on it if you just give me a piece of advice. I think > that two ways are possible: > > A) To use the static table and to modify create_driver to work with it. > > B] To create a 16bit printer driver DLL similarly to the 32bit drivers. The static table is OK, but you'll need to add a number of functions that were done by escapes before (AbortDoc, StartDoc, etc.) And of course there is still the GDI lock issue so I don't know if you can actually print something even if you fix the initialisation. -- Alexandre Julliard julliard(a)winehq.com

2 1

Eliminating [afmfiles] from .wine/config
by Ian Pilcher 08 Aug '01

08 Aug '01

Anyone see any reason not to? [afmdirs] has been around for quite a while now. -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

Re: CS_PARENTDC with WS_CLIPSIBLINGS
by Alexandre Julliard 07 Aug '01

07 Aug '01

Ladislav Sladecek <lsla(a)post.cz> writes: > Maybe the printer driver never gets initialised? (Just a stupid speculation). Not stupid at all, actually the 16-bit driver support is temporarily broken (not that it really worked well before anyway). It shouldn't be too hard to fix, but I haven't had time yet. Volunteers are welcome... -- Alexandre Julliard julliard(a)winehq.com

2 1

Implementing Winsock2 Function
by Nick Bauer 07 Aug '01

07 Aug '01

Hello, I was working with Andreas Mohr on a program I was trying to get running under Wine, and he suggested that I email this list and ask for help to get an un-implemented function implemented. My application is a software program used to control our phone system. The error is: Unhandled exception: unimplemented function ws2_32.WSALookupServiceBeginA called in 32-bit code (0x407be056). In 32-bit mode. 0x407be056 (__wine_unimplemented+0x56 [ws2_32.spec.c:40] in WS2_32.DLL): jmp 0x407be050 (__wine_unimplemented+0x50 [ws2_32.spec.c:40] in WS2_32.DLL) 43 void __wine_stub_ws2_32_WPUCompleteOverlappedRequest(void) { __wine_unimplemented("WPUCompleteOverlappedRequest"); } I have tried using the native WS2_32 DLL and then the program no longer crashes, but it looks like its attempting to connect to the server, but never gets connected. I set up iptables to log all packets going to that server out eth0, but it never catches any packets. Any help would be greatly appreciated, as I have no knowledge of coding. Also, I am not on the list, so please include my email on any responses. Thanks a lot, -Nick

1 0

printing with wine
by Ricahrd Canada 07 Aug '01

07 Aug '01

Does anybody have complete instructions on how to set up a printer to use in wine? I have tried all of the suggestions with add entries to the wine.conf file, using the internal driver, etc. I cannot seem to get wine to see any printers. I use lprng through a print server, so I do not have any local printers attached. Can anyone help?? Richard

1 0

printing in wine
by richard.canada＠mrlinternational.com 07 Aug '01

07 Aug '01

Does anybody have complete instructions on how to set up a printer to use in wine? I have tried all of the suggestions with add entries to the wine.conf file, using the internal driver, etc. I cannot seem to get wine to see any printers. I use lprng through a print server, so I do not have any local printers attached. Can anyone help?? Richard

1 0

AbiWord 0.9 problems even with latest Wine from CVS
by Dan Kegel 07 Aug '01

07 Aug '01

The AbiWord win32 0.9 problems I described recently on wine-users with Codeweavers Preview 4 also happen with the latest Wine built from CVS this afternoon. These problems don't happen when run on Windows, nor when running the native Linux version; they therefore appear to be Wine bugs. Details at http://www.kegel.com/wine/abiword0.9/readme.html I stand ready and willing to apply and test patches, but might not have time to write any fixes myself. Thanks, Dan -- "I have seen the future, and it licks itself clean." -- Bucky Katt

2 4

Re: named critical sections
by Andreas Mohr 07 Aug '01

07 Aug '01

On Tue, Aug 07, 2001 at 04:15:41PM +0200, Andreas Mohr wrote: > Hi all, > > this patch implements *names* for the most important critical sections. > > I simply grew tired of constantly having to look up the crst addresses > in winedbg whenever there was some crst timeout. > Yeah, I know, that patch is slightly weird/dirty, but it's useful. Yup, this patch is weird: > + TRACE("#1\n"); > + TRACE("#2: %p\n", obj); Alexandre, please apply it without this crap ;-) (hmm, I really thought I had properly checked it) -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0

Re: CoGetClassObject
by r.maurizzi＠gvs.it 07 Aug '01

07 Aug '01

[Notes 5.0.8] > The only error message the installer came up with was a dialog saying > "AddFolderIcon" failed. The same here. > I had also understood that there was now a facility to add programs that > would have installed themselves into the Windows startup menu into the KDE > menu structure. I am running KDE 2.2 from CVS if it matters. But nothing > appeared. Had I understood wrong, or do I need to try to do some > debugging? Maybe not for all the InstallShield versions: it worked for me for the game "I-War" (quite old... DirectX 5 I think), with KDE 2.1 Or it could be that the installer crash doesn't help in getting the icon loaded... :-) I didn't had time to look into this feature. Ciao, Roberto.

3 2

CoGetClassObject
by Daniel Walker 07 Aug '01

07 Aug '01

I was thinking of ways to get the CLSCTX_LOCAL_SERVER option working in wine. The only program that uses it , that I know of, is installshield v6 .. I pretty sure some other people are working on this, but I don't know that status. (Anyone care to update me?) There is another problem. It's with the TypeLib information in the IKernel.exe that comes with InstallShield v6. The TypeLib information is encoded somehow, any ideas? I was able to get around that problem because installshield also looks for type information in "ikernel.tlb" . So I was able to create a .tlb that worked. I also used the reaktivate typelib patch so the typelib info gets put into the registry. So the way I understand it is that when CoGetClassObject is called Wine is suppose to , in this case, execute IKernel.exe . Then IKernel.exe will CoRegisterClassObject on all needed objects .. One problem is that the registered class object list isn't shared between the two processes, so we would need to move that list into the wine server (Right?) .. Then we would also need to send an instance of the class object to the Wine server (Yeah??) .. Following that road seems to lead to some messy address translations for DLL's and whatever else.. Since we have complete control over how IKernel.exe is run, how would we get the two processes to share memory? Maybe have IKernel.exe execute in a thread? IKernel.exe doesn't do anything but register it's class objects .. Would it be possible to treat IKernel.exe as a DLL then run CoRegisterClassObject for it? Daniel Walker

8 13

Re: CoGetClassObject
by David.Goodenough＠dga.co.uk 07 Aug '01

07 Aug '01

Curiously (on the subject of InstallSheild) I have just successfully installed the latest (5.0.8) Lotus Notes client on a wine system (latest tarball) and the new Lotus installer is InstallSheild based. It ran perfectly EXCEPT that the program would not terminate. The Lotus installer takes over the whole screen, and that went away, but wine never returned to the command line. As far as I could see there were no messages about locks or anything. The only error message the installer came up with was a dialog saying "AddFolderIcon" failed. I had also understood that there was now a facility to add programs that would have installed themselves into the Windows startup menu into the KDE menu structure. I am running KDE 2.2 from CVS if it matters. But nothing appeared. Had I understood wrong, or do I need to try to do some debugging? Ove Kaaven <ovehk(a)ping.uio.no> on 08/07/2001 07:55:41 AM To: Rein Klazes <rklazes(a)xs4all.nl> cc: wine-devel(a)winehq.com (bcc: David Goodenough/DGA/GB) Subject: Re: CoGetClassObject On Tue, 7 Aug 2001, Rein Klazes wrote: > On Tue, 7 Aug 2001 01:12:34 +0200 (CEST), you wrote: > > > > > > > It couldn't get it from the ikernel.exe because I think > > > it's encoded somehow (unicode, MultiByte??). > > > > It doesn't look encoded, it's just different (it's most likely what is > > boasted as the "Typelib 2 Format"). Win2000's stdole32.tlb also uses this > > new format (it has a "SLTG" signature instead of the old "MSFT"). > > > SLTG is the old format, MSFT came later. Wine can (natively) only read > MSFT. Allright, but the most important question remains: who will volunteer to reverse engineer these SLTG typelibs and make Wine able to read them, so I can concentrate on the actual COM marshaling stuff (which is pretty hard enough as it is), so we can finally get those @#&% InstallShields up?

1 0

Re: ownerdrawn button fix
by Alexandre Julliard 06 Aug '01

06 Aug '01

Aric Stewart <aric(a)codeweavers.com> writes: > A full fix would be to make sure we never call the paint function > directly. However the only time this seems to actually cause a crash is > with owner drawn. This patch corrected the problem with owner drawn so > that we do not have to retest everything with buttons. This seems to defeat the purpose of having the ODA_* constants. Would it also fix your problem to only do the PAINT_BUTTON when the window is visible? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: (no subject)
by Alexandre Julliard 05 Aug '01

05 Aug '01

Ladislav Sladecek <lsla(a)post.cz> writes: > If you run the binary in the Windows, you will see two properly sized > red rectangles on a white background. If you run the same binary in > Wine, you will see only one large red child but no white parent > background. If either the CS_PARENTDC or WS_CLIPSIBLINGS gets removed > from my example, both Windows and Wine give identical results. Yes, there were a number of problems with the flags handling in GetDCEx. I think the behavior with the current CVS should now be correct in all cases; please give it a try. -- Alexandre Julliard julliard(a)winehq.com

3 3

Just out of interest whats this?
by Robert Laverick 05 Aug '01

05 Aug '01

FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock what's this, what's causing it and what needs fixing (I'll give it a look if it's needed) or is it just an old error that dosn't really need fixing (I can run almost everything I want to and the all show this error) just intersted Rob

1 1

Window-position bug?
by davep 04 Aug '01

04 Aug '01

Here's one I haven't seen before. Build the 'winemine' application in the programs directory and start it running. Click on the smiley-face button (which redraws the window). Every time I press the button the entire window moves down the screen one pixel. Dave

1 0

Re: wine/dlls/oleaut32 typelib.c
by Dmitry Timoshkov 04 Aug '01

04 Aug '01

"Alexandre Julliard" <julliard(a)winehq.com> wrote: > Log message: > Malte Starostik <malte(a)kde.org> > Implemented RegisterTypeLib. > > Patch: http://cvs.winehq.com/patch.py?id=99686240431774649117142 + if (res == S_OK && RegCreateKeyExA(key, "FLAGS", 0, NULL, 0, + KEY_WRITE, NULL, &subKey, NULL) == ERROR_SUCCESS) + { + CHAR buf[20]; + /* FIXME: is %u correct? */ + snprintf(buf, strlen(buf), "%u", attr->wLibFlags); ^^^^^^^^^^^ + if (RegSetValueExA(subKey, NULL, 0, REG_SZ, + buf, lstrlenA(buf) + 1) != ERROR_SUCCESS) + res = E_FAIL; + } I'm sorry, it's late a bit. But anyway, instead of strlen() above should be sizeof(). -- Dmitry.

1 0

Re: PATCH: ITypeInfo::Invoke
by Dmitry Timoshkov 04 Aug '01

04 Aug '01

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > +static void dump_VarType(VARTYPE vt,char *szVarType) { > + /* FIXME : we could have better trace here, depending on the VARTYPE > + * of the variant > + */ > + switch(vt) { > + case VT_UI1: MESSAGE(szVarType, "VT_UI"); break; ^^^^^^^ > + case VT_I2: sprintf(szVarType, "VT_I2"); break; > + case VT_I4: sprintf(szVarType, "VT_I4"); break; Seems to be a typo. Shouldn't it be sprintf instead of MESSAGE? -- Dmitry.

1 0

RE: What is the @ in the function headers
by Patrik Stridvall 03 Aug '01

03 Aug '01

> Quick question. What is the @ in a function header supposed > to contain? > Presumably it is the ordinal in the Dll. Well, functions either has an ordinal or a @. If it has a @ it is means that it doesn't matter what the ordinal is, that winebuild can assign any ordinal it likes for the function. > But what if the > same function has > different ordinals in different copies of the Dll? You mean different versions? Anyway, Wine has no support for it, because none is really needed, because any application that tries to access functions by ordinal that doesn't have a fixed ordinal across DLL version is broken even on Windows.

1 0

What is the @ in the function headers
by Bill Medland 03 Aug '01

03 Aug '01

Quick question. What is the @ in a function header supposed to contain? Presumably it is the ordinal in the Dll. But what if the same function has different ordinals in different copies of the Dll? Bill

1 0

Re: Dont allow SetSelectorBase to change into an kernel region
by Alexandre Julliard 03 Aug '01

03 Aug '01

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > If I only allow to set the selector base when (selector base + selector > limit) is smaller than 0x8000000, the application goes on and lets me read > an eprom plugged into the Galep3 Programmer. Is the appended fix a right > acceptable? No, it's legal to have selectors covering the entire address space. I'm afraid there is no good solution to this kind of problem. What does the app do under NT or with -winver nt40? -- Alexandre Julliard julliard(a)winehq.com

2 1

Some questions about TB_REPLACEBITMAP
by Marco Bizzarri 03 Aug '01

03 Aug '01

Hi all. I'm trying to implement the TB_REPLACEBITMAP message in the comctrl32, and I would like to have some advice about the ImageList structure. The TB_REPLACEBITMAP provides (via the hInst, nID pair) the handle to the old bitmap and the handle to the new bitmap, as well as the number of button in the new bitmap. I think I could use the ImageList_Replace to actually replace the bitmaps. However, the ImageList_Replace function requires a number, which is the first bitmap to be replaced. How can I retrieve this information? For what I can see, once a bitmap has been added to the imagelist, no information about is is stored. I'm doing some tests, using a value (like 0) as the bitmap index, but this is of little help, of course. Any help will be appreciated. Bye Marco

1 0

Some questions about TB_REPLACEBITMAP
by Marco Bizzarri 03 Aug '01

03 Aug '01

Hi all. I'm trying to implement the TB_REPLACEBITMAP message in the comctrl32, and I would like to have some advice about the ImageList structure. The TB_REPLACEBITMAP provides (via the hInst, nID pair) the handle to the old bitmap and the handle to the new bitmap, as well as the number of button in the new bitmap. I think I could use the ImageList_Replace to actually replace the bitmaps. However, the ImageList_Replace function requires a number, which is the first bitmap to be replaced. How can I retrieve this information? For what I can see, once a bitmap has been added to the imagelist, no information about is is stored. I'm doing some tests, using a value (like 0) as the bitmap index, but this is of little help, of course. Any help will be appreciated. Bye Marco

1 0

Switching threads in winedbg
by Francois Gouget 03 Aug '01

03 Aug '01

Is it possible to switch threads in winedbg? I can use 'walk thread' to see a list of the threads of my application but I could not find how to get a backtrace of one of these other threads. It's not in the Wine Developper's Guide and I could not find it from the source. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In a world without fences who needs Gates?

2 1

Dose wine people hate Solaris?
by EriK W 03 Aug '01

03 Aug '01

I have posted my question for compiling Wine in solaris x86 for 2 weeks, seems no anybody even has a bit interest. Do you guys hate solaris? :) I checked almost all the documents and faq, except it mentioned wine works with Solaris, there almost have no other info for it at all. Does anybody has even a suggestion for me? pls don't tell me nuke my solaris. :)

5 8

Re: Documenting functions
by Alexandre Julliard 02 Aug '01

02 Aug '01

"Bill Medland" <medbi01(a)accpac.com> writes: > Ay, there's the rub. It isn't our function. It';s Microsoft's function. > Now was it Holub or McConnell that complains about functions having weird > behaviour on certain inputs. IMO Microsoft functions need less documentation than internal ones, since there is MSDN and other countless books about Windows. You can assume that people reading your code already know what the various APIs are supposed to do. > The biggest problem, I believe, is the functions that take flags. Bear in > mind that a single DWORD argument used for flags is equivalent to up to 32 > boolean arguments. Documenting the relationship between those is a pain > but it needs to be done if we expect compatibility. This is clearly something that is best documented with code, not with text. You may need pages of text to describe the flags behavior in English, while with code it's usually only a few lines, plus a few comments here and there. This doesn't mean it wouldn't be a good thing to also have the full description in English; but in a separate document, not in the code. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Prevent excessive clipping in SysListView32
by Uwe Bonnes 02 Aug '01

02 Aug '01

>>>>> "Medland," == Medland, Bill <Bill.Medland(a)accpac.com> writes: Medland,> I am not very comfortable with this one but strange as it may Medland,> seem it solves the problem. I'd love to know why. Medland,> <<diff13.txt>> Bill Medland (medbi01(a)accpac.com) Prevents Medland,> excessive clipping in SysListView32. Medland,> Medland,>-static inline int perfect_graphics(void) Medland,>+static int perfect_graphics(void) Medland,> { Medland,> static int perfect = -1; Medland,> if (perfect == -1) Medland,> Some C-Expert is requested here, but I suspect that in the old function the variable "perfect" was created in every instantiation of the "perfect_graphics" inlined function. Could you perhaps try to declare the "perfect" outside the inlined function, like static int perfect = -1; static inline int perfect_graphics(void) Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

6 9

Re: Documenting functions
by Alexandre Julliard 02 Aug '01

02 Aug '01

Jeremy White <jwhite(a)codeweavers.com> writes: > I would say that I would rather have 100% of the effort a > particular developer *wants* to put in, rather than only > have his/her coding efforts. Absolutely; I'm not going to discourage anybody from writing doc if they feel like it. But I don't want anyone to feel somehow obliged to spend time on the doc if they'd rather be writing code, which I expect is the case with most developers... > However, I think that there should be a standard function > header, with a standard place to put notes and comments > in general about a function. I don't see a need to standardize anything. If you want to add a comment before a function just do it, there is no need for a standard format, plain text works just as well. > I have been trained, and I suspect that many of us have > been trained, to look at a function header for general > tips and tricks before diving into the code. I know > this is sacriledge to you, Alexandre, but there are some > of us who like to quickly look at a function, rather than > always reading the code to understand it completely. I think you misunderstand my position; I'm not opposed to having a comment at the start of the function explaining the general goal and the non-obvious things going on. But if you need more than a couple of paragraphs to do this, then either there are too many non-obvious things going on in your function, or you are wasting space explaining the obvious. I do strongly think that the goal should be to write code that doesn't require documentation in order to be understood. Of course adding a small amount of comments is a good idea; but when you start having more lines of documentation than lines of code, something is very wrong IMO. But this is mainly a matter of personal taste, and except in extreme cases I'm not going to reject code because it has too much (or not enough) documentation. It may happen that some of your beloved horizontal lines get lost during the cvs commit though ;-) -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Documenting functions
by Jeremy White 02 Aug '01

02 Aug '01

[Resend due to exim crash; thanks Ove] >> I'd much rather have developers spend their time writing code. Making >> them duplicate the whole MSDN documentation would be a huge waste of >> their time. Our resources are not infinite, and it's much more useful >> to have 100% API coverage with no docs at all than 50% coverage and >> tons of docs. I think this is a dangerous attitude to take. I think that you cannot (and should not) attempt to force volunteer developers to add documentation to code. However, there are some few of us, who don't feel that the job is satisfactorily done until the documentation reflects important things that we've learned. I would say that I would rather have 100% of the effort a particular developer *wants* to put in, rather than only have his/her coding efforts. If I, like Bill, spend 24 hours ripping my hair out to learn some oddball things, I want a place to put those things. I want someone else (or an older version of me) to have a chance to not have to learn those things the hard way. Please don't misunderstand me. I agree that we shouldn't try to replicate MSDN. I'm not even sure we should provide minimal documentation like parameter lists and return values. Further, I agree that where it makes sense, the best place for comments is inline with the relevant code. However, I think that there should be a standard function header, with a standard place to put notes and comments in general about a function. I have been trained, and I suspect that many of us have been trained, to look at a function header for general tips and tricks before diving into the code. I know this is sacriledge to you, Alexandre, but there are some of us who like to quickly look at a function, rather than always reading the code to understand it completely. <in joke> Finally, I think all the code would be dramatically improved, in fact, I bet we'd be at Wine 1.0 by now, if there were nice big horizontal separator lines everywhere. </in joke>

1 0

Re: Documenting functions
by Alexandre Julliard 02 Aug '01

02 Aug '01

Francois Gouget <fgouget(a)free.fr> writes: > So I think the functions implemented in Wine should be fully > documented. And the only place to do that is in the code source because > this is the only place where they have a remote chance of staying up to > date (and also where it's most practical to have it). I have to disagree here. Yes it would be nice to have a free Win API documentation, but it definitely doesn't belong inside the Wine source. First it would be a huge bloat in the source; and more importantly the Wine source doesn't define the Windows API, it is defined by Microsoft. > Of course developpers are very well-known for hating to document > stuff so it's going to be pretty hard to get proper documentation. But > we should encourage all Wine developpers to write good documentation for > the functions they implement/fix, not dissuade them to do so. I'd much rather have developers spend their time writing code. Making them duplicate the whole MSDN documentation would be a huge waste of their time. Our resources are not infinite, and it's much more useful to have 100% API coverage with no docs at all than 50% coverage and tons of docs. > Also I agree with you that the strict minimum is to at least document > all the undocumented/weird behaviors. Especially since without some sort > of documentation the next developper may be tempted to remove what looks > like unnecessarily convoluted/obviously wrong code. That should be done with comments inside the code itself. And in many cases it would actually be better to comment the places where the behavior is not right. What I mean is, instead of adding a comment on every line stating "yes this is what Windows does", I'd prefer adding a comment/FIXME to mark the lines that have been written without checking whether Windows really does it this way. -- Alexandre Julliard julliard(a)winehq.com

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel